Re: [FFmpeg-devel] [PATCH 07/11] avformat/dashenc: logic to compute bitrate overhead

2018-04-01 Thread Jeyapal, Karthick
On 3/23/18 10:57 AM, vdi...@akamai.com wrote: > From: Vishwanath Dixit > > --- > libavformat/dashenc.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index d20bdba..0ba9f55 100644 > ---

Re: [FFmpeg-devel] [PATCH 06/11] avformat/dashenc: addition of @availabilityTimeOffset in MPD

2018-04-01 Thread Jeyapal, Karthick
On 3/23/18 10:57 AM, vdi...@akamai.com wrote: > From: Vishwanath Dixit > > availability time of Nth segment = availabilityStartTime + (N*segment > duration) - availabilityTimeOffset. > This field helps to reduce the latency by about a segment duration in > streaming mode. >

Re: [FFmpeg-devel] [PATCH 05/11] avformat/dashenc: setting @availabilityStartTime when the first frame is ready

2018-04-01 Thread Jeyapal, Karthick
On 3/23/18 10:56 AM, vdi...@akamai.com wrote: > From: Vishwanath Dixit > > @availabilityStartTime specifies the anchor for the computation of the > earliest > availability time (in UTC) for any Segment in the Media Presentation. Please be little more verbose for a clearer

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/avpacket: add av_packet_make_refcounted()

2018-04-01 Thread James Almer
On 4/1/2018 11:12 AM, Michael Niedermayer wrote: > On Fri, Mar 30, 2018 at 02:24:23PM -0300, James Almer wrote: >> It works as a drop in replacement for the deprecated av_dup_packet(), >> to ensure a packet is reference counted. >> >> Signed-off-by: James Almer >> --- >>

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-04-01 Thread misty
From: Misty De Meo I've resolved the one TODO that remained by adding support for the one other supported video codec in this container. Is there anything else that you'd like to see changed? I understand the concerns about this too niche, but I have been speaking to a

[FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-04-01 Thread misty
From: Misty De Meo --- Changelog | 1 + doc/general.texi | 2 +- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/segafilmenc.c | 397 ++ libavformat/version.h |

Re: [FFmpeg-devel] [PATCH 1/6] lavf/allformats: remove left-over index decrement

2018-04-01 Thread Josh de Kock
On 2018/04/02 2:40, wm4 wrote: On Sun, 1 Apr 2018 03:39:40 +0100 Josh de Kock wrote: Signed-off-by: Josh de Kock --- libavformat/allformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/allformats.c

Re: [FFmpeg-devel] [PATCH] lavf/hls: Remove the dead code in parse_playlist()

2018-04-01 Thread Steven Liu
> On 2 Apr 2018, at 07:09, Jun Zhao wrote: > > <0001-lavf-hls-Remove-the-dead-code-in-parse_playlist.patch> From 96de206d191264d2a5aacff5f877caad1d861439 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Sun, 1 Apr 2018 11:17:45 +0800 Subject: [PATCH]

[FFmpeg-devel] [PATCH] avcodec/libaomenc: fix encoding of sRGB streams

2018-04-01 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libaomenc.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 8ebdcc20e3..fb9d60527b 100644 --- a/libavcodec/libaomenc.c +++

Re: [FFmpeg-devel] [PATCH 2/6] lavf/img2dec: use new iteration API

2018-04-01 Thread wm4
On Sun, 1 Apr 2018 03:39:41 +0100 Josh de Kock wrote: > Signed-off-by: Josh de Kock > --- > libavformat/img2dec.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c > index

Re: [FFmpeg-devel] [PATCH 6/6] lavf/format: use const AVInputFormat for iteration

2018-04-01 Thread Jun Zhao
On 2018/4/1 10:39, Josh de Kock wrote: > Signed-off-by: Josh de Kock > --- > libavformat/format.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavformat/format.c b/libavformat/format.c > index 1b2ce22e25..1c66afb7e6 100644 > ---

Re: [FFmpeg-devel] [PATCH 1/6] lavf/allformats: remove left-over index decrement

2018-04-01 Thread wm4
On Sun, 1 Apr 2018 03:39:40 +0100 Josh de Kock wrote: > Signed-off-by: Josh de Kock > --- > libavformat/allformats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/allformats.c b/libavformat/allformats.c > index

Re: [FFmpeg-devel] [PATCH 1/6] lavf/allformats: remove left-over index decrement

2018-04-01 Thread Josh de Kock
On 2018/04/01 3:39, Josh de Kock wrote: Signed-off-by: Josh de Kock --- libavformat/allformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/allformats.c b/libavformat/allformats.c index 2a20548c95..cf430a9680 100644 ---

Re: [FFmpeg-devel] [PATCH 3/6] lavf: move avpriv function definition to internal.h

2018-04-01 Thread Josh de Kock
On 2018/04/01 16:14, James Almer wrote: [...] > LGTM. Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] cmdutils: fix new API break the "ffmpeg -muxers/demuxers"

2018-04-01 Thread Josh de Kock
On 2018/04/02 0:07, Jun Zhao wrote: [...] Thanks, pushed. I thought I had checked this, obviously not. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Change the seek2any location in opt table.

2018-04-01 Thread Michael Niedermayer
On Mon, Apr 02, 2018 at 07:08:24AM +0800, Jun Zhao wrote: > > options_table.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 01d5e71dc3ed316593e35a9f7d973331b04bc65a > 0001-avformat-options_table-Change-the-seek2any-location-.patch > From 2fcdbfe24d82b3d287d6f4f70144bc2ee16820dc

[FFmpeg-devel] [PATCH] lavf/hls: Remove the dead code in parse_playlist()

2018-04-01 Thread Jun Zhao
From 96de206d191264d2a5aacff5f877caad1d861439 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Sun, 1 Apr 2018 11:17:45 +0800 Subject: [PATCH] lavf/hls: Remove the dead code in parse_playlist() Signed-off-by: Jun Zhao --- libavformat/hls.c | 7 ---

[FFmpeg-devel] [PATCH] avformat/options_table: Change the seek2any location in opt table.

2018-04-01 Thread Jun Zhao
From 2fcdbfe24d82b3d287d6f4f70144bc2ee16820dc Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Sun, 1 Apr 2018 15:53:11 +0800 Subject: [PATCH] avformat/options_table: Change the seek2any location in opt table. Change the seek2any location in avformat_options to make code more

[FFmpeg-devel] [PATCH] cmdutils: fix new API break the "ffmpeg -muxers/demuxers"

2018-04-01 Thread Jun Zhao
From ebc23fc12671783dc2f77b14c3b61f95b16e01c9 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Sun, 1 Apr 2018 22:29:46 +0800 Subject: [PATCH] cmdutils: fix new API break the "ffmpeg -muxers/demuxers" fix commit 2238190 break the "ffmpeg -muxers/demuxers". Signed-off-by: Jun

[FFmpeg-devel] [PATCH] avformat/utils: Stream specifier enhancement

2018-04-01 Thread Bodecs Bela
Dear All, currently when specifying the program id you can only decide to select all stream of the specified program (e.g. p:103 will select all streams of program 103) or narrow the selection to a specific stream sub index (e.g. p:145:1 will select 2nd stream of program 145.) But you can not

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-04-01 Thread Michael Niedermayer
On Sun, Apr 01, 2018 at 03:39:07PM +0100, Derek Buitenhuis wrote: > On 4/1/2018 12:44 AM, Michael Niedermayer wrote: > >> Not sure I follow what this has to do with timelines? There is no format > >> that > >> exists that store timeline data interleaved, as far as I know - it is a > >> purely

Re: [FFmpeg-devel] [PATCH v2] Change cube faces order to match Youtube's

2018-04-01 Thread Paul B Mahol
On 4/1/18, Hazem Ashmawy wrote: > Please find another implementation for bilinear > https://github.com/HazemSamir/FFmpeg/commit/6a62f6db30bed37323d70eb7d66d6c33fa8f00c3 > > Please let me know your thoughts. > Should be fine if it works.

Re: [FFmpeg-devel] [PATCH v2] Change cube faces order to match Youtube's

2018-04-01 Thread Hazem Ashmawy
Please find another implementation for bilinear https://github.com/HazemSamir/FFmpeg/commit/6a62f6db30bed37323d70eb7d66d6c33fa8f00c3 Please let me know your thoughts. On 3/14/18, Paul B Mahol wrote: > On 3/14/18, Hazem Ashmawy wrote: >> So I'm still

[FFmpeg-devel] [PATCHv5] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-04-01 Thread Kieran Kunhya
0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] avcodec/libaomdec: remove duplicate code

2018-04-01 Thread James Almer
Signed-off-by: James Almer --- libaom generates all files as I4xx16 right now, so the code i'm removing here is unused. And even if it ends up generating I4xx files down the road, it's safe to assume the bit_depth field in aom_image_t will still be populated.

[FFmpeg-devel] [PATCH 2/2] avcodec/libaomdec: add support for monochrome files

2018-04-01 Thread James Almer
All such files are signaled as I42016, as there's no monochrome value in aom_img_fmt_t. Signed-off-by: James Almer --- libavcodec/libaomdec.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c index

Re: [FFmpeg-devel] [PATCH] avformat/mpeg: fix PCM-DVD mis-detection as MLP

2018-04-01 Thread Michael Niedermayer
On Fri, Mar 30, 2018 at 04:10:52PM +0200, Paul B Mahol wrote: > Fixes #6563. > > Signed-off-by: Paul B Mahol > --- > libavformat/mpeg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) tested a bit, found no files this breaks. thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] Reviews (was: lavc: prefer the mp3float decoder to the mp3 decoder)

2018-04-01 Thread Nicolas George
Rostislav Pehlivanov (2018-04-01): > Backlogs are a thing. Backlogs are a waste of time. IRC discussions are conducted in direct and barely readable afterwards. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] Reviews (was: lavc: prefer the mp3float decoder to the mp3 decoder)

2018-04-01 Thread Rostislav Pehlivanov
On 1 April 2018 at 15:33, Nicolas George wrote: > Rostislav Pehlivanov (2018-04-01): > > Please go on IRC, its where most developers talk, exchange ideas, > > information, discuss patches and so on. > > I do not have time to go on IRC. The place where most developers talk, >

Re: [FFmpeg-devel] [PATCH 3/6] lavf: move avpriv function definition to internal.h

2018-04-01 Thread James Almer
On 3/31/2018 11:39 PM, Josh de Kock wrote: > Signed-off-by: Josh de Kock > --- > libavdevice/alldevices.c | 1 + > libavformat/allformats.c | 1 + > libavformat/avformat.h | 2 -- > libavformat/internal.h | 1 + > 4 files changed, 3 insertions(+), 2 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH] lavc: prefer the mp3float decoder to the mp3 decoder

2018-04-01 Thread James Almer
On 3/31/2018 7:59 PM, Rostislav Pehlivanov wrote: > On modern x86 systems its around 2x faster. For systems without > FPUs it'll be slower, but our policy is to prefer floating point > implementations and to let users decide what's best (or just not > compile them on systems without FPUs). > >

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-04-01 Thread Derek Buitenhuis
On 4/1/2018 12:44 AM, Michael Niedermayer wrote: >> Not sure I follow what this has to do with timelines? There is no format that >> exists that store timeline data interleaved, as far as I know - it is a >> purely theoretical scenario. > > that surprises me. But if this case never occurs (or

Re: [FFmpeg-devel] [PATCH] avformat/mpeg: fix detection and demuxing of raw AC3 in mpegps

2018-04-01 Thread Michael Niedermayer
On Fri, Mar 30, 2018 at 06:46:06PM +0200, Paul B Mahol wrote: > Fixes #4889. > > Signed-off-by: Paul B Mahol > --- > libavformat/mpeg.c | 27 +++ > 1 file changed, 19 insertions(+), 8 deletions(-) > > diff --git a/libavformat/mpeg.c

Re: [FFmpeg-devel] Reviews (was: lavc: prefer the mp3float decoder to the mp3 decoder)

2018-04-01 Thread Nicolas George
Rostislav Pehlivanov (2018-04-01): > Please go on IRC, its where most developers talk, exchange ideas, > information, discuss patches and so on. I do not have time to go on IRC. The place where most developers talk, exchange ideas, information, discuss patches and so on is the mailing-list. IRC

Re: [FFmpeg-devel] [PATCH] bug in avcodec_find_best_pix_fmt_of_list

2018-04-01 Thread Michael Niedermayer
On Sat, Mar 31, 2018 at 08:09:38PM +0700, Александр Чирятьев wrote: > Hello! > > Let me propose to review my patch for avcodec_find_best_pix_fmt_of_list. > It's very old bug. Here is example: > > AVPixelFormat pixFmts[] = { AV_PIX_FMT_RGB24, AV_PIX_FMT_RGBA }; > int loss = 0; > AVPixelFormat

Re: [FFmpeg-devel] Reviews (was: lavc: prefer the mp3float decoder to the mp3 decoder)

2018-04-01 Thread Rostislav Pehlivanov
On 1 April 2018 at 13:24, Nicolas George wrote: > Rostislav Pehlivanov (2018-04-01): > > > lgtm > > > Thanks, pushed > > I think some clarification is required about reviews. > > "LGTM" means "looks good to me". I insist: "me". When Paul writes > "LGTM", it means the patch looks

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/avpacket: add av_packet_make_refcounted()

2018-04-01 Thread Michael Niedermayer
On Fri, Mar 30, 2018 at 02:24:23PM -0300, James Almer wrote: > It works as a drop in replacement for the deprecated av_dup_packet(), > to ensure a packet is reference counted. > > Signed-off-by: James Almer > --- > libavcodec/avcodec.h | 18 +- >

[FFmpeg-devel] Reviews (was: lavc: prefer the mp3float decoder to the mp3 decoder)

2018-04-01 Thread Nicolas George
Rostislav Pehlivanov (2018-04-01): > > lgtm > Thanks, pushed I think some clarification is required about reviews. "LGTM" means "looks good to me". I insist: "me". When Paul writes "LGTM", it means the patch looks good to Paul, not anybody else. If Paul is the maintainer of the affected piece

Re: [FFmpeg-devel] [PATCH] lavc: prefer the mp3float decoder to the mp3 decoder

2018-04-01 Thread Rostislav Pehlivanov
On 1 April 2018 at 09:56, Paul B Mahol wrote: > On 4/1/18, Rostislav Pehlivanov wrote: > > On modern x86 systems its around 2x faster. For systems without > > FPUs it'll be slower, but our policy is to prefer floating point > > implementations and to let

Re: [FFmpeg-devel] lavfi/silencedetect v3

2018-04-01 Thread Paul B Mahol
On 3/5/18, Gaullier Nicolas wrote: > Hello, > I have not received any comment yet on my patchset v3 ("add mono mode" new > feature + 4 fixes including a ticket), does it look good to you, could it be > committed ? > >

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-04-01 Thread Jan Ekström
On Sun, Apr 1, 2018 at 1:43 PM, Nicolas George wrote: > > Looks reasonable, thanks. > > Regards, > > -- > Nicolas George > Thanks for the review, pushed. Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter: add vfrdet filter

2018-04-01 Thread Paul B Mahol
On 12/20/17, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 11 + > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_vfrdet.c | 111 >

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: only set output stream index before returning packet

2018-04-01 Thread Nicolas George
Marton Balint (2018-03-25): > Fixes ticket #6434. > > Signed-off-by: Marton Balint > --- > libavformat/concatdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM, thanks. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-04-01 Thread Nicolas George
Jan Ekström (2018-03-31): > With certain types of input and the filter chain getting re-initialized > or re-configured, multiple nullptr AVSubtitles can get pushed into > sub2video_update() in a row from sub2video_heartbeat. > > This causes end_pts, and on the next round pts, to become INT64_MAX,

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-04-01 Thread Paul B Mahol
On 3/31/18, Jan Ekstroem wrote: > With certain types of input and the filter chain getting re-initialized > or re-configured, multiple nullptr AVSubtitles can get pushed into > sub2video_update() in a row from sub2video_heartbeat. > > This causes end_pts, and on the next round

Re: [FFmpeg-devel] [PATCH] lavc: prefer the mp3float decoder to the mp3 decoder

2018-04-01 Thread Paul B Mahol
On 4/1/18, Rostislav Pehlivanov wrote: > On modern x86 systems its around 2x faster. For systems without > FPUs it'll be slower, but our policy is to prefer floating point > implementations and to let users decide what's best (or just not > compile them on systems without

Re: [FFmpeg-devel] [PATCH] avfilter/af_amix: add weights option

2018-04-01 Thread Paul B Mahol
On 3/29/18, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 3 +++ > libavfilter/af_amix.c | 32 +++- > 2 files changed, 34 insertions(+), 1 deletion(-) > Will apply.