Re: [FFmpeg-devel] [PATCH] tests/checkasm/Makefile: fix 'make fate' error when enable vaapi

2018-10-23 Thread Zhou, Zachary
Good point, and I find in the build script configure can do function "XDisplayName" check when checking to enable vaapi. resent the patch. -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Hendrik Leppkes Sent: Tuesday, October 23, 2018 8:56

[FFmpeg-devel] [PATCH] tests/checkasm/Makefile: fix 'make fate' error when enable vaapi

2018-10-23 Thread Zachary Zhou
Reproduce the issue: $ ./configure --enable-libmfx --enable-vaapi --enable-shared --samples=fate-suite/ $ make fate LD tests/checkasm/checkasm /usr/bin/x86_64-linux-gnu-ld: libavutil/libavutil.a(hwcontext_vaapi.o): undefined reference to symbol 'XDisplayName'

Re: [FFmpeg-devel] [PATCH] doc/fate.texi: Mention that samples should be uploaded before pushing dependant commits

2018-10-23 Thread Gyan
On Wed, Oct 24, 2018 at 3:09 AM Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/fate.texi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/doc/fate.texi b/doc/fate.texi > index a352994230..9ca77f7772 100644 > --- a/doc/fate.texi > +++ b/doc/fate.texi > @@

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: add several options supported in srt 1.3.0 v3

2018-10-23 Thread Matsuzawa Tomohiro
Thank you for your review! Regards, Tomo 差出人: ffmpeg-devel が Marton Balint の代理で送信 送信日時: 2018年10月23日 11:00 宛先: FFmpeg development discussions and patches 件名: Re: [FFmpeg-devel] [PATCH] avformat/libsrt: add several options supported in srt 1.3.0 v3 On Tue,

Re: [FFmpeg-devel] [PATCH] vp9_parser: set profile in AVCodecContext

2018-10-23 Thread James Almer
On 10/23/2018 10:16 PM, chcunningham wrote: > --- > libavcodec/vp9_parser.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c > index 9531f34a32..b6b621198b 100644 > --- a/libavcodec/vp9_parser.c > +++ b/libavcodec/vp9_parser.c > @@

[FFmpeg-devel] [PATCH] vp9_parser: set profile in AVCodecContext

2018-10-23 Thread chcunningham
--- libavcodec/vp9_parser.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c index 9531f34a32..b6b621198b 100644 --- a/libavcodec/vp9_parser.c +++ b/libavcodec/vp9_parser.c @@ -43,6 +43,8 @@ static int parse(AVCodecParserContext *ctx,

[FFmpeg-devel] [PATCH] avutil/integer: Fix integer overflow in av_mul_i()

2018-10-23 Thread Michael Niedermayer
Found-by: fate Signed-off-by: Michael Niedermayer --- libavutil/integer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/integer.c b/libavutil/integer.c index 890e314dce..78e252fbde 100644 --- a/libavutil/integer.c +++ b/libavutil/integer.c @@ -74,7 +74,7 @@

Re: [FFmpeg-devel] [PATCH v3] avcodec: libdav1d AV1 decoder wrapper.

2018-10-23 Thread James Almer
On 10/23/2018 8:15 PM, Dale Curtis wrote: > On Fri, Oct 19, 2018 at 4:50 PM James Almer wrote: > >> +s.n_tile_threads = dav1d->tile_threads; >> +s.n_frame_threads = dav1d->frame_threads; >> > > Did you consider using the AVCodecContext.threads value along > AVCodecContext.thread_type

Re: [FFmpeg-devel] [PATCH v3] avcodec: libdav1d AV1 decoder wrapper.

2018-10-23 Thread Dale Curtis
On Fri, Oct 19, 2018 at 4:50 PM James Almer wrote: > +s.n_tile_threads = dav1d->tile_threads; > +s.n_frame_threads = dav1d->frame_threads; > Did you consider using the AVCodecContext.threads value along AVCodecContext.thread_type flags? That seems to be how this is handled elsewhere. -

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavu/qsv: make a copy as libmfx alignment requirement for uploading

2018-10-23 Thread Mark Thompson
On 23/10/18 08:49, Li, Zhong wrote: >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Mark Thompson >> Sent: Sunday, October 14, 2018 12:36 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavu/qsv: make a copy as >> libmfx alignment

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

2018-10-23 Thread Alex Converse
> From a12637c97c3140a1676f20b19c91647313379b39 Mon Sep 17 00:00:00 2001 > From: pkviet > Date: Sun, 9 Sep 2018 16:47:32 +0200 > Subject: [PATCH 3/3] avcodec/aacdec: Translate pce to avutil channel_layout > > This commit enables the native aac decoder to translate pce to > ffmpeg channel layouts

[FFmpeg-devel] [PATCH 2/2] lavfi/ebur128: Fix mixed declarations and code

2018-10-23 Thread Mark Thompson
--- libavfilter/f_ebur128.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index e03adc9ba1..f613d8def2 100644 --- a/libavfilter/f_ebur128.c +++ b/libavfilter/f_ebur128.c @@ -777,6 +777,7 @@ static int

[FFmpeg-devel] [PATCH 1/2] lavd/v4l2: Avoid warning about path length

2018-10-23 Thread Mark Thompson
GCC warns about the name being truncated here - in theory it will indeed behave unexpectedly if the user has a device in /dev with a 255 character name beginning with "video", but this is probably a niche use-case. --- libavdevice/v4l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH] doc/fate.texi: Mention that samples should be uploaded before pushing dependant commits

2018-10-23 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/fate.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/fate.texi b/doc/fate.texi index a352994230..9ca77f7772 100644 --- a/doc/fate.texi +++ b/doc/fate.texi @@ -155,6 +155,8 @@ space on each client, network bandwidth and so on benefit from

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: simplify dnxhd handling and add more flavors

2018-10-23 Thread Baptiste Coudurier
Hey Tomas, On Mon, Oct 22, 2018 at 12:52 PM Tomas Härdin wrote: > mån 2018-10-22 klockan 11:37 -0700 skrev Baptiste Coudurier: > > --- > > libavformat/mxfenc.c | 215 --- > > 1 file changed, 61 insertions(+), 154 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Eoff, Ullysses A > Sent: Tuesday, October 23, 2018 1:50 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation >

Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Tuesday, October 23, 2018 10:06 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi

Re: [FFmpeg-devel] [PATCH v5] fate: add api-h264-slice test

2018-10-23 Thread Michael Niedermayer
On Tue, Oct 23, 2018 at 12:15:13PM +0100, jos...@ob-encoder.com wrote: > From: Josh de Kock > > This test ensures that you are able to send N number of slice NALUs in slice > threaded mode to be decoded simultaneously > --- > Prints a warning to the user when threading is not enabled, slice

Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Timo Rothenpieler
On 23.10.2018 10:55, Moritz Barsnick wrote: On Tue, Oct 23, 2018 at 15:52:40 +0800, Zachary Zhou wrote: It supports clockwise rotation by 0/90/180/270 degrees defined in va/va_vpp.h, tested following command line on SKL platform Since these angles of rotation are called "transpose" in

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: add several options supported in srt 1.3.0 v3

2018-10-23 Thread Marton Balint
On Tue, 23 Oct 2018, Matsuzawa Tomohiro wrote: Several SRT options are missing. Since pkg_config requires libsrt v1.3.0 and above, it should be able to support options added in libsrt v1.3.0 and below. This commit adds 8 SRT options. sndbuf, rcvbuf, lossmaxttl, minversion, streamid,

Re: [FFmpeg-devel] [PATCHv2 2/2] avdevice/sdl2 : add option to set window position

2018-10-23 Thread Marton Balint
On Mon, 22 Oct 2018, Marton Balint wrote: On Sat, 20 Oct 2018, Marton Balint wrote: From: Dave Rice Allows arrangement of multiple windows such as: ffmpeg -re -f lavfi -i mandelbrot -f sdl -window_x 1 -window_y 1 mandelbrot -vf waveform,format=yuv420p -f sdl -window_x 641 -window_y 1

Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Michael Niedermayer
On Tue, Oct 23, 2018 at 03:52:40PM +0800, Zachary Zhou wrote: > It supports clockwise rotation by 0/90/180/270 degrees defined in > va/va_vpp.h, tested following command line on SKL platform > > ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 > -hwaccel_output_format vaapi -i input.264

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: remove FF_CODEC_CAP_INIT_THREADSAFE flag

2018-10-23 Thread Henrik Gramner
On Tue, Oct 23, 2018 at 3:22 PM Derek Buitenhuis wrote: > I'd like to point out that this patch or some variant may be required anyway. > > libx264 only uses strtok_r or strtok_s if available on the platform. > > See: >

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-10-23 Thread Jacob Trimble
On Mon, Oct 1, 2018 at 11:30 AM Jacob Trimble wrote: > > On Mon, Sep 17, 2018 at 2:35 PM Jacob Trimble wrote: > > > > On Wed, Sep 12, 2018 at 11:50 AM Michael Niedermayer > > wrote: > > > > > > On Tue, Sep 11, 2018 at 03:50:57PM -0700, Jacob Trimble wrote: > > > > [...] > > > > > > > > So how

Re: [FFmpeg-devel] avfilter/show_info : print color information

2018-10-23 Thread Paul B Mahol
On 10/20/18, Martin Vignali wrote: > Hello, > > Patch in attach add to show_info filter > print of the color property (range, primaries, trc, space) > > Martin > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Zhou, Zachary
I was planning to enable VAAPI rotation and mirroring as two features in two patches. I am checking VAProcPipelineParameterBuffer::mirror_state, it looks like iHD driver doesn’t support to query mirror_flags via vaQueryVideoProcPipelineCaps currently. -Original Message- From:

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: remove FF_CODEC_CAP_INIT_THREADSAFE flag

2018-10-23 Thread Derek Buitenhuis
Hi, On 21/10/2018 15:07, Henrik Gramner wrote: > Fixed in x264-sandbox. All uses of plain strtok() will be removed from > x264 in the next push. > > I though all of the strtok() uses in x264 had already been converted > to strtok_r() but apparently that wasn't the case. Sorry about that. I'd

Re: [FFmpeg-devel] [PATCH] tests/checkasm/Makefile: fix 'make fate' error when enable vaapi

2018-10-23 Thread Hendrik Leppkes
On Tue, Oct 23, 2018 at 2:00 PM Zachary Zhou wrote: > > Reproduce the issue: > > $ ./configure --enable-libmfx --enable-vaapi --enable-shared > --samples=fate-suite/ > $ make fate > LD tests/checkasm/checkasm > /usr/bin/x86_64-linux-gnu-ld: libavutil/libavutil.a(hwcontext_vaapi.o): >

Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Moritz Barsnick > Sent: Tuesday, October 23, 2018 8:32 PM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation > feature via call Intel iHD

[FFmpeg-devel] [PATCH] avcodec/vc1: set ticks_per_frame irrespective of FRAMERATE_FLAG

2018-10-23 Thread Jerome Borsboom
vc1_decode_frame assumes that ticks_per_frame is set to two when RFF or RPTFRM is set. When FRAMERATE_FLAG is zero, this may not be the case as the setting of ticks_per_frame is guarded by FRAMERATE_FLAG. Signed-off-by: Jerome Borsboom --- libavcodec/vc1.c | 6 +++--- 1 file changed, 3

Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Moritz Barsnick
On Tue, Oct 23, 2018 at 09:56:04 +, Li, Zhong wrote: > Not sure vaapi can expose more angles or not. VAAPI's rotation_state only supports those four "angles": http://01org.github.io/libva_staging_doxygen/struct__VAProcPipelineParameterBuffer.html#ae05cc1f2189c9e85339f7c63e9a61e1c > But using

[FFmpeg-devel] [PATCH] tests/checkasm/Makefile: fix 'make fate' error when enable vaapi

2018-10-23 Thread Zachary Zhou
Reproduce the issue: $ ./configure --enable-libmfx --enable-vaapi --enable-shared --samples=fate-suite/ $ make fate LD tests/checkasm/checkasm /usr/bin/x86_64-linux-gnu-ld: libavutil/libavutil.a(hwcontext_vaapi.o): undefined reference to symbol 'XDisplayName'

[FFmpeg-devel] [PATCH v5] fate: add api-h264-slice test

2018-10-23 Thread joshdk
From: Josh de Kock This test ensures that you are able to send N number of slice NALUs in slice threaded mode to be decoded simultaneously --- Prints a warning to the user when threading is not enabled, slice NALUs should still be checked for proper decoding irregardless of whether threads

Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Moritz Barsnick > Sent: Tuesday, October 23, 2018 4:55 PM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation > feature via call Intel iHD

Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Zachary Zhou > Sent: Tuesday, October 23, 2018 3:53 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Zhou, Zachary > Subject: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation > feature via call Intel iHD driver > >

Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Moritz Barsnick
On Tue, Oct 23, 2018 at 15:52:40 +0800, Zachary Zhou wrote: > It supports clockwise rotation by 0/90/180/270 degrees defined in > va/va_vpp.h, tested following command line on SKL platform Since these angles of rotation are called "transpose" in ffmpeg's other filters (transpose, transpose_npp),

Re: [FFmpeg-devel] Why does ffmpeg h264 decoder stop decoding when certain type of packets are coming in the input stream?

2018-10-23 Thread Naveed Basha
Below code change fixes Bug #7340 Not sure if that would impact something else. Request your kind opinion on this. diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 7b4c5c7..4656d22 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -473,7 +473,7 @@ static void

[FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Zachary Zhou
It supports clockwise rotation by 0/90/180/270 degrees defined in va/va_vpp.h, tested following command line on SKL platform ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -hwaccel_output_format vaapi -i input.264 -vf "rotation_vaapi=angle=90" -c:v h264_vaapi output.h264 ---

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavu/qsv: make a copy as libmfx alignment requirement for uploading

2018-10-23 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Sunday, October 14, 2018 12:36 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavu/qsv: make a copy as > libmfx alignment requirement for uploading > > On 11/10/18

Re: [FFmpeg-devel] [PATCH V2] avcodec-qsvdec-flush-the-buffered-data-before-reinit

2018-10-23 Thread Li, Zhong
> From: Fu, Linjie > Sent: Tuesday, October 16, 2018 9:36 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie ; Li, Zhong > Subject: [PATCH V2] avcodec-qsvdec-flush-the-buffered-data-before-reinit > > Flush the buffered data in libmfx before video param reinit in case the > frames drop. > > Cache

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc_hevc: correction for QSV HEVC default plugin selection on Windows

2018-10-23 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Maxym Dmytrychenko > Sent: Sunday, October 14, 2018 3:36 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc_hevc: correction for > QSV HEVC default plugin selection on Windows > > On