[FFmpeg-devel] [PATCH] lavf/mov: fix hang while seek on a kind of fragmented mp4.

2019-02-01 Thread Charles Liu
Binary searching would hang if the fragment items do NOT have timestamp for the specified stream. For example, a fmp4 consists of separated 'moof' boxes for each track, and separated 'sidx' for each segment, but no 'mfra' box. Then every fragment item only have the timestamp for one of its

Re: [FFmpeg-devel] [PATCH] Support HDR dynamic metadata (HDR10+) in HEVC decoder.

2019-02-01 Thread James Almer
On 2/1/2019 4:53 PM, Hendrik Leppkes wrote: > On Tue, Jan 22, 2019 at 11:13 PM Mohammad Izadi wrote: >> >> --- >> libavcodec/hevc_sei.c | 216 -- >> libavcodec/hevc_sei.h | 6 ++ >> libavcodec/hevcdec.c | 21 >> 3 files changed, 237 insertions(+),

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-02-01 Thread mptcultist
From skimming the documents, FF's behavior appears to be correct. However, in both of the sidx atoms of the problematic file, they point to the same media and as such both point to the end of the file, meaning either will complete the fragment index incorrectly. I'm not sure what's to be done. On

[FFmpeg-devel] [PATCH] lavfi/vf_hwmap: move some code into seperate function

2019-02-01 Thread Ruiling Song
This is just code fine. No functional change. Signed-off-by: Ruiling Song --- libavfilter/vf_hwmap.c | 83 -- 1 file changed, 39 insertions(+), 44 deletions(-) diff --git a/libavfilter/vf_hwmap.c b/libavfilter/vf_hwmap.c index 290559a..14276ce

[FFmpeg-devel] [PATCH] avformat/mov: validate chunk_count vs stsc_data

2019-02-01 Thread chcunningham
Bad content may contain stsc boxes with a first_chunk index that exceeds stco.entries (chunk_count). mov_get_stsc_samples now checks for this and returns 0 when values are invalid. --- libavformat/mov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c

[FFmpeg-devel] [PATCH] avformat/isom.h: use usnigned types in MOVStsc

2019-02-01 Thread chcunningham
Unsigned types match the isobmff spec. --- libavformat/isom.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index e629663949..8e0d8355b3 100644 --- a/libavformat/isom.h +++ b/libavformat/isom.h @@ -59,9 +59,9 @@ typedef struct

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

2019-02-01 Thread Michael Niedermayer
On Fri, Feb 01, 2019 at 10:29:13PM +0100, Marton Balint wrote: > > > On Fri, 25 Jan 2019, Marton Balint wrote: > > > > > > >On Fri, 25 Jan 2019, Michael Niedermayer wrote: > > > >>On Thu, Jan 24, 2019 at 09:38:00PM +0100, Marton Balint wrote: > >>>discard_pid can be quite expensive, so let's

[FFmpeg-devel] [PATCH 2/2] avcodec/mpegvideo_enc: Use av_assert1() instead of assert()

2019-02-01 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/mpegvideo_enc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index c5480e17c4..4fa628b741 100644 --- a/libavcodec/mpegvideo_enc.c +++

[FFmpeg-devel] [PATCH 1/2] avcodec/vorbisenc: use av_assert1() instead of assert()

2019-02-01 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/vorbisenc.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavcodec/vorbisenc.c b/libavcodec/vorbisenc.c index 18a679f2dc..54cac0c0ad 100644 --- a/libavcodec/vorbisenc.c +++ b/libavcodec/vorbisenc.c @@ -40,9

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-02-01 Thread Jan Ekström
On Fri, Feb 1, 2019 at 9:54 PM mptcultist wrote: > > ah, i couldn’t find a copy of the standard, i’ll look it over and figure out > what’s actually wrong, as the bug still remains. > ISOBMFF (14496-12) is available for free at https://standards.iso.org/ittf/PubliclyAvailableStandards/index.html

Re: [FFmpeg-devel] [PATCH]lavu/imgutils: Use llabs() for ptrdiff_t

2019-02-01 Thread Carl Eugen Hoyos
2019-02-01 22:58 GMT+01:00, Michael Niedermayer : > On Fri, Feb 01, 2019 at 10:37:22PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes a warning with clang. >> >> Please comment, Carl Eugen > >> imgutils.c |4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >>

Re: [FFmpeg-devel] [PATCH]lavu/imgutils: Use llabs() for ptrdiff_t

2019-02-01 Thread Michael Niedermayer
On Fri, Feb 01, 2019 at 10:37:22PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a warning with clang. > > Please comment, Carl Eugen > imgutils.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > d1c5f9eb38d36664164f3df0170eb946b6d4f1cd >

[FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: Use av_assert1() instead of assert() in merge_context_after_encode()

2019-02-01 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/mpegvideo_enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 9fdab31a25..c5480e17c4 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c

[FFmpeg-devel] [PATCH]lavu/imgutils: Use llabs() for ptrdiff_t

2019-02-01 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a warning with clang. Please comment, Carl Eugen From 5218c47a129a927dd3de781cdd66d2250955b2cb Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 1 Feb 2019 22:34:51 +0100 Subject: [PATCH] lavu/imgutils: Use llabs() for ptrdiff_t. Fixes a warning with clang:

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

2019-02-01 Thread Marton Balint
On Fri, 25 Jan 2019, Marton Balint wrote: On Fri, 25 Jan 2019, Michael Niedermayer wrote: On Thu, Jan 24, 2019 at 09:38:00PM +0100, Marton Balint wrote: discard_pid can be quite expensive, so let's cache it and recalculate it on every packet start. ffmpeg -y -i

Re: [FFmpeg-devel] amf: maintainership of amf components

2019-02-01 Thread Carl Eugen Hoyos
2019-02-01 20:53 GMT+01:00, Alexander Kravchenko : > I am talking about patches which were send while ago I know. I was talking about the missing patch against the MAINTAINER file if you want to take over maintainership. Please find out what "top-posting" means and don't do it here! Carl

Re: [FFmpeg-devel] Access to the dolby vision decoder info

2019-02-01 Thread Hendrik Leppkes
On Fri, Feb 1, 2019 at 8:42 PM Gresserman Dmitrij wrote: > > The main motivation of the patch is to provide the complete structure of the > Dolby Vision Configuration Box and decoder configuration record (dvcC/dvvC) > and the DOVI Video Stream Descriptor. This provided structure can be parsed

Re: [FFmpeg-devel] [PATCH] Support HDR dynamic metadata (HDR10+) in HEVC decoder.

2019-02-01 Thread Hendrik Leppkes
On Tue, Jan 22, 2019 at 11:13 PM Mohammad Izadi wrote: > > --- > libavcodec/hevc_sei.c | 216 -- > libavcodec/hevc_sei.h | 6 ++ > libavcodec/hevcdec.c | 21 > 3 files changed, 237 insertions(+), 6 deletions(-) > Whats the status of this patch

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

2019-02-01 Thread Clément Bœsch
On Fri, Feb 01, 2019 at 05:50:37PM +0800, myp...@gmail.com wrote: [...] > > Ok, makes sense. Would you mind updating the comment to something like: > > > > /* Note: WEIGHT_LUT_SIZE must be larger than max_meaningful_diff > > * (log(255)*max(h)^2, which is approximately 50 with the

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-02-01 Thread mptcultist
ah, i couldn’t find a copy of the standard, i’ll look it over and figure out what’s actually wrong, as the bug still remains. Sent from my iPhone > On Feb 1, 2019, at 2:12 PM, John Stebbins wrote: > >> On 1/30/19 1:18 PM, Carl Eugen Hoyos wrote: >> 2019-01-30 19:44 GMT+01:00, no pls : >>>

Re: [FFmpeg-devel] Access to the dolby vision decoder info

2019-02-01 Thread Gresserman Dmitrij
The main motivation of the patch is to provide the complete structure of the Dolby Vision Configuration Box and decoder configuration record (dvcC/dvvC) and the DOVI Video Stream Descriptor. This provided structure can be parsed now and used (for example in dump.c) to indicate if a dolby vision

Re: [FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

2019-02-01 Thread Alexander Kravchenko
Hello Carl Ok, I’m going to test and coming back. Thanks, Alexander От: ffmpeg-devel от имени Carl Eugen Hoyos Обратный адрес: FFmpeg development discussions and patches Дата: пятница, 1 февраля 2019 г., 21:51 Кому: FFmpeg development discussions and patches Тема: Re:

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-02-01 Thread John Stebbins
On 1/30/19 1:18 PM, Carl Eugen Hoyos wrote: 2019-01-30 19:44 GMT+01:00, no pls : From: mptcultist fixes an issue where if the video size was very specific, ffmpeg would hang from not filling the sidx_pts for all streams, due to not reading the last sidx lump. for #7572 Please wait for a

Re: [FFmpeg-devel] [PATCH] avformat/mov: validate chunk_count vs stsc_data

2019-02-01 Thread Carl Eugen Hoyos
2019-02-01 2:18 GMT+01:00, chcunningham : > Bad content may contain stsc boxes with a first_chunk index that > exceeds stco.entries (chunk_count). > > mov_get_stsc_samples now checks for this and returns 0 when > values are invalid. > Also updates MOVStsc to use unsigned ints, per spec. Could be

[FFmpeg-devel] RTMP Streaming With FFMPEG (Development / Troubleshooting)

2019-02-01 Thread TalkVideo
Hello. I am working on Apps to send RTMP streams. Basically the behavior of av_read_frame() affects how OBS, and as far as I can tell, ffmpeg itself receives data from an incoming stream. This is where I need to do some work so that for example, a stream can come in at whatever time, and be

Re: [FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

2019-02-01 Thread Carl Eugen Hoyos
2019-02-01 19:39 GMT+01:00, Alexander Kravchenko : > I could take manteinership and one person from my team, hopefully > it could help to move pending patches which are required to be > applied and have been waiting for a long time A good start would be to review this patch an stop top-posting.

Re: [FFmpeg-devel] amf: maintainership of amf components

2019-02-01 Thread Carl Eugen Hoyos
2019-02-01 19:45 GMT+01:00, Alexander Kravchenko : > could you add me as maintainer of AMF components: encoder > (+ coming scaler, decoder, vulkan) You forgot to attach your patch (against MAINTAINERS). Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

2019-02-01 Thread Michael Dirks
On 01.02.2019 19:31, Carl Eugen Hoyos wrote: Could you take over mantainership? Unfortunately I lack the necessary FFmpeg experience for this task. Even though I am the maintainer of the OBS Studio AMD Encoder integration, I'd be horribly lost in FFmpegs code when it comes to AMD/AMF.

[FFmpeg-devel] amf: maintainership of amf components

2019-02-01 Thread Alexander Kravchenko
Hello guys, could you add me as maintainer of AMF components: encoder (+ coming scaler, decoder, vulkan) There are lots of my pending patches and it look like nobody else have time to process/review them I know AMF architecture and I already have experience in FFmpeg development.

Re: [FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

2019-02-01 Thread Alexander Kravchenko
Hi guys, I could take manteinership and one person from my team, hopefully it could help to move pending patches which are required to be applied and have been waiting for a long time Thanks Alexander От: ffmpeg-devel от имени Carl Eugen Hoyos Обратный адрес: FFmpeg development

Re: [FFmpeg-devel] Server upgrades

2019-02-01 Thread Carl Eugen Hoyos
2019-02-01 13:53 GMT+01:00, Michael Niedermayer : > The OS and related things on the host on which our servers live > as VMs is being upgraded as it soon would reach end of support otherwise. > The VMs may get similarly upgrades afterwards so there may be slight > outages today. Work is being

Re: [FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

2019-02-01 Thread Carl Eugen Hoyos
2019-02-01 19:25 GMT+01:00, Michael Dirks : > On 15.01.2019 23:41, Michael Dirks wrote: >> On 15.01.2019 23:05, michael.di...@xaymar.com wrote: >>> From: Michael Fabian 'Xaymar' Dirks >>> >>> Adds support for the pict_type field in AVFrame to amf_h264 and >>> amf_h265 simultaneously. This field

Re: [FFmpeg-devel] Access to the dolby vision decoder info

2019-02-01 Thread Carl Eugen Hoyos
2019-02-01 19:15 GMT+01:00, Gresserman Dmitrij : > The prefixes i'm adding to the data are not needed by the > decoder at this point. How does the decoder distinguish between the different data structures? > It's only my approach to provide information on the origin > of the dolby vision decoder

Re: [FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

2019-02-01 Thread Michael Dirks
On 15.01.2019 23:41, Michael Dirks wrote: On 15.01.2019 23:05, michael.di...@xaymar.com wrote: From: Michael Fabian 'Xaymar' Dirks Adds support for the pict_type field in AVFrame to amf_h264 and amf_h265 simultaneously. This field is needed in cases where the application wishes to override

Re: [FFmpeg-devel] Access to the dolby vision decoder info

2019-02-01 Thread Gresserman Dmitrij
The prefixes i'm adding to the data are not needed by the decoder at this point. It's only my approach to provide information on the origin of the dolby vision decoder info. Best Regards [Ein einzigartiges Sounderlebnis mit Loewe und Mimi Defined™]

[FFmpeg-devel] [PATCH] avfilter: add median filter

2019-02-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 15 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/median.h | 47 libavfilter/median_template.c | 152 +++ libavfilter/vf_median.c | 220

Re: [FFmpeg-devel] [PATCH] doc/filters: document ranges and defaults for nlmeans options

2019-02-01 Thread Gyan
On 01-02-2019 11:43 AM, Jun Zhao wrote: document ranges and defaults for nlmeans options Signed-off-by: Jun Zhao --- doc/filters.texi |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index fc98323..d588315 100644 ---

Re: [FFmpeg-devel] Access to the dolby vision decoder info

2019-02-01 Thread Carl Eugen Hoyos
2019-02-01 17:05 GMT+01:00, Gresserman Dmitrij : > i need access to the dolby vision decoder info. > This includes the Dolby Vision Configuration Box and > decoder configuration record (dvcC/dvvC). > Also includes the DOVI Video Stream Descriptor. > Here is my approach attached as a patch. Could

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2019-02-01 Thread Vasile Toncu
Hello, Happy New Year. Any news about this patch? Maybe Carl Eugen Hoyos could help us with this? Best regards. On Thu, Dec 6, 2018 at 6:10 PM Vasile Toncu wrote: > Hi, > > Since this patch is passing all the current tests, all the modification > required by Thomas were implemented and from

[FFmpeg-devel] Access to the dolby vision decoder info

2019-02-01 Thread Gresserman Dmitrij
Hello, i need access to the dolby vision decoder info. This includes the Dolby Vision Configuration Box and decoder configuration record (dvcC/dvvC). Also includes the DOVI Video Stream Descriptor. Here is my approach attached as a patch. Best regards [Ein einzigartiges Sounderlebnis mit Loewe

[FFmpeg-devel] Server upgrades

2019-02-01 Thread Michael Niedermayer
Hi all The OS and related things on the host on which our servers live as VMs is being upgraded as it soon would reach end of support otherwise. The VMs may get similarly upgrades afterwards so there may be slight outages today. Work is being done by Raz. Thanks to Raz for doing this needed work

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

2019-02-01 Thread myp...@gmail.com
On Fri, Feb 1, 2019 at 5:43 PM Clément Bœsch wrote: > On Fri, Feb 01, 2019 at 05:19:53PM +0800, myp...@gmail.com wrote: > > On Fri, Feb 1, 2019 at 5:11 PM Clément Bœsch wrote: > > > > > > On Fri, Feb 01, 2019 at 04:57:37PM +0800, myp...@gmail.com wrote: > > > [...] > > > > > > -#define

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

2019-02-01 Thread Clément Bœsch
On Fri, Feb 01, 2019 at 05:19:53PM +0800, myp...@gmail.com wrote: > On Fri, Feb 1, 2019 at 5:11 PM Clément Bœsch wrote: > > > > On Fri, Feb 01, 2019 at 04:57:37PM +0800, myp...@gmail.com wrote: > > [...] > > > > > -#define WEIGHT_LUT_NBITS 9 > > > > > -#define WEIGHT_LUT_SIZE (1< > > > >

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

2019-02-01 Thread Clément Bœsch
On Fri, Feb 01, 2019 at 04:57:37PM +0800, myp...@gmail.com wrote: [...] > > > -#define WEIGHT_LUT_NBITS 9 > > > -#define WEIGHT_LUT_SIZE (1< > > +#define WEIGHT_LUT_SIZE (80) // need to > 300 * 300 * log(255) > > > > So the LUT is now 3.2MB? > > > > Why 300? 300*300*log(255) is closer to

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

2019-02-01 Thread myp...@gmail.com
On Fri, Feb 1, 2019 at 4:29 PM Clément Bœsch wrote: > > On Fri, Feb 01, 2019 at 10:45:24AM +0800, Jun Zhao wrote: > > Remove the pdiff_lut_scale in nlmeans and increase weight_lut table size > > from 2^9 to 80, this change will avoid using pdiff_lut_scale in > > nlmeans_slice() for weight_lut

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: no need check ref list1 for P slices.

2019-02-01 Thread Lin, Decai
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > myp...@gmail.com > Sent: 2019年2月1日 15:14 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: no need check ref > list1 for P slices.

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

2019-02-01 Thread Clément Bœsch
On Fri, Feb 01, 2019 at 10:45:24AM +0800, Jun Zhao wrote: > Remove the pdiff_lut_scale in nlmeans and increase weight_lut table size > from 2^9 to 80, this change will avoid using pdiff_lut_scale in > nlmeans_slice() for weight_lut table search, it's will improve the > performance about 12%.