Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Hendrik Leppkes
On Wed, Apr 10, 2019 at 3:28 AM James Almer wrote: > > > >> Two thirds of SPS is not hard to implement, so i really don't understand > >> why you're so adamantly against it. > > > > I’m adamant about re-using code between libavcodec and libavformat. > > Re-using code is _good_ > > So lets do what

Re: [FFmpeg-devel] [RFC PATCH] avformat/utils: always seek back after avformat_find_stream_info()

2019-04-09 Thread Hendrik Leppkes
On Wed, Apr 10, 2019 at 2:21 AM Aman Gupta wrote: > > From: Aman Gupta > > Previously, the initial seek position was recorded into > old_offset at the beginning of avformat_find_stream_info(), > and passed into estimate_timings(). In the case of mpegts > with a known filesize, it was further

[FFmpeg-devel] [PATCH] lavfi: add colorkey_opencl filter

2019-04-09 Thread Jarek Samic
This is a direct port of the CPU filter. Signed-off-by: Jarek Samic --- This is my submission for the GSoC OpenCL video filters project qualification task. Command you can use to try it out: ./ffmpeg -i some_video -i some_img -init_hw_device opencl=gpu -filter_hw_device gpu -filter_complex

Re: [FFmpeg-devel] [PATCH RFC v2 2/3] libavcodec: Add thumbnail output to vaapi_h264 decoder

2019-04-09 Thread Li, Zhong
> As my investigation - > - This feature can save some power and memory bandwidth. > - This feature can save the ffmpeg filters code writing for end user. it also > support ARGB output for some AI use case, I think some AI cases may need > ARGB input. IIUC, vaapi SFC scaling in libavfilter path

Re: [FFmpeg-devel] [PATCH RFC v2 1/3] fftools: Add thumbnail output to vaapi_h264 decoder

2019-04-09 Thread Zachary Zhou
On 4/8/19 5:18 PM, myp...@gmail.com wrote: On Mon, Apr 8, 2019 at 4:54 PM Zachary Zhou wrote: This is sample code for reference HW support for decode+scaling in a single HW command (VDBOX+SFC). The primary target usage is video analytics, but can be used playback, transcoding, etc. For

Re: [FFmpeg-devel] [PATCH RFC v2 2/3] libavcodec: Add thumbnail output to vaapi_h264 decoder

2019-04-09 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Wednesday, April 10, 2019 6:27 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH RFC v2 2/3] libavcodec: Add thumbnail > output to vaapi_h264 decoder > > On 08/04/2019 09:53,

Re: [FFmpeg-devel] [PATCH RFC v2 2/3] libavcodec: Add thumbnail output to vaapi_h264 decoder

2019-04-09 Thread Zhou, Zachary
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Mark Thompson > Sent: Wednesday, April 10, 2019 6:27 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH RFC v2 2/3] libavcodec: Add thumbnail > output to vaapi_h264

Re: [FFmpeg-devel] [PATCH] libavfilter: Add derain filter init version--GSoC Qualification Task.

2019-04-09 Thread xwmeng
Hi, Yes, I use the espcn model for deraining as the initial version as it's a easier way to implement the filter, although the paper proposes it for super-resolution. And the model does have some effect on deraining project. While, it is just the first version. I will use more suitable and

Re: [FFmpeg-devel] [PATCH RFC v2 3/3] libavutil: Add thumbnail output to vaapi_h264 decoder

2019-04-09 Thread Zhou, Zachary
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Carl Eugen Hoyos > Sent: Tuesday, April 9, 2019 9:27 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH RFC v2 3/3] libavutil: Add thumbnail > output

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread James Almer
On 4/9/2019 9:40 PM, Baptiste Coudurier wrote: > >> On Apr 9, 2019, at 5:24 PM, James Almer wrote: >> >> On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: >>> On Apr 9, 2019, at 4:51 PM, James Almer wrote: On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: > Hi James, > >>

Re: [FFmpeg-devel] [PATCH RFC v2 2/3] libavcodec: Add thumbnail output to vaapi_h264 decoder

2019-04-09 Thread Zhou, Zachary
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Hendrik Leppkes > Sent: Monday, April 8, 2019 5:27 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH RFC v2 2/3] libavcodec: Add thumbnail > output to

Re: [FFmpeg-devel] [PATCH] Updated the documentation about the encoding options for libaom-av1 encoder.

2019-04-09 Thread Sam John via ffmpeg-devel
James, Thanks for the review. I am sending the updated patch now. libaom-av1 enables global-motion/intrabc by default. These options were added to enable/disable these tools to reduce the complexity. The default value is set to -1. On Thu, Apr 4, 2019 at 10:31 AM James Almer wrote: > On

[FFmpeg-devel] [PATCH] Updated the documentation for libaom encoder options.

2019-04-09 Thread Sam John via ffmpeg-devel
--- doc/encoders.texi | 47 +++ 1 file changed, 47 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 94337d009c..15b9199549 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1434,6 +1434,16 @@ value is 1, which will be

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Baptiste Coudurier
> On Apr 9, 2019, at 5:24 PM, James Almer wrote: > > On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: >> >>> On Apr 9, 2019, at 4:51 PM, James Almer wrote: >>> >>> On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: Hi James, > On Apr 9, 2019, at 4:09 PM, James Almer wrote: >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread James Almer
On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: > >> On Apr 9, 2019, at 4:51 PM, James Almer wrote: >> >> On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: >>> Hi James, >>> On Apr 9, 2019, at 4:09 PM, James Almer wrote: > […] Ok so, the only fields you need from the sps are

[FFmpeg-devel] [RFC PATCH] avformat/utils: always seek back after avformat_find_stream_info()

2019-04-09 Thread Aman Gupta
From: Aman Gupta Previously, the initial seek position was recorded into old_offset at the beginning of avformat_find_stream_info(), and passed into estimate_timings(). In the case of mpegts with a known filesize, it was further passed into estimate_timings_from_pts() which called

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Baptiste Coudurier
> On Apr 9, 2019, at 4:51 PM, James Almer wrote: > > On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: >> Hi James, >> >>> On Apr 9, 2019, at 4:09 PM, James Almer wrote: >>> […] >>> >>> Ok so, the only fields you need from the sps are constraint_set_flags, >>> frame_mbs_only_flag,

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread James Almer
On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: > Hi James, > >> On Apr 9, 2019, at 4:09 PM, James Almer wrote: >> >>> […] >> >> Ok so, the only fields you need from the sps are constraint_set_flags, >> frame_mbs_only_flag, bit_depth_luma, profile_idc, level_idc and sar, >> meaning you don't even

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Baptiste Coudurier
> On Apr 9, 2019, at 4:05 PM, Hendrik Leppkes wrote: > > On Wed, Apr 10, 2019 at 12:21 AM Baptiste Coudurier > wrote: >> +return 0; >> +} >> +init_get_bits(, tmp, tmp_size*8); >> +ret = avpriv_h264_decode_seq_parameter_set(, >>

Re: [FFmpeg-devel] avcodec/videotoolbox: add support for full range and 10bit pixel formats

2019-04-09 Thread Carl Eugen Hoyos
2019-04-09 19:45 GMT+02:00, Jan Ekström : > On Wed, Mar 27, 2019 at 11:32 PM der richter wrote: >> >> the second patch >> > > Generally looks like a nice addition and apparently VideoToolbox seems > to be properly supporting this sort of content (at least according to > the results of

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Baptiste Coudurier
Hi James, > On Apr 9, 2019, at 4:09 PM, James Almer wrote: > >> […] > > Ok so, the only fields you need from the sps are constraint_set_flags, > frame_mbs_only_flag, bit_depth_luma, profile_idc, level_idc and sar, > meaning you don't even need to parse the sps until the very end (sar is > the

Re: [FFmpeg-devel] [PATCH, v4] lavc/vaapi_decode: find exact va_profile for HEVC_REXT

2019-04-09 Thread Mark Thompson
On 09/04/2019 03:33, Linjie Fu wrote: > Use the profile constraint flags to determine the exact va_profile for > HEVC_REXT. > > Directly cast PTLCommon to H265RawProfileTierLevel, Please don't. The two structures aren't really connected, they shouldn't be assumed to be compatible. >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_parse: change prefix to avpriv for usage in avformat mxf muxer

2019-04-09 Thread Hendrik Leppkes
On Wed, Apr 10, 2019 at 12:44 AM Mark Thompson wrote: > > On 09/04/2019 23:14, Baptiste Coudurier wrote: > > --- > > libavcodec/h264_parse.c | 2 +- > > libavcodec/h264_parser.c | 2 +- > > libavcodec/h264_ps.c | 4 ++-- > > libavcodec/h264_ps.h | 4 ++-- > > libavcodec/h264dec.c |

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-04-09 Thread Carl Eugen Hoyos
2019-03-23 0:22 GMT+01:00, Mathieu Duponchelle : > It is perfectly valid to have multiple CC Picture User Data > for the same frame. Instead of using the first side_data > potentially present with the A53_CC type, iterate over all > side_data. Please separate the functional changes in your patch

Re: [FFmpeg-devel] [PATCH v2] aarch64/opusdsp: implement NEON accelerated postfilter and deemphasis

2019-04-09 Thread Carl Eugen Hoyos
2019-04-02 13:47 GMT+02:00, Lynne : > 153372 UNITS in postfilter_c, 65536 runs, 0 skips > 73164 UNITS in postfilter_neon, 65536 runs, 0 skips -> 2.1x speedup > > 80591 UNITS in deemphasis_c, 131072 runs, 0 skips > 43969 UNITS in deemphasis_neon, 131072 runs, 0 skips ->

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread James Almer
On 4/9/2019 7:14 PM, Baptiste Coudurier wrote: > --- > libavformat/Makefile | 2 +- > libavformat/avc.c| 32 +++ > libavformat/avc.h| 2 + > libavformat/hevc.c | 36 +--- > libavformat/mxf.h| 1 + > libavformat/mxfenc.c | 201

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Hendrik Leppkes
On Wed, Apr 10, 2019 at 12:21 AM Baptiste Coudurier wrote: > +return 0; > +} > +init_get_bits(, tmp, tmp_size*8); > +ret = avpriv_h264_decode_seq_parameter_set(, > (AVCodecContext*)s, , 0); The AVCodecContext cast looks like a recipe for

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-04-09 Thread Mathieu Duponchelle
Anyone? :) On 3/23/19 12:22 AM, Mathieu Duponchelle wrote: > It is perfectly valid to have multiple CC Picture User Data > for the same frame. Instead of using the first side_data > potentially present with the A53_CC type, iterate over all > side_data. > --- > libavcodec/mpeg12enc.c | 56

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_parse: change prefix to avpriv for usage in avformat mxf muxer

2019-04-09 Thread Mark Thompson
On 09/04/2019 23:14, Baptiste Coudurier wrote: > --- > libavcodec/h264_parse.c | 2 +- > libavcodec/h264_parser.c | 2 +- > libavcodec/h264_ps.c | 4 ++-- > libavcodec/h264_ps.h | 4 ++-- > libavcodec/h264dec.c | 6 +++--- > 5 files changed, 9 insertions(+), 9 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Baptiste Coudurier
Hi Thomas, I hope you are doing well > On Apr 4, 2019, at 7:27 AM, Thomas Mundt wrote: > > Hi Baptiste, > > […] > For RP2027 Class 100 1080/50i I still get the error: frame size does not > match index unit size, 568832 != 0 > I used the following command: > ffmpeg -f lavfi -i

Re: [FFmpeg-devel] [PATCH RFC v2 2/3] libavcodec: Add thumbnail output to vaapi_h264 decoder

2019-04-09 Thread Mark Thompson
On 08/04/2019 09:53, Zachary Zhou wrote: > This is sample code for reference > > HW support for decode+scaling in a single HW command (VDBOX+SFC). > The primary target usage is video analytics, but can be used playback, > transcoding, etc. > > For VAAPI - > https://github.com/intel/libva >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_parse: change prefix to avpriv for usage in avformat mxf muxer

2019-04-09 Thread Baptiste Coudurier
Hi James, I hope you are doing well > On Apr 3, 2019, at 6:59 AM, James Almer wrote: > > On 4/3/2019 9:25 AM, Baptiste Coudurier wrote: >> Hey Hendrik >> >>> On Apr 3, 2019, at 11:37 AM, Hendrik Leppkes wrote: >>> >>> On Wed, Apr 3, 2019 at 11:22 AM Baptiste Coudurier >>> wrote:

[FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Baptiste Coudurier
--- libavformat/Makefile | 2 +- libavformat/avc.c| 32 +++ libavformat/avc.h| 2 + libavformat/hevc.c | 36 +--- libavformat/mxf.h| 1 + libavformat/mxfenc.c | 201 +-- 6 files changed, 193 insertions(+), 81 deletions(-) diff

[FFmpeg-devel] [PATCH 1/2] avcodec/h264_parse: change prefix to avpriv for usage in avformat mxf muxer

2019-04-09 Thread Baptiste Coudurier
--- libavcodec/h264_parse.c | 2 +- libavcodec/h264_parser.c | 2 +- libavcodec/h264_ps.c | 4 ++-- libavcodec/h264_ps.h | 4 ++-- libavcodec/h264dec.c | 6 +++--- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c index

[FFmpeg-devel] [PATCH v4 5/7] lavfi/vaapi: Improve support for colour properties

2019-04-09 Thread Mark Thompson
Attempts to pick the set of supported colour properties best matching the input. Output is then set with the same values, except for the colour matrix which may change when converting between RGB and YUV. --- On 04/03/2019 11:36, Song, Ruiling wrote: > Why using these magic number instead of

[FFmpeg-devel] [PATCH v4 7/7] vaapi_encode: Warn if input has cropping information

2019-04-09 Thread Mark Thompson
Cropping is not supported by VAAPI encode. --- On 26/03/2019 10:59, Song, Ruiling wrote:> > And do we need to add warning message against crop information in encoder if > user failed to add some vaapi filter after crop? > Seems that vaapi encoder does not encode correctly with crop? That's a

[FFmpeg-devel] [PATCH v4 6/7] vf_scale_vaapi: Add options to configure output colour properties

2019-04-09 Thread Mark Thompson
The "out_color_matrix" and "out_range" properties match the same options in vf_scale; the others attempt to follow the same pattern. --- libavfilter/vf_scale_vaapi.c | 70 1 file changed, 70 insertions(+) diff --git a/libavfilter/vf_scale_vaapi.c

[FFmpeg-devel] [PATCH v4 4/7] vf_misc_vaapi: Add missing return value checks

2019-04-09 Thread Mark Thompson
Parameter buffer creation can fail. --- libavfilter/vf_misc_vaapi.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_misc_vaapi.c b/libavfilter/vf_misc_vaapi.c index 6f31a04293..6fbd453741 100644 --- a/libavfilter/vf_misc_vaapi.c +++

[FFmpeg-devel] [PATCH v4 2/7] doc/indevs: Add example using cropping to capture part of a plane

2019-04-09 Thread Mark Thompson
--- doc/indevs.texi | 8 1 file changed, 8 insertions(+) diff --git a/doc/indevs.texi b/doc/indevs.texi index 1d5ed65773..a4f0f608d7 100644 --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -910,6 +910,14 @@ Capture from CRTC ID 42 at 60fps, map the result to VAAPI, convert to NV12 and e

[FFmpeg-devel] [PATCH v4 1/7] vf_crop: Add support for cropping hardware frames

2019-04-09 Thread Mark Thompson
Set the cropping fields in the AVFrame. --- On 26/03/2019 10:59, Song, Ruiling wrote:> > I think we need to make scale_vaapi evaluate input dimensions considering > crop information. What do you think? I agree. But the cropping information is currently carried on the frame, not at any higher

[FFmpeg-devel] [PATCH v4 3/7] lavfi/vaapi: Factorise out common code for parameter buffer setup

2019-04-09 Thread Mark Thompson
Also enables cropping on all VAAPI filters, inherited from the existing support in scale_vaapi. --- libavfilter/vaapi_vpp.c| 55 -- libavfilter/vaapi_vpp.h| 8 - libavfilter/vf_deinterlace_vaapi.c | 33 --

Re: [FFmpeg-devel] [PATCH v2] libavutil/hwcontext_opencl.c: fix bug in `opencl_get_plane_format`

2019-04-09 Thread Mark Thompson
On 09/04/2019 02:08, Song, Ruiling wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Mark Thompson >> Sent: Tuesday, April 9, 2019 3:49 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v2]

[FFmpeg-devel] [PATCH 1/2] avcodec/agm: add support for higher compression

2019-04-09 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/agm.c | 404 +++-- libavformat/riff.c | 4 + 2 files changed, 392 insertions(+), 16 deletions(-) diff --git a/libavcodec/agm.c b/libavcodec/agm.c index cbd45e8095..1d6a277827 100644 --- a/libavcodec/agm.c +++

[FFmpeg-devel] [PATCH 2/2] avcodec/agm: add support for non-dct coding

2019-04-09 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/agm.c | 332 +++-- libavformat/riff.c | 2 + 2 files changed, 291 insertions(+), 43 deletions(-) diff --git a/libavcodec/agm.c b/libavcodec/agm.c index 1d6a277827..e465b22d41 100644 --- a/libavcodec/agm.c +++

[FFmpeg-devel] [PATCH 3/3] avdevice/decklink_common: add support for DeckLink SDK 11

2019-04-09 Thread Marton Balint
Fixes ticket #7789. Signed-off-by: Marton Balint --- libavdevice/decklink_common.cpp | 53 ++--- libavdevice/decklink_common.h | 6 - 2 files changed, 55 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_common.cpp

[FFmpeg-devel] [PATCH 1/3] avdevice/decklink_dec: set configs before listing formats

2019-04-09 Thread Marton Balint
Format list can be input and profile dependant. Signed-off-by: Marton Balint --- libavdevice/decklink_dec.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 9de8fa0c9d..4da9122bff 100644 ---

[FFmpeg-devel] [PATCH 2/3] avdevice/decklink_common: properly check DoesSupportVideoMode result when trying VANC flag

2019-04-09 Thread Marton Balint
Signed-off-by: Marton Balint --- libavdevice/decklink_common.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/decklink_common.cpp b/libavdevice/decklink_common.cpp index d3cc1eb3d1..3902311edd 100644 --- a/libavdevice/decklink_common.cpp +++

Re: [FFmpeg-devel] [PATCHv2] avformat/file: add seekable option to disallow seeking

2019-04-09 Thread Marton Balint
On Sun, 7 Apr 2019, Marton Balint wrote: v2: Disallow positive override of seekability as requested by Hendrik Leppkes. Ping, will apply soon. Thanks, Marton Signed-off-by: Marton Balint --- doc/protocols.texi | 8 libavformat/file.c | 5 + 2 files changed, 13 insertions(+)

[FFmpeg-devel] [PATCH 3/3] avcodec/h264dec: don't ignore ff_h264_queue_decode_slice() return values

2019-04-09 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h264dec.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 837c3b7538..85a57fc124 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -637,7 +637,7 @@ static

[FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-09 Thread James Almer
Fixes ticket #7174. Signed-off-by: James Almer --- This makes what's essentially a non spec compliant stream decodable again with no visual artifacts, and without reintroducing the risk of overflows. Alternatively, we could clip the luma and chroma values to the -128..127 range instead of

[FFmpeg-devel] [PATCH 1/3] avcodec/h264_parse: clear invalid luma weights in ff_h264_pred_weight_table()

2019-04-09 Thread James Almer
Based on commit 85c85f3f9c75301db3eba1bd5f2fb1e6285d. Signed-off-by: James Almer --- libavcodec/h264_parse.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c index a075443d17..8bdd886000 100644 ---

[FFmpeg-devel] [PATCH v6] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Shivam Goyal
lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720. >From 605dc262abf948813c26d58f51d5e2d7f498d9cd Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Tue, 9 Apr 2019 23:36:27 +0530 Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720. --- Changelog

Re: [FFmpeg-devel] avcodec/videotoolbox: add support for full range and 10bit pixel formats

2019-04-09 Thread Jan Ekström
On Wed, Mar 27, 2019 at 11:32 PM der richter wrote: > > the second patch > Generally looks like a nice addition and apparently VideoToolbox seems to be properly supporting this sort of content (at least according to the results of https://github.com/mpv-player/mpv/issues/6546 ). The first part

Re: [FFmpeg-devel] [PATCH] libavfilter: Add derain filter init version--GSoC Qualification Task.

2019-04-09 Thread Pedro Arthur
Em ter, 9 de abr de 2019 às 04:15, escreveu: > > +Training scripts as well as scripts for model generation are provided in > +the repository at @url{https://github.com/XueweiMeng/derain_filter.git}. This repository is a copy of a previous year student [1], which is MIT licensed, and therefore

Re: [FFmpeg-devel] avcodec/videotoolbox: add support for full range and 10bit pixel formats

2019-04-09 Thread Jan Ekström
Hi, On Wed, Mar 27, 2019 at 11:34 PM der richter wrote: > > apparently the first patch didn't make it through > Sorry for this taking a while. This has been generally tested to build and work with XCode 10.1 (I think this is the newest version still available for 10.13.x) and generally seems

Re: [FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Moritz Barsnick
On Tue, Apr 09, 2019 at 20:45:41 +0530, Shivam Goyal wrote: > > I believe Carl Eugen asked you to change this to: > > AVPROBE_SCORE_EXTENSION / 2 + 1 > Carl Eugen suggested me to change to AVPROBE_SCORE_MAX /2 +1 Ah, sorry, my bad - I missed that. Thanks, Moritz

Re: [FFmpeg-devel] [PATCH] libavfilter: Add derain filter init version--GSoC Qualification Task.

2019-04-09 Thread Pedro Arthur
Hi, Em ter, 9 de abr de 2019 às 04:15, escreveu: > +@section derain > + > +Remove the rain in the input image/video by applying the derain methods > based on > +convolutional neural networks. Supported models: > + > +@itemize > +@item > +Efficient Sub-Pixel Convolutional Neural Network model

Re: [FFmpeg-devel] [PATCH] avdevice/opengl_enc: fix build error using msvc compiler

2019-04-09 Thread BIGLER Don (Framatome)
>2019-04-08 17:07 GMT+02:00, BIGLER Don (Framatome) : >> diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c >> index 54c7e610bd..4263f0e4ef 100644 >> --- a/libavdevice/opengl_enc.c >> +++ b/libavdevice/opengl_enc.c >> @@ -25,7 +25,7 @@ >> #include >> #include >> #include >>

Re: [FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Shivam Goyal
On 09-04-2019 08:32 PM, Moritz Barsnick wrote: Some minor nitpicking remarks from me: Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720. Basically, the second sentence belongs into the body of the commit message, after a single empty line separator. (It may not

Re: [FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Moritz Barsnick
Some minor nitpicking remarks from me: > Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720. Basically, the second sentence belongs into the body of the commit message, after a single empty line separator. (It may not matter here.) > Changelog| 1 + >

Re: [FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Carl Eugen Hoyos
2019-04-09 16:19 GMT+02:00, Shivam Goyal : > lavf/flv: Add XV (Xunlei Video) Support. > > Fixes ticket #3720 > > I have fixed the minor mistakes in the patch. I have also > checked the patch with patcheck. > +offset = ((avio_r8(ic) + rot & 0xff) << 24 | > +(avio_r8(ic) + rot &

[FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Shivam Goyal
lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720 I have fixed the minor mistakes in the patch. I have also checked the patch with patcheck. >From a64698a11c10ec62968a5d853d7db0fed956c0d3 Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Tue, 9 Apr 2019 19:25:23 +0530 Subject:

Re: [FFmpeg-devel] [PATCH] apedec: add ability to check CRC

2019-04-09 Thread Lynne
Apr 7, 2019, 12:56 AM by mich...@niedermayer.cc: > On Sat, Apr 06, 2019 at 10:44:00AM +0200, Lynne wrote: > >> Apr 4, 2019, 10:30 AM by >> mich...@niedermayer.cc >> >> : >> >> > On Wed, Mar 06, 2019 at 02:47:37PM +0100, Lynne wrote: >> > >> >> 6 Mar 2019, 11:22

Re: [FFmpeg-devel] [PATCH v2] aarch64/opusdsp: implement NEON accelerated postfilter and deemphasis

2019-04-09 Thread Lynne
Apr 6, 2019, 3:41 PM by ceffm...@gmail.com: > 2019-04-06 16:08 GMT+02:00, Lynne <> d...@lynne.ee > >: > >> >> >> >> Apr 6, 2019, 2:42 PM by >> ceffm...@gmail.com >> : >> >>> 2019-04-02 13:47 GMT+02:00, Lynne <> >>> d...@lynne.ee >>>

Re: [FFmpeg-devel] [PATCH] matroskaenc: fix leak on error

2019-04-09 Thread James Almer
On 4/9/2019 10:28 AM, Tristan Matthews wrote: > On Thu, Apr 4, 2019 at 12:56 PM Tristan Matthews wrote: >> >> --- >> libavformat/matroskaenc.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c >> index

Re: [FFmpeg-devel] [Patch v4] flv: Add XV (Xunlie Video) Support, Updated patch for ticket #3720

2019-04-09 Thread Carl Eugen Hoyos
2019-04-09 15:26 GMT+02:00, Shivam Goyal : > > On 4/9/19 5:10 PM, Carl Eugen Hoyos wrote: >> 2019-04-09 11:36 GMT+02:00, Shivam Goyal : >> The following probably doesn't work for some very large files: >> >>> +offset = ((avio_r8(ic) + rot & 0xff)<<24) | >>> + ((avio_r8(ic) + rot &

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Pass correct pointer to av_log().

2019-04-09 Thread Carl Eugen Hoyos
2019-04-08 3:40 GMT+02:00, myp...@gmail.com : > On Mon, Apr 8, 2019 at 5:30 AM Carl Eugen Hoyos wrote: >> >> Hi! >> >> Attached patch is what git grep showed me after seeing ecdaa4b4 by Paul. >> >> Please comment, Carl Eugen > LGTM if pass the fate. Thanks Patch applied. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH] matroskaenc: fix leak on error

2019-04-09 Thread Tristan Matthews
On Thu, Apr 4, 2019 at 12:56 PM Tristan Matthews wrote: > > --- > libavformat/matroskaenc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index b9f99c4463..1a06103c5d 100644 > --- a/libavformat/matroskaenc.c >

Re: [FFmpeg-devel] [PATCH RFC v2 3/3] libavutil: Add thumbnail output to vaapi_h264 decoder

2019-04-09 Thread Carl Eugen Hoyos
2019-04-08 10:53 GMT+02:00, Zachary Zhou : > This is sample code for reference > > HW support for decode+scaling in a single HW command (VDBOX+SFC). > The primary target usage is video analytics, but can be used playback, > transcoding, etc. Yes. So why is the feature called "thumbnail"? I

Re: [FFmpeg-devel] [Patch v4] flv: Add XV (Xunlie Video) Support, Updated patch for ticket #3720

2019-04-09 Thread Shivam Goyal
On 4/9/19 5:10 PM, Carl Eugen Hoyos wrote: 2019-04-09 11:36 GMT+02:00, Shivam Goyal : flv: Add XV (Xunlie Video) Support. Updated patch for ticket #3720. Above is an acceptable commit message, slightly better would be: " lavf/flv: Add XV (Xunlie Video) Support. Fixes ticket #3720. " I

Re: [FFmpeg-devel] [PATCH] lavfi: add nlmeans_opencl filter

2019-04-09 Thread Carl Eugen Hoyos
2019-04-09 4:54 GMT+02:00, Song, Ruiling : >> > +kernel void vert_sum(__global uint4 *ii, >> > + int width, >> > + int height) >> > +{ >> > +int x = get_global_id(0); >> > +uint4 sum = 0; >> > +for (int i = 0; i < height; i++) { >> > +

Re: [FFmpeg-devel] [Patch v4] flv: Add XV (Xunlie Video) Support, Updated patch for ticket #3720

2019-04-09 Thread Carl Eugen Hoyos
2019-04-09 11:36 GMT+02:00, Shivam Goyal : > flv: Add XV (Xunlie Video) Support. > > Updated patch for ticket #3720. Above is an acceptable commit message, slightly better would be: " lavf/flv: Add XV (Xunlie Video) Support. Fixes ticket #3720. " I applied your patch with git am and what I get

Re: [FFmpeg-devel] [Patch v4] flv: Add XV (Xunlie Video) Support, Updated patch for ticket #3720

2019-04-09 Thread Steven Liu
Steven Liu 于2019年4月9日周二 下午5:46写道: > > maybe title should change from > flv: Add XV (Xunlie Video) Support, Updated patch for ticket #3720 > to > flv: Add XV (Xunlei Video) Support, Updated patch for ticket #3720 Ignore my comment please, the attachment file is correct. > > Shivam Goyal

Re: [FFmpeg-devel] [Patch v4] flv: Add XV (Xunlie Video) Support, Updated patch for ticket #3720

2019-04-09 Thread Steven Liu
maybe title should change from flv: Add XV (Xunlie Video) Support, Updated patch for ticket #3720 to flv: Add XV (Xunlei Video) Support, Updated patch for ticket #3720 Shivam Goyal 于2019年4月9日周二 下午5:36写道: > > flv: Add XV (Xunlie Video) Support. > > Updated patch for ticket #3720. > > > > >

[FFmpeg-devel] [Patch v4] flv: Add XV (Xunlie Video) Support, Updated patch for ticket #3720

2019-04-09 Thread Shivam Goyal
flv: Add XV (Xunlie Video) Support. Updated patch for ticket #3720. >From 4e976186059b0fc41de7b65f538c352d264477d4 Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Tue, 9 Apr 2019 15:00:49 +0530 Subject: [PATCH] Updated patch for ticket #3720. flv: Add XV (Xunlei Video) support ---

[FFmpeg-devel] [PATCH] avformat/hlsenc: flush packets before update split message

2019-04-09 Thread Steven Liu
fix ticket: 7831 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 5f9a200c6e..6b913be31c 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2241,6 +2241,7 @@ static int

Re: [FFmpeg-devel] [PATCH] avfilter/af_asetnsamples: fix sample queuing.

2019-04-09 Thread Tobias Rapp
On 06.04.2019 02:11, Nikolas Bowe via ffmpeg-devel wrote: When asetnsamples uses output samples < input samples, remaining samples build up in the fifo over time. Fix this by marking the filter as ready again if there are enough samples. Regression since

Re: [FFmpeg-devel] [RFC 2/6] Add common V4L2 request API code

2019-04-09 Thread Jonas Karlman
On 2019-04-09 01:32, Jonas Karlman wrote: > On 2019-04-09 00:35, James Almer wrote: >> On 4/8/2019 5:12 PM, Jonas Karlman wrote: >>> Signed-off-by: Jonas Karlman >>> --- >>> configure | 8 + >>> libavcodec/Makefile | 1 + >>> libavcodec/hwaccel.h | 2 + >>>

Re: [FFmpeg-devel] [PATCH] libavfilter: Add derain filter init version--GSoC Qualification Task.

2019-04-09 Thread Liu Steven
> 在 2019年4月9日,下午3:14,xwm...@pku.edu.cn 写道: > > This patch is the qualification task of the derain filter project in GSoC. > It maybe better if you submit a model file and test example here. > From 61463dfe14c0e0de4e233f68c8404d73d5bd9f8f Mon Sep 17 00:00:00 2001 > > From: Xuewei Meng >

Re: [FFmpeg-devel] [PATCH] libavfilter: Add derain filter init version--GSoC Qualification Task.

2019-04-09 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of xwm...@pku.edu.cn > Sent: Tuesday, April 09, 2019 3:15 PM > To: ffmpeg-devel@ffmpeg.org > Cc: l...@chinaffmpeg.org > Subject: [FFmpeg-devel] [PATCH] libavfilter: Add derain filter init

[FFmpeg-devel] [PATCH] libavfilter: Add derain filter init version--GSoC Qualification Task.

2019-04-09 Thread xwmeng
This patch is the qualification task of the derain filter project in GSoC. From 61463dfe14c0e0de4e233f68c8404d73d5bd9f8f Mon Sep 17 00:00:00 2001 From: Xuewei Meng Date: Tue, 9 Apr 2019 15:09:33 +0800 Subject: [PATCH] Add derain filter init version-GSoC Qualification Task Signed-off-by: