Re: [FFmpeg-devel] [PATCH v4] avutil/mips: refine msa macros CLIP_*.

2019-08-11 Thread Shiyou Yin
>-Original Message- >From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] >On Behalf Of >Michael Niedermayer >Sent: Friday, August 9, 2019 12:07 AM >To: FFmpeg development discussions and patches >Subject: Re: [FFmpeg-devel] [PATCH v4] avutil/mips: refine msa

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/hevcdec: Check delta_luma_weight_l0/1

2019-08-11 Thread James Almer
On 8/11/2019 9:17 PM, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1 + 2147483647 cannot be represented in type > 'int' > Fixes: > 16041/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5685680656613376 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH v2] avfilter/f_select: yuv will use Y plane only for scenecut detect

2019-08-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/f_select.c | 3 ++- tests/ref/fate/filter-metadata-scenedetect | 16 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c index

Re: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: Fix build failures

2019-08-11 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Andreas Rheinhardt > Sent: Monday, August 12, 2019 9:15 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: Fix build failures

[FFmpeg-devel] [PATCH] avfilter/vf_convolution: Fix build failures

2019-08-11 Thread Andreas Rheinhardt
98e419cb added SIMD for the convolution filter for x64 systems. As usual, it used a check of the form if (ARCH_X86_64) ff_convolution_init_x86(s); and thereby relied on the compiler eliminating this pseudo-runtime check at compiletime for non x64 systems (for which ff_convolution_init_x86

[FFmpeg-devel] [PATCH 4/6] [RFC] avcodec/motionpixels: Check for end of input in mp_decode_frame_helper()

2019-08-11 Thread Michael Niedermayer
Improves: Timeout (75sec -> 50sec) Improves: 16053/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOTIONPIXELS_fuzzer-5647069169057792 Together with the planed reduction in the threshold this would bring this to 20sec and fix the Timeout Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 5/6] avcodec/4xm: Check for end of input in decode_p_block()

2019-08-11 Thread Michael Niedermayer
Fixes: Timeout (81sec -> 0.2sec) Fixes: 16169/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5662570416963584 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/4xm.c | 2 ++ 1

[FFmpeg-devel] [PATCH 6/6] avcodec/vb: Check input packet size to be large enough to contain flags

2019-08-11 Thread Michael Niedermayer
Fixes: Timeout (->9sec) Fixes: 16292/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VB_fuzzer-5747063496638464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vb.c | 3 +++ 1 file changed,

[FFmpeg-devel] [PATCH 3/6] [RFC] avcodec/motionpixels: Mark 2 functions as always_inline

2019-08-11 Thread Michael Niedermayer
Improves: Timeout (90 -> 75sec) Improves: 16053/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOTIONPIXELS_fuzzer-5647069169057792 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 2/6] avcodec/hevcdec: Check delta_luma_weight_l0/1

2019-08-11 Thread Michael Niedermayer
Fixes: signed integer overflow: 1 + 2147483647 cannot be represented in type 'int' Fixes: 16041/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5685680656613376 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 1/6] avcodec/tta: Fix integer overflow in prediction

2019-08-11 Thread Michael Niedermayer
Fixes: signed integer overflow: -395281576 + -1827578048 cannot be represented in type 'int' Fixes: 16038/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5646109705240576 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH v2 1/2] swscale: Replace illegal vector keyword usage in altivec code

2019-08-11 Thread Daniel Kolesa
On Sun, Aug 11, 2019, at 21:37, Reimar Döffinger wrote: > On 07.08.2019, at 19:39, Daniel Kolesa wrote: > > > While this technically compiles in current ffmpeg, this is only > > because ffmpeg is compiled in strict ISO C mode, which disables > > the builtin 'vector' keyword for AltiVec/VSX.

Re: [FFmpeg-devel] [PATCH v2 2/2] swscale: Fix AltiVec/VSX build with recent GCC

2019-08-11 Thread Daniel Kolesa
On Sun, Aug 11, 2019, at 21:39, Reimar Döffinger wrote: > On 11.08.2019, at 21:24, Reimar Döffinger wrote: > > > On 07.08.2019, at 19:39, Daniel Kolesa wrote: > > > >> The argument to vec_splat_u16 must be a literal. By making the > >> function always inline and marking the arguments const,

Re: [FFmpeg-devel] [PATCH v1] avfilter/f_select: yuv will use Y plane only for scenecut detect

2019-08-11 Thread Limin Wang
On Sat, Aug 10, 2019 at 11:04:37PM +0200, Marton Balint wrote: > > > On Sun, 11 Aug 2019, lance.lmw...@gmail.com wrote: > > >From: Limin Wang > > > >It'll improve about +0.1 threshold for scenecut detect > > > >Signed-off-by: Limin Wang > >--- > >libavfilter/f_select.c |

Re: [FFmpeg-devel] [PATCH]lavc/zmbvenc: Do not left-shift negative values

2019-08-11 Thread Carl Eugen Hoyos
Am Mo., 1. Juli 2019 um 20:41 Uhr schrieb Michael Niedermayer : > > On Mon, Jul 01, 2019 at 01:47:46AM +0200, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes the only (remaining) issue I see with the sample > > of ticket #7980. > > > > Please comment, Carl Eugen > > > zmbvenc.c |

Re: [FFmpeg-devel] [PATCH] avcodec/encode: only allow undersized audio frames if they are the last

2019-08-11 Thread Marton Balint
On Sat, 10 Aug 2019, Marton Balint wrote: On Sun, 4 Aug 2019, Marton Balint wrote: On Sat, 3 Aug 2019, Lynne wrote: Aug 3, 2019, 9:40 PM by c...@passwd.hu: Otherwise the user might get a silence padded frame in the beginning or in the middle of the encoding. Some other bug

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-11 Thread Marton Balint
On Sun, 11 Aug 2019, Andreas Håkon wrote: Hi Marton, > This new version LGTM. Thanks. I did a slight change for VBR streams and tried to mimic the old behaviour when selecting a PCR interval. Will post an updated version, but that should only affect VBR. Regarding this new VBR patch I

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-11 Thread Reimar Döffinger
On 11.08.2019, at 21:51, Marton Balint wrote: > > > On Sun, 11 Aug 2019, Reimar Döffinger wrote: > >> On 11.08.2019, at 20:41, Reimar Döffinger wrote: >> >>> On 05.08.2019, at 23:34, Marton Balint wrote: These functions can be used to print a variable number of strings

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-11 Thread Marton Balint
On Sun, 11 Aug 2019, Reimar Döffinger wrote: On 11.08.2019, at 20:41, Reimar Döffinger wrote: On 05.08.2019, at 23:34, Marton Balint wrote: These functions can be used to print a variable number of strings consecutively to the IO context. Unlike av_bprintf, no temporery buffer is

Re: [FFmpeg-devel] [PATCH v2 2/2] swscale: Fix AltiVec/VSX build with recent GCC

2019-08-11 Thread Reimar Döffinger
On 11.08.2019, at 21:24, Reimar Döffinger wrote: > On 07.08.2019, at 19:39, Daniel Kolesa wrote: > >> The argument to vec_splat_u16 must be a literal. By making the >> function always inline and marking the arguments const, gcc can >> turn those into literals, and avoid build errors like: > >

Re: [FFmpeg-devel] [PATCH v2 1/2] swscale: Replace illegal vector keyword usage in altivec code

2019-08-11 Thread Reimar Döffinger
On 07.08.2019, at 19:39, Daniel Kolesa wrote: > While this technically compiles in current ffmpeg, this is only > because ffmpeg is compiled in strict ISO C mode, which disables > the builtin 'vector' keyword for AltiVec/VSX. Instead this gets > replaced with a macro inside altivec.h, which

Re: [FFmpeg-devel] [PATCH v2 2/2] swscale: Fix AltiVec/VSX build with recent GCC

2019-08-11 Thread Reimar Döffinger
On 07.08.2019, at 19:39, Daniel Kolesa wrote: > The argument to vec_splat_u16 must be a literal. By making the > function always inline and marking the arguments const, gcc can > turn those into literals, and avoid build errors like: Why marking the arguments const? If it depends on that it

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-11 Thread Reimar Döffinger
On 11.08.2019, at 20:41, Reimar Döffinger wrote: > On 05.08.2019, at 23:34, Marton Balint wrote: > >> These functions can be used to print a variable number of strings >> consecutively >> to the IO context. Unlike av_bprintf, no temporery buffer is necessary. > > Hm, is there a use-example

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-11 Thread Reimar Döffinger
On 05.08.2019, at 23:34, Marton Balint wrote: > These functions can be used to print a variable number of strings > consecutively > to the IO context. Unlike av_bprintf, no temporery buffer is necessary. Hm, is there a use-example patch I missed? Also is the #define ugliness worth it compared

Re: [FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

2019-08-11 Thread Reimar Döffinger
On 08.08.2019, at 10:36, Michael Niedermayer wrote: > This provides an alternative to retry counters. > Useful if there is no reasonable maximum number of iterations and > no ordering that naturally avoids loops. Going by the old principle of "an API is not tested until it has at least 3

Re: [FFmpeg-devel] [PATCH] libavformat/rtspdec: Don't send teardown if rtsp_hd_out is null

2019-08-11 Thread Ross Nicholson
3rd time lucky, can anyone take a look at this? It’s a minor patch and is required for kodi. Thanks in advance > On 8 Aug 2019, at 11:46, Ross Nicholson wrote: > > Any feedback on this patch? > >> On Mon, 5 Aug 2019 at 00:18, Ross Nicholson wrote: >> Example stream that does not work: >>

Re: [FFmpeg-devel] [PATCH]lavf/dump: Fix cpb bitrate types after next major bump

2019-08-11 Thread James Almer
On 8/11/2019 2:07 PM, Michael Niedermayer wrote: > On Sun, Aug 11, 2019 at 01:38:38PM -0300, James Almer wrote: >> On 8/11/2019 1:08 PM, Michael Niedermayer wrote: >>> On Sat, Aug 10, 2019 at 11:51:15PM +0200, Carl Eugen Hoyos wrote: Am Sa., 10. Aug. 2019 um 17:01 Uhr schrieb James Almer :

Re: [FFmpeg-devel] [PATCH]lavf/dump: Fix cpb bitrate types after next major bump

2019-08-11 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 01:38:38PM -0300, James Almer wrote: > On 8/11/2019 1:08 PM, Michael Niedermayer wrote: > > On Sat, Aug 10, 2019 at 11:51:15PM +0200, Carl Eugen Hoyos wrote: > >> Am Sa., 10. Aug. 2019 um 17:01 Uhr schrieb James Almer : > >>> > >>> On 8/10/2019 9:47 AM, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH]lavf/dump: Fix cpb bitrate types after next major bump

2019-08-11 Thread James Almer
On 8/11/2019 1:08 PM, Michael Niedermayer wrote: > On Sat, Aug 10, 2019 at 11:51:15PM +0200, Carl Eugen Hoyos wrote: >> Am Sa., 10. Aug. 2019 um 17:01 Uhr schrieb James Almer : >>> >>> On 8/10/2019 9:47 AM, Carl Eugen Hoyos wrote: Hi! Attached patch fixes a compilation warning when

Re: [FFmpeg-devel] [PATCH]lavf/dump: Fix cpb bitrate types after next major bump

2019-08-11 Thread Michael Niedermayer
On Sat, Aug 10, 2019 at 11:51:15PM +0200, Carl Eugen Hoyos wrote: > Am Sa., 10. Aug. 2019 um 17:01 Uhr schrieb James Almer : > > > > On 8/10/2019 9:47 AM, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch fixes a compilation warning when compiling without > > >

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/hevc_refs: Optimize 16bit generate_missing_ref()

2019-08-11 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 12:51:59PM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excellence is to question oneself and others. -- Socrates

Re: [FFmpeg-devel] [PATCH] avcodec/scpr: Use av_memcpy_backptr() in type 17 and 33

2019-08-11 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 12:56:53PM +0200, Paul B Mahol wrote: > lgtm will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He who speaks, does not know. -- Lao Tsu signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_scale: Ensure scaled video is divisible by n

2019-08-11 Thread Michael Niedermayer
On Mon, Jul 08, 2019 at 05:43:40PM +0200, Lars Kiesow wrote: > This patch adds a new option to the scale filter which ensures that the > output resolution is divisible by the given integer when used together > with `force_original_aspect_ratio`. This works similar to using `-n` in > the `w` and

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/tiff: Enforce increasing offsets

2019-08-11 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 11:32:36AM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User questions about the command line tools should be

Re: [FFmpeg-devel] [PATCH 6/8] avformat/vividas: Fix another infinite loop

2019-08-11 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 11:04:12AM +0200, Paul B Mahol wrote: > On Sat, Aug 10, 2019 at 11:17 PM Michael Niedermayer > wrote: > > > Not found by the fuzzer > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/vividas.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH 5/8] avformat/vividas: Fix infinite loop in header parser

2019-08-11 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 11:04:32AM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/mpc8: Fix 32bit mask/enum

2019-08-11 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 11:05:41AM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User questions about the command line tools should be

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: make transfer_fnc initialized for unsupport function

2019-08-11 Thread Rick Kern
On Sat, Aug 10, 2019 at 11:02 AM Limin Wang wrote: > > > ping the change! > Tests look good. Pushed. > > On Thu, Jul 18, 2019 at 06:59:35AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > The current function will report one error message, but the caller func > > haven't

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vp56: Consider the alpha start as end of the prior header

2019-08-11 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 09:29:14AM +1000, Peter Ross wrote: > On Tue, Aug 06, 2019 at 11:30:02PM +0200, Michael Niedermayer wrote: > > Fixes: Timeout (23sec -> 71ms) > > Fixes: > > 15661/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP6A_fuzzer-6257865947348992 > > > > Found-by: continuous

[FFmpeg-devel] [PATCH v14 13/14] lavc/tiff: Support DNGs with striped (non-tiled) JPEGs images

2019-08-11 Thread Nick Renieris
From: Nick Renieris DNG samples here can now be decoded: - https://www.photographyblog.com/previews/pentax_k1_photos Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 61 --- 1 file changed, 37 insertions(+), 24 deletions(-) diff --git

[FFmpeg-devel] [PATCH v14 14/14] lavc/tiff: Default-initialize WhiteLevel DNG tag value

2019-08-11 Thread Nick Renieris
From: Nick Renieris Initialized to `(2 ^ BitsPerSample) - 1` as per the DNG Specification. Also make sure that `BlackLevel < WhiteLevel`. This fixes decoding for "X7 CinemaDNG" samples here: - https://www.dji.com/gr/zenmuse-x7/info#downloads Signed-off-by: Nick Renieris ---

[FFmpeg-devel] [PATCH v14 12/14] lavc/mjpegdec: Skip unknown APPx marker on bayer images

2019-08-11 Thread Nick Renieris
From: Nick Renieris Samples: - Embedded JPEG images in the DNG images here: https://www.photographyblog.com/previews/pentax_k1_photos Signed-off-by: Nick Renieris --- libavcodec/mjpegdec.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavcodec/mjpegdec.c

[FFmpeg-devel] [PATCH v14 11/14] lavc/tiff: Decode 14-bit DNG images

2019-08-11 Thread Nick Renieris
From: Nick Renieris Sample file: https://drive.google.com/open?id=0B4JyRT3Lth5HVndyOTVOdWktM3J4TFEydTk1MnY3RWlpSzVB Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/libavcodec/tiff.c

[FFmpeg-devel] [PATCH v14 10/14] lavc/tiff: Support decoding of DNGs with single-component JPEGs

2019-08-11 Thread Nick Renieris
From: Nick Renieris This enables decoding of DNG images generated by the 'DJI Zenmuse X7' digital camera Samples: https://www.dji.com/gr/zenmuse-x7/info#downloads Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 61 +++ 1 file changed, 51

[FFmpeg-devel] [PATCH v14 08/14] lavc/tiff: Force DNG pixel data endianness on an edge case

2019-08-11 Thread Nick Renieris
From: Nick Renieris Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index ff9ac30b3f..709bbfb301 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1038,6 +1038,18 @@ static int

[FFmpeg-devel] [PATCH v14 05/14] lavc/jpegtables: Handle multiple mappings to the same value

2019-08-11 Thread Nick Renieris
From: Nick Renieris Some JPEGs [1] have incorrect DHT entries that map 2 codes to the same value. The second (last) mapping does not ever actually appear in the code stream, therefore ignoring any mappings after the first one fixes this. Without this, an "mjpeg_decode_dc: bad vlc: 0:0" error

[FFmpeg-devel] [PATCH v14 09/14] lavc/mjpegdec: Enable decoding of single-component bayer images

2019-08-11 Thread Nick Renieris
From: Nick Renieris Also, ensure no false positives when determining DNG bayer images, by setting them in tiff.c instead of relying on a heuristic. There's no way to determine this just from the JPEG data, so we have to pass this information from outside the MJPEG decoder. Signed-off-by: Nick

[FFmpeg-devel] [PATCH v14 07/14] lavc/tiff: Don't apply strips-related logic to tiled images

2019-08-11 Thread Nick Renieris
From: Nick Renieris Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 14928ed3d5..ff9ac30b3f 100644 --- a/libavcodec/tiff.c +++

[FFmpeg-devel] [PATCH v14 03/14] lavc/tiff: Convert DNGs to sRGB color space

2019-08-11 Thread Nick Renieris
From: Nick Renieris Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 4c6b835afe..a2102f32b5 100644 --- a/libavcodec/tiff.c +++

[FFmpeg-devel] [PATCH v14 04/14] lavc/tiff: Apply color scaling to uncompressed DNGs

2019-08-11 Thread Nick Renieris
From: Nick Renieris Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index a2102f32b5..040e83ba7c 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@

[FFmpeg-devel] [PATCH v14 01/14] lavc/mjpegdec: Decode Huffman-coded lossless JPEGs embedded in DNGs

2019-08-11 Thread Nick Renieris
From: Nick Renieris Main image data in DNGs is usually comprised of tiles, each of which is a Huffman-encoded lossless JPEG. Tested for ljpeg regressions with: `ffmpeg -f lavfi -i testsrc=d=1 -vcodec ljpeg test.avi` `ffmpeg test.avi out.avi` The modified code in ljpeg_decode_rgb_scan runs

[FFmpeg-devel] [PATCH v14 02/14] lavc/tiff: Decode embedded JPEGs in DNG images

2019-08-11 Thread Nick Renieris
From: Nick Renieris Used a technique similar to lavc/tdsc.c for invoking the MJPEG decoder. This commit adds support for: - DNG tiles - DNG tile huffman lossless JPEG decoding - DNG 8-bpp ("packed" as dcraw calls it) decoding - DNG color scaling [1] - LinearizationTable tag - BlackLevel tag

[FFmpeg-devel] [PATCH v14 06/14] lavc/tiff: Fix edge case with full-length/width tiles

2019-08-11 Thread Nick Renieris
From: Nick Renieris In an image [1], the height was equal to the tile length (full-height tile) and after `height % tile_length` was applied to them with the current code, it resulted in the operating tile_length to be 0. This commit makes this leftover logic only applies if it's necessary.

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/alsdec: Fix integer overflow of raw_samples in decode_blocks()

2019-08-11 Thread Michael Niedermayer
On Fri, Jul 26, 2019 at 06:26:05PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483424 - -1772303236 cannot be > represented in type 'int' > Fixes: > 15708/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5067890362941440 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/alsdec: Fix integer overflows of raw_samples in decode_var_block_data()

2019-08-11 Thread Michael Niedermayer
On Fri, Jul 26, 2019 at 06:26:07PM +0200, Michael Niedermayer wrote: > This also makes the code consistent with the existing similar MUL64() > in decode_var_block_data() > > Fixes: signed integer overflow: -7277630735906765035 + -3272193951413647896 > cannot be represented in type 'long' >

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/alsdec: fix mantisse shift

2019-08-11 Thread Michael Niedermayer
On Fri, Jul 26, 2019 at 06:26:08PM +0200, Michael Niedermayer wrote: > Fixes: shift exponent -1 is negative > Fixes: > 16039/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5656825657032704 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec/rl2: set dimensions

2019-08-11 Thread Michael Niedermayer
On Mon, Jul 22, 2019 at 11:57:24PM +0200, Michael Niedermayer wrote: > The dimensions are always 320x200 they are hardcoded in the demuxer. > Hardcode them instead in the decoder. > > Fixes: Timeout (16sec -> 400ms) > Fixes: >

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_template: fix integer overflow in imdct_and_windowing()

2019-08-11 Thread Michael Niedermayer
On Wed, Jul 10, 2019 at 10:09:28AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483645 + 4 cannot be represented in type > 'int' > Fixes: > 15418/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5685269069561856 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 1/4] avformat/hashenc: use an array of hashes

2019-08-11 Thread Nicolas George
Moritz Barsnick (12019-08-11): > Only the first one used currently. > > Signed-off-by: Moritz Barsnick > --- > libavformat/hashenc.c | 58 +++ > 1 file changed, 36 insertions(+), 22 deletions(-) > > diff --git a/libavformat/hashenc.c

[FFmpeg-devel] [PATCH 3/3] avcodec: Support EBU Tech. 3213-E primaries values

2019-08-11 Thread rzumer
From: Raphaël Zumer Signed-off-by: Raphaël Zumer --- libavcodec/options_table.h | 1 + libavcodec/version.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index 4a266eca16..c3a500a629 100644 ---

[FFmpeg-devel] [PATCH 1/3] avutil/pixfmt: Add EBU Tech. 3213-E AVColorPrimaries value

2019-08-11 Thread rzumer
From: Raphaël Zumer This is an alias for JEDEC P22. The name associated with the value is also changed from "jedec-p22" to "ebu3213" to match ITU-T H.273. Signed-off-by: Raphaël Zumer --- doc/APIchanges | 3 +++ libavutil/pixdesc.c | 2 +- libavutil/pixfmt.h | 3 ++-

[FFmpeg-devel] [PATCH 2/3] avfilter: Support EBU Tech. 3213-E primaries values

2019-08-11 Thread rzumer
From: Raphaël Zumer Signed-off-by: Raphaël Zumer --- libavfilter/version.h | 2 +- libavfilter/vf_colorspace.c | 1 + libavfilter/vf_setparams.c | 1 + libavfilter/vf_zscale.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/version.h

Re: [FFmpeg-devel] [PATCH] avformat/hashenc: add an option to create a hash per stream

2019-08-11 Thread Moritz Barsnick
On Sun, Aug 11, 2019 at 14:47:52 +0200, Moritz Barsnick wrote: > This patchset adds an option to the non-frame based hash muxers to create a > hash per stream. (The frame based muxers already do that.) I forgot to bump micro in the patch which adds the functionality. Please do when pushing, or I

[FFmpeg-devel] [PATCH 4/4] avformat/hashenc: reindent after previous commit

2019-08-11 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- libavformat/hashenc.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavformat/hashenc.c b/libavformat/hashenc.c index 394b8a0fce..070d4001b1 100644 --- a/libavformat/hashenc.c +++ b/libavformat/hashenc.c

[FFmpeg-devel] [PATCH 3/4] avformat/hashenc: add option to create hash per stream

2019-08-11 Thread Moritz Barsnick
Non-frame based muxers only, the frame based ones are already per stream. Signed-off-by: Moritz Barsnick --- doc/muxers.texi | 5 + libavformat/hashenc.c | 41 + 2 files changed, 34 insertions(+), 12 deletions(-) diff --git a/doc/muxers.texi

[FFmpeg-devel] [PATCH] avformat/hashenc: add an option to create a hash per stream

2019-08-11 Thread Moritz Barsnick
This patchset adds an option to the non-frame based hash muxers to create a hash per stream. (The frame based muxers already do that.) The first patch prepares by replacing the hash variable by an array of hashes (using only the first item). The second one rearranges tho options, which were a bit

[FFmpeg-devel] [PATCH 2/4] avformat/hashenc: rearrange options definition

2019-08-11 Thread Moritz Barsnick
Only the frame* muxers support the format_version option. Signed-off-by: Moritz Barsnick --- libavformat/hashenc.c | 35 +++ 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/libavformat/hashenc.c b/libavformat/hashenc.c index 7f83df5cca..96e00f580c

[FFmpeg-devel] [PATCH 1/4] avformat/hashenc: use an array of hashes

2019-08-11 Thread Moritz Barsnick
Only the first one used currently. Signed-off-by: Moritz Barsnick --- libavformat/hashenc.c | 58 +++ 1 file changed, 36 insertions(+), 22 deletions(-) diff --git a/libavformat/hashenc.c b/libavformat/hashenc.c index 06fc085d18..7f83df5cca 100644 ---

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/hevc_refs: Optimize 16bit generate_missing_ref()

2019-08-11 Thread Paul B Mahol
LGTM On Tue, Aug 6, 2019 at 11:32 PM Michael Niedermayer wrote: > Fixes: Timeout (86sec -> 8sec) > Fixes: > 15702/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5657764929470464 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec/scpr: Use av_memcpy_backptr() in type 17 and 33

2019-08-11 Thread Paul B Mahol
lgtm On Tue, Jul 30, 2019 at 2:12 AM Michael Niedermayer wrote: > This makes the changed code-path faster. > > Change not tested except with the fuzzer testcase as I found no other > testcase. > > Improves: Timeout (136sec -> 74sec) > Improves: >

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_scale: Ensure scaled video is divisible by n

2019-08-11 Thread Paul B Mahol
Michael, can you merge this? On Fri, Aug 9, 2019 at 10:16 AM Lars Kiesow wrote: > Well… then, can anyone merge this patch? > Best regards, > Lars > > On Mon, 5 Aug 2019 14:31:43 +0200 > Paul B Mahol wrote: > > > On Mon, Aug 5, 2019 at 1:31 PM Lars Kiesow wrote: > > > > > Hi everyone, > > >

Re: [FFmpeg-devel] [PATCH v12 10/14] lavc/tiff: Support decoding of DNGs with single-component JPEGs

2019-08-11 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 01:29:44AM +0200, Michael Niedermayer wrote: > On Sun, Aug 11, 2019 at 12:57:17AM +0300, Nick Renieris wrote: > > > after this commit the code dies when used with ffplay with floating point > > > exceptions > > > > I tried this on Ubuntu and I can't repro, it works fine. >

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/tiff: Enforce increasing offsets

2019-08-11 Thread Paul B Mahol
LGTM On Fri, Aug 9, 2019 at 1:25 AM Michael Niedermayer wrote: > This may break some valid tiff files, it appears the specification does > not require > the offsets to be increasing. They increase in the 2 test files i have > though except > the last offset which is 0 (an end marker) and for

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/mpc8: Fix 32bit mask/enum

2019-08-11 Thread Paul B Mahol
LGTM On Sat, Aug 10, 2019 at 11:18 PM Michael Niedermayer wrote: > Fixes: left shift of 1 by 31 places cannot be represented in type 'int' > Fixes: > 15817/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPC8_fuzzer-5636626409062400 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/dds: Use ff_set_dimensions()

2019-08-11 Thread Paul B Mahol
LGTM On Sat, Aug 10, 2019 at 11:16 PM Michael Niedermayer wrote: > Fixes: signed integer overflow: 2082471995 * 36 cannot be represented in > type 'int' > Fixes: > 16025/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DDS_fuzzer-5136663778426880 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 5/8] avformat/vividas: Fix infinite loop in header parser

2019-08-11 Thread Paul B Mahol
LGTM On Sat, Aug 10, 2019 at 11:18 PM Michael Niedermayer wrote: > Fixes: Timeout (Infinite -> Finite) > Fixes: > 16010/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5638616102993920 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 6/8] avformat/vividas: Fix another infinite loop

2019-08-11 Thread Paul B Mahol
On Sat, Aug 10, 2019 at 11:17 PM Michael Niedermayer wrote: > Not found by the fuzzer > > Signed-off-by: Michael Niedermayer > --- > libavformat/vividas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/vividas.c b/libavformat/vividas.c > index

Re: [FFmpeg-devel] [PATCH V1 1/2] lavf/avio: add a ffio_realloc_buf API for AVIO buffer realloc

2019-08-11 Thread Steven Liu
> 在 2019年8月8日,19:32,Jun Zhao 写道: > > From: tomajsjiang > > Add new API ffio_realloc_buf for AVIO buffer realloc. > > Signed-off-by: Zhongxing Jiang > --- > libavformat/avio_internal.h |9 + > libavformat/aviobuf.c | 31 +++ > 2 files changed,

Re: [FFmpeg-devel] [PATCH v2 1/2] lavf/dump: use error log level for invalid size

2019-08-11 Thread Steven Liu
> 在 2019年8月10日,23:53,lance.lmw...@gmail.com 写道: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/dump.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavformat/dump.c b/libavformat/dump.c > index 1c44656..68ce9a8 100644 > ---

Re: [FFmpeg-devel] [PATCH v13 14/14] lavc/tiff: Default-initialize WhiteLevel DNG tag value

2019-08-11 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 01:19:34AM +0300, Nick Renieris wrote: > From: Nick Renieris > > Initialized to `(2 ^ BitsPerSample) - 1` as per the DNG Specification. > > Also make sure that `BlackLevel < WhiteLevel`. > > This fixes decoding for "X7 CinemaDNG" samples here: > -

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-11 Thread Andreas Håkon
Hi Marton, > > This new version LGTM. > Thanks. I did a slight change for VBR streams and tried to mimic the old > behaviour when selecting a PCR interval. Will post an updated version, but > that should only affect VBR. Regarding this new VBR patch I have one comment... ‐‐‐ Original