[FFmpeg-devel] [PATCH 2/2] avcodec/cbs_av1_syntax_template: Remove unused variable

2019-11-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_av1_syntax_template.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c index c843cfa02b..c00982f74f 100644 --- a/libavcodec/cbs_av1_syntax_template.c +++

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs: Fix potential double-free when adding unit fails

2019-11-17 Thread Andreas Rheinhardt
ff_cbs_insert_unit_data() has two modes of operation: It can insert a unit with a newly created reference to an already existing AVBuffer; or it can take a buffer and create an AVBuffer for it. Said buffer will then become owned by the unit lateron. A potential memleak/double-free exists in the

Re: [FFmpeg-devel] TCP timeout for HTTP/HTTPS connections.

2019-11-17 Thread Tom Gaudasiński
That seems to change the call-stack a bit, but it still gets stuck on something in hls.c. I'm looking into what it is. I've also tried connect_timeout. I really just need to terminate the av_read_frame call, so that it returns immediately when I need it to, but av_read_frame appears to reconnect

Re: [FFmpeg-devel] TCP timeout for HTTP/HTTPS connections.

2019-11-17 Thread Steven Liu
> 在 2019年11月18日,14:56,Tom Gaudasiński 写道: > > I'm trying to set a read timeout for a http/https stream through the > API. Currently I'm passing... > > av_dict_set(, "timeout", "10", 0); > > ... to avformat_open_input(). > > This appears to not work once the connection has been

[FFmpeg-devel] TCP timeout for HTTP/HTTPS connections.

2019-11-17 Thread Tom Gaudasiński
I'm trying to set a read timeout for a http/https stream through the API. Currently I'm passing...       av_dict_set(, "timeout", "10", 0); ... to avformat_open_input(). This appears to not work once the connection has been established. The protocol call-stack appears to be hls.c -> http.c

Re: [FFmpeg-devel] [PATCH] lavf/rtmpproto: fix the playpath truncation if the len > 512

2019-11-17 Thread myp...@gmail.com
On Sun, Nov 17, 2019 at 4:05 AM Michael Niedermayer wrote: > > On Fri, Nov 15, 2019 at 07:46:33PM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > fix the playpath truncation if the len > 512 > > > > Found-by: liuwenhuang > > Signed-off-by: Jun Zhao > > --- > > libavformat/rtmpproto.c |8

Re: [FFmpeg-devel] [PATCH] avfilter/scale: allow dynamic output via expressions

2019-11-17 Thread Gyan
On 16-11-2019 06:29 pm, Michael Niedermayer wrote: On Fri, Nov 15, 2019 at 11:10:26AM +0530, Gyan wrote: On 15-11-2019 04:01 am, Michael Niedermayer wrote: On Thu, Nov 14, 2019 at 11:12:23PM +0530, Gyan wrote: On 14-11-2019 01:12 am, Michael Niedermayer wrote: Moving and changing code at

Re: [FFmpeg-devel] [PATCH v2] avutil/eval: add function to track variable use

2019-11-17 Thread Gyan
On 16-11-2019 08:53 pm, Gyan wrote: On 16-11-2019 08:12 pm, Michael Niedermayer wrote: On Sat, Nov 16, 2019 at 05:39:56PM +0530, Gyan wrote: As suggested by Michael in the review for the vf_scale patch, new eval function tracks count of all variables in a parsed expression in an array.

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add option to drop frames till timecode is seen

2019-11-17 Thread Gyan
On 17-11-2019 10:00 pm, Marton Balint wrote: From: Gyan Doshi Date: Mon, 9 Sep 2019 18:33:09 +0530 Subject: [PATCH v2] avdevice/decklink: add option to drop frames till timecode  is seen Option wait_for_tc only takes effect if tc_format is set ---  doc/indevs.texi |  8

Re: [FFmpeg-devel] [PATCH] avfilter/Makefile: add missing dependency for scale_cuda

2019-11-17 Thread Gyan
On 16-11-2019 08:53 pm, Gyan wrote: Was missing since initial commit. Ping. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

[FFmpeg-devel] [PATCH] fate/cbs: add initial AV1 tests

2019-11-17 Thread James Almer
Signed-off-by: James Almer --- tests/fate/cbs.mak| 26 ++- .../fate/cbs-av1-av1-1-b10-23-film_grain-50 | 1 + tests/ref/fate/cbs-av1-av1-1-b8-02-allintra | 1 + tests/ref/fate/cbs-av1-av1-1-b8-03-sizedown | 1 +

Re: [FFmpeg-devel] [PATCH v2 5/6] avcodec/cbs_jpeg: Use memcpy when writing pictures

2019-11-17 Thread Andreas Rheinhardt
On Mon, Nov 18, 2019 at 1:02 AM Mark Thompson wrote: > On 17/11/2019 07:34, Andreas Rheinhardt wrote: > > This is possible because the size of a scan header is always a multiple > > of a byte. > > > > Signed-off-by: Andreas Rheinhardt > > --- > > libavcodec/cbs_jpeg.c | 10 +++--- > > 1

Re: [FFmpeg-devel] [PATCH v2] avcodec/vp8: fix multiple ff_thread_finish_setup() calls

2019-11-17 Thread zhilizhao
Ping for review, thanks! > On Nov 14, 2019, at 12:29 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > webp decoder doesn't set update_thread_context field > > $ ffmpeg -i rgb_q80.webp -f null - > [webp @ 0x7ffbd5823200] Multiple ff_thread_finish_setup() calls > --- >

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_decode: Set surfaces reference pool size according to SPS for H.264/HEVC

2019-11-17 Thread Fu, Linjie
Hi, > On Nov 18, 2019, at 07:40, Mark Thompson wrote: > > On 06/11/2019 04:53, Linjie Fu wrote: >> Set surfaces pool used for storing reference frames dynamically >> according to SPS.(reference framecount, reordered frame number, etc) >> >> Compared to a fixed pool size for H.264 and HEVC, the

Re: [FFmpeg-devel] [PATCH v1 4/4] fate/filter-video: add 10bit test for unsharp filter

2019-11-17 Thread Limin Wang
On Sat, Nov 16, 2019 at 02:03:53PM +0100, Michael Niedermayer wrote: > On Fri, Nov 15, 2019 at 11:03:35PM +0800, Limin Wang wrote: > > On Mon, Oct 21, 2019 at 08:33:07PM +0200, Michael Niedermayer wrote: > > > On Mon, Oct 21, 2019 at 03:55:50PM +0800, Limin Wang wrote: > > > > On Tue, Oct 15, 2019

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mp3dec: Check that the frame fits within the probe buffer

2019-11-17 Thread Limin Wang
On Sun, Nov 17, 2019 at 10:03:03AM -0300, James Almer wrote: > On 11/16/2019 7:39 PM, Michael Niedermayer wrote: > > On Thu, Nov 07, 2019 at 10:25:31PM +0100, Michael Niedermayer wrote: > >> Signed-off-by: Michael Niedermayer > >> --- > >> libavformat/mp3dec.c | 2 +- > >> 1 file changed, 1

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_av1: implement missing set_frame_refs() function

2019-11-17 Thread James Almer
Defined in Section 7.8 This finishes implementing support for frames using frame_refs_short_signaling. Signed-off-by: James Almer --- libavcodec/cbs_av1_syntax_template.c | 122 --- 1 file changed, 112 insertions(+), 10 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_decode: Set surfaces reference pool size according to SPS for H.264/HEVC

2019-11-17 Thread Mark Thompson
On 06/11/2019 04:53, Linjie Fu wrote: > Set surfaces pool used for storing reference frames dynamically > according to SPS.(reference framecount, reordered frame number, etc) > > Compared to a fixed pool size for H.264 and HEVC, the usage of > GPU memory could be improved. > > CMD: > ffmpeg

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_av1: implement missing set_frame_refs() function

2019-11-17 Thread James Almer
On 11/17/2019 8:55 PM, James Almer wrote: > Defined in Section 7.8 > > This finishes implementing support for frames using > frame_refs_short_signaling. > > Signed-off-by: James Almer Here's a sample using short ref signaling:

Re: [FFmpeg-devel] [PATCH v2 3/6] avcodec/cbs_vp9: Write frame data directly

2019-11-17 Thread Mark Thompson
On 17/11/2019 07:34, Andreas Rheinhardt wrote: > Writing a unit (always a frame) in cbs_vp9 used an intermediate buffer > to write the frame header followed by the frame data that was copied > into said buffer. Afterwards, the final buffer for the frame was > allocated and everything copied into

Re: [FFmpeg-devel] [PATCH v2 5/6] avcodec/cbs_jpeg: Use memcpy when writing pictures

2019-11-17 Thread Mark Thompson
On 17/11/2019 07:34, Andreas Rheinhardt wrote: > This is possible because the size of a scan header is always a multiple > of a byte. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_jpeg.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH 2/2] Revert "avcodec/cbs_av1_syntax_template: Check ref_frame_idx before use"

2019-11-17 Thread James Almer
This reverts commit 8174e5c77d8a94b57b6b1bcbb90728cf8b08ab6b. It's no longer needed after the previous commit. --- libavcodec/cbs_av1_syntax_template.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/cbs_av1_syntax_template.c

Re: [FFmpeg-devel] [PATCH 2/2 v2] avcodec/cbs_av1: keep separate reference frame state for reading and writing

2019-11-17 Thread James Almer
On 11/15/2019 9:42 PM, James Almer wrote: > In scearios where a Temporal Unit is written right after reading it using the > same > CBS context (av1_metadata, av1_frame_merge, etc), the reference frame state > used > by the writer must not be the state that's the result of the reader having >

Re: [FFmpeg-devel] [PATCH v2 2/6] avcodec/cbs: Fix potential overflow

2019-11-17 Thread Mark Thompson
On 17/11/2019 07:34, Andreas Rheinhardt wrote: > The number of bits in a PutBitContext must fit into an int, yet nothing > guaranteed the size argument cbs_write_unit_data() uses in init_put_bits() > to be in the range 0..INT_MAX / 8. This has been changed. > > Furthermore, the check 8 *

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/cbs: Factor out common code for writing units

2019-11-17 Thread Mark Thompson
On 17/11/2019 07:34, Andreas Rheinhardt wrote: > All cbs-functions to write units share a common pattern: > 1. They check whether they have a write buffer (that is used to store > the unit's data until the needed size becomes known after writing the > unit when a dedicated buffer will be

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Async the encoding and output procedure of encoder

2019-11-17 Thread Mark Thompson
On 07/11/2019 16:32, Linjie Fu wrote: > Currently, vaapi encodes a pic if all its references are ready, > and then outputs it immediately by calling vaapi_encode_output. > > However, while working on output procedure, hardware is be able to > cope with encoding tasks in the meantime to have the

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: reconfigure sequence parameter in case it changes

2019-11-17 Thread Mark Thompson
On 13/11/2019 12:11, Linjie Fu wrote: > Aspect ratio change should be preserved in the output result of > transcoding. A better choice is to reconfigure when parameter changing > is detected, but a fix to reconfigure on IDR frame is simple and effective > with no performance drop. > > Fix #6276

Re: [FFmpeg-devel] [PATCH 4/4] avformat/flacdec: Remove useless packet

2019-11-17 Thread Michael Niedermayer
On Tue, Oct 08, 2019 at 09:24:29AM +0200, Paul B Mahol wrote: > lgtm will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] Allow using primary CUDA device context

2019-11-17 Thread Timo Rothenpieler
On 17.11.2019 15:58, Oleg Dobkin wrote: Add AVCUDADeviceContextFlags to control the creation of CUDA device context for the hardware CUDA decoder. The current values are 0 (default behavior) - new context will be created for each decoder, and 1 - primary CUDA context will be used. There are

Re: [FFmpeg-devel] [PATCH] configure: Fix build on MacOS 10.15

2019-11-17 Thread James Almer
On 11/17/2019 6:57 PM, Rick Kern wrote: > The default ./configure produces binaries that segfault on MacOS 10.15. > Fixes #8073 using the work-around mentioned in the ticket. > --- > configure | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure b/configure > index

[FFmpeg-devel] [PATCH] configure: Fix build on MacOS 10.15

2019-11-17 Thread Rick Kern
The default ./configure produces binaries that segfault on MacOS 10.15. Fixes #8073 using the work-around mentioned in the ticket. --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 31a3744dc6..6e371ae433 100755 --- a/configure +++ b/configure @@ -6878,6

[FFmpeg-devel] av_read_frame timeout

2019-11-17 Thread gga
The following patch adds a timeout interrupt to av_read_frame to prevent it from hanging up the application.  This patch was proposed some years ago but was not applied back then.  I believe it is useful and should be considered for approval. diff --git a/libavformat/utils.c

Re: [FFmpeg-devel] [PATCH] [PATCH] avcodec: Add more kCVImageBufferColorPrimaries to videotoolboxenc

2019-11-17 Thread Rick Kern
On Sun, Nov 17, 2019 at 10:25 AM Nomis101 wrote: > Am 17.11.19 um 01:05 schrieb Richard Kern: > > > >> On Nov 16, 2019, at 7:03 PM, Nomis101 wrote: > >> > >> Thanks for reviewing. Would be nice, if somebody could push to master > then. I can't. > >> > >> > > I’ll test it out tomorrow and push.

Re: [FFmpeg-devel] [PATCH] avfilter: add eval video filter

2019-11-17 Thread Michael Niedermayer
On Sun, Nov 17, 2019 at 11:33:13AM +0100, Paul B Mahol wrote: > I do not feel like going to look at all of this, sure ill do it but please tell me from whom you already have permission to relicense ? i do not want to pester people with the same question multiple times. thx > so I'm for

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add option to drop frames till timecode is seen

2019-11-17 Thread Marton Balint
From: Gyan Doshi Date: Mon, 9 Sep 2019 18:33:09 +0530 Subject: [PATCH v2] avdevice/decklink: add option to drop frames till timecode is seen Option wait_for_tc only takes effect if tc_format is set --- doc/indevs.texi | 8 libavdevice/decklink_common.h | 1 +

Re: [FFmpeg-devel] [PATCH] [PATCH] avcodec: Add more kCVImageBufferColorPrimaries to videotoolboxenc

2019-11-17 Thread Nomis101
Am 17.11.19 um 01:05 schrieb Richard Kern: > >> On Nov 16, 2019, at 7:03 PM, Nomis101 wrote: >> >> Thanks for reviewing. Would be nice, if somebody could push to master then. >> I can't. >> >> > I’ll test it out tomorrow and push. Cool, thank you very much. :-) > >>> Am 15.11.19 um 15:58

[FFmpeg-devel] [PATCH] Allow using primary CUDA device context

2019-11-17 Thread Oleg Dobkin
Add AVCUDADeviceContextFlags to control the creation of CUDA device context for the hardware CUDA decoder. The current values are 0 (default behavior) - new context will be created for each decoder, and 1 - primary CUDA context will be used. There are several reasons for using primary device

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mp3dec: Check that the frame fits within the probe buffer

2019-11-17 Thread James Almer
On 11/16/2019 7:39 PM, Michael Niedermayer wrote: > On Thu, Nov 07, 2019 at 10:25:31PM +0100, Michael Niedermayer wrote: >> Signed-off-by: Michael Niedermayer >> --- >> libavformat/mp3dec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > will apply There was a comment/review by

[FFmpeg-devel] [PATCH] Add cuDevicePrimaryCtxRetain and cuDevicePrimaryCtxRelease

2019-11-17 Thread Oleg Dobkin
These functions can be used to create HW cuda device using primary contexts - which is the preferred approach. --- include/ffnvcodec/dynlink_cuda.h | 2 ++ include/ffnvcodec/dynlink_loader.h | 4 2 files changed, 6 insertions(+) diff --git a/include/ffnvcodec/dynlink_cuda.h

Re: [FFmpeg-devel] [PATCH] avfilter: add eval video filter

2019-11-17 Thread Paul B Mahol
I do not feel like going to look at all of this, so I'm for applying this filter. On 11/2/19, Michael Niedermayer wrote: > On Fri, Nov 01, 2019 at 09:38:39PM +0100, Paul B Mahol wrote: >> On 11/1/19, Michael Niedermayer wrote: >> > On Fri, Nov 01, 2019 at 04:50:38PM +0100, Paul B Mahol wrote: