Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cbs_mpeg2: Change assertion from bytes to bits

2019-12-08 Thread James Almer
On 12/8/2019 6:31 PM, Michael Niedermayer wrote: > This allows writing empty slices Are empty slices valid in mpeg2 to begin with? Or is that the result of invalid/truncated data exclusively? The code in cbs_mpeg2_write_slice() is run only when slice->data is not NULL, which after a cursory look

Re: [FFmpeg-devel] [PATCH V3 2/2] libswscale/x86/yuv2rgb: add ssse3 version

2019-12-08 Thread Fu, Ting
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: Wednesday, December 4, 2019 11:00 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V3 2/2] libswscale/x86/yuv2rgb: add ssse3 > version > > Tested using this command: > /ffmpeg -pix_fmt yuv420p -s

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2019-12-08 Thread Nicolas George
Michael Niedermayer (12019-12-09): > One problem with unsigned is that in expressions you cannot have negative > values, nor can you compare to negative values without casting to signed. > That has some risk for producing unexpected behavior bugs > > for example > if (ch >= s->nb_channels) { >

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2019-12-08 Thread Michael Niedermayer
On Sat, Dec 07, 2019 at 09:25:53PM +0100, Nicolas George wrote: > Anton Khirnov (12019-12-06): > > The new API is more extensible and allows for custom layouts. > > More accurate information is exported, eg for decoders that do not > > set a channel layout, lavc will not make one up for them. > >

[FFmpeg-devel] [PATCH] avcodec/ffv1enc: Use version 3 by default (CRCs by default)

2019-12-08 Thread Michael Niedermayer
Version 3 is since 2013 (FFmpeg 2.1) non experimental so should be widely supported Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 3 ++- tests/fate/vcodec.mak | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c

[FFmpeg-devel] [PATCH 4/5] avcodec/vc1dec: Check field_mode for sprites

2019-12-08 Thread Michael Niedermayer
Fixes: Out of array read Fixes: 19263/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5389219325542400 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c | 7 ++-

[FFmpeg-devel] [PATCH 3/5] avcodec/vc1dec: Limit bits by the actual bitstream size

2019-12-08 Thread Michael Niedermayer
Fixes: Timeout (350 ->19sec) Fixes: 19249/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-6566896438870016 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c | 6

[FFmpeg-devel] [PATCH 2/5] avcodec/cbs_mpeg2: Change assertion from bytes to bits

2019-12-08 Thread Michael Niedermayer
This allows writing empty slices Fixes: Assertion slice->data_bit_start >= 0 && slice->data_size > slice->data_bit_start / 8 failed at libavcodec/cbs_mpeg2.c:340 Fixes: 19280/clusterfuzz-testcase-minimized-ffmpeg_BSF_MPEG2_METADATA_fuzzer-5632206173372416 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 1/5] avcodec/ralf: Fix integer overflow in apply_lpc()

2019-12-08 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147482897 + 2048 cannot be represented in type 'int' Fixes: 19240/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5743240326414336 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 5/5] libavcodec/vc1: Remove bits variable

2019-12-08 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/mss2.c | 2 -- libavcodec/vc1.h | 2 -- libavcodec/vc1_block.c | 16 libavcodec/vc1dec.c| 2 -- 4 files changed, 8 insertions(+), 14 deletions(-) diff --git a/libavcodec/mss2.c b/libavcodec/mss2.c index

Re: [FFmpeg-devel] [PATCH] fate/matroska: Add a test for propagating flac channel layouts

2019-12-08 Thread James Almer
On 12/8/2019 5:44 PM, Andreas Rheinhardt wrote: > contained in Vorbis comments in the CodecPrivate of flac tracks. > Moreover, it also tests header removal compression. > > Signed-off-by: Andreas Rheinhardt > --- > Sample already sent to James to take care of uploading it. Uploaded sample and

Re: [FFmpeg-devel] [aarch64] improve performance of ff_hscale_8_to_15_neon

2019-12-08 Thread Martin Storsjö
On Sun, 8 Dec 2019, Clément Bœsch wrote: On Wed, Dec 04, 2019 at 05:24:46PM -0600, Sebastian Pop wrote: Hi Clément, please find attached the updated patch addressing all your comments. Let me know if there is anything else that I missed and that I need to address. I can't test but patch

[FFmpeg-devel] [PATCH] fate/matroska: Add a test for propagating flac channel layouts

2019-12-08 Thread Andreas Rheinhardt
contained in Vorbis comments in the CodecPrivate of flac tracks. Moreover, it also tests header removal compression. Signed-off-by: Andreas Rheinhardt --- Sample already sent to James to take care of uploading it. tests/fate/matroska.mak | 6

[FFmpeg-devel] [PATCH] avcodec/aptx: split decoder and encoder into separate files

2019-12-08 Thread James Almer
Signed-off-by: James Almer --- Untested beyond checking it compiles because there are no FATE tests for either module. libavcodec/Makefile | 8 +- libavcodec/aptx.c| 634 +-- libavcodec/aptx.h| 221 +++ libavcodec/aptxdec.c | 206

[FFmpeg-devel] AVWriter API

2019-12-08 Thread Nicolas George
Hi. [ TL;DR: a lightweight oo API for functions that need to return a string, designed to be as convenient as possible. ] Yesterday, in my comments about the new channel layout API: https://ffmpeg.org/pipermail/ffmpeg-devel/2019-December/254020.html I evoked the following issue: We have many

[FFmpeg-devel] Reimbursement request NTTW4 in Budapest

2019-12-08 Thread Carl Eugen Hoyos
Hi! I gave a talk at NTTW4 in Budapest last week and participated (late) in the community day. I request reimbursement for travel and accommodation, together € 78,- and will prepare the usual paperwork for SPI. Thank you, Carl Eugen https://www.youtube.com/watch?v=cjJZ0cjtaz8

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_opt: hide a few deprecation warnings.

2019-12-08 Thread Nicolas George
James Almer (12019-12-08): > Last time i tried to silence deprecation warnings on fftool/* files it > broke compilation in some cases/compilers, since apparently the > __pragma() these expand into would clash with something else. I don't > recall what compiler, though. That is annoying. Well, I

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_opt: hide a few deprecation warnings.

2019-12-08 Thread James Almer
On 12/8/2019 8:47 AM, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > fftools/ffmpeg_opt.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > index 71063cc443..5ce70db23e 100644 > --- a/fftools/ffmpeg_opt.c

Re: [FFmpeg-devel] [PATCH 2/2] lavf/dump: hide a few deprecation warnings.

2019-12-08 Thread James Almer
On 12/8/2019 8:47 AM, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavformat/dump.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavformat/dump.c b/libavformat/dump.c > index 56814ff7d2..fcf8bad63a 100644 > --- a/libavformat/dump.c > +++

Re: [FFmpeg-devel] [aarch64] improve performance of ff_hscale_8_to_15_neon

2019-12-08 Thread Clément Bœsch
On Wed, Dec 04, 2019 at 05:24:46PM -0600, Sebastian Pop wrote: > Hi Clément, > > please find attached the updated patch addressing all your comments. > Let me know if there is anything else that I missed and that I need to > address. > I can't test but patch LGTM. Aside from the commit

[FFmpeg-devel] [PATCH 2/2] lavf/dump: hide a few deprecation warnings.

2019-12-08 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/dump.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 56814ff7d2..fcf8bad63a 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -479,12 +479,14 @@ static void

[FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_opt: hide a few deprecation warnings.

2019-12-08 Thread Nicolas George
Signed-off-by: Nicolas George --- fftools/ffmpeg_opt.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 71063cc443..5ce70db23e 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -34,6 +34,7 @@ #include

[FFmpeg-devel] [PATCH] avfilter: rename scale.c,h to scale_eval

2019-12-08 Thread Gyan
Makes commit msgs less ambiguous. Regards, Gyan From 331496c1746dfe66a893a6fde1b9cfacca100667 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sun, 8 Dec 2019 16:42:36 +0530 Subject: [PATCH] avfilter: rename scale.c,h to scale_eval scale.c is too generic; scale_eval is more representative ---

Re: [FFmpeg-devel] [PATCH] avfilter/scale.c: factorize ff_scale_eval_dimensions

2019-12-08 Thread Gyan
On 08-12-2019 10:03 am, Gyan wrote: On 07-12-2019 11:47 pm, Michael Niedermayer wrote: On Sat, Dec 07, 2019 at 12:08:53PM +0530, Gyan wrote:   doc/filters.texi |   40 +   libavfilter/scale.c  |   59

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: add Tiles encode support for HEVC

2019-12-08 Thread Zhong Li
Linjie Fu 于2019年11月26日周二 下午12:04写道: > > Add -tile_rows and -tile_cols option to specify the number of tile rows > and columns for ICL+ (gen 11) platform. > > A tile must wholly contain all the slices within it. Slices cannot cross > tile boundaries. So the slice number would be implicitly resized

Re: [FFmpeg-devel] [PATCH 3/4] Remove redundant ;

2019-12-08 Thread Fu, Linjie
Hi, > -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Sunday, December 8, 2019 07:20 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: [FFmpeg-devel] [PATCH 3/4] Remove redundant ; > > Signed-off-by: Michael Niedermayer >