James Almer:
> On 3/22/2020 12:47 AM, Andreas Rheinhardt wrote:
>> If reading the header fails, the demuxer's read_close() function (if
>> existing) is not called automatically; instead several demuxers call it
>> via "goto fail" in read_header().
>>
>> This commit intends to change this by adding
On 3/22/2020 12:47 AM, Andreas Rheinhardt wrote:
> If reading the header fails, the demuxer's read_close() function (if
> existing) is not called automatically; instead several demuxers call it
> via "goto fail" in read_header().
>
> This commit intends to change this by adding a flag to
On Fri, 13 Mar 2020 at 10:32, Anton Khirnov wrote:
> Those SEIs refer to the currently active SPS. However, since the SEI
> NALUs precede the coded picture data in the bitstream, the active SPS is
> in general not known when we are decoding the SEI.
>
The spec disagrees with this statement
by setting the FF_INPUTFORMAT_HEADER_CLEANUP flag. Also check error
conditions for being negative instead of only nonzero (they couldn't be
positive here anyway).
Signed-off-by: Andreas Rheinhardt
---
libavformat/tiertexseq.c | 19 ++-
1 file changed, 6 insertions(+), 13
by setting the FF_INPUTFORMAT_HEADER_CLEANUP flag.
Signed-off-by: Andreas Rheinhardt
---
libavformat/icodec.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/libavformat/icodec.c b/libavformat/icodec.c
index b47fa98f80..9449bb7315 100644
--- a/libavformat/icodec.c
by setting the FF_INPUTFORMAT_HEADER_CLEANUP flag. Furthermore, also
remove an unnecessary check for NULL before avformat_close_input().
Signed-off-by: Andreas Rheinhardt
---
libavformat/mpeg.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/libavformat/mpeg.c
In this case, the subtitle queue would leak because ass_read_close() is
not called automatically when reading the header fails. This is changed
by setting the FF_INPUTFORMAT_HEADER_CLEANUP flag.
Signed-off-by: Andreas Rheinhardt
---
libavformat/assdec.c | 1 +
1 file changed, 1 insertion(+)
The subtitle queue would leak in this scenario. This has been fixed by
adding the FF_INPUTFORMAT_HEADER_CLEANUP flag so that aqt_read_close() is
called if reading the header fails.
Signed-off-by: Andreas Rheinhardt
---
libavformat/aqtitledec.c | 1 +
1 file changed, 1 insertion(+)
diff --git
If inserting a packet into a subtitle queue fails, said queue would leak
(because jacosub_read_close() which frees the queue was not called
automatically when reading the header fails); moreover, an AVBPrint
leaks, too. Both these leaks have been fixed, the former by setting the
by setting the FF_INPUTFORMAT_HEADER_CLEANUP flag.
Signed-off-by: Andreas Rheinhardt
---
libavformat/brstm.c | 26 +-
1 file changed, 9 insertions(+), 17 deletions(-)
diff --git a/libavformat/brstm.c b/libavformat/brstm.c
index ca965ed7e1..22d862ae43 100644
---
by setting the FF_INPUTFORMAT_HEADER_CLEANUP flag.
Signed-off-by: Andreas Rheinhardt
---
libavformat/nsvdec.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/libavformat/nsvdec.c b/libavformat/nsvdec.c
index eb26b29450..a0f1d698f7 100644
---
by setting the FF_INPUTFORMAT_HEADER_CLEANUP flag.
Signed-off-by: Andreas Rheinhardt
---
libavformat/nutdec.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c
index 3779dce2a8..260dd514b6 100644
---
The subtitle queue could leak because microdvd_read_close() would never
be called to clean up the subtitle queue if inserting another subtitle
fails. This has been fixed by setting the FF_INPUTFORMAT_HEADER_CLEANUP
flag.
Signed-off-by: Andreas Rheinhardt
---
libavformat/microdvddec.c | 1 +
1
Several buffers allocated in the course of reading the header would leak
if an error happened after their allocation. Fix this by setting the
FF_INPUTFORMAT_HEADER_CLEANUP flag so that ape_read_close() will be called
to clean up in case of failure to read the header.
Signed-off-by: Andreas
by setting the FF_INPUTFORMAT_HEADER_CLEANUP flag.
Signed-off-by: Andreas Rheinhardt
---
libavformat/av1dec.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c
index 1be2fac1c1..3bf7b598a0 100644
---
By default, a demuxer's read_close function is not called automatically
if an error happens when reading the header; instead it is up to the
demuxer to clean up after itself in this case. The mov demuxer did this
by calling its read_close function when it encountered some errors when
reading the
by setting the FF_INPUTFORMAT_HEADER_CLEANUP flag.
Signed-off-by: Andreas Rheinhardt
---
libavformat/xmv.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/libavformat/xmv.c b/libavformat/xmv.c
index 0c69d267de..288b1e8463 100644
--- a/libavformat/xmv.c
+++
by setting the FF_INPUTFORMAT_HEADER_CLEANUP flag.
Signed-off-by: Andreas Rheinhardt
---
libavformat/jvdec.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/libavformat/jvdec.c b/libavformat/jvdec.c
index 551f8069e6..efa034c9ce 100644
--- a/libavformat/jvdec.c
+++
When allocating a new stream failed, the contents of an AVBPrint
as well as a subtitle queue would leak. This commit fixes this.
It also slightly simplifies the cleanup process by setting the
FF_INPUTFORMAT_HEADER_CLEANUP flag.
Signed-off-by: Andreas Rheinhardt
---
This patch and the other
This commit simplifies cleanup after read_header failure: By setting the
FF_INPUTFORMAT_HEADER_CLEANUP flag for both the ordinary Matroska demuxer
as well as the WebM DASH Manifest demuxer one can remove the "goto fail"
in matroska_read_header() as well as an explicit matroska_read_close()
in
Also return 0 after successfully reading a packet.
Signed-off-by: Andreas Rheinhardt
---
libavformat/yop.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/libavformat/yop.c b/libavformat/yop.c
index f9ead026a2..0d8d9f2ff7 100644
--- a/libavformat/yop.c
+++
Forgotten in 6a67d518.
Signed-off-by: Andreas Rheinhardt
---
libavformat/mpeg.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c
index fad7c7fd55..eba5852266 100644
--- a/libavformat/mpeg.c
+++ b/libavformat/mpeg.c
@@ -961,7
If reading the header fails, the demuxer's read_close() function (if
existing) is not called automatically; instead several demuxers call it
via "goto fail" in read_header().
This commit intends to change this by adding a flag to AVInputFormat
that can be used to set on a per-AVInputFormat basis
Also simply return 0 in case a packet has been successfully read.
Signed-off-by: Andreas Rheinhardt
---
libavformat/nsvdec.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavformat/nsvdec.c b/libavformat/nsvdec.c
index b5d9313778..eb26b29450 100644
---
---
libavformat/subviewerdec.c | 36 +---
1 file changed, 21 insertions(+), 15 deletions(-)
diff --git a/libavformat/subviewerdec.c b/libavformat/subviewerdec.c
index 83378eab5f..88344d0976 100644
--- a/libavformat/subviewerdec.c
+++ b/libavformat/subviewerdec.c
> 2020年3月22日 上午7:28，Andreas Rheinhardt 写道：
>
> Andreas Rheinhardt:
>> If an URI indicated that the data protocol was in use, it would be
>> copied into a temporary buffer via strncpy(dst, src, strlen(src)),
>> thereby ensuring that the trailing \0 would not be copied, despite dst
>> being
Andreas Rheinhardt:
> If an URI indicated that the data protocol was in use, it would be
> copied into a temporary buffer via strncpy(dst, src, strlen(src)),
> thereby ensuring that the trailing \0 would not be copied, despite dst
> being uninitialized. dst would then be av_strdup'ed, leading to
>
On Fri, Mar 20, 2020 at 02:31:05PM +0100, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> configure |1 +
> libavcodec/Makefile |1 +
> libavcodec/allcodecs.c |1 +
> libavcodec/avcodec.h|1 +
> libavcodec/bink2.c | 869
On 3/21/2020 7:44 PM, Michael Niedermayer wrote:
> On Tue, Mar 17, 2020 at 01:13:53AM +0100, Michael Niedermayer wrote:
>> On Mon, Mar 16, 2020 at 04:42:31PM -0300, James Almer wrote:
>>> On 3/16/2020 3:51 PM, Michael Niedermayer wrote:
On Fri, Mar 13, 2020 at 11:28:45AM +0100, Anton Khirnov
On Tue, Mar 17, 2020 at 01:13:53AM +0100, Michael Niedermayer wrote:
> On Mon, Mar 16, 2020 at 04:42:31PM -0300, James Almer wrote:
> > On 3/16/2020 3:51 PM, Michael Niedermayer wrote:
> > > On Fri, Mar 13, 2020 at 11:28:45AM +0100, Anton Khirnov wrote:
> > >> Those SEIs refer to the currently
On 3/18/2020 10:44 AM, Anton Khirnov wrote:
> Quoting Andreas Rheinhardt (2020-03-17 22:31:47)
>> Up until now, the name of every AVBSFContext for logging purposes was
>> "AVBSFContext", so that the default logging callback produced output
>> like "[AVBSFContext @ 0x55813bae92c0] Extradata". This
On 3/20/2020 5:17 AM, Anton Khirnov wrote:
> Quoting Andreas Rheinhardt (2020-03-18 17:10:37)
>> Anton Khirnov:
>>> Quoting Andreas Rheinhardt (2020-03-17 22:31:46)
This happened for AVBSFContext.
Signed-off-by: Andreas Rheinhardt
---
>>> Maybe ok. Not sure if it's better to
Am Sa., 21. März 2020 um 02:04 Uhr schrieb Hendrik Leppkes
:
>
> On Thu, Mar 19, 2020 at 12:39 AM Carl Eugen Hoyos wrote:
> >
> > Hi!
> >
> > Without this patch, make clean (and make distclean) do not delete
> > ffmpeg_g.ilk and ffmpeg_g.pdb (and friends).
> >
>
> LGTM
Patch applied.
Thank you,
On Fri, Mar 20, 2020 at 10:29:33AM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2020-03-17 01:09:51)
> > Fixes: signed integer overflow: 2 * 1210064928 cannot be represented in
> > type 'int'
> > Fixes:
> > 20873/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5761116909338624
Am Sa., 21. März 2020 um 18:35 Uhr schrieb Michael Niedermayer
:
>
> On Fri, Mar 20, 2020 at 09:05:12AM +0100, Carl Eugen Hoyos wrote:
> > Am Fr., 20. März 2020 um 01:49 Uhr schrieb Michael Niedermayer
> > :
> > >
> > > On Thu, Mar 19, 2020 at 10:18:33PM +0100, Carl Eugen Hoyos wrote:
> > > > Am
On Fri, Mar 20, 2020 at 09:05:12AM +0100, Carl Eugen Hoyos wrote:
> Am Fr., 20. März 2020 um 01:49 Uhr schrieb Michael Niedermayer
> :
> >
> > On Thu, Mar 19, 2020 at 10:18:33PM +0100, Carl Eugen Hoyos wrote:
> > > Am Do., 19. März 2020 um 19:32 Uhr schrieb Michael Niedermayer
> > > :
> > > >
> >
On 3/21/20, James Almer wrote:
> On 3/20/2020 10:31 AM, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol
>> ---
>> configure |1 +
>> libavcodec/Makefile |1 +
>> libavcodec/allcodecs.c |1 +
>> libavcodec/avcodec.h|1 +
>> libavcodec/bink2.c | 869
Am 21.03.20 um 15:58 schrieb Rick Kern:
> On Wed, Mar 18, 2020 at 12:32 PM Nomis101 wrote:
>
>> Am 29.02.20 um 02:39 schrieb Nomis101:
>>> From: Damiano Galassi
>>>
>>> Signed-off-by: Nomis101
>>> ---
>>> libavcodec/videotoolboxenc.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git
Paul B Mahol:
> ok if fate passed and it is covered.
>
It is not covered, yet I checked all the samples from [1] as well as the
one from ticket #3464. (That the stuff I removed is actually unused can
also be seen from the fact that I did not modify hnm_read_packet() at all.)
- Andreas
[1]:
On Wed, Mar 18, 2020 at 12:32 PM Nomis101 wrote:
> Am 29.02.20 um 02:39 schrieb Nomis101:
> > From: Damiano Galassi
> >
> > Signed-off-by: Nomis101
> > ---
> > libavcodec/videotoolboxenc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/libavcodec/videotoolboxenc.c
On 3/21/20, Nicolas George wrote:
> Paul B Mahol (12020-03-21):
>> I'm not gonna remove those tables, no matter how "valid" your comments
>> are.
>
> Then you're not gonna apply this patch either. That's how a collective
> project works.
I'm not listening to your comments.
>
> --
> Nicolas
Paul B Mahol (12020-03-21):
> I'm not gonna remove those tables, no matter how "valid" your comments are.
Then you're not gonna apply this patch either. That's how a collective
project works.
--
Nicolas George
signature.asc
Description: PGP signature
On 3/21/20, Jan Ekström wrote:
> On Fri, Mar 20, 2020 at 3:31 PM Paul B Mahol wrote:
>>
>> Signed-off-by: Paul B Mahol
>> ---
>
> I am not sure how well I'd be able to review the technicalities, and
> thus I only have the following requests:
> - Since I didn't see a mention of the current
On Fri, Mar 20, 2020 at 3:31 PM Paul B Mahol wrote:
>
> Signed-off-by: Paul B Mahol
> ---
I am not sure how well I'd be able to review the technicalities, and
thus I only have the following requests:
- Since I didn't see a mention of the current limitations of this
implementation (such as the
On Sat, Mar 21, 2020 at 1:30 PM Paul B Mahol wrote:
>
> On 3/21/20, Jan Ekström wrote:
> > On Sat, Mar 21, 2020 at 11:27 AM Paul B Mahol wrote:
> >>
> >> I do not plan to remove any of this,
> >>
> >> So please refrain from posting such "reviews".
> >>
> >
> > While I have respect for your
On 3/21/20, Jan Ekström wrote:
> On Sat, Mar 21, 2020 at 11:27 AM Paul B Mahol wrote:
>>
>> I do not plan to remove any of this,
>>
>> So please refrain from posting such "reviews".
>>
>
> While I have respect for your technical capabilities, can you please
> refrain from behaving in such a
On Sat, Mar 21, 2020 at 11:27 AM Paul B Mahol wrote:
>
> I do not plan to remove any of this,
>
> So please refrain from posting such "reviews".
>
While I have respect for your technical capabilities, can you please
refrain from behaving in such a toxic and off-putting manner?
Someone clearly
Mar 21, 2020, 09:24 by m...@jailuthra.in:
> Please mark the patch as [WIP] or [RFC] if you are not sending it for a merge
> review.
>
> On Wed, Mar 18, 2020 at 11:01:22AM +0530, Kartik wrote:
>
>> From: Kartik K. Khullar
>>
>> ---
>> FFmpeg/libavutil/colorspace.h | 11 +++
>> 1 file
lgtm
On 3/21/20, Andreas Rheinhardt wrote:
> by putting the palette in the demuxer's context. This also allows to
> remove this demuxer's read_close-function.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/bethsoftvid.c | 25 +++--
> 1 file changed, 7
lgtm
On 3/21/20, Andreas Rheinhardt wrote:
> and also add padding to it; moreover, don't use memcpy to write one byte
> to extradata.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/hnm.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git
Hi Kartik,
Please mark the patch as [WIP] or [RFC] if you are not sending it for a merge
review. You may also mark it as [GSoC].
You've done a good job of reading the spec and turning the pseudocode there to
a method, but I'm afraid it is not enough.
I would suggest you run the reference
LGTM
On 3/21/20, Andreas Rheinhardt wrote:
> The classical ptr = av_realloc(ptr, size), just with av_fast_realloc().
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/bethsoftvid.c | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git
I do not plan to remove any of this,
So please refrain from posting such "reviews".
On 3/21/20, Peter Ross wrote:
> On Fri, Mar 20, 2020 at 02:31:05PM +0100, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol
>> ---
>> configure |1 +
>> libavcodec/Makefile |1 +
>>
ok if fate passed and it is covered.
On 3/21/20, Andreas Rheinhardt wrote:
> The hnm demuxer's context struct contained lots of fields that are
> write-only variables or that are not used outside of parsing the header
> and that can therefore be replaced by local variables of hnm_read_header().
Please mark the patch as [WIP] or [RFC] if you are not sending it for a merge
review.
On Wed, Mar 18, 2020 at 11:01:22AM +0530, Kartik wrote:
From: Kartik K. Khullar
---
FFmpeg/libavutil/colorspace.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/FFmpeg/libavutil/colorspace.h
ping for review, thanks.
On Tue, Dec 24, 2019 at 09:06:18AM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavcodec/decode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/decode.c
The hnm demuxer's context struct contained lots of fields that are
write-only variables or that are not used outside of parsing the header
and that can therefore be replaced by local variables of hnm_read_header().
This commit removes all of these from the context; the second type has
been
and also add padding to it; moreover, don't use memcpy to write one byte
to extradata.
Signed-off-by: Andreas Rheinhardt
---
libavformat/hnm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libavformat/hnm.c b/libavformat/hnm.c
index 40ef5c06ee..31221553a4 100644
---
58 matches
Mail list logo
