Re: [FFmpeg-devel] [PATCH 2/2] avcodec/motion_est: fix penalty_factor for b frames

2020-03-23 Thread Ramiro Polla
On Mon, Mar 23, 2020 at 10:42 PM Michael Niedermayer wrote: > On Sun, Mar 22, 2020 at 04:55:25PM +0100, Ramiro Polla wrote: > > In ff_estimate_b_frame_motion(), penalty_factor would be used before > > being initialized in estimate_motion_b(). Also, the initialization > > would happen more than onc

[FFmpeg-devel] [PATCH v3] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-23 Thread Steven Liu
These member will be used for get more correct information of the MPD Suggested-by: Andreas Rheinhardt Suggested-by: Nicolas George Signed-off-by: Steven Liu --- libavformat/dashdec.c | 244 -- 1 file changed, 214 insertions(+), 30 deletions(-) diff --g

Re: [FFmpeg-devel] JPEG2000 Decoder/Encoder Enhancements

2020-03-23 Thread Gautam Ramakrishnan
Hi Michael, I do not mind spending most of the time myself. I just need a person to go to when I have doubts. I really do not mind doing it without it being through GSoC either. Just wanted to try contributing to the organization. I was thinking about starting by fixing tickets #4601 or #4610. Wou

Re: [FFmpeg-devel] [PATCH 04/21] avformat: Redo cleanup of demuxer upon read_header() failure

2020-03-23 Thread Andreas Rheinhardt
Andreas Rheinhardt: > James Almer: >> On 3/22/2020 12:47 AM, Andreas Rheinhardt wrote: >>> If reading the header fails, the demuxer's read_close() function (if >>> existing) is not called automatically; instead several demuxers call it >>> via "goto fail" in read_header(). >>> >>> This commit inten

Re: [FFmpeg-devel] [PATCH 3/3] lavc/vaapi_encode_h265: add h265 tile encoding support

2020-03-23 Thread Fu, Linjie
> From: myp...@gmail.com > Sent: Monday, March 23, 2020 22:44 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavc/vaapi_encode_h265: add h265 > tile encoding support > > On Mon, Mar 23, 2020 at 10:30 PM Linjie Fu wr

[FFmpeg-devel] [PATCH] Check return value from avio_read() to verify data actually read

2020-03-23 Thread John Rummell
Chromium fuzzers have caught places where uninitialized data was used due to calls to avio_read() not verifying that the number of bytes expected was actually read. So updating the code to check the result from avio_read(). 0001-Check-return-value-from-avio_read-to-verify-data-act.patch Descripti

[FFmpeg-devel] [PATCH] avcodec/decode: Clear format on ff_get_buffer() failure

2020-03-23 Thread Michael Niedermayer
Fixes: out of array access Fixes: 21193/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5125168956702720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/decode.c | 1 + 1 file

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/wavpack: Prevent frame format from being wrong

2020-03-23 Thread Michael Niedermayer
On Mon, Mar 23, 2020 at 05:49:06PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-03-20 21:50:18) > > On Fri, Mar 20, 2020 at 10:18:49AM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2020-03-20 01:03:36) > > > > Fixes: out of array access > > > > Fixes: > > > > 21

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/wavpack: Prevent frame format from being wrong

2020-03-23 Thread Michael Niedermayer
On Mon, Mar 23, 2020 at 05:08:23PM -0700, David Bryant wrote: > On 3/23/20 9:49 AM, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-03-20 21:50:18) > >> On Fri, Mar 20, 2020 at 10:18:49AM +0100, Anton Khirnov wrote: > >>> Quoting Michael Niedermayer (2020-03-20 01:03:36) > Fixes: ou

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/wavpack: Prevent frame format from being wrong

2020-03-23 Thread David Bryant
On 3/23/20 9:49 AM, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-03-20 21:50:18) >> On Fri, Mar 20, 2020 at 10:18:49AM +0100, Anton Khirnov wrote: >>> Quoting Michael Niedermayer (2020-03-20 01:03:36) Fixes: out of array access Fixes: 21193/clusterfuzz-testcase-minimized

Re: [FFmpeg-devel] [PATCH] movenc: mark Opus encapsulation as stable

2020-03-23 Thread Derek Buitenhuis
On 23/03/2020 22:11, Lynne wrote: > The specifications are de-facto frozen now as they've already been used in > production for years now, the author has indicated reluctance on IRC to change > it further, and the only potential changes would, from what I understand, be > forward-compatible. +1 fr

[FFmpeg-devel] [PATCH] movenc: mark Opus encapsulation as stable

2020-03-23 Thread Lynne
The specifications are de-facto frozen now as they've already been used in production for years now, the author has indicated reluctance on IRC to change it further, and the only potential changes would, from what I understand, be forward-compatible. Patch attached. >From c8d4d5a3d7aeaddabb9e14bc

Re: [FFmpeg-devel] [PATCH 14/18] h264_ps: make the PPS hold a reference to its SPS

2020-03-23 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting James Almer (2020-03-18 17:05:38) >> On 3/13/2020 7:28 AM, Anton Khirnov wrote: >>> It represents the relationship between them more naturally and will be >>> useful in the following commits. >>> >>> Allows significantly more frames in fate-h264-attachment-631 to be >>> dec

Re: [FFmpeg-devel] [PATCH v1] avformat/mxfdec: use av_asprintf()

2020-03-23 Thread Michael Niedermayer
On Mon, Mar 23, 2020 at 08:29:32PM +0100, Tomas Härdin wrote: > sön 2020-03-22 klockan 23:03 +0800 skrev lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/mxfdec.c | 6 ++ > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add my gpg fingerprint

2020-03-23 Thread Michael Niedermayer
On Mon, Mar 23, 2020 at 09:57:31PM +0100, Ramiro Polla wrote: > Hi Michael, > > On Mon, Mar 23, 2020 at 8:44 PM Michael Niedermayer > wrote: > > > > On Mon, Mar 23, 2020 at 04:11:04AM +0100, Ramiro Polla wrote: > > > --- > > > MAINTAINERS | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > d

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/motion_est: fix penalty_factor for b frames

2020-03-23 Thread Michael Niedermayer
On Sun, Mar 22, 2020 at 04:55:25PM +0100, Ramiro Polla wrote: > In ff_estimate_b_frame_motion(), penalty_factor would be used before > being initialized in estimate_motion_b(). Also, the initialization > would happen more than once unnecessarily. > --- > libavcodec/motion_est.c |

Re: [FFmpeg-devel] [PATCH 13/18] h264_sei: parse the picture timing SEIs correctly

2020-03-23 Thread Kieran Kunhya
> > I don't think you read that section carefully enough. What it says (in > my interpretation) is that an SPS can be activated only by: > - buffering period SEI > - a PPS (which is itself activated by picture data) > Picture timing SEI is neither of those. > The contents of pic-struct do not affe

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add my gpg fingerprint

2020-03-23 Thread Ramiro Polla
Hi Michael, On Mon, Mar 23, 2020 at 8:44 PM Michael Niedermayer wrote: > > On Mon, Mar 23, 2020 at 04:11:04AM +0100, Ramiro Polla wrote: > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index f9810d5594..9238a1a762 100644 > > --

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add my gpg fingerprint

2020-03-23 Thread Michael Niedermayer
On Mon, Mar 23, 2020 at 04:11:04AM +0100, Ramiro Polla wrote: > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f9810d5594..9238a1a762 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -614,6 +614,7 @@ Nikolay Aleksandrov 89

Re: [FFmpeg-devel] [PATCH v1] avformat/mxfdec: use av_asprintf()

2020-03-23 Thread Tomas Härdin
sön 2020-03-22 klockan 23:03 +0800 skrev lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/mxfdec.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index 9113e2a09c..3374f36a

Re: [FFmpeg-devel] [PATCH 14/18] h264_ps: make the PPS hold a reference to its SPS

2020-03-23 Thread James Almer
On 3/23/2020 2:36 PM, Anton Khirnov wrote: > Quoting James Almer (2020-03-18 17:05:38) >> On 3/13/2020 7:28 AM, Anton Khirnov wrote: >>> It represents the relationship between them more naturally and will be >>> useful in the following commits. >>> >>> Allows significantly more frames in fate-h264-

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-03-23 Thread Michael Niedermayer
On Thu, Mar 19, 2020 at 12:00:20PM +, Zane van Iperen wrote: [...] > index 4cce0a5857..a1f6966c75 100644 > --- a/libavcodec/adpcm_data.c > +++ b/libavcodec/adpcm_data.c > @@ -177,3 +177,16 @@ const int16_t ff_adpcm_mtaf_stepsize[32][16] = { > { 424, 1273, 2121, 2970, 3819, 4668, 55

Re: [FFmpeg-devel] [PATCH 14/18] h264_ps: make the PPS hold a reference to its SPS

2020-03-23 Thread Anton Khirnov
Quoting James Almer (2020-03-18 17:05:38) > On 3/13/2020 7:28 AM, Anton Khirnov wrote: > > It represents the relationship between them more naturally and will be > > useful in the following commits. > > > > Allows significantly more frames in fate-h264-attachment-631 to be > > decoded. > > That s

Re: [FFmpeg-devel] [PATCH 18/18] h264_ps: pass AVCodecContext as void* where possible

2020-03-23 Thread Michael Niedermayer
On Wed, Mar 18, 2020 at 10:02:39AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-03-16 12:23:11) > > On Sun, Mar 15, 2020 at 06:02:04PM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2020-03-13 23:29:12) > > > > On Fri, Mar 13, 2020 at 11:28:50AM +0100, Anton Khirn

Re: [FFmpeg-devel] JPEG2000 Decoder/Encoder Enhancements

2020-03-23 Thread Michael Niedermayer
On Sun, Mar 22, 2020 at 06:58:24PM +0100, Carl Eugen Hoyos wrote: > Am So., 22. März 2020 um 18:27 Uhr schrieb Gautam Ramakrishnan > : > > > I saw the list of unmentored projects for GSoC and enhancements to the > > JPEG2000 decoder and encoder were there. I am finding it very > > difficult to mak

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/wavpack: Prevent frame format from being wrong

2020-03-23 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-03-20 21:50:18) > On Fri, Mar 20, 2020 at 10:18:49AM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-03-20 01:03:36) > > > Fixes: out of array access > > > Fixes: > > > 21193/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-512516

Re: [FFmpeg-devel] [PATCH 13/18] h264_sei: parse the picture timing SEIs correctly

2020-03-23 Thread Anton Khirnov
Quoting James Almer (2020-03-23 17:20:56) > On 3/23/2020 1:17 PM, Anton Khirnov wrote: > > Quoting Kieran Kunhya (2020-03-22 05:24:35) > >> On Fri, 13 Mar 2020 at 10:32, Anton Khirnov wrote: > >> > >>> Those SEIs refer to the currently active SPS. However, since the SEI > >>> NALUs precede the cod

[FFmpeg-devel] [PATCH] h264_sei: parse the picture timing SEIs correctly

2020-03-23 Thread Anton Khirnov
Those SEIs refer to the currently active SPS. However, since the SEI NALUs precede the coded picture data in the bitstream, the active SPS is in general not known when we are decoding the SEI. Therefore, store the content of the picture timing SEIs and actually parse it when the active SPS is know

Re: [FFmpeg-devel] [PATCH 13/18] h264_sei: parse the picture timing SEIs correctly

2020-03-23 Thread James Almer
On 3/23/2020 1:17 PM, Anton Khirnov wrote: > Quoting Kieran Kunhya (2020-03-22 05:24:35) >> On Fri, 13 Mar 2020 at 10:32, Anton Khirnov wrote: >> >>> Those SEIs refer to the currently active SPS. However, since the SEI >>> NALUs precede the coded picture data in the bitstream, the active SPS is >>

[FFmpeg-devel] [PATCH] avcodec/cbs_h264_syntax_template: fix off by 1 error with slice_group_change_cycle

2020-03-23 Thread Michael Niedermayer
Fixes: assertion failure Fixes: 20390/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5683400772157440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cbs_h264_syntax_templ

Re: [FFmpeg-devel] [PATCH 13/18] h264_sei: parse the picture timing SEIs correctly

2020-03-23 Thread Anton Khirnov
Quoting Kieran Kunhya (2020-03-22 05:24:35) > On Fri, 13 Mar 2020 at 10:32, Anton Khirnov wrote: > > > Those SEIs refer to the currently active SPS. However, since the SEI > > NALUs precede the coded picture data in the bitstream, the active SPS is > > in general not known when we are decoding th

Re: [FFmpeg-devel] [PATCH 3/3] lavc/vaapi_encode_h265: add h265 tile encoding support

2020-03-23 Thread myp...@gmail.com
On Mon, Mar 23, 2020 at 10:30 PM Linjie Fu wrote: > > Default to enable uniform_spacing_flag. Guess level by the tile > rows/cols. Supported for ICL+ platforms. > > Also add documentations. > > To encode with 4 rows 2 columns: > ffmpeg ... -c:v hevc_vaapi -tile_rows 4 -tile_cols 2 ... > > Sign

[FFmpeg-devel] [PATCH 3/3] lavc/vaapi_encode_h265: add h265 tile encoding support

2020-03-23 Thread Linjie Fu
Default to enable uniform_spacing_flag. Guess level by the tile rows/cols. Supported for ICL+ platforms. Also add documentations. To encode with 4 rows 2 columns: ffmpeg ... -c:v hevc_vaapi -tile_rows 4 -tile_cols 2 ... Signed-off-by: Linjie Fu --- doc/encoders.texi | 8 +

[FFmpeg-devel] [PATCH 2/3] lavc/vaapi_encode: add tile slice encoding support

2020-03-23 Thread Linjie Fu
Add functions to initialize tile slice structure and make tile slice: - vaapi_encode_init_tile_slice_structure - vaapi_encode_make_tile_slice Tile slice is not allowed to cross the boundary of a tile due to the constraints of media-driver. Currently adding support for one slice per tile. N x N

[FFmpeg-devel] [PATCH 1/3] lavc/vaapi_encode: wrap slice codes into row slice functions

2020-03-23 Thread Linjie Fu
Wrap current whole-row slice codes into following functions: - vaapi_encode_make_row_slice() - vaapi_encode_init_row_slice_structure() Signed-off-by: Linjie Fu --- libavcodec/vaapi_encode.c | 184 ++ 1 file changed, 106 insertions(+), 78 deletions(-)

Re: [FFmpeg-devel] [PATCH v3 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-03-23 Thread Zane van Iperen
Hi all, Could I please get some reviews on this? Thanks, Zane On Thu, 19 Mar 2020 12:00:15 + "Zane van Iperen" wrote: > Adds support for the soundbank files used by the Pro Pinball series > of games. > > Please ping for review. > > v3: > - fix potential memory leak if read_header() fa

Re: [FFmpeg-devel] [PATCH] [PATCH] POWER8 VSX vectorization libswscale/input.c Track ticket 5570

2020-03-23 Thread Carl Eugen Hoyos
> Am 23.03.2020 um 12:31 schrieb Pestov Vyacheslav : > > libswscale/ppc/Makefile |3 +- > libswscale/ppc/input_vsx.c| 4562 + > libswscale/swscale.c |2 + > libswscale/swscale_internal.h |1 + > 4 files changed, 4567 insertions(+

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h264_syntax_template: fix off by 1 error with slice_group_change_cycle

2020-03-23 Thread Michael Niedermayer
On Mon, Mar 23, 2020 at 12:30:31AM -0300, James Almer wrote: > On 3/22/2020 8:00 PM, Michael Niedermayer wrote: > > Fixes: assertion failure > > Fixes: > > 20390/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5683400772157440 > > > > Found-by: continuous fuzzing process > >