Hi ffmpeg maintainers / community,
New contributor here. The patch [0] for the drawtext filter was submitted some
time ago now but has been reviewed yet. It seems there is no official maintainer
for this filter (as per the MAINTAINERS file)
What should be done to have it reviewed ?
[0]
On Fri, May 15, 2020 at 12:04 AM Martin Storsjö wrote:
> On Tue, 12 May 2020, Martin Storsjö wrote:
>
> > From: wm4
> >
> > This contains encoder wrappers for H264, HEVC, AAC, AC3 and MP3.
> >
> > This is based on top of an original patch by wm4
> > . The original patch supported both encoding
From: Mark Reid
---
libavfilter/vf_lut3d.c | 367 +++--
1 file changed, 312 insertions(+), 55 deletions(-)
diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c
index 482e2394a7..4067c4a60a 100644
--- a/libavfilter/vf_lut3d.c
+++
From: Mark Reid
---
libavfilter/vf_lut3d.c | 207 +++--
1 file changed, 201 insertions(+), 6 deletions(-)
diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c
index fda85b16b4..482e2394a7 100644
--- a/libavfilter/vf_lut3d.c
+++
On Sun, May 10, 2020 at 12:40 AM Paul B Mahol wrote:
> On 5/10/20, Mark Reid wrote:
> > On Sat., May 9, 2020, 11:59 p.m. Paul B Mahol, wrote:
> >
> >> Do we support these float formats in swscale?
> >> If not, than patch is IMHO pointless.
> >>
> >
> > Yes, my patches for swscale float support
On Mon, May 18, 2020 at 3:24 PM Dale Curtis wrote:
> On Mon, May 18, 2020 at 2:22 PM Michael Niedermayer
> wrote:
>
>>
>> > 38cfdcfc9d4fa1c1239dc01a766e369b20a0232a sat_math_builtin_v5.patch
>>
>
> Latest upload is sat_math_builtin_v6.patch -- is that not showing up for
> you? I just tested
2d8d554f15a7a27cfeca81467cc9341a86f784e2 added a new error condition
to mov_read_stsz() but forgot to free a temporary buffer when it
occurs.
Signed-off-by: Dale Curtis
---
libavformat/mov.c | 1 +
1 file changed, 1 insertion(+)
free_temp_v0.patch
Description: Binary data
On Mon, May 18, 2020 at 2:22 PM Michael Niedermayer
wrote:
>
> > 38cfdcfc9d4fa1c1239dc01a766e369b20a0232a sat_math_builtin_v5.patch
>
Latest upload is sat_math_builtin_v6.patch -- is that not showing up for
you? I just tested and it applies cleanly to trunk.
> > From
Hi
Its quite a while since 4.2.2 so i intend to make 4.2.3 soon
if you want something backported, backport it now
thx
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
While the State exists there can be no freedom; when there is freedom there
will be no State. --
On Mon, May 04, 2020 at 11:40:47AM -0700, Dale Curtis wrote:
> On Mon, May 4, 2020 at 11:19 AM James Almer wrote:
>
> > On 5/4/2020 3:09 PM, Dale Curtis wrote:
> > > Bump. I have 5 integer overflow fuzzing issues awaiting our resolution of
> > > this discussion. Thanks.
> > >
> > > - dale
> >
>
Already asked and answered several times.
On 5/18/20, Patrick Watts wrote:
> All,
>
> Apologies in advance if this is not the correct forum. We're currently
> using FFmpeg in a production application, and our infosec folks have
> flagged it as a vulnerability.
>
>
From: Artem Galin
Adding DX11 relevant device type checks and adjusting callback with
proper MediaSDK pair type support.
Signed-off-by: Artem Galin
---
libavfilter/qsvvpp.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git
From: Artem Galin
Makes selection of d3d11va device type by default and over DirectX 9,
which might break users with older drivers/systems.
DCH driver with Gen6th support should be still fine.
Decode, encode, transcode have been validated.
child_device_type option is responsible for
From: Artem Galin
Adding DX11 relevant device type checks and adjusting callback with
proper MediaSDK pair type support.
Signed-off-by: Artem Galin
---
libavfilter/vf_scale_qsv.c | 43 +-
1 file changed, 24 insertions(+), 19 deletions(-)
diff --git
From: Artem Galin
Adding DX11 relevant device type checks and adjusting callback with
proper MediaSDK pair type support.
Signed-off-by: Artem Galin
---
libavfilter/vf_deinterlace_qsv.c | 44 ++--
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git
From: Artem Galin
Signed-off-by: Artem Galin
---
libavutil/hwcontext_qsv.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c
index 488655b686..e75d4b7c24 100644
--- a/libavutil/hwcontext_qsv.c
+++ b/libavutil/hwcontext_qsv.c
@@
From: Artem Galin
This enables usage of non-powered/headless GPU, better HDR support.
Pool of resources is allocated as one texture with array of slices.
Signed-off-by: Artem Galin
---
libavutil/hwcontext_qsv.c | 323 +++---
1 file changed, 262 insertions(+),
From: Artem Galin
Example: --init_hw_device d3d11va:,vendor=0x8086
qsv_device option is still works and has higher priority over vendor
option.
Signed-off-by: Artem Galin hwctx;
HRESULT hr;
+AVDictionaryEntry *e;
IDXGIAdapter *pAdapter = NULL;
ID3D10Multithread
From: Artem Galin
Adding DX11 relevant device type checks and adjusting callbacks with
proper MediaSDK pair type support.
Extending structure for proper MediaSDK pair type support.
Signed-off-by: Artem Galin
---
libavcodec/qsv.c | 53 ++-
From: Artem Galin
Signed-off-by: Artem Galin
---
fftools/ffmpeg_opt.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 60bb437ea7..83f1b53e9d 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -558,7 +558,11
Do I need to do anything else for someone to take a look? It would be great
to get it merged, if possible, and I think the change itself is pretty
trivial. Apologies if this is being pinged too soon; I'm trying to follow
the guidance on the FFmpeg contributing page ("if some time passes without
From: Artem Galin
Signed-off-by: Artem Galin
---
fftools/ffmpeg_opt.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 60bb437ea7..83f1b53e9d 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -558,7 +558,11
On Mon, 18 May 2020, Emanuele Oriani wrote:
Hi Marton/ffmpeg devs/all,
Haven't seen any response to the proposed XComposite windows capture.
As per below the reasoning for adding this code to libav*/ffmpeg is that
seems to be better in quality than x11grab, although it uses more CPU in
From: Artem Galin
Adding DX11 relevant device type checks and adjusting callbacks with
proper MediaSDK pair type support.
Extending structure for proper MediaSDK pair type support.
Signed-off-by: Artem Galin
---
libavcodec/qsv.c | 53 ++-
From: Artem Galin
This enables usage of non-powered/headless GPU, better HDR support.
Pool of resources is allocated as one texture with array of slices.
Signed-off-by: Artem Galin
---
libavutil/hwcontext_qsv.c | 323 +++---
1 file changed, 262 insertions(+),
From: Artem Galin
Signed-off-by: Artem Galin
---
libavutil/hwcontext_qsv.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c
index 036dc94748..d84de696dd 100644
--- a/libavutil/hwcontext_qsv.c
+++ b/libavutil/hwcontext_qsv.c
@@
From: Artem Galin
Adding DX11 relevant device type checks and adjusting callback with
proper MediaSDK pair type support.
Signed-off-by: Artem Galin
---
libavfilter/qsvvpp.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git
From: Artem Galin
Makes selection of d3d11va device type by default and over DirectX 9,
which might break users with older drivers/systems.
DCH driver with Gen6th support should be still fine.
Decode, encode, transcode have been validated.
child_device_type option is responsible for
From: Artem Galin
Adding DX11 relevant device type checks and adjusting callback with
proper MediaSDK pair type support.
Signed-off-by: Artem Galin
---
libavfilter/vf_deinterlace_qsv.c | 44 ++--
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git
From: Artem Galin
Example: --init_hw_device d3d11va:,vendor=0x8086
qsv_device option is still works and has higher priority over vendor
option.
Signed-off-by: Artem Galin hwctx;
HRESULT hr;
+AVDictionaryEntry *e;
IDXGIAdapter *pAdapter = NULL;
ID3D10Multithread
From: Artem Galin
Adding DX11 relevant device type checks and adjusting callback with
proper MediaSDK pair type support.
Signed-off-by: Artem Galin
---
libavfilter/vf_scale_qsv.c | 43 +-
1 file changed, 24 insertions(+), 19 deletions(-)
diff --git
On Mon, 11 May 2020, Marton Balint wrote:
This will be used for AVCodecContext->profile. By specifying constants in the
encoders we won't have to use the common AVCodecContext options table and
different encoders can use the same profile name even with different values.
Signed-off-by: Marton
On Mon, 18 May 2020, Fu, Linjie wrote:
diff --git a/libavcodec/profiles.h b/libavcodec/profiles.h
index d950971875..e414ea77a7 100644
--- a/libavcodec/profiles.h
+++ b/libavcodec/profiles.h
@@ -37,6 +37,12 @@
FF_AVCTX_PROFILE_OPTION("mpeg2_aac_low", NULL, AUDIO,
On Mon, 18 May 2020, Anton Khirnov wrote:
Quoting Marton Balint (2020-05-16 15:52:22)
Hi,
As you may know, a recent patchset enabled AVCodecContext->profile
constants to reside in encoders.
In order to make a full transition to avctx->profile even in existing
encoders which might use a
The C versions of these functions have landed. Michael, did you intend to
land this one too?
- dale
On Thu, May 14, 2020 at 12:47 PM Dale Curtis wrote:
> Rebased.
>
> On Mon, May 4, 2020 at 11:47 AM James Almer wrote:
>
>> On 5/4/2020 3:40 PM, Dale Curtis wrote:
>> > On Mon, May 4, 2020 at
All,
Apologies in advance if this is not the correct forum. We're currently
using FFmpeg in a production application, and our infosec folks have
flagged it as a vulnerability.
https://github.com/FFmpeg/FFmpeg/commit/1812352d767ccf5431aa440123e2e260a4db2726
a) has anyone applied and implemented
They are codec properties, not encoder capabilities.
Signed-off-by: James Almer
---
fftools/cmdutils.c | 4
1 file changed, 4 deletions(-)
diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 7f5a5ca664..7bec1db18b 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -1423,10
Both are codec properties and not encoder capabilities. The relevant
AVCodecDescriptor.props flags exist for this purpose.
Signed-off-by: James Almer
---
doc/APIchanges | 3 +++
libavcodec/audiotoolboxenc.c| 2 +-
libavcodec/avcodec.h| 7 +--
Signed-off-by: James Almer
---
fftools/ffmpeg_filter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index 8b5b157be7..422e1268e9 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -99,7 +99,8 @@ void
On 5/18/2020 12:16 PM, Anton Khirnov wrote:
> Quoting James Almer (2020-05-11 16:27:56)
>> Signed-off-by: James Almer
>> ---
>> libavcodec/libdav1d.c | 6 ++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c
>> index 72f06c550e..a265a487d8
Quoting James Almer (2020-05-11 16:27:56)
> Signed-off-by: James Almer
> ---
> libavcodec/libdav1d.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c
> index 72f06c550e..a265a487d8 100644
> --- a/libavcodec/libdav1d.c
> +++
On 5/18/2020 11:36 AM, Anton Khirnov wrote:
> Quoting James Almer (2020-05-18 15:56:36)
>> It's the correct dedicated capability reported by supported encoders.
>> Otherwise, the frame thread path will be used for unsupported encoders
>> like r210 for no gain.
>>
>> Signed-off-by: James Almer
>>
On 5/18/2020 11:43 AM, Anton Khirnov wrote:
> Quoting James Almer (2020-05-11 16:27:55)
>> If extradata is available, use it to initialize the AVCodecContext before
>> packet data is seen. Also, don't constantly overwrite it after it's set.
>>
>> Signed-off-by: James Almer
>> ---
>> The main
Quoting James Almer (2020-05-11 16:27:55)
> If extradata is available, use it to initialize the AVCodecContext before
> packet data is seen. Also, don't constantly overwrite it after it's set.
>
> Signed-off-by: James Almer
> ---
> The main benefit from this is using ff_decode_frame_props() to
Quoting James Almer (2020-05-18 15:56:36)
> It's the correct dedicated capability reported by supported encoders.
> Otherwise, the frame thread path will be used for unsupported encoders
> like r210 for no gain.
>
> Signed-off-by: James Almer
> ---
Looks ok.
Also, this capability looks like it
Use 0, which selects the alignment automatically.
---
doc/examples/encode_video.c| 2 +-
doc/examples/muxing.c | 2 +-
doc/examples/vaapi_encode.c| 2 +-
fftools/ffmpeg.c | 2 +-
fftools/ffmpeg_videotoolbox.c | 2 +-
libavcodec/asvenc.c
It is not a public header and has not been used since
10173c0e58e557582dbd659f42c6aa164a8682db
---
fftools/cmdutils.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 7f5a5ca664..b4fd44555b 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
From: Limin Wang
Signed-off-by: Limin Wang
---
depend on below patchset:
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=1212
doc/filters.texi | 21 ++
libavfilter/vf_libopencv.c | 147 +++--
2 files changed, 162 insertions(+), 6
On Mon, May 18, 2020 at 01:11:12PM +0200, Paul B Mahol wrote:
> This opencv module is obsolete for latest opencv.
>
> Instead there should be C++ wrapper.
Sorry, where is the C++ wrapper? Now Opencv 2.x and 3.x is good
to use for my current function. By my initial testing, the performance is
It's the correct dedicated capability reported by supported encoders.
Otherwise, the frame thread path will be used for unsupported encoders
like r210 for no gain.
Signed-off-by: James Almer
---
libavcodec/frame_thread_encoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Quoting James Almer (2020-04-11 17:44:51)
> On 4/10/2020 12:41 PM, Anton Khirnov wrote:
> > ---
> > Not sure what to do with AVFieldOrder. It gets moved to codec_par.h
> > since it is used in AVCodecParameters, but it isn't precisely the right
> > place for it, though it's not horribly wrong
From: Limin Wang
then ff_h264_free_tables() and h264_decode_end() can be removed
in h264_decode_init() if it's failed.
The FF_CODEC_CAP_INIT_CLEANUP flag is need for single thread, For multithread,
it'll be cleanup still by AV_CODEC_CAP_FRAME_THREADS flag if have.
Signed-off-by: Limin Wang
This opencv module is obsolete for latest opencv.
Instead there should be C++ wrapper.
On 5/18/20, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> change the update_metadata() to postprocess() only, I'll add opencv drawbox
> filter and it need
From: Limin Wang
then ff_mpv_encode_end() will be unnecessary in ff_mpv_encode_init()
if it's failed.
The FF_CODEC_CAP_INIT_CLEANUP flag is need for single thread, For multithread,
it'll be cleanup still by AV_CODEC_CAP_FRAME_THREADS flag if have.
Signed-off-by: Limin Wang
---
From: Limin Wang
then we can remove adpcm_encode_close() in adpcm_encode_init() if have failed.
so the goto error lable wlll be unnecessary and can be removed later.
Signed-off-by: Limin Wang
---
libavcodec/adpcmenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Mon, May 18, 2020 at 11:34:03AM +0200, Manolis Stamatogiannakis wrote:
> Bumping this up after 10 days without a comment.
>
> On Fri, 8 May 2020 at 13:14, Manolis Stamatogiannakis
> wrote:
>
> > Allows shifting of subtitle display times to align them with the video.
> > This avoids having to
On Sat, May 16, 2020 at 9:59 PM Andreas Rheinhardt
wrote:
>
> Mattias Wadman:
> > lavf flacenc could previously write truncated metadata picture size if
> > the picture data did not fit in 24 bits. Detect this by truncting the
> > size found inside the picture block and if it matches the block
From: Limin Wang
Signed-off-by: Limin Wang
---
change the update_metadata() to postprocess() only, I'll add opencv drawbox
filter and it need preprocess() to get the meta, so I prefer to change the
function name for better readablity, in future, it may have other processing
than metadata only.
Some flac muxers write truncated metadata picture size if the picture
data do not fit in 24 bits. Detect this by truncting the size found inside
the picture block and if it matches the block size use it and read rest
of picture data.
Used to be an issue with lavf flacenc that was fixed in
Nicolas George (12020-04-16):
> Signed-off-by: Nicolas George
> ---
> libavfilter/tests/formats.c | 136 ++--
> 1 file changed, 68 insertions(+), 68 deletions(-)
I indent to push this soon, so that I can push vf_untile too.
Regards,
--
Nicolas George
Nicolas George (12020-04-16):
> TODO APIchanges and minor bump.
>
> Signed-off-by: Nicolas George
> ---
> libavutil/rational.c | 9 +
> libavutil/rational.h | 6 ++
> 2 files changed, 15 insertions(+)
>
>
> This one too, I need for the code I am writing.
> And lavfi/avf_concat
On Mon, 18 May 2020 at 09:33, Anton Khirnov wrote:
> Quoting Tao Zhang (2020-05-18 08:00:55)
> > If no more comments, I will try to code something to create a pseudo
> > encoder which run the actual encoding in the separate thread. Thanks
>
> I do not think it is a good idea to have the library
---
libavcodec/h264_picture.c| 8 ++-
libavcodec/h264_slice.c | 9 +++
libavcodec/h264dec.c | 46
libavcodec/h264dec.h | 6 +
libavutil/video_enc_params.h | 13 ++
5 files changed, 81 insertions(+), 1 deletion(-)
---
libavformat/Makefile | 1 +
tests/Makefile| 1 +
tests/fate-run.sh | 7 +
tests/fate/h264.mak | 6 +-
tests/fate/vpx.mak| 5 +
tests/ref/fate/h264-encparams | 404 +++
tests/ref/fate/vp9-encparams | 937
Bumping this up after 10 days without a comment.
On Fri, 8 May 2020 at 13:14, Manolis Stamatogiannakis
wrote:
> Allows shifting of subtitle display times to align them with the video.
> This avoids having to rewrite the subtitle file in order to display
> subtitles correctly when input is
Quoting Marton Balint (2020-05-16 15:52:22)
> Hi,
>
> As you may know, a recent patchset enabled AVCodecContext->profile
> constants to reside in encoders.
>
> In order to make a full transition to avctx->profile even in existing
> encoders which might use a private profile setting, we have to
Quoting Tao Zhang (2020-05-18 08:00:55)
> If no more comments, I will try to code something to create a pseudo
> encoder which run the actual encoding in the separate thread. Thanks
I do not think it is a good idea to have the library compensate for
deficiencies in the calling program.
--
Anton
Quoting James Almer (2020-05-15 20:47:56)
> On 5/15/2020 3:36 PM, Lynne wrote:
> > Just posting this as a single email not to spam the ML too much.
> > Going to push this sometime over the weekend alongside the other 3 patches
> > to finish
> > all work on Vulkan before the next release.
>
> The
Hello,
The patch fixes bug with CQ RC mode: max and average bitrate values were not
set to zero.
How to reproduce:
#CQ 30 file
ffmpeg \
-i big_buck_bunny_1080p_h264.mov -c:v h264_nvenc -preset medium \
-cq 30 -y output_cq30.mp4
#CQ 10 file
ffmpeg \
-i big_buck_bunny_1080p_h264.mov -c:v
Will apply soon.
On 5/14/20, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/Makefile | 1 +
> libavcodec/allcodecs.c | 1 +
> libavcodec/codec_desc.c | 7 +
> libavcodec/codec_id.h | 1 +
> libavcodec/notchlc.c| 461
Will apply soon.
On 5/15/20, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> doc/filters.texi | 27
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfilter/vsrc_gradients.c | 290 +++
> 4 files
Hi Marton/ffmpeg devs/all,
Haven't seen any response to the proposed XComposite windows capture.
As per below the reasoning for adding this code to libav*/ffmpeg is that
seems to be better in quality than x11grab, although it uses more CPU in
its current implementation (uses OpenGL and PBO -
Will apply soon.
On 5/16/20, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavfilter/vf_chromakey.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavfilter/vf_chromakey.c b/libavfilter/vf_chromakey.c
> index ce8003657c..4b1669d084 100644
> ---
> From: Fu, Linjie
> Sent: Tuesday, May 12, 2020 21:44
> To: ffmpeg-devel@ffmpeg.org
> Cc: Xu, Guangxin ; Fu, Linjie
> Subject: [PATCH 2/2] lavc/hevc_refs: Fix the logic of find_ref_idx()
>
> From: Xu Guangxin
>
> Currently find_ref_idx() would trigger 2 scans in DPB to find the
> requested
> Mark Thompson:
> Sent: Monday, November 18, 2019 07:14
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Async the
> encoding and output procedure of encoder
>
> On 07/11/2019 16:32, Linjie Fu wrote:
> > Currently, vaapi encodes a pic if all its references
If no more comments, I will try to code something to create a pseudo
encoder which run the actual encoding in the separate thread. Thanks
Tao Zhang 于2020年5月15日周五 上午10:14写道：
>
> Marton Balint 于2020年5月15日周五 上午2:33写道：
> >
> >
> >
> > On Thu, 14 May 2020, Tao Zhang wrote:
> >
> > > Hi,
> > > FFmpeg
76 matches
Mail list logo
