Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-12-04 Thread Gyan Doshi
On 05-12-2020 04:00 am, Michael Niedermayer wrote: On Thu, Dec 03, 2020 at 12:40:40PM -0800, Thierry Foucu wrote: On Wed, Nov 18, 2020 at 12:09 PM Thierry Foucu wrote: --- libavformat/mov.c | 8 ++--

[FFmpeg-devel] [PATCH] fate: fix fate-filter-hqx on BE arches

2020-12-04 Thread Andriy Gelman
From: Andriy Gelman One of the inputs to the fate test has an rgba pixel format which needs to be converted to rgb32 (argb on BE) for the hqx filter. Because auto scaling in the fate test is disabled, this needs a separate scale filter. Signed-off-by: Andriy Gelman ---

[FFmpeg-devel] [PATCH] avformat/mxfenc: Discard audio until valid video has been received

2020-12-04 Thread Andreas Rheinhardt
Normally, video packets are muxed before audio packets for mxf (there is a dedicated interleave function for this); furthermore the first (video) packet triggers writing the actual header. Yet when the first video packet fails the checks performed on it, codec_ul (a value set based upon properties

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/av1dec: Fix leak in case of failure

2020-12-04 Thread James Almer
On 12/4/2020 8:19 PM, Andreas Rheinhardt wrote: James Almer: On 12/4/2020 7:57 PM, Andreas Rheinhardt wrote: A reference to an AV1RawFrameHeader and consequently the AV1RawFrameHeader itself and everything it has a reference to leak if the hardware has no AV1 decoding capabilities. It looks

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/av1dec: Fix leak in case of failure

2020-12-04 Thread Andreas Rheinhardt
James Almer: > On 12/4/2020 7:57 PM, Andreas Rheinhardt wrote: >> A reference to an AV1RawFrameHeader and consequently the >> AV1RawFrameHeader itself and everything it has a reference to leak >> if the hardware has no AV1 decoding capabilities. > > It looks like it can happen if get_buffer()

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/av1dec: Fix leak in case of failure

2020-12-04 Thread James Almer
On 12/4/2020 7:57 PM, Andreas Rheinhardt wrote: A reference to an AV1RawFrameHeader and consequently the AV1RawFrameHeader itself and everything it has a reference to leak if the hardware has no AV1 decoding capabilities. It looks like it can happen if get_buffer() fails even with hardware

[FFmpeg-devel] [PATCH 3/3] tests/fate-run.sh: Don't overlook errors from md5 tests

2020-12-04 Thread Andreas Rheinhardt
The md5 test up until now ignored errors from ffmpeg (the cli) and just md5'ed whatever ffmpeg has output; while testing scenarios in which ffmpeg fails has its merits, errors should not be overlooked by default; doing so also reduces the effectiveness of sanitizers as errors from them are

[FFmpeg-devel] [PATCH 2/3] fate/mxf: Fix d10-user-comments test

2020-12-04 Thread Andreas Rheinhardt
The mxf_d10 muxer is very picky regarding the input it accepts: The only video accepted is MPEG-2 with absolutely constant bitrate, i.e. all packets need to have exactly the same size; and only a few bitrates are accepted. The sample file used did not abide by this: Writing the first packet (a

[FFmpeg-devel] [PATCH 1/3] avcodec/av1dec: Fix leak in case of failure

2020-12-04 Thread Andreas Rheinhardt
A reference to an AV1RawFrameHeader and consequently the AV1RawFrameHeader itself and everything it has a reference to leak if the hardware has no AV1 decoding capabilities. It happens e.g. in the cbs-av1-av1-1-b8-02-allintra FATE-test; it has just been masked because the return value of ffmpeg

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-12-04 Thread Michael Niedermayer
On Thu, Dec 03, 2020 at 12:40:40PM -0800, Thierry Foucu wrote: > On Wed, Nov 18, 2020 at 12:09 PM Thierry Foucu wrote: > > > --- > > libavformat/mov.c | 8 ++-- > > tests/ref/fate/hapqa-extract-nosnappy-to-hapalphaonly-mov | 1 + > >

Re: [FFmpeg-devel] [PATCH] avfilter: add asubcut filter

2020-12-04 Thread Paul B Mahol
Will apply shortly. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] avcodec/decode: port last_pkt_props to AVFifoBuffer

2020-12-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/decode.c | 31 +++ libavcodec/internal.h | 4 ++-- libavcodec/utils.c| 26 +- 3 files changed, 42 insertions(+), 19 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index

Re: [FFmpeg-devel] [PATCH] avcodec/decode: port last_pkt_props to AVFifoBuffer

2020-12-04 Thread James Almer
On 12/4/2020 5:18 PM, Andreas Rheinhardt wrote: James Almer: On 12/4/2020 4:08 PM, Andreas Rheinhardt wrote: James Almer: On 12/4/2020 2:08 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- The idea of making avpriv_packet_list_* public was not liked, and it was

Re: [FFmpeg-devel] [PATCH] avcodec/decode: port last_pkt_props to AVFifoBuffer

2020-12-04 Thread Andreas Rheinhardt
James Almer: > On 12/4/2020 4:08 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 12/4/2020 2:08 PM, Andreas Rheinhardt wrote: James Almer: > Signed-off-by: James Almer > --- > The idea of making avpriv_packet_list_* public was not liked, and > it was > suggested to

Re: [FFmpeg-devel] [PATCH] avcodec/decode: port last_pkt_props to AVFifoBuffer

2020-12-04 Thread James Almer
On 12/4/2020 4:08 PM, Andreas Rheinhardt wrote: James Almer: On 12/4/2020 2:08 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- The idea of making avpriv_packet_list_* public was not liked, and it was suggested to just use AVFifoBuffer instead. After this, the

Re: [FFmpeg-devel] [PATCH] avcodec/decode: port last_pkt_props to AVFifoBuffer

2020-12-04 Thread Andreas Rheinhardt
James Almer: > On 12/4/2020 2:08 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Signed-off-by: James Almer >>> --- >>> The idea of making avpriv_packet_list_* public was not liked, and it was >>> suggested to just use AVFifoBuffer instead. >>> >>> After this, the avpriv_packet_list_* functions

Re: [FFmpeg-devel] [PATCH] avcodec/decode: port last_pkt_props to AVFifoBuffer

2020-12-04 Thread James Almer
On 12/4/2020 2:08 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- The idea of making avpriv_packet_list_* public was not liked, and it was suggested to just use AVFifoBuffer instead. After this, the avpriv_packet_list_* functions can be made local to libavformat

[FFmpeg-devel] [PATCH] avfilter/af_earwax: fix filter behavior

2020-12-04 Thread Paul B Mahol
Previous filter output was incorrect. New one actually follows graph in comments described on side of filter taps. Signed-off-by: Paul B Mahol --- libavfilter/af_earwax.c | 119 +++ tests/fate/filter-audio.mak | 2 +- tests/ref/fate/filter-earwax | 40

Re: [FFmpeg-devel] [PATCH 4/7] lavfi/vf_spp: convert to the video_enc_params API

2020-12-04 Thread Michael Niedermayer
On Fri, Nov 27, 2020 at 03:38:51PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-10-09 19:17:06) > > On Fri, Oct 09, 2020 at 08:13:24AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2020-10-06 00:15:06) > > > > On Mon, Oct 05, 2020 at 10:26:24AM +0200, Anton

Re: [FFmpeg-devel] [PATCH] avcodec/decode: port last_pkt_props to AVFifoBuffer

2020-12-04 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > The idea of making avpriv_packet_list_* public was not liked, and it was > suggested to just use AVFifoBuffer instead. > > After this, the avpriv_packet_list_* functions can be made local to > libavformat again. > > libavcodec/decode.c | 41

Re: [FFmpeg-devel] [PATCH 3/7] lavfi/vf_pp: convert to the video_enc_params API

2020-12-04 Thread Michael Niedermayer
On Fri, Oct 02, 2020 at 08:03:27PM +0200, Anton Khirnov wrote: > --- > libavfilter/Makefile| 2 +- > libavfilter/qp_table.c | 66 + > libavfilter/qp_table.h | 32 ++ > libavfilter/vf_pp.c | 19 --- >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/cdgraphics: Check frame before clearing

2020-12-04 Thread Michael Niedermayer
On Fri, Dec 04, 2020 at 11:27:46AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-12-04 01:07:04) > > Fixes: null pointer dereference > > Fixes: > > 27730/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CDGRAPHICS_fuzzer-6212402236096512 > > > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 1/3] avformat/id3v2: Sanity check tlen before alloc and uncompress

2020-12-04 Thread Michael Niedermayer
On Thu, Dec 03, 2020 at 10:11:37AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (>20sec -> 65ms) > Fixes: > 26896/clusterfuzz-testcase-minimized-ffmpeg_dem_DAUD_fuzzer-5691024049176576 > Fixes: > 27627/clusterfuzz-testcase-minimized-ffmpeg_dem_AEA_fuzzer-4907019324358656 > > Found-by:

Re: [FFmpeg-devel] [PATCH 2/6] avformat/mov: Avoid overflow in end computation in mov_read_custom()

2020-12-04 Thread Michael Niedermayer
On Sat, Oct 31, 2020 at 11:46:29PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 18 + 9223372036854775799 cannot be > represented in type 'long' > Fixes: > 26731/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5696846019952640 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 3/6] avformat/mov: Use av_sat_add64() in mov_read_sidx()

2020-12-04 Thread Michael Niedermayer
On Sat, Oct 31, 2020 at 11:46:30PM +0100, Michael Niedermayer wrote: > This avoids a potential integer overflow, no testcase is known > > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 1/5] avformat/vqf: Check len for COMM chunks

2020-12-04 Thread Michael Niedermayer
On Mon, Nov 02, 2020 at 01:21:24AM +0100, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 26696/clusterfuzz-testcase-minimized-ffmpeg_dem_VQF_fuzzer-5648269168082944 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 3/5] avformat/wavdec: Check for EOF in cues reading

2020-12-04 Thread Michael Niedermayer
On Mon, Nov 02, 2020 at 01:21:26AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (>20sec -> 1ms) > Fixes: > 26793/clusterfuzz-testcase-minimized-ffmpeg_dem_WAV_fuzzer-5674966852567040 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 4/5] avformat/mpc8: Check remaining space in mpc8_parse_seektable()

2020-12-04 Thread Michael Niedermayer
On Fri, Oct 30, 2020 at 10:52:05PM +0100, Michael Niedermayer wrote: > Fixes: Fixes infinite loop > Fixes: > 26704/clusterfuzz-testcase-minimized-ffmpeg_dem_MPC8_fuzzer-6327056939614208 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 4/7] lavfi/vf_spp: convert to the video_enc_params API

2020-12-04 Thread Anton Khirnov
ping Michael, do you still object to this set? If not, I am going to push it. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

[FFmpeg-devel] [PATCH] avcodec/decode: port last_pkt_props to AVFifoBuffer

2020-12-04 Thread James Almer
Signed-off-by: James Almer --- The idea of making avpriv_packet_list_* public was not liked, and it was suggested to just use AVFifoBuffer instead. After this, the avpriv_packet_list_* functions can be made local to libavformat again. libavcodec/decode.c | 41

[FFmpeg-devel] [PATCH 1/3] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2020-12-04 Thread Jan Ekström
From: Stefano Sabatini --- libavutil/avstring.h | 1 + libavutil/bprint.c | 14 ++ tools/ffescape.c | 1 + 3 files changed, 16 insertions(+) diff --git a/libavutil/avstring.h b/libavutil/avstring.h index ee225585b3..79bb920a70 100644 --- a/libavutil/avstring.h +++

[FFmpeg-devel] [PATCH 2/3] ffprobe: switch to av_bprint_escape for XML escaping

2020-12-04 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- fftools/ffprobe.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 86bd23d36d..a127a3f9bb 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@

Re: [FFmpeg-devel] [PATCH 3/3] TTML encoder and muxer

2020-12-04 Thread Paul B Mahol
AWESOME!! On Fri, Dec 4, 2020 at 3:55 PM Jan Ekström wrote: > From: Jan Ekström > > Enables encoding of other subtitle formats into TTML and writing > them out as such documents. > > Signed-off-by: Jan Ekström > --- > Changelog | 1 + > doc/general_contents.texi |

[FFmpeg-devel] [PATCH 3/3] TTML encoder and muxer

2020-12-04 Thread Jan Ekström
From: Jan Ekström Enables encoding of other subtitle formats into TTML and writing them out as such documents. Signed-off-by: Jan Ekström --- Changelog | 1 + doc/general_contents.texi | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 +

[FFmpeg-devel] [PATCH 0/3] Initial implementation of TTML encoding/muxing

2020-12-04 Thread Jan Ekström
I've intentionally kept this initial version simple (no styling etc) to focus on the basics. As this goes through review, additional features can be added (I had initial PoC for styling implemented some time around previous VDD), and there is another patch set in my queue which would then add

Re: [FFmpeg-devel] [PATCH] avfilter/vf_hwupload_cuda: add transparent pix_fmts

2020-12-04 Thread Timo Rothenpieler
On 03.12.2020 16:56, Daniel Raniz Raneland wrote: Signed-off-by: Daniel Raniz Raneland --- libavfilter/vf_hwupload_cuda.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_hwupload_cuda.c b/libavfilter/vf_hwupload_cuda.c index 33906f2515..83b7babeaa 100644 ---

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsv: use avpriv_ instead of ff_ as prefix for some functions

2020-12-04 Thread James Almer
On 12/4/2020 7:24 AM, Anton Khirnov wrote: Quoting Haihao Xiang (2020-11-23 09:16:13) ff_qsv_print_iopattern, ff_qsv_print_error and ff_qsv_print_warning can be used outside of lavc. In addition, ff_qsv_map_error is used in libavcodec/qsv.c only, so remove ff_ from ff_qsv_map_error and make it

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsv: use avpriv_ instead of ff_ as prefix for some functions

2020-12-04 Thread Xiang, Haihao
On Fri, 2020-12-04 at 11:24 +0100, Anton Khirnov wrote: > Quoting Haihao Xiang (2020-11-23 09:16:13) > > ff_qsv_print_iopattern, ff_qsv_print_error and ff_qsv_print_warning can be > > used outside of lavc. In addition, ff_qsv_map_error is used in > > libavcodec/qsv.c only, so remove ff_ from

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2020-12-04 Thread Anton Khirnov
Quoting Alan Kelly (2020-11-19 09:41:56) > --- > All of Henrik's suggestions have been implemented. Additionally, > m3 and m6 are permuted in avx2 before storing to ensure bit by bit > identical results in avx2. > libswscale/x86/Makefile | 1 + > libswscale/x86/swscale.c| 75

Re: [FFmpeg-devel] [PATCH 45/45] avcodec/utils: Remove ff_codec_open2_recursive()

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:49) > This function existed to enable codecs with non-threadsafe init functions > to initialize other codecs despite the fact that normally no two codecs > with non-threadsafe init functions can be initialized at the same time > (there is a mutex

Re: [FFmpeg-devel] [PATCH 44/45] avcodec/tiff: Make decoder init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:48) > The only thing that stands in the way of adding the > FF_CODEC_CAP_INIT_THREADSAFE flag to the TIFF decoder is its usage > of ff_codec_open2_recursive(): This function requires its caller to hold > the lock for the mutex that guards initialization

Re: [FFmpeg-devel] [PATCH 43/45] avcodec/faxcompr: Make ff_ccitt_unpack_init() thread-safe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:47) > This will allow to make the TIFF decoder's init function thread-safe. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/faxcompr.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > Looks ok -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH 38/45] avcodec/cri: Make decoder init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:42) > The only thing that stands in the way of adding the > FF_CODEC_CAP_INIT_THREADSAFE flag to the Cintel RAW decoder is its usage > of ff_codec_open2_recursive(): This function requires its caller to hold > the lock for the mutex that guards

Re: [FFmpeg-devel] [PATCH 37/45] avcodec: Fix invalid uses of ff_codec_open2_recursive()

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:41) > Normally no two codecs with FF_CODEC_CAP_INIT_THREADSAFE unset > can be initialized at the same time: a mutex in avcodec_open2() > ensures this. This implies that one cannot simply open a codec > with a non-threadsafe init-function from the init

Re: [FFmpeg-devel] [PATCH 36/45] avcodec/mxpegdec: Fix memleaks upon init failure

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:40) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mjpegdec.c | 2 ++ > libavcodec/mxpegdec.c | 6 ++ > 2 files changed, 4 insertions(+), 4 deletions(-) This use of mjpeg by other decoders is an ugly mess, but the patch looks ok --

Re: [FFmpeg-devel] [PATCH 35/45] avcodec/mjpegdec: Fix memleak upon init failure

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:39) > This affected all decoders that used ff_mjpeg_decode_init() as init > function; and it also affected decoders that open jpeg decoders via > ff_codec_open2_recursive() as well as MxPEG. > > Signed-off-by: Andreas Rheinhardt > --- >

Re: [FFmpeg-devel] [PATCH 31/45] avcodec/smc: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:35) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/smc.c | 1 + > 1 file changed, 1 insertion(+) Visibly ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 30/45] avcodec/sipr: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:34) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/sipr.c | 1 + > 1 file changed, 1 insertion(+) Looks safe indeed -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 29/45] avcodec/shorten: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:33) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/shorten.c | 1 + > 1 file changed, 1 insertion(+) Ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 28/45] avcodec/sgirledec: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:32) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/sgirledec.c | 1 + > 1 file changed, 1 insertion(+) > Obviously ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 27/45] avcodec/sgienc: Combine av_log() statements

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:31) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/sgienc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Makes sense -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 26/45] avcodec/sgienc: Mark encoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:30) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/sgienc.c | 1 + > 1 file changed, 1 insertion(+) > Good and just -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 25/45] avcodec/sgidec: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:29) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/sgidec.c | 1 + > 1 file changed, 1 insertion(+) Sure -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 24/45] avcodec/tmv: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:28) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/tmv.c | 1 + > 1 file changed, 1 insertion(+) Brilliant -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 23/45] avcodec/ulti: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:27) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ulti.c | 1 + > 1 file changed, 1 insertion(+) Acceptable -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 22/45] avcodec/ws-snd1: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:26) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ws-snd1.c | 1 + > 1 file changed, 1 insertion(+) > Clearly ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 21/45] avcodec/xxan: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:25) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/xxan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Doubleplusgood -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 20/45] avcodec/xxan: Cleanup generically on init failure

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:24) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/xxan.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) Assent -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 19/45] avcodec/xsubenc: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:23) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/xsubenc.c | 2 ++ > 1 file changed, 2 insertions(+) Extremely good -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 18/45] avcodec/xsubdec: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:22) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/xsubdec.c | 2 ++ > 1 file changed, 2 insertions(+) > Good -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 17/45] avcodec/xl: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:21) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/xl.c | 1 + > 1 file changed, 1 insertion(+) Approval -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 16/45] avcodec/xfacedec: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:20) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/xfacedec.c | 1 + > 1 file changed, 1 insertion(+) > Ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 15/45] avcodec/xan: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:19) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/xan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Looks even better. -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 14/45] avcodec/xan: Cleanup generically on init failure

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:18) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/xan.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) Looks good -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 13/45] avcodec/yuv4dec: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:17) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/yuv4dec.c | 1 + > 1 file changed, 1 insertion(+) Much ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 12/45] avcodec/y41penc: Mark encoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:16) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/y41penc.c | 1 + > 1 file changed, 1 insertion(+) > Very ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 11/45] avcodec/y41pdec: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:15) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/y41pdec.c | 1 + > 1 file changed, 1 insertion(+) > Clearly ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 10/45] avcodec/yop: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:14) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/yop.c | 1 + > 1 file changed, 1 insertion(+) Most likely ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 09/45] avcodec/cljrdec: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:13) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cljrdec.c | 1 + > 1 file changed, 1 insertion(+) Obviously ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 08/45] avcodec/loco: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:12) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/loco.c | 1 + > 1 file changed, 1 insertion(+) Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 07/45] avcodec/pcm: Mark decoders as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:11) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pcm.c | 1 + > 1 file changed, 1 insertion(+) Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 06/45] avcodec/pcm: Make encoders init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:10) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pcm.c | 24 +++- > 1 file changed, 15 insertions(+), 9 deletions(-) > Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 05/45] avcodec/adpcmenc: Mark encoders as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:09) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/adpcmenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 04/45] avcodec/adpcm: Mark decoders as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:08) > They don't modify any global state > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/adpcm.c | 1 + > 1 file changed, 1 insertion(+) Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 03/45] avcodec/cdtoons: Mark decoder as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:07) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cdtoons.c | 1 + > 1 file changed, 1 insertion(+) > LGTM -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 02/45] avcodec/a64multienc: Mark encoders as init-threadsafe

2020-12-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-27 02:02:06) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/a64multienc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/cdgraphics: Check frame before clearing

2020-12-04 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-12-04 01:07:04) > Fixes: null pointer dereference > Fixes: > 27730/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CDGRAPHICS_fuzzer-6212402236096512 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsv: use avpriv_ instead of ff_ as prefix for some functions

2020-12-04 Thread Nicolas George
Anton Khirnov (12020-12-04): > Those should either be inline in a private header, or exported as proper > public API from libavutil. What a waste of energy. And you still haven't given a single practical benefit of keeping the libraries separate that could not be achieved more efficiently

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsv: use avpriv_ instead of ff_ as prefix for some functions

2020-12-04 Thread Anton Khirnov
Quoting Haihao Xiang (2020-11-23 09:16:13) > ff_qsv_print_iopattern, ff_qsv_print_error and ff_qsv_print_warning can be > used outside of lavc. In addition, ff_qsv_map_error is used in > libavcodec/qsv.c only, so remove ff_ from ff_qsv_map_error and make it > static. > > Signed-off-by: Haihao

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: Change compute_chapters_end() from O(n²) to O(n log n)

2020-12-04 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-11-22 16:37:32) > Fixes: Timeout (49sec -> 9sec) > Fixes: > 27427/clusterfuzz-testcase-minimized-ffmpeg_dem_FFMETADATA_fuzzer-5140589838073856 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >