Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/qsv: make some functions inline

2020-12-06 Thread Xiang, Haihao
On Mon, 2020-12-07 at 03:10 +0100, Andreas Rheinhardt wrote: > Haihao Xiang: > > ff_qsv_print_iopattern, ff_qsv_print_error, ff_qsv_print_warning and > > ff_qsv_map_error can be used outside of lavc, make them inline in a > > private header so that other libraries may include this private header.

[FFmpeg-devel] [PATCH v3] avformat/framecrcenc: Make side-data checksums endian-independent

2020-12-06 Thread Andreas Rheinhardt
Do this by converting big-endian side data to little endian for checksumming. Reviewed-by: Andriy Gelman Reviewed-by: Michael Niedermayer Signed-off-by: Andreas Rheinhardt --- I have incorporated Michael's resp. Andriy's suggestion regarding av_unused resp. renaming the buffer for the actual

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/qsv: make some functions inline

2020-12-06 Thread Andreas Rheinhardt
Haihao Xiang: > ff_qsv_print_iopattern, ff_qsv_print_error, ff_qsv_print_warning and > ff_qsv_map_error can be used outside of lavc, make them inline in a > private header so that other libraries may include this private header. > In addition, QSV_VERSION_ATLEAST() and

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsv: use avpriv_ instead of ff_ as prefix for some functions

2020-12-06 Thread Xiang, Haihao
On Fri, 2020-12-04 at 10:21 -0300, James Almer wrote: > On 12/4/2020 7:24 AM, Anton Khirnov wrote: > > Quoting Haihao Xiang (2020-11-23 09:16:13) > > > ff_qsv_print_iopattern, ff_qsv_print_error and ff_qsv_print_warning can be > > > used outside of lavc. In addition, ff_qsv_map_error is used in >

[FFmpeg-devel] [PATCH v2 2/2] qsv: dump more info in error, debug and verbose mode

2020-12-06 Thread Haihao Xiang
Dump iopattern mode and the SDK error/warning desciptions for qsv based filters and iopattern mode for qsvenc Signed-off-by: Haihao Xiang --- libavcodec/qsvenc.c | 1 + libavfilter/qsvvpp.c | 21 +-- libavfilter/qsvvpp.h | 10 +

[FFmpeg-devel] [PATCH v2 1/2] lavc/qsv: make some functions inline

2020-12-06 Thread Haihao Xiang
ff_qsv_print_iopattern, ff_qsv_print_error, ff_qsv_print_warning and ff_qsv_map_error can be used outside of lavc, make them inline in a private header so that other libraries may include this private header. In addition, QSV_VERSION_ATLEAST() and QSV_RUNTIME_VERSION_ATLEAST() can be used across

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Sanity check codec_id/track type

2020-12-06 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: memleak > Fixes: > 27766/clusterfuzz-testcase-minimized-ffmpeg_dem_MATROSKA_fuzzer-5198300814508032 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- >

[FFmpeg-devel] [PATCH] avformat/matroskadec: Sanity check codec_id/track type

2020-12-06 Thread Michael Niedermayer
Fixes: memleak Fixes: 27766/clusterfuzz-testcase-minimized-ffmpeg_dem_MATROSKA_fuzzer-5198300814508032 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/matroskadec.c | 12 1 file

[FFmpeg-devel] [PATCH] avformat/hashenc: Reuse hash_free() for framehash muxers

2020-12-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/hashenc.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/libavformat/hashenc.c b/libavformat/hashenc.c index ce609f6efa..5523dfd1cd 100644 --- a/libavformat/hashenc.c +++ b/libavformat/hashenc.c @@ -156,6

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dynamic_hdr10_plus: don't take a GetBitContext as input argument

2020-12-06 Thread Jan Ekström
On Mon, Dec 7, 2020 at 1:23 AM Jan Ekström wrote: > > On Sun, Dec 6, 2020 at 5:44 PM James Almer wrote: > > > > Create a local one instead from a byte buffer input argument. > > > > Signed-off-by: James Almer > > The actual change mentioned in the commit message is LGTM, and the > updated

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_sei: split Dynamic HDR10+ SEI parsing into its own function

2020-12-06 Thread Jan Ekström
On Sun, Dec 6, 2020 at 5:43 PM James Almer wrote: > > Signed-off-by: James Almer LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dynamic_hdr10_plus: don't take a GetBitContext as input argument

2020-12-06 Thread Jan Ekström
On Sun, Dec 6, 2020 at 5:44 PM James Almer wrote: > > Create a local one instead from a byte buffer input argument. > > Signed-off-by: James Almer The actual change mentioned in the commit message is LGTM, and the updated sanity checks seem good (since now the alternatives at that point are

[FFmpeg-devel] [PATCH] avfilter: add asuperpass and asuperstop filter

2020-12-06 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 50 ++ libavfilter/Makefile | 2 + libavfilter/af_asupercut.c | 133 +++-- libavfilter/allfilters.c | 2 + 4 files changed, 183 insertions(+), 4 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH v2 000/162] VLC, esp. init_vlc patches

2020-12-06 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This is the second version of my init_vlc patchset [1]. Given the > feedback I received for the last version I stressed thread-safety of > init functions of decoders. As a consequence, the amount of decoders > with FF_CODEC_CAP_INIT_THREADSAFE increased by 25 (some of them

Re: [FFmpeg-devel] [PATCH 2/2] avformat/framecrcenc: Make side-data checksums endian-independent

2020-12-06 Thread Andreas Rheinhardt
Andriy Gelman: > On Sun, 06. Dec 04:09, Andreas Rheinhardt wrote: >> Do this by converting big-endian side data to little endian for >> checksumming. Fixes the ts-demux FATE test. > > It's quite nicely done imo. > > Same as Michael, I enabled ts-demux test in link below and it worked fine >

[FFmpeg-devel] [PATCH v3 161/191] avcodec/mpegaudiodec: Hardcode tables to save space

2020-12-06 Thread Andreas Rheinhardt
The csa_tables (which always consist of 32 entries of four byte each, but the type depends upon whether the decoder is fixed or floating-point) are currently initialized once during decoder initialization; yet it turns out that this is actually no benefit: The code used to initialize these tables

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

2020-12-06 Thread Marton Balint
On Sat, 5 Dec 2020, Michael Niedermayer wrote: On Sun, Nov 15, 2020 at 01:14:55AM +0100, Marton Balint wrote: On Fri, 6 Nov 2020, Michael Niedermayer wrote: On Wed, Nov 04, 2020 at 10:44:56PM +0100, Marton Balint wrote: On Wed, 4 Nov 2020, Michael Niedermayer wrote: we have

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: Add support for decoding monochrome av1

2020-12-06 Thread Timo Rothenpieler
nvdec change is simple enough. Can't really say too much about the av1dec changes, other than they look generally sensible. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

Re: [FFmpeg-devel] [PATCH 2/2] avformat/framecrcenc: Make side-data checksums endian-independent

2020-12-06 Thread Andriy Gelman
On Sun, 06. Dec 04:09, Andreas Rheinhardt wrote: > Do this by converting big-endian side data to little endian for > checksumming. Fixes the ts-demux FATE test. It's quite nicely done imo. Same as Michael, I enabled ts-demux test in link below and it worked fine (PPC64 qemu)

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate: add a test for HDR10+ metadata in HEVC

2020-12-06 Thread James Almer
On 12/6/2020 1:20 PM, Michael Niedermayer wrote: On Sat, Dec 05, 2020 at 10:24:53PM +, Mohammad Izadi wrote: ffmpeg | branch: master | Mohammad Izadi | Mon Nov 23 13:29:37 2020 -0800| [89e3f5abb72aeb3ef55e7da2b9693a6caa391d5f] | committer: James Almer fate: add a test for HDR10+

Re: [FFmpeg-devel] [PATCH 6/7] avcodec/h264idct_template: Fix integer overflow in ff_h264_chroma422_dc_dequant_idct()

2020-12-06 Thread Michael Niedermayer
On Fri, Nov 06, 2020 at 12:11:09AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2105540608 - 2105540608 cannot be > represented in type 'int' > Fixes: > 26870/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5656647567147008 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 5/7] avformat/dsfdec: Check block_align more completely

2020-12-06 Thread Michael Niedermayer
On Fri, Nov 06, 2020 at 12:11:08AM +0100, Michael Niedermayer wrote: > Fixes: infinite loop > Fixes: > 26865/clusterfuzz-testcase-minimized-ffmpeg_dem_DSF_fuzzer-5649473830912000 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 3/7] avformat/av1dec: check size before addition in probing

2020-12-06 Thread Michael Niedermayer
On Fri, Nov 06, 2020 at 12:11:06AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 175 + 2147483571 cannot be represented in > type 'int' > Fixes: > 26833/clusterfuzz-testcase-minimized-ffmpeg_dem_IMAGE2_fuzzer-5969501214212096 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/7] avformat/realtextdec: read_ts() in 64bits

2020-12-06 Thread Michael Niedermayer
On Fri, Nov 06, 2020 at 12:11:05AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 46671062 * 100 cannot be represented in type > 'int' > Fixes: > 26826/clusterfuzz-testcase-minimized-ffmpeg_dem_REALTEXT_fuzzer-5644062910316544 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate: add a test for HDR10+ metadata in HEVC

2020-12-06 Thread Michael Niedermayer
On Sat, Dec 05, 2020 at 10:24:53PM +, Mohammad Izadi wrote: > ffmpeg | branch: master | Mohammad Izadi | Mon Nov 23 > 13:29:37 2020 -0800| [89e3f5abb72aeb3ef55e7da2b9693a6caa391d5f] | committer: > James Almer > > fate: add a test for HDR10+ metadata in HEVC > > Signed-off-by: James Almer

[FFmpeg-devel] [PATCH 2/2] avcodec/dynamic_hdr10_plus: don't take a GetBitContext as input argument

2020-12-06 Thread James Almer
Create a local one instead from a byte buffer input argument. Signed-off-by: James Almer --- libavcodec/dynamic_hdr10_plus.c | 13 ++--- libavcodec/dynamic_hdr10_plus.h | 7 --- libavcodec/hevc_sei.c | 26 -- 3 files changed, 34 insertions(+), 12

[FFmpeg-devel] [PATCH 1/2] avcodec/hevc_sei: split Dynamic HDR10+ SEI parsing into its own function

2020-12-06 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc_sei.c | 45 +-- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c index 8a29181a31..8af9f9b29d 100644 --- a/libavcodec/hevc_sei.c +++

Re: [FFmpeg-devel] [PATCH 2/2] avformat/framecrcenc: Make side-data checksums endian-independent

2020-12-06 Thread Michael Niedermayer
On Sun, Dec 06, 2020 at 04:09:34AM +0100, Andreas Rheinhardt wrote: > Do this by converting big-endian side data to little endian for > checksumming. Fixes the ts-demux FATE test. > > Signed-off-by: Andreas Rheinhardt > --- > a) When commenting the #if HAVE_BIGENDIAN out, I get the same checksum

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Discard audio until valid video has been received

2020-12-06 Thread Marton Balint
On Sun, 6 Dec 2020, Andreas Rheinhardt wrote: Marton Balint: On Sat, 5 Dec 2020, Andreas Rheinhardt wrote: Normally, video packets are muxed before audio packets for mxf (there is a dedicated interleave function for this); furthermore the first (video) packet triggers writing the actual

Re: [FFmpeg-devel] [PATCH] [RFC] Tech Resolution Process

2020-12-06 Thread Nicolas George
Jean-Baptiste Kempf (12020-12-05): > --- > doc/dev_community/resolution_process.md | 83 + > 1 file changed, 83 insertions(+) > create mode 100644 doc/dev_community/resolution_process.md > > diff --git a/doc/dev_community/resolution_process.md >

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-12-06 Thread James Almer
On 12/6/2020 8:13 AM, Hendrik Leppkes wrote: On Sat, Dec 5, 2020 at 11:28 PM James Almer wrote: On 12/1/2020 3:09 PM, Mohammad Izadi wrote: Ian, can you please take a look into it? And if it's fine to push it. Thanks, Mohammad I removed the packet side data addition since it was not used

[FFmpeg-devel] [PATCH] avfilter/vf_hwupload_cuda: add YUVA420P to pix_fmts

2020-12-06 Thread Daniel Raniz Raneland
Signed-off-by: Daniel Raniz Raneland --- libavfilter/vf_hwupload_cuda.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_hwupload_cuda.c b/libavfilter/vf_hwupload_cuda.c index 33906f2515..c98ef7dd95 100644 --- a/libavfilter/vf_hwupload_cuda.c +++

Re: [FFmpeg-devel] [PATCH] avfilter/vf_hwupload_cuda: add transparent pix_fmts

2020-12-06 Thread Daniel Raniz Raneland
Oh, I just assumed it would work since YUVA420P worked out of the box and both YUV420P and YUV444P were on the list of supported formats. Removing then since I only need YUVA420P. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-12-06 Thread Hendrik Leppkes
On Sat, Dec 5, 2020 at 11:28 PM James Almer wrote: > > On 12/1/2020 3:09 PM, Mohammad Izadi wrote: > > Ian, can you please take a look into it? And if it's fine to push it. > > > > Thanks, > > Mohammad > > I removed the packet side data addition since it was not used by any > module. It can be

Re: [FFmpeg-devel] [PATCH] [RFC] Tech Resolution Process

2020-12-06 Thread Christophe Gisquet
Hi, Le sam. 5 déc. 2020 à 15:59, Jean-Baptiste Kempf a écrit : > +After all the emails are in, the TC has 96 hours to give its final decision. > + > +### Within TC > + > +In the internal case, the TC has 96 hours to give its final decision. How is the unavailability of any TC member handled?

[FFmpeg-devel] [PATCH] avcodec/nvdec: Add support for decoding monochrome av1

2020-12-06 Thread Philip Langdale
The nvidia hardware explicitly supports decoding monochrome content, presumably for the AVIF alpha channel. Supporting this requires an adjustment in av1dec and explicit monochrome detection in nvdec. I'm not sure why the monochrome path in av1dec did what it did - it seems non-functional -