On 23-12-2020 09:52 pm, Gyan Doshi wrote:
Plan to push tomorrow morning.
Pushed as 9a0f5e412ad42a1c1a959d582e4fe2021b9ceda6
On 23-12-2020 04:53 pm, Gyan Doshi wrote:
Wait for all output files to be initialized before printing first stats.
Avoids breaking output file dump report.
---
Great news that the patch is accepted.
Just updated the author is this version.
Thanks!
---
libswscale/slice.c| 12
libswscale/swscale_unscaled.c | 4 +---
2 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/libswscale/slice.c b/libswscale/slice.c
index
On Wed, Dec 23, 2020 at 10:14 PM Michael Niedermayer
wrote:
> patch should be ok, is the author intended to be like this:
> Author: jleconte
> I mean theres no full name in there
>
That's great news!
If it's ok on your side, I'm good with the author being 'jleconte'.
On 12/23/2020 8:53 PM, James Almer wrote:
On 12/23/2020 8:32 PM, Paul B Mahol wrote:
+static int librist_close(URLContext *h)
+{
+ RISTContext *s = h->priv_data;
+ int ret = 0;
+
+ s->peer = NULL;
+
+ if (s->rist_ctx)
+ ret = rist_destroy(s->rist_ctx);
+ if (ret < 0)
+
On 12/23/2020 8:32 PM, Paul B Mahol wrote:
+static int librist_close(URLContext *h)
+{
+RISTContext *s = h->priv_data;
+int ret = 0;
+
+s->peer = NULL;
+
+if (s->rist_ctx)
+ret = rist_destroy(s->rist_ctx);
+if (ret < 0)
+return risterr2ret(ret);
+
This work is sponsored by Open Broadcast Systems.
Signed-off-by: Paul B Mahol
---
configure | 5 +
doc/protocols.texi | 32 ++
libavformat/Makefile| 1 +
libavformat/librist.c | 233
libavformat/protocols.c | 1 +
5
On Wed, 23 Dec 2020, Paul B Mahol wrote:
On Wed, Dec 23, 2020 at 10:30 PM Marton Balint wrote:
INT_MAX for pkt_size is probably not a good default. pkt_size is used (at
least in other protocols) to determine the maximum allowed packet size for
output, and the maximum supported packet
Paul B Mahol (12020-12-23):
> I nowhere see proof that this cause any bugs.
get_file_handle() returns a file descriptor for use with select() or
poll(). If you give it a random number (fd is a random number), the
application will poll it as if it were a file descriptor. At best, it
causes EBADFD.
Paul B Mahol (12020-12-23):
> This work is sponsored by Open Broadcast Systems.
Thanks for the disclosure.
>
> Signed-off-by: Paul B Mahol
> ---
> configure | 5 +
> doc/protocols.texi | 29 +
> libavformat/Makefile| 1 +
> libavformat/librist.c | 227
On Wed, Dec 23, 2020 at 11:29 PM Nicolas George wrote:
> Marton Balint (12020-12-23):
> > > +static int librist_get_file_handle(URLContext *h)
> > > +{
> > > +RISTContext *s = h->priv_data;
> > > +
> > > +return s->fd;
> > > +}
> >
> > I don't think this is right, s->fd is a flow id, not
Marton Balint (12020-12-23):
> > +static int librist_get_file_handle(URLContext *h)
> > +{
> > +RISTContext *s = h->priv_data;
> > +
> > +return s->fd;
> > +}
>
> I don't think this is right, s->fd is a flow id, not an ordinary file
> descriptor. You probably don't need this callback
On Wed, Dec 23, 2020 at 10:30 PM Marton Balint wrote:
>
>
> On Wed, 23 Dec 2020, Paul B Mahol wrote:
>
> > This work is sponsored by Open Broadcast Systems.
> >
> > Signed-off-by: Paul B Mahol
> > ---
> > configure | 5 +
> > doc/protocols.texi | 29 +
> >
In order to fine-control referencing schemes in VP9 encoding, there
is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit
provides a way to use the API through frame metadata.
---
doc/encoders.texi | 32 +
libavcodec/libvpxenc.c | 81
On Wed, 23 Dec 2020, Paul B Mahol wrote:
This work is sponsored by Open Broadcast Systems.
Signed-off-by: Paul B Mahol
---
configure | 5 +
doc/protocols.texi | 29 +
libavformat/Makefile| 1 +
libavformat/librist.c | 227
On Tue, Dec 22, 2020 at 09:39:38AM +, jleconte wrote:
> Thanks for the feedback.
> It's not easy to work with -Wdeclaration-after-statement.
patch should be ok, is the author intended to be like this:
Author: jleconte
I mean theres no full name in there
Iam asking as this cannot be changed
On Wed, Dec 23, 2020 at 05:01:44PM +0100, Paul B Mahol wrote:
> On Wed, Dec 23, 2020 at 4:07 PM Michael Niedermayer
> wrote:
>
> > On Wed, Dec 23, 2020 at 12:35:39PM +0100, Paul B Mahol wrote:
> > > Signed-off-by: Paul B Mahol
> > > ---
> > > libavcodec/cfhd.c | 3 +++
> > > 1 file changed, 3
Ping.
On 8 Dec 2020, at 23:18, Marvin Scholz wrote:
> When targeting a recent enough macOS/iOS version that has clock_gettime
> it won't be a weak symbol, in which case clang warns for this check
> as it's always true:
>
> warning: address of function 'clock_gettime' will always
> evaluate
Pinging again... hope this can be merged...
-Original Message-
From: Eran Kornblau
Sent: Wednesday, December 16, 2020 9:18 PM
To: FFmpeg development discussions and patches
Subject: FW: [FFmpeg-devel] [PATCH] http: support retry on connection error
Ping...
-Original Message-
This work is sponsored by Open Broadcast Systems.
Signed-off-by: Paul B Mahol
---
configure | 5 +
doc/protocols.texi | 29 +
libavformat/Makefile| 1 +
libavformat/librist.c | 227
libavformat/protocols.c | 1 +
5
sure, thanks all for the suggestions.
On Thu, Dec 24, 2020 at 12:24 AM Lynne wrote:
> Dec 23, 2020, 16:48 by jamr...@gmail.com:
>
> > On 12/23/2020 12:38 PM, Nuo Mi wrote:
> >
> >> On Wed, Dec 23, 2020 at 10:00 PM Lynne wrote:
> >>
> >>> Dec 23, 2020, 14:07 by nuomi2...@gmail.com:
> >>>
>
Dec 23, 2020, 16:48 by jamr...@gmail.com:
> On 12/23/2020 12:38 PM, Nuo Mi wrote:
>
>> On Wed, Dec 23, 2020 at 10:00 PM Lynne wrote:
>>
>>> Dec 23, 2020, 14:07 by nuomi2...@gmail.com:
>>>
Hi Lynne & James,
Do not worry about the dav1d things that happened on vvcdec. It just a
Plan to push tomorrow morning.
On 23-12-2020 04:53 pm, Gyan Doshi wrote:
Wait for all output files to be initialized before printing first stats.
Avoids breaking output file dump report.
---
fftools/ffmpeg.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
On 12/23/2020 12:38 PM, Nuo Mi wrote:
On Wed, Dec 23, 2020 at 10:00 PM Lynne wrote:
Dec 23, 2020, 14:07 by nuomi2...@gmail.com:
Hi Lynne & James,
Do not worry about the dav1d things that happened on vvcdec. It just a
reference code like libaom.
libaom does encoding and decoding. And most
At 2020-12-23 23:38:18, "Nuo Mi" wrote:
>On Wed, Dec 23, 2020 at 10:00 PM Lynne wrote:
>
>> Dec 23, 2020, 14:07 by nuomi2...@gmail.com:
>>
>> > Hi Lynne & James,
>> > Do not worry about the dav1d things that happened on vvcdec. It just a
>> > reference code like libaom.
>> >
>>
>> libaom does
On Wed, Dec 23, 2020 at 4:07 PM Michael Niedermayer
wrote:
> On Wed, Dec 23, 2020 at 12:35:39PM +0100, Paul B Mahol wrote:
> > Signed-off-by: Paul B Mahol
> > ---
> > libavcodec/cfhd.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c
> >
On Wed, Dec 23, 2020 at 10:00 PM Lynne wrote:
> Dec 23, 2020, 14:07 by nuomi2...@gmail.com:
>
> > Hi Lynne & James,
> > Do not worry about the dav1d things that happened on vvcdec. It just a
> > reference code like libaom.
> >
>
> libaom does encoding and decoding. And most people only use
> it
On Wed, Dec 23, 2020 at 12:35:39PM +0100, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/cfhd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c
> index a4f4cb4b3c..ae0d4b9496 100644
> --- a/libavcodec/cfhd.c
> +++
On Wed, Dec 23, 2020 at 12:35:38PM +0100, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/cfhd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c
> index a2b9c7c76a..a4f4cb4b3c 100644
> --- a/libavcodec/cfhd.c
>
On Wed, Dec 23, 2020 at 3:59 PM Michael Niedermayer
wrote:
> On Wed, Dec 23, 2020 at 10:52:03AM +0100, Paul B Mahol wrote:
> > On Tue, Dec 22, 2020 at 10:27 PM Michael Niedermayer
>
> > wrote:
> >
> > > On Sun, Dec 20, 2020 at 10:18:40PM +0100, Paul B Mahol wrote:
> > > > Unacceptable, please
On Wed, Dec 23, 2020 at 10:52:03AM +0100, Paul B Mahol wrote:
> On Tue, Dec 22, 2020 at 10:27 PM Michael Niedermayer
> wrote:
>
> > On Sun, Dec 20, 2020 at 10:18:40PM +0100, Paul B Mahol wrote:
> > > Unacceptable, please share privately sample that allows to reproduce
> > this.
> >
> > shared
Dec 23, 2020, 14:07 by nuomi2...@gmail.com:
> Hi Lynne & James,
> Do not worry about the dav1d things that happened on vvcdec. It just a
> reference code like libaom.
>
libaom does encoding and decoding. And most people only use
it for encoding, as its not a very fast decoder. As-is, this patch
Hi Lynne & James,
Do not worry about the dav1d things that happened on vvcdec. It just a
reference code like libaom.
We will not have a useable native vvc decoder in 0.5~1 years. During this
time, the wrapper can help us build many things, like container demuxer,
hls/dash/rtsp network streaming...
Signed-off-by: Paul B Mahol
---
libavcodec/cfhd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c
index a4f4cb4b3c..ae0d4b9496 100644
--- a/libavcodec/cfhd.c
+++ b/libavcodec/cfhd.c
@@ -1372,6 +1372,9 @@ static int update_thread_context(AVCodecContext
Signed-off-by: Paul B Mahol
---
libavcodec/cfhd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c
index a2b9c7c76a..a4f4cb4b3c 100644
--- a/libavcodec/cfhd.c
+++ b/libavcodec/cfhd.c
@@ -436,7 +436,7 @@ static int
Wait for all output files to be initialized before printing first stats.
Avoids breaking output file dump report.
---
fftools/ffmpeg.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 2c0820aacf..84a60f944a 100644
---
On 23-12-2020 04:03 pm, Nicolas George wrote:
Gyan Doshi (12020-12-23):
It's void av_dump_format(...)
Seems too trivial to change it , or add + initialize yet another global
variable just for this.
Exactly. Dumping the output is a global affair, it can warrant a global
variable.
Gyan Doshi (12020-12-23):
> It's void av_dump_format(...)
>
> Seems too trivial to change it , or add + initialize yet another global
> variable just for this.
Exactly. Dumping the output is a global affair, it can warrant a global
variable. Something like this:
of->header_written = 1;
On 23-12-2020 03:53 pm, Nicolas George wrote:
Gyan Doshi (12020-12-23):
That's not the issue. It's the mangled line - the output from lavf/dump.c.
mangled with stats line
AV_NOPTS_VALUE is an acceptable value and already checked for at line 1815.
As is <=0 output size.
Indicating to the
Gyan Doshi (12020-12-23):
> That's not the issue. It's the mangled line - the output from lavf/dump.c.
> mangled with stats line
>
> AV_NOPTS_VALUE is an acceptable value and already checked for at line 1815.
> As is <=0 output size.
>
> Indicating to the user that ffmpeg processing has stalled
On 23-12-2020 03:35 pm, Nicolas George wrote:
Gyan Doshi (12020-12-23):
Which piece of info or object would indicate that? At the stage of this
check, I don't see any available.
Read Michael's mail:
Output #0, avi, to 'file.avi':= 0kB time=-577014:32:22.77 bitrate=
-0.0kbits/s
Gyan Doshi (12020-12-23):
> Which piece of info or object would indicate that? At the stage of this
> check, I don't see any available.
Read Michael's mail:
Output #0, avi, to 'file.avi':= 0kB time=-577014:32:22.77 bitrate=
-0.0kbits/s speed=N/A
The problem is obviously the time. The
On 23-12-2020 03:12 pm, Nicolas George wrote:
Gyan Doshi (12020-12-23):
Avoids breaking output file dump report.
---
fftools/ffmpeg.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
This looks broken. Why 100ms? Because on your setup, 80ms is not enough
but 100ms is? On a slower
On Tue, Dec 22, 2020 at 10:27 PM Michael Niedermayer
wrote:
> On Sun, Dec 20, 2020 at 10:18:40PM +0100, Paul B Mahol wrote:
> > Unacceptable, please share privately sample that allows to reproduce
> this.
>
> shared the ones which reproduce.
>
> Please explain why this patch is unacceptable to
Gyan Doshi (12020-12-23):
> Avoids breaking output file dump report.
> ---
> fftools/ffmpeg.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
This looks broken. Why 100ms? Because on your setup, 80ms is not enough
but 100ms is? On a slower system, it would need to be 120 or 200.
Test
reference link to rfc8216
Signed-off-by: liuqi05
---
libavformat/hlsproto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/hlsproto.c b/libavformat/hlsproto.c
index de45f771d6..9aa211f648 100644
--- a/libavformat/hlsproto.c
+++ b/libavformat/hlsproto.c
@@ -22,7
reference link to rfc8216
Signed-off-by: liuqi05
---
libavformat/hls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index 0a522a4595..a987996810 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -23,7 +23,7 @@
/**
* @file
On 23-12-2020 10:28 am, Gyan Doshi wrote:
Avoids breaking output file dump report.
---
fftools/ffmpeg.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 2c0820aacf..449da484d9 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
47 matches
Mail list logo
