Re: [FFmpeg-devel] [PATCH 03/10] avcodec/vp8data: Remove unused array

2021-01-23 Thread Peter Ross
On Sat, Jan 23, 2021 at 09:47:53PM +0100, Andreas Rheinhardt wrote: > Unused since 748f921ad1997a464fb8963d0ba2c5bb5e036b1b. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp8data.h | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/libavcodec/vp8data.h

Re: [FFmpeg-devel] [PATCH v3] avformat/hls: change sequence number type to int64_t

2021-01-23 Thread Steven Liu
"zhilizhao(赵志立)" 于2021年1月22日周五 下午9:24写道: > > > > > On Jan 22, 2021, at 4:10 PM, Steven Liu wrote: > > > > "zhilizhao(赵志立)" 于2021年1月22日周五 下午3:17写道: > >> > >> Ping for review. > > > > looks no objections? > > Please help merge the patch, thanks! Pushed, thanks Zhili and thanks all the reviewers

Re: [FFmpeg-devel] [PATCH 2/2] avformat/swfdec: Check outlen before allocation

2021-01-23 Thread Michael Niedermayer
On Sat, Jan 23, 2021 at 03:29:38PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-01-22 15:09:47) > > Fixes: Timeout (too long -> 241ms) > > Fixes: > > 29083/clusterfuzz-testcase-minimized-ffmpeg_dem_SWF_fuzzer-6273684478230528 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-23 Thread Lynne
Jan 23, 2021, 23:12 by c...@passwd.hu: > > > On Sat, 23 Jan 2021, Lynne wrote: > >> Jan 23, 2021, 21:42 by c...@passwd.hu: >> >>> >>> >>> On Sat, 23 Jan 2021, Lynne wrote: >>> Jan 23, 2021, 21:04 by c...@passwd.hu: > > > On Sat, 23 Jan 2021, Lynne wrote: > >> This is

[FFmpeg-devel] [PATCH 2/6] avcodec/apedec: Use FFABSU() in do_apply_filter()

2021-01-23 Thread Michael Niedermayer
Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself Fixes: 29053/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-4814432697974784 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 5/6] avformat/flvdec: Check for nesting depth in amf_skip_tag()

2021-01-23 Thread Michael Niedermayer
Fixes: out of array access Fixes: 29440/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-5985279812960256.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/flvdec.c | 9 ++--- 1

Re: [FFmpeg-devel] [PATCH]lsws/ppc/yuv2rgb: Fix transparency converting from yuv->rgb32

2021-01-23 Thread Reimar Döffinger
> On 23 Jan 2021, at 19:35, Carl Eugen Hoyos wrote: > > > New patch attached, thank you! > Looks good to me. I don’t know if I didn’t test the original change properly or if compiler behaviour has changed/is different, but this way should be more correct either way.

[FFmpeg-devel] [PATCH 3/6] tools/target_dec_fuzzer: adjust threshold for cook

2021-01-23 Thread Michael Niedermayer
Fixes: Timeout (long -> 3ms) Fixes: 29134/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_COOK_fuzzer-5192822695264256 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

[FFmpeg-devel] [PATCH 1/6] avutil/common: Add FFABSU() for a signed -> unsigned ABS

2021-01-23 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/common.h | 8 1 file changed, 8 insertions(+) diff --git a/libavutil/common.h b/libavutil/common.h index b9fbcc4d60..a60a558b1d 100644 --- a/libavutil/common.h +++ b/libavutil/common.h @@ -80,6 +80,14 @@ */ #define FFNABS(a) ((a) <= 0

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-23 Thread Marton Balint
On Sat, 23 Jan 2021, Lynne wrote: Jan 23, 2021, 21:42 by c...@passwd.hu: On Sat, 23 Jan 2021, Lynne wrote: Jan 23, 2021, 21:04 by c...@passwd.hu: On Sat, 23 Jan 2021, Lynne wrote: This is an RFC about the upcoming additions to the AVPacket structure (whose size is still part of

[FFmpeg-devel] [PATCH 4/6] avformat/flvdec: Check for nesting depth in amf_parse_object()

2021-01-23 Thread Michael Niedermayer
Fixes: out of array access Fixes: 29202/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-5112845840809984 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/flvdec.c | 5 + 1 file

[FFmpeg-devel] [PATCH 6/6] avformat/flvdec: Check for EOF in loop in flv_data_packet()

2021-01-23 Thread Michael Niedermayer
Fixes: Timeout Fixes: 29656/clusterfuzz-testcase-minimized-ffmpeg_dem_FLV_fuzzer-5840098987999232 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/flvdec.c | 5 + 1 file changed, 5

Re: [FFmpeg-devel] [PATCH 07/39] avcodec/rl: Allow to create only a few VLC tables

2021-01-23 Thread Andreas Rheinhardt
Andreas Rheinhardt: > It is not uncommon that only the first one is used; this is similar to > ff_init_2d_vlc_rl(). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/rl.c | 3 +++ > libavcodec/rl.h | 8 > 2 files changed, 11 insertions(+) > > diff --git a/libavcodec/rl.c

Re: [FFmpeg-devel] [PATCH 05/10] avcodec/tiff_common: Remove declarations of inexistent functions

2021-01-23 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-23 Thread Lynne
Jan 23, 2021, 21:42 by c...@passwd.hu: > > > On Sat, 23 Jan 2021, Lynne wrote: > >> Jan 23, 2021, 21:04 by c...@passwd.hu: >> >>> >>> >>> On Sat, 23 Jan 2021, Lynne wrote: >>> This is an RFC about the upcoming additions to the AVPacket structure (whose size is still part of the ABI, so

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/flashsv2enc: factorize updating block dimensions

2021-01-23 Thread Marton Balint
On Tue, 19 Jan 2021, Anton Khirnov wrote: Quoting Marton Balint (2021-01-18 21:53:30) On Mon, 18 Jan 2021, Anton Khirnov wrote: > Quoting Marton Balint (2021-01-10 02:20:45) >> Signed-off-by: Marton Balint >> --- >> libavcodec/flashsv2enc.c | 76 +---

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dvenc: dv100_weight_shift never used

2021-01-23 Thread Andreas Rheinhardt
Peter Ross: > --- > libavcodec/dvenc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/dvenc.c b/libavcodec/dvenc.c > index 0dc290642e..233e2b68c7 100644 > --- a/libavcodec/dvenc.c > +++ b/libavcodec/dvenc.c > @@ -318,9 +318,8 @@ static const int

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_waveform: flat_pix_fmts never used

2021-01-23 Thread Andreas Rheinhardt
Peter Ross: > --- > libavfilter/vf_waveform.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/libavfilter/vf_waveform.c b/libavfilter/vf_waveform.c > index 11f8c0016e..8191da2792 100644 > --- a/libavfilter/vf_waveform.c > +++ b/libavfilter/vf_waveform.c > @@ -303,13 +303,6 @@

[FFmpeg-devel] [PATCH 08/10] avcodec/mpeg4videodec: Move code around to avoid forward declaration

2021-01-23 Thread Andreas Rheinhardt
Also fix the indentation of decode_studio_vol_header while at it; it was wrong since 177133a0f4b41b3c98b9cbc7f8f45755412c537b. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videodec.c | 308 ++--- 1 file changed, 152 insertions(+), 156 deletions(-) diff

[FFmpeg-devel] [PATCH 07/10] avcodec/sp5x: Remove unused quant tables

2021-01-23 Thread Andreas Rheinhardt
Only the fifth one is used. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 4 +- libavcodec/sp5x.h | 92 +- libavcodec/sp5xdec.c | 5 +-- 3 files changed, 5 insertions(+), 96 deletions(-) diff --git

[FFmpeg-devel] [PATCH 06/10] avcodec/exif: Avoid allocation for small buffer

2021-01-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/exif.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/libavcodec/exif.c b/libavcodec/exif.c index 2874772db4..0b656fd09b 100644 --- a/libavcodec/exif.c +++ b/libavcodec/exif.c @@ -95,22 +95,15 @@ static

[FFmpeg-devel] [PATCH 05/10] avcodec/tiff_common: Remove declarations of inexistent functions

2021-01-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/tiff_common.h | 20 1 file changed, 20 deletions(-) diff --git a/libavcodec/tiff_common.h b/libavcodec/tiff_common.h index 03558c31a3..019d23e6d5 100644 --- a/libavcodec/tiff_common.h +++ b/libavcodec/tiff_common.h @@ -79,26

[FFmpeg-devel] [PATCH 10/10] Revert "mpeg4videodec: raise an error if sprite_trajectory.table is NULL"

2021-01-23 Thread Andreas Rheinhardt
This reverts commit 6ac0e7818399a57e4684202bac79f35b3561ad1e. The mpeg4video parser can reach code that presumes that a certain VLC has been initialized; yet Libav did not ensure this and Libav bug #1012 [1] is about an ensuing crash. Instead of fixing the root cause a simple check for whether

[FFmpeg-devel] [PATCH 04/10] avcodec/amrnbdata: Remove unused array

2021-01-23 Thread Andreas Rheinhardt
Always unused. Signed-off-by: Andreas Rheinhardt --- libavcodec/amrnbdata.h | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/amrnbdata.h b/libavcodec/amrnbdata.h index 435fd9924b..20b7a6452f 100644 --- a/libavcodec/amrnbdata.h +++ b/libavcodec/amrnbdata.h @@ -1424,11 +1424,6

[FFmpeg-devel] [PATCH 09/10] avcodec/mpeg4videodec: Fix indentation

2021-01-23 Thread Andreas Rheinhardt
It was wrong since e03bf251d8784f4d1df2c22381c902087e151e31. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videodec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index e364e0b493..a4479f889b

[FFmpeg-devel] [PATCH 03/10] avcodec/vp8data: Remove unused array

2021-01-23 Thread Andreas Rheinhardt
Unused since 748f921ad1997a464fb8963d0ba2c5bb5e036b1b. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8data.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavcodec/vp8data.h b/libavcodec/vp8data.h index 5e6dea7617..1fcce134eb 100644 --- a/libavcodec/vp8data.h +++

[FFmpeg-devel] [PATCH 02/10] avcodec/ilbcdata: Remove unused array

2021-01-23 Thread Andreas Rheinhardt
Never used. Signed-off-by: Andreas Rheinhardt --- libavcodec/ilbcdata.h | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/ilbcdata.h b/libavcodec/ilbcdata.h index 8d145bc183..b17e24df5f 100644 --- a/libavcodec/ilbcdata.h +++ b/libavcodec/ilbcdata.h @@ -60,10 +60,6 @@ static

[FFmpeg-devel] [PATCH 01/10] avcodec/atrac3plus_data: Remove unused arrays

2021-01-23 Thread Andreas Rheinhardt
Forgotten in 58fc810d42fde26ed6c1f2996122e98ab7005849. Signed-off-by: Andreas Rheinhardt --- libavcodec/atrac3plus_data.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/libavcodec/atrac3plus_data.h b/libavcodec/atrac3plus_data.h index b0b85c4368..05ae2b78a9 100644 ---

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-23 Thread Marton Balint
On Sat, 23 Jan 2021, Lynne wrote: Jan 23, 2021, 21:04 by c...@passwd.hu: On Sat, 23 Jan 2021, Lynne wrote: This is an RFC about the upcoming additions to the AVPacket structure (whose size is still part of the ABI, so we need to plan for any changes). The current RFC patch adds 3

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-23 Thread Lynne
Jan 23, 2021, 21:04 by c...@passwd.hu: > > > On Sat, 23 Jan 2021, Lynne wrote: > >> This is an RFC about the upcoming additions to the AVPacket structure >> (whose size is still part of the ABI, so we need to plan for any changes). >> >> The current RFC patch adds 3 fields: >>     - "void

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-23 Thread Marton Balint
On Sat, 23 Jan 2021, Lynne wrote: This is an RFC about the upcoming additions to the AVPacket structure (whose size is still part of the ABI, so we need to plan for any changes). The current RFC patch adds 3 fields:     - "void *opaque;" for the user to use as they wish, same as

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-23 Thread Gyan Doshi
On 24-01-2021 12:40 am, Lynne wrote: This is an RFC about the upcoming additions to the AVPacket structure (whose size is still part of the ABI, so we need to plan for any changes). The current RFC patch adds 3 fields:     - "void *opaque;" for the user to use as they wish, same as

[FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-23 Thread Lynne
This is an RFC about the upcoming additions to the AVPacket structure (whose size is still part of the ABI, so we need to plan for any changes). The current RFC patch adds 3 fields:     - "void *opaque;" for the user to use as they wish, same as AVFrame.opaque     - "void *opaque_ref;" for more

Re: [FFmpeg-devel] [PATCH] Revert "avutil/timecode: fix sscanf format string with garbage at the end"

2021-01-23 Thread Marton Balint
On Sun, 17 Jan 2021, lance.lmw...@gmail.com wrote: On Sun, Jan 17, 2021 at 03:30:15AM +0100, Marton Balint wrote: On Sun, 17 Jan 2021, lance.lmw...@gmail.com wrote: > On Sat, Jan 16, 2021 at 09:49:42AM +0100, Marton Balint wrote: > > This reverts commit

Re: [FFmpeg-devel] [PATCH]lsws/ppc/yuv2rgb: Fix transparency converting from yuv->rgb32

2021-01-23 Thread Carl Eugen Hoyos
Am Sa., 23. Jan. 2021 um 19:16 Uhr schrieb Reimar Döffinger : > > Hi! > > > On 23 Jan 2021, at 17:31, Carl Eugen Hoyos wrote: > > Attached patch fixes ticket #9077 for me. > > > > Please comment, Carl Eugen > > <0001-lsws-ppc-yuv2rgb-Fix-transparency-converting-from-yu.patch> > > Unfortunately I

Re: [FFmpeg-devel] [PATCH 20/39] avcodec/h261dec: Don't initialize unused part of RLTable

2021-01-23 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2021-01-21 21:20:52) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2020-12-10 12:16:38) The H.261 decoder only uses an RLTable's VLC table, yet it also initializes its index_run, max_level and max_run. This commit stops doing so; it

Re: [FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-23 Thread James Almer
On 1/23/2021 3:17 PM, Anton Khirnov wrote: Quoting James Almer (2021-01-21 14:29:22) On 1/21/2021 9:59 AM, Anton Khirnov wrote: Quoting James Almer (2021-01-09 18:47:17) The st->codec values are updated based on the lowres factor by avformat_find_stream_info() when it runs an instance of the

Re: [FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-23 Thread Anton Khirnov
Quoting James Almer (2021-01-21 14:29:22) > On 1/21/2021 9:59 AM, Anton Khirnov wrote: > > Quoting James Almer (2021-01-09 18:47:17) > >> The st->codec values are updated based on the lowres factor by > >> avformat_find_stream_info() when it runs an instance of the decoder > >> internally, > >>

Re: [FFmpeg-devel] [PATCH]lsws/ppc/yuv2rgb: Fix transparency converting from yuv->rgb32

2021-01-23 Thread Reimar Döffinger
Hi! > On 23 Jan 2021, at 17:31, Carl Eugen Hoyos wrote: > Attached patch fixes ticket #9077 for me. > > Please comment, Carl Eugen > <0001-lsws-ppc-yuv2rgb-Fix-transparency-converting-from-yu.patch> Unfortunately I can’t test anything myself anymore since I don’t have any devices with VGA

Re: [FFmpeg-devel] [PATCH 20/39] avcodec/h261dec: Don't initialize unused part of RLTable

2021-01-23 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-01-21 21:20:52) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2020-12-10 12:16:38) > >> The H.261 decoder only uses an RLTable's VLC table, yet it also > >> initializes its index_run, max_level and max_run. This commit stops > >> doing so; it will also simplify

[FFmpeg-devel] [PATCH]lsws/ppc/yuv2rgb: Fix transparency converting from yuv->rgb32

2021-01-23 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #9077 for me. Please comment, Carl Eugen From 82ac1fb1e33340e956ed36e106ea8a74ecf1f3a3 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 23 Jan 2021 17:28:14 +0100 Subject: [PATCH] lsws/ppc/yuv2rgb: Fix transparency converting from yuv->rgb32. Based on

Re: [FFmpeg-devel] [PATCH] libavdevice: Add KMS/DRM output device

2021-01-23 Thread Anton Khirnov
Quoting Marton Balint (2021-01-20 00:40:30) > > > On Tue, 19 Jan 2021, Anton Khirnov wrote: > > > Quoting Mark Thompson (2021-01-19 00:37:09) > >> On 16/01/2021 22:12, Nicolas Caramelli wrote: > >> > This patch adds KMS/DRM output device for rendering a video stream > >> > using KMS/DRM dumb

[FFmpeg-devel] [PATCH] avfilter: add kirsch video filter

2021-01-23 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 21 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_convolution.c | 133 +++ 4 files changed, 156 insertions(+) diff --git a/doc/filters.texi

Re: [FFmpeg-devel] [PATCH 2/2] avformat/swfdec: Check outlen before allocation

2021-01-23 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-01-22 15:09:47) > Fixes: Timeout (too long -> 241ms) > Fixes: > 29083/clusterfuzz-testcase-minimized-ffmpeg_dem_SWF_fuzzer-6273684478230528 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH] configure: add fallback to $arch in msvc assembler check.

2021-01-23 Thread Martin Storsjö
On Sat, 23 Jan 2021, Reimar Döffinger wrote: Setting the defaults for $arch happens only later, so the current code would not set AS correctly if --arch was not specified on the command-line. Fix it by adding an explicit fallback to $arch_default. --- configure | 2 +- 1 file changed, 1

[FFmpeg-devel] [PATCH] configure: add fallback to $arch in msvc assembler check.

2021-01-23 Thread Reimar Döffinger
Setting the defaults for $arch happens only later, so the current code would not set AS correctly if --arch was not specified on the command-line. Fix it by adding an explicit fallback to $arch_default. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure

[FFmpeg-devel] [PATCH] avfilter: add shear video filter

2021-01-23 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 27 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_shear.c | 309 +++ 4 files changed, 338 insertions(+) create mode 100644 libavfilter/vf_shear.c diff