Re: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Check for too many styles

> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2021年2月21日 12:39 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Check for too > many styles > > Guo, Yejun: > > > > > >> -Original Message- > >>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Check for too many styles

Guo, Yejun: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: 2021年2月21日 12:12 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Check for too >> many styles >> >> Guo, Yejun: >>> >>>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Check for too many styles

> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2021年2月21日 12:12 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Check for too > many styles > > Guo, Yejun: > > > > > >> -Original Message- > >>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Check for too many styles

Guo, Yejun: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: 2021年2月21日 9:41 >> To: ffmpeg-devel@ffmpeg.org >> Cc: Andreas Rheinhardt >> Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Check for too many >> styles >> >> The counter for

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Check for too many styles

> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2021年2月21日 9:41 > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Check for too many > styles > > The counter for the number of styles is

Re: [FFmpeg-devel] [PATCH v6 4/9] avcodec: add cbs for h266/vvc

On Sat, Feb 20, 2021 at 2:17 AM Jan Ekström wrote: > On Fri, Feb 19, 2021 at 3:52 PM Nuo Mi wrote: > > > >> > > > >> The current logic is that we are writing an AU, so the first NAL > unit in > > > >> it is necessarily an AU start and subsequent NAL units are not? > > > >> > > > > H.266 AU

Re: [FFmpeg-devel] [PATCH 2/8] libavfilter/vf_ssim.c: fix build warning

> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Sunday, February 21, 2021 6:21 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 2/8] libavfilter/vf_ssim.c: fix build > warning > > Guo, Yejun: > > The build warning message: > >

[FFmpeg-devel] [PATCH 2/2] avcodec/bitstream: Rewrite code to avoid triggering compiler warning

Clang infers from the existence of a default case that said case can be taken. In case of libavcodec/bitstream.c said default case consisted of an av_assert1 that evaluates to nothing in case of the ordinary assert level. In this case (that doesn't happen) a variable wouldn't be initialized, so

[FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Check for too many styles

The counter for the number of styles is written on two bytes, ergo anything > UINT16_MAX is invalid. This also fixes a compiler warning because of a tautologically true check on 64bit systems. Signed-off-by: Andreas Rheinhardt --- A better solution would be to error out as soon as the byte

Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

On 2/20/2021 9:20 PM, Andreas Rheinhardt wrote: James Almer: On 2/20/2021 8:41 PM, Lynne wrote: Feb 20, 2021, 21:53 by jamr...@gmail.com: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had

Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

Lynne: > Feb 21, 2021, 01:10 by jamr...@gmail.com: > >> On 2/20/2021 8:41 PM, Lynne wrote: >> >>> Maybe mention thread safety? Since in a frame-threaded encoder >>> this may be called from different threads. >>> >> >> So copy paste the paragraph "If frame multithreading is used, this callback >>

Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

Feb 21, 2021, 01:10 by jamr...@gmail.com: > On 2/20/2021 8:41 PM, Lynne wrote: > >> Maybe mention thread safety? Since in a frame-threaded encoder >> this may be called from different threads. >> > > So copy paste the paragraph "If frame multithreading is used, this callback > may be called from

Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

James Almer: > On 2/20/2021 8:41 PM, Lynne wrote: >> Feb 20, 2021, 21:53 by jamr...@gmail.com: >> >>> This callback is functionally the same as get_buffer2() is for >>> decoders, and >>> implements for the new encode API the functionality of the old encode >>> API had >>> where the user could

Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

On 2/20/2021 8:41 PM, Lynne wrote: Feb 20, 2021, 21:53 by jamr...@gmail.com: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers.

Re: [FFmpeg-devel] [PATCH] avcodec/exr: simplify piz decompression

On Sat, Feb 20, 2021 at 11:11 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Paul B Mahol: > > Signed-off-by: Paul B Mahol > > --- > > libavcodec/exr.c | 212 +++ > > 1 file changed, 65 insertions(+), 147 deletions(-) > > > > diff

[FFmpeg-devel] [PATCH] avcodec/exr: simplify piz decompression

Note that >32 codes are no longer supported, give proper error code if such scenario ever happens. Signed-off-by: Paul B Mahol --- libavcodec/exr.c | 251 +-- 1 file changed, 89 insertions(+), 162 deletions(-) diff --git a/libavcodec/exr.c

Re: [FFmpeg-devel] [PATCH] lavu/tx: support in-place FFT transforms

Feb 10, 2021, 21:31 by d...@lynne.ee: > Feb 10, 2021, 18:15 by d...@lynne.ee: > >> This commit adds support for in-place FFT transforms. Since our >> internal transforms were all in-place anyway, this only changes >> the permutation on the input. >> >> Unfortunately, research papers were of no

Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

Feb 20, 2021, 21:53 by jamr...@gmail.com: > This callback is functionally the same as get_buffer2() is for decoders, and > implements for the new encode API the functionality of the old encode API had > where the user could provide their own buffers. > > Signed-off-by: James Almer > --- > As

Re: [FFmpeg-devel] libavfilter: build failure in vf_lensfun.c

Only latest version of library is actually supported. On Sat, Feb 20, 2021 at 5:51 AM Hanspeter Niederstrasser < niederstras...@gmail.com> wrote: > On macOS 10.13,libavfilter/vf_lensfun.c fails like this: > > clang -I. -Isrc/ -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 > -D_LARGEFILE_SOURCE

Re: [FFmpeg-devel] [PATCH 2/8] libavfilter/vf_ssim.c: fix build warning

Guo, Yejun: > The build warning message: > src/libavfilter/vf_ssim.c: In function ‘ssim_plane_16bit’: > src/libavfilter/vf_ssim.c:246:24: warning: ‘main’ is usually a function > [-Wmain] > const uint8_t *main = td->main_data[c]; > ^~~~ > src/libavfilter/vf_ssim.c:

Re: [FFmpeg-devel] [PATCH] avcodec/exr: simplify piz decompression

Paul B Mahol: > Signed-off-by: Paul B Mahol > --- > libavcodec/exr.c | 212 +++ > 1 file changed, 65 insertions(+), 147 deletions(-) > > diff --git a/libavcodec/exr.c b/libavcodec/exr.c > index cacdff5774..625ee4680c 100644 > --- a/libavcodec/exr.c >

Re: [FFmpeg-devel] [RFC] Event loop

On 19/02/2021 19:34, Kieran Kunhya wrote: On Fri, 19 Feb 2021 at 19:04, Nicolas George wrote: Kieran Kunhya (12021-02-19): I don't have a strong opinion on either. But I think you can use container_of on the fd. Thanks. I find no trace of it in the docs:

Re: [FFmpeg-devel] [PATCH] cbs_h265: Detect more reference combinations which would overflow the DPB

On 03/02/2021 21:34, Mark Thompson wrote: In total, the number of short term references (from the selected short term ref pic set), the number of long term references (combining both the used candidates from the SPS and those defined in the slice header) and the number of instances of the

[FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers. Signed-off-by: James Almer --- As suggested by Anton, here's get_buffer() for encoders. This

Re: [FFmpeg-devel] [PATCH] cbs_sei: Detect payload overflows when reading SEI messages

On 02/02/2021 20:58, Mark Thompson wrote: The top-level GetBitContext is sized for the whole NAL unit, so it fails to detect overflows where a payload continues into the following message. To fix that, we make a new context on the stack for reading each payload. --- On 01/02/2021 22:31, Michael

Re: [FFmpeg-devel] [PATCH 1/2 v2] avcodec/gifenc: Add global_palette option

On Sat, 20 Feb 2021, Derek Buitenhuis wrote: This option will disable the writing of the global palette in global GIF header if it is set to 0, causing only the frame-level palette to ever be written. This will be useful later on when further frame-level palette optimizations are introduced.

[FFmpeg-devel] [PATCH 1/2 v2] avcodec/gifenc: Add global_palette option

This option will disable the writing of the global palette in global GIF header if it is set to 0, causing only the frame-level palette to ever be written. This will be useful later on when further frame-level palette optimizations are introduced. The default is 1, which maintains current

[FFmpeg-devel] [PATCH 2/2 v3] avcodec/gifenc: Only write frame palette entries that actually used

GIF palette entries are not compressed, and writing 256 entries, which can be up to every frame, uses a significant amount of space, especially in extreme cases, where palettes can be very small. Example, first six seconds of Tears of Steel, palette generated with libimagequant, 320x240

Re: [FFmpeg-devel] [PATCH 2/2 v2] avcodec/gifenc: Only write frame palette entries that actually used

Derek Buitenhuis: > GIF palette entries are not compressed, and writing 256 entries, > which can be up to every frame, uses a significant amount of > space, especially in extreme cases, where palettes can be very > small. > > Example, first six seconds of Tears of Steel, palette generated > with

Re: [FFmpeg-devel] [PATCH 2/2 v2] avcodec/gifenc: Only write frame palette entries that actually used

On Sat, Feb 20, 2021 at 7:58 PM Derek Buitenhuis wrote: > GIF palette entries are not compressed, and writing 256 entries, > which can be up to every frame, uses a significant amount of > space, especially in extreme cases, where palettes can be very > small. > > Example, first six seconds of

[FFmpeg-devel] [PATCH 2/2 v2] avcodec/gifenc: Only write frame palette entries that actually used

GIF palette entries are not compressed, and writing 256 entries, which can be up to every frame, uses a significant amount of space, especially in extreme cases, where palettes can be very small. Example, first six seconds of Tears of Steel, palette generated with libimagequant, 320x240

[FFmpeg-devel] [PATCH 0/2 v2] GIF Palette Improvements

Derek Buitenhuis (2): avcodec/gifenc: Add global_palette option avcodec/gifenc: Only write frame palette entries that actually used libavcodec/gif.c | 93 ++-- 1 file changed, 82 insertions(+), 11 deletions(-) -- 2.30.0

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dpxenc: write framerate to header

On Sat, Feb 20, 2021 at 7:02 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > James Almer: > > On 2/20/2021 1:37 PM, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/dpxenc.c | 21 ++--- > >> tests/ref/lavf/gbrp10le.dpx |

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dpxenc: write framerate to header

James Almer: > On 2/20/2021 1:37 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >>   libavcodec/dpxenc.c   | 21 ++--- >>   tests/ref/lavf/gbrp10le.dpx   |  4 ++-- >>   tests/ref/lavf/gbrp12le.dpx   |  4 ++-- >>   tests/ref/lavf/rgb48le.dpx    |  4 ++-- >>  

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

Hi, > On Oct 31, 2020, at 5:15 PM, Marton Balint > wrote: > On Sat, 31 Oct 2020, Dave Rice wrote: >>> On Oct 31, 2020, at 3:47 PM, Marton Balint >> > wrote: >>> On Sat, 31 Oct 2020, Dave Rice wrote: Hi Marton, > On Oct 31, 2020, at 12:56 PM,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dpxenc: write framerate to header

On Sat, Feb 20, 2021 at 6:17 PM James Almer wrote: > On 2/20/2021 1:37 PM, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > libavcodec/dpxenc.c | 21 ++--- > > tests/ref/lavf/gbrp10le.dpx | 4 ++-- > > tests/ref/lavf/gbrp12le.dpx | 4 ++-- > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dpxenc: write framerate to header

On 2/20/2021 1:37 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavcodec/dpxenc.c | 21 ++--- tests/ref/lavf/gbrp10le.dpx | 4 ++-- tests/ref/lavf/gbrp12le.dpx | 4 ++-- tests/ref/lavf/rgb48le.dpx| 4 ++-- tests/ref/lavf/rgb48le_10.dpx | 4

[FFmpeg-devel] [PATCH 2/2] avcodec/dpx_parser: export framerate and timebase of frames

Also always skip pixel bytes. Signed-off-by: Paul B Mahol --- libavcodec/dpx_parser.c | 68 ++--- 1 file changed, 44 insertions(+), 24 deletions(-) diff --git a/libavcodec/dpx_parser.c b/libavcodec/dpx_parser.c index 8e4a01e09d..ed7b085040 100644 ---

[FFmpeg-devel] [PATCH 1/2] avcodec/dpxenc: write framerate to header

Signed-off-by: Paul B Mahol --- libavcodec/dpxenc.c | 21 ++--- tests/ref/lavf/gbrp10le.dpx | 4 ++-- tests/ref/lavf/gbrp12le.dpx | 4 ++-- tests/ref/lavf/rgb48le.dpx| 4 ++-- tests/ref/lavf/rgb48le_10.dpx | 4 ++-- tests/ref/lavf/rgba64le.dpx | 4 ++-- 6

Re: [FFmpeg-devel] [PATCH] Ticket #8750 Add inline function for the vec_xl intrinsic in non-VSX environments

Hi Reimar, On Sat, 20. Feb 12:34, Reimar Döffinger wrote: > Hi! > > > On 24 Jan 2021, at 17:35, Andriy Gelman wrote: > > > > On Sat, 07. Nov 16:31, Andriy Gelman wrote: > >> On Sat, 31. Oct 10:17, Andriy Gelman wrote: > >>> On Fri, 16. Oct 00:02, Andriy Gelman wrote: > On Fri, 09. Oct

[FFmpeg-devel] [PATCH v2 18/19] fate/matroska: Test remuxing tracks for hearing/visually impaired

The tests also test the other dispositions: commentary, descriptions as well as dub and original language. Signed-off-by: Andreas Rheinhardt --- The first version of the matroska-wtv-remux test used the fixed-point mp2 decoder; given that no floats are involved I presumed that this would give

Re: [FFmpeg-devel] [PATCH 2/4] libavutil: add side data AV_FRAME_DATA_BOUNDING_BOXES

Feb 20, 2021, 15:13 by yejun@intel.com: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Lynne >> Sent: 2021年2月20日 6:54 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH 2/4] libavutil: add side data >> AV_FRAME_DATA_BOUNDING_BOXES

Re: [FFmpeg-devel] [PATCH 137/217] avcodec/cpia: Mark decoder as init-threadsafe

> libavcodec/cpia.c | 1 + > 1 file changed, 1 insertion(+) lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH 2/6] lavc: split LSCR decoder out of PNG decoder

On 2/16/2021 5:24 PM, Anton Khirnov wrote: It shares very little code with pngdec, so keeping them together only makes the code harder to read. --- libavcodec/Makefile | 2 +- libavcodec/lscrdec.c | 279 +++ libavcodec/png.h | 5 +

Re: [FFmpeg-devel] [PATCH] avcodec: remove pointless lowres deprecation wrappers

On 2/13/2021 1:32 PM, James Almer wrote: Neither the feature, public fields, or AVOptions were ever truly deprecated, and will also not be removed if this FF_API_ define was left in place, so remove it as it's misleading. Signed-off-by: James Almer --- libavcodec/avcodec.h | 13 -

[FFmpeg-devel] [PATCH 16/16] avcodec/rv34data: Remove rv34_dquant_tab

It is unused and coincides with ff_modified_quant_tab. Signed-off-by: Andreas Rheinhardt --- libavcodec/rv34data.h | 13 - 1 file changed, 13 deletions(-) diff --git a/libavcodec/rv34data.h b/libavcodec/rv34data.h index 32ecc395a8..4509e1feed 100644 --- a/libavcodec/rv34data.h +++

Re: [FFmpeg-devel] [PATCH 2/4] libavutil: add side data AV_FRAME_DATA_BOUNDING_BOXES

> -Original Message- > From: ffmpeg-devel On Behalf Of Lynne > Sent: 2021年2月20日 6:54 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 2/4] libavutil: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Feb 19, 2021, 07:59 by yejun@intel.com: > >

[FFmpeg-devel] [PATCH] avutil/buffer: free all pooled buffers immediately after uninitializing the pool

No buffer will be fetched from the pool after it's uninitialized, so there's no benefit from waiting until every single buffer has been returned to it before freeing them all. This should free some memory in certain scenarios, which can be beneficial in low memory systems. Based on a patch by

Re: [FFmpeg-devel] [PATCH 31/32] avcodec/ac3tab: Move ff_ac3_enc_channel_map to its only user

Feb 20, 2021, 06:01 by andreas.rheinha...@gmail.com: > and make it static. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ac3enc.c | 11 ++- > libavcodec/ac3tab.c | 18 -- > libavcodec/ac3tab.h | 9 - > 3 files changed, 18 insertions(+), 20

Re: [FFmpeg-devel] [PATCH 32/32] avcodec/dirac_vlc: Make ff_dirac_golomb_lut static

Feb 20, 2021, 06:01 by andreas.rheinha...@gmail.com: > Only used here. > > Signed-off-by: Andreas Rheinhardt > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH] Ticket #8750 Add inline function for the vec_xl intrinsic in non-VSX environments

Hi! > On 24 Jan 2021, at 17:35, Andriy Gelman wrote: > > On Sat, 07. Nov 16:31, Andriy Gelman wrote: >> On Sat, 31. Oct 10:17, Andriy Gelman wrote: >>> On Fri, 16. Oct 00:02, Andriy Gelman wrote: On Fri, 09. Oct 20:17, Andriy Gelman wrote: > From: Chip Kerchner > > --- >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add Simbiosis IMX video decoder

will apply soon this set ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".