Re: [FFmpeg-devel] [PATCH 2/4] avcodec/libx264: Don't use init_static_data for newer versions

2021-02-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > x264 versions >= 153 can support multiple bitdepths; they also don't > export x264_bit_depth any more. The actual check whether a bitdepth > is supported is therefore performed at runtime in x264_encoder_open. > Ergo it is unnecessary to use init_static_data for these versions

Re: [FFmpeg-devel] [PATCH V3 1/5] libavdevice/v4l2.c: fix build warning for [-Wformat-truncation=]

2021-02-26 Thread Guo, Yejun
> -Original Message- > From: Nicolas George > Sent: 2021年2月26日 17:28 > To: FFmpeg development discussions and patches > Cc: Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH V3 1/5] libavdevice/v4l2.c: fix build > warning for [-Wformat-truncation=] > > Guo, Yejun (12021-02-26): > > Here

Re: [FFmpeg-devel] [PATCH V2 1/7] libavdevice/v4l2.c: fix build warning for [-Wformat-truncation=]

2021-02-26 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Reimar > D?ffinger > Sent: 2021年2月26日 17:21 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V2 1/7] libavdevice/v4l2.c: fix build > warning for [-Wformat-truncation=] > > > > On 25 Feb 2021, a

Re: [FFmpeg-devel] [PATCH 2/3] avcodec: add SGA Video decoder

2021-02-26 Thread James Almer
On 2/26/2021 8:29 AM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 + libavcodec/codec_id.h | 1 + libavcodec/sga.c| 534 5 files cha

Re: [FFmpeg-devel] [PATCH 01/15] avformat/movenc: Remove always true check

2021-02-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/movenc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 545b0885ae..cdfcbd3d76 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -6395,7

Re: [FFmpeg-devel] [PATCH 1] avcodec/x86: add cfhdenc SIMD

2021-02-26 Thread James Almer
On 2/26/2021 9:27 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavcodec/cfhdencdsp.c | 3 + libavcodec/x86/Makefile | 2 + libavcodec/x86/cfhdencdsp.asm| 431 +++ libavcodec/x86/cfhdencdsp_init.c | 48 4 files changed

[FFmpeg-devel] [PATCH 1] avcodec/x86: add cfhdenc SIMD

2021-02-26 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/cfhdencdsp.c | 3 + libavcodec/x86/Makefile | 2 + libavcodec/x86/cfhdencdsp.asm| 431 +++ libavcodec/x86/cfhdencdsp_init.c | 48 4 files changed, 484 insertions(+) create mode 100644 libavcode

Re: [FFmpeg-devel] [PATCH v3] libsvtav1: Add logical_processors option

2021-02-26 Thread Christopher Degawa
> Maybe I am reading this wrong or not understanding but this says it is > used for limiting threads and then in the next sentence says it does > not limit threads? > > It is quite confusing. > it's confusing for me too, but the idea is that it doesn't set n threads, but it can be used to make it s

Re: [FFmpeg-devel] [PATCH v3] libsvtav1: Add logical_processors option

2021-02-26 Thread Marvin Scholz
On 27 Feb 2021, at 1:00, Christopher Degawa wrote: From: Christopher Degawa Used for limiting the size of memory buffers and threads for a target logical processor count, but does not set thread affinity or limit the amount of threads used, although thread affinities can be controlled with a

[FFmpeg-devel] [PATCH v3] libsvtav1: Add logical_processors option

2021-02-26 Thread Christopher Degawa
From: Christopher Degawa Used for limiting the size of memory buffers and threads for a target logical processor count, but does not set thread affinity or limit the amount of threads used, although thread affinities can be controlled with an additional parameters, it is prefered to add them unti

Re: [FFmpeg-devel] [PATCH] avdevice: use av_gettime_relative() for elapsed time calculations

2021-02-26 Thread Marton Balint
On Fri, 19 Feb 2021, Marton Balint wrote: av_gettime_relative() is using the monotonic clock therefore more suitable for elapsed time calculations. Packet timestamps are still kept absolute, although that should be configurable in the future. Signed-off-by: Marton Balint --- libavdevice/bktr

Re: [FFmpeg-devel] [PATCH] avcodec/options: deprecate avcodec_get_frame_class()

2021-02-26 Thread James Almer
On 2/25/2021 5:37 PM, James Almer wrote: AVFrame hasn't been a struct defined in libavcodec for a decade now, when it was moved to libavutil. Will apply. Found-by: mkver Signed-off-by: James Almer --- libavcodec/avcodec.h | 8 libavcodec/options.c | 2 ++ libavcodec/version.h |

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-26 Thread Marton Balint
On Fri, 26 Feb 2021, Paul B Mahol wrote: This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 29 + libavformat/Makefile| 1 + libavformat/librist.c | 248 +++

[FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-26 Thread Paul B Mahol
This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 29 + libavformat/Makefile| 1 + libavformat/librist.c | 248 libavformat/protocols.c | 1 + 5 file

Re: [FFmpeg-devel] [PATCH v5 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-26 Thread Jan Ekström
On Fri, Feb 26, 2021 at 9:00 PM Jan Ekström wrote: > > On Fri, Feb 26, 2021 at 7:54 PM Michael Niedermayer > wrote: > > > > On Mon, Feb 22, 2021 at 03:19:11PM +0200, Jan Ekström wrote: > > > From: Stefano Sabatini > > > > > > Base escaping only escapes values required for base character data > >

Re: [FFmpeg-devel] [PATCH v5 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-26 Thread Jan Ekström
On Fri, Feb 26, 2021 at 7:54 PM Michael Niedermayer wrote: > > On Mon, Feb 22, 2021 at 03:19:11PM +0200, Jan Ekström wrote: > > From: Stefano Sabatini > > > > Base escaping only escapes values required for base character data > > according to part 2.4 of XML, and if additional flags are added > >

Re: [FFmpeg-devel] [PATCH 3/5] tests/api-flac-test: convert to new encoding/decoding API

2021-02-26 Thread James Almer
On 2/24/2021 7:04 AM, Anton Khirnov wrote: --- tests/api/api-flac-test.c | 40 +-- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/tests/api/api-flac-test.c b/tests/api/api-flac-test.c index 7c96a4d99e..3d83c56987 100644 --- a/tests/api/api-f

Re: [FFmpeg-devel] [PATCH 4/5] tests/api-flac-test: reindent

2021-02-26 Thread James Almer
On 2/24/2021 7:04 AM, Anton Khirnov wrote: --- tests/api/api-flac-test.c | 42 +++ 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/tests/api/api-flac-test.c b/tests/api/api-flac-test.c index 3d83c56987..b67c3d7363 100644 --- a/tests/api/api-f

Re: [FFmpeg-devel] [PATCH v5 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-26 Thread Michael Niedermayer
On Mon, Feb 22, 2021 at 03:19:11PM +0200, Jan Ekström wrote: > From: Stefano Sabatini > > Base escaping only escapes values required for base character data > according to part 2.4 of XML, and if additional flags are added > single and double quotes can additionally be escaped in order > to handl

[FFmpeg-devel] [PATCH 6/6] avformat: Deprecate AVFMT_FLAG_PRIV_OPT, remove av_demuxer_open on bump

2021-02-26 Thread Andreas Rheinhardt
This flag was added in 492026209b9b58eaf6d2ea56423f6b1e1a8a76a5 in conjunction with av_demuxer_open() to allow to pass private options to demuxers. It worked as follows: av_open_input_stream() (the predecessor of avformat_open_input()) would not call the read_header function if this flag is set. In

Re: [FFmpeg-devel] [PATCH 5/5] lavc: remove tests/options

2021-02-26 Thread Andreas Rheinhardt
Anton Khirnov: > It tests deprecated avcodec_copy_context(). > --- > libavcodec/Makefile| 1 - > libavcodec/tests/options.c | 194 - > tests/fate/libavcodec.mak | 4 - > 3 files changed, 199 deletions(-) > delete mode 100644 libavcodec/tests/option

Re: [FFmpeg-devel] [PATCH 2/5] avcodec: Add missing FF_API define for libavcodec pix fmt API

2021-02-26 Thread James Almer
On 2/26/2021 10:18 AM, Andreas Rheinhardt wrote: avcodec_find_best_pix_fmt2 has been deprecated and replaced by avcodec_find_best_pix_fmt_of_2 in 2a54ae9df8cbc1717b3929222ac75f384e2ff240. avcodec_find_best_pix_fmt_of_2 and avcodec_get_pix_fmt_loss meanwhile were deprecated in 617e866e25b72fa5d9f9

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/mpegvideo: Schedule unused, deprecated rc_strategy for removal

2021-02-26 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/5] avcodec: Add missing FF_API define for libavcodec pix fmt API

2021-02-26 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_filter: Don't use deprecated function

2021-02-26 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 3/5] avcodec/mpegvideo: Schedule unused, deprecated rc_strategy for removal

2021-02-26 Thread Andreas Rheinhardt
Deprecated in d05c3b9ceeb9d00d4500c376448230e45f6ab108. Signed-off-by: Andreas Rheinhardt --- Here is my current WIP branch for the bump for anyone who is interested: https://github.com/mkver/FFmpeg/commits/bump libavcodec/mpegvideo.h | 14 +++--- libavcodec/version.h | 3 +++ 2 file

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/parser: Schedule av_parser_change for removal

2021-02-26 Thread James Almer
On 2/26/2021 10:18 AM, Andreas Rheinhardt wrote: Originally deprecated in 748c2fca7e4d99357c234936aa71212a6282be36, publically deprecated in 9a07c1332cfe092b57b5758f22b686ca58806c60 (merged into FFmpeg in 1885ffb03d0af28e6bac2bcc8725fa15b93f6ac9). Signed-off-by: Andreas Rheinhardt --- libavco

[FFmpeg-devel] [PATCH 5/5] doc/codecs.texi: Remove removed or ineffective options

2021-02-26 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Is it possible that Libav didn't use codecs.texi and that the committers forgot to update it when Libav merges removed some of these options? doc/codecs.texi | 122 +--- 1 file changed, 1 insertion(+), 121 deletion

[FFmpeg-devel] [PATCH 4/5] avcodec/parser: Schedule av_parser_change for removal

2021-02-26 Thread Andreas Rheinhardt
Originally deprecated in 748c2fca7e4d99357c234936aa71212a6282be36, publically deprecated in 9a07c1332cfe092b57b5758f22b686ca58806c60 (merged into FFmpeg in 1885ffb03d0af28e6bac2bcc8725fa15b93f6ac9). Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.h | 6 +- libavcodec/parser.c | 3 +

[FFmpeg-devel] [PATCH 2/5] avcodec: Add missing FF_API define for libavcodec pix fmt API

2021-02-26 Thread Andreas Rheinhardt
avcodec_find_best_pix_fmt2 has been deprecated and replaced by avcodec_find_best_pix_fmt_of_2 in 2a54ae9df8cbc1717b3929222ac75f384e2ff240. avcodec_find_best_pix_fmt_of_2 and avcodec_get_pix_fmt_loss meanwhile were deprecated in 617e866e25b72fa5d9f9d6bbcbd7e4bd69e63a54 when these functions were de f

[FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_filter: Don't use deprecated function

2021-02-26 Thread Andreas Rheinhardt
avcodec_find_best_pix_fmt_of_2 has been moved to libavutil in 617e866e25b72fa5d9f9d6bbcbd7e4bd69e63a54. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 921839

Re: [FFmpeg-devel] Feature request

2021-02-26 Thread Tomas Härdin
ons 2021-02-24 klockan 23:45 + skrev Jimmy Jaffe: > Hi people. Now it is very common videos recorded with bad rotations. > With ffmpeg it is possible to rotate without re-encoding the video > using the 'rotate' instruction. But if the video has more than one > rotation it is not possible. Will

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: change toolkit_version metadata field to toolkit_version_num

2021-02-26 Thread Tomas Härdin
lör 2021-02-20 klockan 00:17 +0100 skrev Marton Balint: > It only got added recently, and the new name makes it consistent with > product_version_num in the next patch. > > Signed-off-by: Marton Balint > --- > libavformat/mxfdec.c | 2 +- > tests/ref/fate/mxf-d10-user-comments |

Re: [FFmpeg-devel] [PATCH] avformat/gopher: Add support for Gopher over TLS.

2021-02-26 Thread Ivan J.
As for the test cases, curl has implemented their local test units[0] that test gophers. After applying the patch and compiling, the ffmpeg implementation can be tested with the following: 1) No encryption: $ ./ffplay gopher://parazyd.org/9/pub/dev/random/1593154977112.webm $ ./f

[FFmpeg-devel] [PATCH 1/3] avcodec: add SGA PCM decoder

2021-02-26 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/pcm.c| 9 + libavcodec/utils.c | 1 + 6 files changed, 20 insertions(+) diff --git a/libavcodec/Makefi

[FFmpeg-devel] [PATCH 2/3] avcodec: add SGA Video decoder

2021-02-26 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 + libavcodec/codec_id.h | 1 + libavcodec/sga.c| 534 5 files changed, 544 insertions(+) create mode 100644 libavc

Re: [FFmpeg-devel] [PATCH V3 3/5] libavformat/protocols.c: fix build warning for [-Wdiscarded-qualifiers]

2021-02-26 Thread Paul B Mahol
look at same/similar patches like yours that have been already rejected. On Fri, Feb 26, 2021 at 9:48 AM Guo, Yejun wrote: > src/libavformat/protocols.c: In function ‘avio_enum_protocols’: > src/libavformat/protocols.c:116:7: warning: assignment discards ‘const’ > qualifier from pointer target t

[FFmpeg-devel] [PATCH 3/3] avformat: add Digital Pictures SGA game demuxer

2021-02-26 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/sga.c| 473 +++ 3 files changed, 475 insertions(+) create mode 100644 libavformat/sga.c diff --git a/libavformat/Makefile b/libavformat/Mak

Re: [FFmpeg-devel] [PATCH v5 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-26 Thread Nicolas George
Jan Ekström (12021-02-22): > From: Stefano Sabatini > > Base escaping only escapes values required for base character data > according to part 2.4 of XML, and if additional flags are added > single and double quotes can additionally be escaped in order > to handle single and double quoted attribu

Re: [FFmpeg-devel] [PATCH V3 1/5] libavdevice/v4l2.c: fix build warning for [-Wformat-truncation=]

2021-02-26 Thread Nicolas George
Guo, Yejun (12021-02-26): > Here is the warning message: > src/libavdevice/v4l2.c: In function ‘v4l2_get_device_list’: > src/libavdevice/v4l2.c:1054:58: warning: ‘%s’ directive output may be > truncated writing up to 255 bytes into a region of size 251 > [-Wformat-truncation=] > snprintf

Re: [FFmpeg-devel] [PATCH V2 1/7] libavdevice/v4l2.c: fix build warning for [-Wformat-truncation=]

2021-02-26 Thread Reimar Döffinger
> On 25 Feb 2021, at 18:52, Chad Fraleigh wrote: > > On 2/24/2021 10:38 PM, Guo, Yejun wrote: >> libavdevice/v4l2.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c >> index 365bacd771..e11d10d20e 100644 >> --- a/libavdevice/v4l2.c

[FFmpeg-devel] [PATCH V3 5/5] libavutil/opt.c: fix build warning for [-Wdiscarded-qualifiers]

2021-02-26 Thread Guo, Yejun
src/libavutil/opt.c: In function ‘av_opt_child_class_iterate’: src/libavutil/opt.c:1738:15: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] *iter = parent->child_class_next(*iter); ^ Signed-off-by: Guo, Yejun --- libavutil

[FFmpeg-devel] [PATCH V3 4/5] libavformat/smoothstreamingenc.c: fix build warning for [-Wformat-truncation=]

2021-02-26 Thread Guo, Yejun
Part of the build message: src/libavformat/smoothstreamingenc.c: In function ‘ism_flush’: src/libavformat/smoothstreamingenc.c:510:49: warning: ‘/temp’ directive output may be truncated writing 5 bytes into a region of size between 1 and 1024 [-Wformat-truncation=] snprintf(filename, siz

[FFmpeg-devel] [PATCH V3 3/5] libavformat/protocols.c: fix build warning for [-Wdiscarded-qualifiers]

2021-02-26 Thread Guo, Yejun
src/libavformat/protocols.c: In function ‘avio_enum_protocols’: src/libavformat/protocols.c:116:7: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] p = p ? p + 1 : url_protocols; ^ Signed-off-by: Guo, Yejun --- libavformat/protocols.c

[FFmpeg-devel] [PATCH V3 2/5] libavformat/dashenc.c: fix build warning for [-Wformat-truncation=]

2021-02-26 Thread Guo, Yejun
Part of warning message: src/libavformat/dashenc.c: In function ‘flush_init_segment’: src/libavformat/dashenc.c:608:49: warning: ‘%s’ directive output may be truncated writing up to 1023 bytes into a region of size between 1 and 1024 [-Wformat-truncation=] snprintf(filename, sizeof(filen

[FFmpeg-devel] [PATCH V3 1/5] libavdevice/v4l2.c: fix build warning for [-Wformat-truncation=]

2021-02-26 Thread Guo, Yejun
Here is the warning message: src/libavdevice/v4l2.c: In function ‘v4l2_get_device_list’: src/libavdevice/v4l2.c:1054:58: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 251 [-Wformat-truncation=] snprintf(device_name, sizeof(device_name), "/de