Re: [FFmpeg-devel] [PATCH] GSoC: Support fast guided filter.

2021-05-12 Thread Steven Liu
> 2021年5月10日 下午9:42,Xuewei Meng <928826...@qq.com> 写道: > > From: Xuewei Meng > > Two modes are supported in guided filter, basic mode and fast mode. > Basic mode is the initial pushed guided filter without optimization. > Fast mode is implemented based on the basic one by sub-sampling method.

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Restore DTS correction for VP9 copies

2021-05-12 Thread Danny Wu
> Shouldn't google not produce invalid files? Also, can you link one of > these videos to test this issue? While I agree that Google should fix the issue, I think it would be beneficial for ffmpeg to correct these classes of errors, in-line with what ffmpeg already does for every other format

Re: [FFmpeg-devel] [PATCH 3/5 v2] lavfi/dnn_backend_native_layer_dense.h: Documentation

2021-05-12 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Shubhanshu Saxena > Sent: 2021年5月13日 2:45 > To: ffmpeg-devel@ffmpeg.org > Cc: Shubhanshu Saxena > Subject: [FFmpeg-devel] [PATCH 3/5 v2] > lavfi/dnn_backend_native_layer_dense.h: Documentation > > Add documentation for Dense

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/adpcm: Set vqa_version before use in init

2021-05-12 Thread Zane van Iperen
On 13/5/21 10:50 am, Andreas Rheinhardt wrote: Michael Niedermayer: Fixes: null pointer dereference Fixes: 33172/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_WS_fuzzer-5200164273913856 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/adpcm: Set vqa_version before use in init

2021-05-12 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: null pointer dereference > Fixes: > 33172/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_WS_fuzzer-5200164273913856 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 5/5] tools/target_dec_fuzzer: Adjust threshold for jpeg2000

2021-05-12 Thread Michael Niedermayer
On Tue, Apr 13, 2021 at 05:45:39PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (25->4sec) > Fixes: > 32780/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-6017852583837696 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 4/5] avformat/utils: Use 64bit earlier in r_frame_rate check

2021-05-12 Thread Michael Niedermayer
On Tue, Apr 13, 2021 at 05:45:38PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1406796319 * 2 cannot be represented in type > 'int' > Fixes: > 32777/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5632576913014784 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 9/9] avcodec/clearvideo: Check for 0 tile_shift

2021-05-12 Thread Michael Niedermayer
On Mon, Apr 19, 2021 at 08:23:46PM +0200, Michael Niedermayer wrote: > Fixes: shift exponent -1 is negative > Fixes: > 33401/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CLEARVIDEO_fuzzer-5908683596890112 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 8/9] tools/target_dec_fuzzer: Adjust threshold for TAK

2021-05-12 Thread Michael Niedermayer
On Mon, Apr 19, 2021 at 08:23:45PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 33346/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TAK_fuzzer-4715352157192192 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/adpcm: Set vqa_version before use in init

2021-05-12 Thread Michael Niedermayer
On Mon, Apr 19, 2021 at 08:23:43PM +0200, Michael Niedermayer wrote: > Fixes: null pointer dereference > Fixes: > 33172/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_WS_fuzzer-5200164273913856 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/vc1: Check remaining bits in ff_vc1_parse_frame_header()

2021-05-12 Thread Michael Niedermayer
On Mon, Apr 19, 2021 at 08:23:42PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 33156/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3_fuzzer-6259655027326976 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 3/9] avformat/mov: Ignore duplicate CoLL

2021-05-12 Thread Michael Niedermayer
On Mon, Apr 19, 2021 at 08:23:40PM +0200, Michael Niedermayer wrote: > Fixes: memleak > Fixes: > 32146/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5377612845285376 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/9] avformat/mov: Limit nb_chapter_tracks to input size

2021-05-12 Thread Michael Niedermayer
On Mon, Apr 19, 2021 at 08:23:39PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (15k loop iterations instead of 400m) > Fixes: > 31368/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6601583174483968 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: don't add offsets to NULL pointers

2021-05-12 Thread James Almer
On 5/4/2021 5:50 PM, James Almer wrote: On 5/4/2021 5:13 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer ---   libavutil/imgutils.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c index

[FFmpeg-devel] [PATCH v2] avfilter/src_movie: Expose open options

2021-05-12 Thread Ignacio Losiggio
Add a dict-typed option to movie/amovie called options that gets forwarded to avformat_open_input. This now allows complex filtergraph setups that require options on their movie sources (for example, setting the pixel format of a webcam). Signed-off-by: Ignacio Losiggio --- doc/filters.texi

[FFmpeg-devel] [PATCH] avfilter/src_movie: Expose open options

2021-05-12 Thread Ignacio Losiggio
Add a dict-typed option to movie/amovie called options that gets forwarded to avformat_open_input. This now allows complex filtergraph setups that require options on their movie sources (for example, setting the pixel format of a webcam). Signed-off-by: Ignacio Losiggio --- doc/filters.texi

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-12 Thread Marton Balint
On Wed, 12 May 2021, James Almer wrote: On 5/12/2021 3:55 PM, Marton Balint wrote: Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Alexander Strasser wrote an alternative approach to using timezone in

[FFmpeg-devel] [PATCH 3/5 v2] lavfi/dnn_backend_native_layer_dense.h: Documentation

2021-05-12 Thread Shubhanshu Saxena
Add documentation for Dense Layer Signed-off-by: Shubhanshu Saxena --- .../dnn/dnn_backend_native_layer_dense.h | 28 +++ 1 file changed, 28 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_native_layer_dense.h b/libavfilter/dnn/dnn_backend_native_layer_dense.h

[FFmpeg-devel] [PATCH 2/5 v2] lavfi/dnn_backend_native_layer_conv2d.h: Documentation

2021-05-12 Thread Shubhanshu Saxena
Add documentation for 2D Convolution Layer Signed-off-by: Shubhanshu Saxena --- .../dnn/dnn_backend_native_layer_conv2d.h | 28 +++ 1 file changed, 28 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_native_layer_conv2d.h

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-12 Thread James Almer
On 5/12/2021 3:55 PM, Marton Balint wrote: Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Alexander Strasser wrote an alternative approach to using timezone in

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-12 Thread James Almer
On 5/12/2021 4:04 PM, James Almer wrote: On 5/12/2021 3:55 PM, Marton Balint wrote: Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Alexander Strasser wrote an alternative approach to using timezone in

[FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-12 Thread Marton Balint
Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 13 ++--- tests/ref/fate/flv-demux | 2 +- 2 files changed, 3 insertions(+), 12

[FFmpeg-devel] [PATCH 4/5 v2] lavfi/dnn_backend_native_layer_depth2space.h: Documentation

2021-05-12 Thread Shubhanshu Saxena
Add documentation for Depth to Space Layer Signed-off-by: Shubhanshu Saxena --- .../dnn_backend_native_layer_depth2space.h| 30 +++ 1 file changed, 30 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_native_layer_depth2space.h

Re: [FFmpeg-devel] [PATCH 1/5] lavfi/dnn_backend_native_layer_avgpool.h: Documentation

2021-05-12 Thread Shubhanshu Saxena
On Wed, May 12, 2021 at 8:31 PM Guo, Yejun wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Shubhanshu Saxena > > Sent: Wednesday, May 12, 2021 5:02 PM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH

Re: [FFmpeg-devel] [PATCH 08/12] fate/demux: convert flv-demux to ffprobe

2021-05-12 Thread Eoff, Ullysses A
TYVM Anton! I will test it and close the Trac ticket if success on my end. > -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Wednesday, May 12, 2021 11:22 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 08/12]

[FFmpeg-devel] [PATCH 5/5 v3] lavfi/dnn_backend_native_layer_mathunary.h: Documentation

2021-05-12 Thread Shubhanshu Saxena
Add documentation for Unary Math Layer Signed-off-by: Shubhanshu Saxena --- .../dnn/dnn_backend_native_layer_mathunary.h | 30 +++ 1 file changed, 30 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_native_layer_mathunary.h

[FFmpeg-devel] [PATCH 1/5 v2] lavfi/dnn_backend_native_layer_avgpool.h: Documentation

2021-05-12 Thread Shubhanshu Saxena
Add documentation for Average Pool Layer Signed-off-by: Shubhanshu Saxena --- .../dnn/dnn_backend_native_layer_avgpool.h| 29 +++ 1 file changed, 29 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_native_layer_avgpool.h

Re: [FFmpeg-devel] [PATCH 08/12] fate/demux: convert flv-demux to ffprobe

2021-05-12 Thread Anton Khirnov
Hey, Quoting Eoff, Ullysses A (2021-05-12 19:16:09) > *bump* > > Is anyone actively fixing this? Anton? Please. Sorry about the delay, the patch was on the ML since Monday, but people had comments. Just pushed it, the rest can be resolved later. -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-12 Thread Anton Khirnov
pushed the patch as is, since it fixes FATE Further comments can be applied on top of it later. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-12 Thread Marton Balint
On Wed, 12 May 2021, Ubaldo Porcheddu wrote: Hi Marton, +} + +//private data +desc_len += 6 + 2; +*q++ = 0x5F; +*q++ = 4; +*q++ = 0x00; +*q++ = 0x00; +put16(, 40); What are these? I didn't find any official document about it but this seems to be the way

Re: [FFmpeg-devel] [PATCH 08/12] fate/demux: convert flv-demux to ffprobe

2021-05-12 Thread Eoff, Ullysses A
*bump* Is anyone actively fixing this? Anton? Please. > -Original Message- > From: ffmpeg-devel On Behalf Of Eoff, > Ullysses A > Sent: Tuesday, May 11, 2021 8:44 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 08/12] fate/demux: convert

Re: [FFmpeg-devel] [PATCH 1/5] lavfi/dnn_backend_native_layer_avgpool.h: Documentation

2021-05-12 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Shubhanshu Saxena > Sent: Wednesday, May 12, 2021 5:02 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/5] > lavfi/dnn_backend_native_layer_avgpool.h: Documentation > >

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: actually use SIMD version for bpp<=2

2021-05-12 Thread Michael Niedermayer
On Wed, May 12, 2021 at 07:07:27AM +0200, Nicolas Frattaroli wrote: > The SIMD version was only used by the bpp > 2 case. This patch > uses the SIMD version for both code paths. > > Change has been tested to still work with a 1-bpp image that uses > paeth, to generate one: change breaks fate ---

Re: [FFmpeg-devel] ffprobe as library rather than CLI

2021-05-12 Thread Timo Rothenpieler
On 12.05.2021 15:19, Samuel Marks wrote: Started hacking around to make it work. So I changed the `main` to a: extern int ffprobe(int argc, char **argv); Then I added a header with a prototype of the same, and started messing with vcpkg + CMake to try and get it to build correctly. That's

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Restore DTS correction for VP9 copies

2021-05-12 Thread James Almer
On 5/12/2021 10:02 AM, Danny Wu wrote: Fixes ticket 9086. Since early 2021, some of YouTube's VP9 encodes have non-monotonous DTS. This makes ffmpeg fatally fail when trying to copy or encode the V9 video. ffmpeg already includes functionality to correct this, however it was disabled without

[FFmpeg-devel] [PATCH] fftools/ffmpeg: Restore DTS correction for VP9 copies

2021-05-12 Thread Danny Wu
Fixes ticket 9086. Since early 2021, some of YouTube's VP9 encodes have non-monotonous DTS. This makes ffmpeg fatally fail when trying to copy or encode the V9 video. ffmpeg already includes functionality to correct this, however it was disabled without explanation for VP9 stream copies in

[FFmpeg-devel] [PATCH] avcodec: remove leftover references to AVCodecContext.refcounted_frames

2021-05-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.h | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 3cf131d0a5..51c29ec54e 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -2737,8 +2737,7 @@ int

[FFmpeg-devel] ffprobe as library rather than CLI

2021-05-12 Thread Samuel Marks
Started hacking around to make it work. So I changed the `main` to a: extern int ffprobe(int argc, char **argv); Then I added a header with a prototype of the same, and started messing with vcpkg + CMake to try and get it to build correctly. Is there any appetite amongst you FFMPEG developers

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix -t inaccurate recording time

2021-05-12 Thread Shiwang.Xie
Is there objection? will push it tomorrow. On Thu, 6 May 2021, Shiwang.Xie wrote: if input start time is not 0 -t is inaccurate doing stream copy, will record extra duration according to input start time. it should base on following cases: input video start time from 60s, duration is 300s,

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-12 Thread Ubaldo Porcheddu
Hi Marton, +} + +//private data +desc_len += 6 + 2; +*q++ = 0x5F; +*q++ = 4; +*q++ = 0x00; +*q++ = 0x00; +put16(, 40); What are these? I didn't find any official document about it but this seems to be the way many national (FR,IT,UK) broadcasters are writing

Re: [FFmpeg-devel] [PATCH 1/5] lavfi/dnn_backend_native_layer_avgpool.h: Documentation

2021-05-12 Thread Shubhanshu Saxena
On Wed, May 12, 2021 at 7:52 AM Guo, Yejun wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Shubhanshu Saxena > > Sent: 2021年5月8日 20:10 > > To: ffmpeg-devel@ffmpeg.org > > Cc: Shubhanshu Saxena > > Subject: [FFmpeg-devel] [PATCH 1/5] > >

Re: [FFmpeg-devel] [PATCH] ffmpeg: return no chosen output if an uninitialized stream is unavailable

2021-05-12 Thread Jan Ekström
On Fri, May 7, 2021 at 12:22 AM Jan Ekström wrote: > > Otherwise the rate emulation logic in `transcode_step` never gets > hit, and the unavailability flag never gets reset, leading to an > eternal loop. > > Fixes #9160 > --- I will be double-checking after $dayjob whether there is another area