Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dnxhdenc: fix possible out of bound writes for big w/h

2022-03-04 Thread Martin Storsjö
On Fri, 4 Mar 2022, Paul B Mahol wrote: ffmpeg | branch: master | Paul B Mahol | Fri Mar 4 23:25:48 2022 +0100| [37480b1b85b0405563962b581dc2899b1b4bec59] | committer: Paul B Mahol avcodec/dnxhdenc: fix possible out of bound writes for big w/h It was caused by integer overflows.

Re: [FFmpeg-devel] [PATCH] avfilter/split: switch to activate()

2022-03-04 Thread Paul B Mahol
On 3/4/22, Nicolas George wrote: > Paul B Mahol (12022-03-03): >> It is caused by number of sample per frame. >> >> I tested actually with -f lavfi -i sine only. >> >> And patch resolves issue. > > I do not doubt it does. But even without activate, EOF should not depend > on the number of samples

[FFmpeg-devel] [PATCH] avcodec/dnxhdenc: add checks for write overflows

2022-03-04 Thread Paul B Mahol
Also add compensation for extra data needed per packet. Signed-off-by: Paul B Mahol --- libavcodec/dnxhdenc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index ac92474e56..cba3a753e5 100644 --- a/libavcodec/dnxhdenc.c +++

Re: [FFmpeg-devel] [PATCH 17/17] fftools/ffmpeg_opt: Apply copyinkf for all stream types

2022-03-04 Thread Andreas Rheinhardt
Jan Ekström: > On Tue, Nov 9, 2021 at 8:05 PM Andreas Rheinhardt > wrote: >> >> The earlier code has ignored it for all stream types except >> video and subtitles, probably because audio was presumed >> to only consist of keyframes. Yet this assumption is not true >> for e.g. TrueHD. >> >>

Re: [FFmpeg-devel] [PATCH v2 4/7] avutil/mathematics: add av_rescale_interval() function

2022-03-04 Thread Pierre-Anthony Lemieux
On Fri, Mar 4, 2022 at 12:13 PM Andreas Rheinhardt wrote: > > p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > Refactors a function used by avformat/concat and avformat/imf. > > > > --- > > libavutil/mathematics.c | 10 ++ > > libavutil/mathematics.h | 21

Re: [FFmpeg-devel] [PATCH v2 4/7] avutil/mathematics: add av_rescale_interval() function

2022-03-04 Thread Andreas Rheinhardt
p...@sandflow.com: > From: Pierre-Anthony Lemieux > > Refactors a function used by avformat/concat and avformat/imf. > > --- > libavutil/mathematics.c | 10 ++ > libavutil/mathematics.h | 21 + > 2 files changed, 31 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH] libavfilter: vf_scale: Properly take in->color_range into account

2022-03-04 Thread Michael Niedermayer
On Thu, Mar 03, 2022 at 02:06:45PM +0200, Martin Storsjö wrote: > While swscale can be reconfigured with sws_setColorspaceDetails, > the in/out ranges also need to be set before calling > sws_init_context, otherwise the initialization might choose > fastpaths that don't take the ranges into

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add pcm-bluray encoder

2022-03-04 Thread Paul B Mahol
Gonna apply this soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec: Check expacc

2022-03-04 Thread Michael Niedermayer
On Thu, Mar 03, 2022 at 06:36:29PM +0100, Paul B Mahol wrote: > On 11/3/16, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/ac3dec.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c > > index

Re: [FFmpeg-devel] [PATCH v8 1/1] avformat: Add IPFS protocol support.

2022-03-04 Thread Michael Niedermayer
On Thu, Mar 03, 2022 at 03:58:53PM +0100, Mark Gaiser wrote: > On Tue, Mar 1, 2022 at 11:01 PM Michael Niedermayer > wrote: > > > On Mon, Feb 28, 2022 at 02:09:15PM +0100, Tomas Härdin wrote: > > > sön 2022-02-27 klockan 15:29 +0100 skrev Mark Gaiser: > > > > Ping 2 > > > > > > > > I'd

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-04 Thread Vignesh Venkatasubramanian
On Fri, Mar 4, 2022 at 3:24 AM James Almer wrote: > > On 3/3/2022 4:16 PM, Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > > > Sample usage for still image: > > ffmpeg -i

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-04 Thread Vignesh Venkatasubramanian
Add an AVIF muxer by re-using the existing the mov/mp4 muxer. AVIF Specifiation: https://aomediacodec.github.io/av1-avif Sample usage for still image: ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif Sample usage for animated AVIF image: ffmpeg -i video.mp4 animated.avif We can

[FFmpeg-devel] [PATCH v2 2/2] avformat/movenc: sidx earliest_presentation_time is applied after editlist

2022-03-04 Thread Zhao Zhili
Fix #8334 --- Remove casual change due to clang-format plugin. libavformat/movenc.c | 3 ++- tests/ref/fate/movenc | 10 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 4c868919ae..a2da80bc00 100644 ---

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: sidx earliest_presentation_time is applied after editlist

2022-03-04 Thread Zhao Zhili
Fix #8334 --- libavformat/movenc.c | 7 --- tests/ref/fate/movenc | 10 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 4c868919ae..c1b455aba2 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -4750,9

[FFmpeg-devel] [PATCH 1/2] avformat/mov: log the right variable

2022-03-04 Thread Zhao Zhili
--- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 5e26267810..52caa6a891 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4863,7 +4863,7 @@ static int mov_read_trun(MOVContext *c, AVIOContext *pb,

[FFmpeg-devel] Ping Re: [PATCH v2 7/7] avformat/concat: refactor to use av_rescale_interval()

2022-03-04 Thread Pierre-Anthony Lemieux
Hi all, Just a quick note to check if additional work is needed on this patchset that has been LGTMed? The patchset is intended to address https://trac.ffmpeg.org/ticket/9648 . Best, -- Pierre On Mon, Feb 21, 2022 at 2:30 AM Nicolas George wrote: > > p...@sandflow.com (12022-02-20): > >

Re: [FFmpeg-devel] [PATCH] ntdll: Zero-initialize the syscall_frame used for starting threads on ARM/ARM64

2022-03-04 Thread Martin Storsjö
On Fri, 4 Mar 2022, Martin Storsjö wrote: Sorry, I sent this to the entirely wrong mailing list... // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

[FFmpeg-devel] [PATCH] ntdll: Zero-initialize the syscall_frame used for starting threads on ARM/ARM64

2022-03-04 Thread Martin Storsjö
This fixes an inconsistency since fed7e7a78b4bea183d0cbb107953e275f17baa4f (ntdll: Simulate a syscall return when starting a thread); in that commit, on i386 and x86_64, the syscall_frame used for starting the thread was zeroed with a memset, while it wasn't on arm and arm64. This had a noticable

Re: [FFmpeg-devel] HEVC open GOP support in MOV/MP4 (v2)

2022-03-04 Thread Clément Bœsch
On Thu, Feb 24, 2022 at 12:48:58PM +0100, Clément Bœsch wrote: > The main patch is now less intrusive by having the index building > related lists (sample_offsets and open_key_samples) and variable > (min_sample_duration) computed in the same place. This is a better > segmentation between pure

[FFmpeg-devel] [PATCH 1/2] lavu: add syntax for loading AV_OPT_TYPE_BINARY from files

2022-03-04 Thread Niklas Haas
From: Niklas Haas I arbitrarily decided to use the syntax 'opt=@filename' to match e.g. `curl -Ffield=@filename`, and also because @ is not a valid hex character, nor does it conflict with any other common shell or ffmpeg syntax. This is arguably somewhat clunky because it does not round-trip

[FFmpeg-devel] [PATCH 2/2] lavu/tests/opts: add tests for filepath options

2022-03-04 Thread Niklas Haas
From: Niklas Haas Using the venerable HEADER.txt as a small file to load. --- libavutil/tests/opt.c| 38 +- tests/fate/libavutil.mak | 2 +- tests/ref/fate/opt | 4 3 files changed, 42 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2] avfilter: add shader_vulkan filter

2022-03-04 Thread Wu, Jianhua
[PATCH 1/2] avfilter: add shader_vulkan filter [PATCH 2/2] avutil/vulkan: print correct text for shader_vulkan filter Patches attached. 0001-avfilter-add-shader_vulkan-filter.patch Description: 0001-avfilter-add-shader_vulkan-filter.patch

[FFmpeg-devel] [PATCH v2 2/2] avformat/movenc: Simplify creating chapter track extradata

2022-03-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/movenc.c | 79 +++- 1 file changed, 26 insertions(+), 53 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 4c868919ae..2a6cc1bc6a 100644 --- a/libavformat/movenc.c +++

[FFmpeg-devel] [PATCH v2 1/2] fate/mov: Add test for muxing chapters

2022-03-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Resending because I forgot the ref file in v1. Thanks to James for noticing. The input audio stream has a title metadata tag that is written in mov_write_track_udta_tag(); yet somehow the demuxer doesn't pick it up. tests/fate/mov.mak | 6

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: Simplify creating chapter track extradata

2022-03-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/movenc.c | 79 +++- 1 file changed, 26 insertions(+), 53 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 4c868919ae..2a6cc1bc6a 100644 --- a/libavformat/movenc.c +++

[FFmpeg-devel] [PATCH 1/2] fate/mov: Add test for muxing chapters

2022-03-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- The input audio stream has a title metadata tag that is written in mov_write_track_udta_tag(); yet somehow the demuxer doesn't pick it up. tests/fate/mov.mak | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak

Re: [FFmpeg-devel] [PATCH] avfilter/split: switch to activate()

2022-03-04 Thread Nicolas George
Paul B Mahol (12022-03-03): > It is caused by number of sample per frame. > > I tested actually with -f lavfi -i sine only. > > And patch resolves issue. I do not doubt it does. But even without activate, EOF should not depend on the number of samples per frame. There is something wrong going

Re: [FFmpeg-devel] [PATCH v2] configure: Fix detecting/using getauxval

2022-03-04 Thread Martin Storsjö
On Wed, 23 Feb 2022, Martin Storsjö wrote: While trying to detect getauxval, this actually never output HAVE_GETAUXVAL into config.h before. Signed-off-by: Martin Storsjö --- Fixed the alphabetical ordering. --- configure | 1 + 1 file changed, 1 insertion(+) Pushed. // Martin

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-04 Thread James Almer
On 3/3/2022 4:16 PM, Vignesh Venkatasubramanian wrote: Add an AVIF muxer by re-using the existing the mov/mp4 muxer. AVIF Specifiation: https://aomediacodec.github.io/av1-avif Sample usage for still image: ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif Sample usage for animated

[FFmpeg-devel] [PATCH v3 4/4] vaapi_encode_h265: Query encoding block sizes and features

2022-03-04 Thread Fei Wang
From: Mark Thompson Signed-off-by: Fei Wang --- libavcodec/vaapi_encode_h265.c | 112 +++-- 1 file changed, 106 insertions(+), 6 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index cafc860772..b9cf3209b3 100644 ---

[FFmpeg-devel] [PATCH v3 3/4] vaapi_encode_h265: Explicitly set and correct some flags

2022-03-04 Thread Fei Wang
From: Mark Thompson max_14bit_constraint_flag should be set if the bit depth is not greater than 14 (currently always true). one_picture_only_flag should not be set because we don't support the still picture profiles. general_profile_compatibility_flag should be set according to

[FFmpeg-devel] [PATCH v3 2/4] vaapi_encode: Move block size calculation after entrypoint selection

2022-03-04 Thread Fei Wang
From: Mark Thompson The block size can be dependent on the profile and entrypoint selected. It defaults to 16x16, with codecs able to override this choice with their own function. Signed-off-by: Fei Wang --- libavcodec/vaapi_encode.c | 16 libavcodec/vaapi_encode.h

[FFmpeg-devel] [PATCH v3 1/4] lavc/vaapi_encode_h265: Add P frame to GPB frame support for hevc_vaapi

2022-03-04 Thread Fei Wang
From: Linjie Fu Use GPB frames to replace regular P frames if backend driver does not support it. - GPB: Generalized P and B picture. P frames replaced by B frames with forward-predict only, L0 == L1. Normal B frames still have 2 different ref_lists and allow bi-prediction

Re: [FFmpeg-devel] [PATCH v2 1/4] lavc/vaapi_encode_h265: Add P frame to GPB frame support for hevc_vaapi

2022-03-04 Thread Wang, Fei W
On Wed, 2022-02-23 at 13:33 +, Wang, Fei W wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Wang, > > Fei W > > Sent: Tuesday, February 22, 2022 4:49 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] lavc/vaapi_encode_h265: > > Add