Re: [FFmpeg-devel] [PATCH v3] libavutil/hwcontext_qsv: Align width and heigh when download qsv frame

2022-04-12 Thread Xiang, Haihao
On Wed, 2022-04-06 at 18:10 +0800, Wenbin Chen wrote: > The width and height for qsv frame to download need to be > aligned with 16. Add the alignment operation. > Now the following command works: > ffmpeg -hwaccel qsv -f rawvideo -s 1920x1080 -pix_fmt yuv420p -i \ > input.yuv -vf

Re: [FFmpeg-devel] [PATCH] avfilter/alimiter: Add "flush_buffer" option to flush the remaining valid data to the output

2022-04-12 Thread Wang Cao
On Tue, Apr 12, 2022 at 12:40 PM Paul B Mahol wrote: > On Mon, Apr 11, 2022 at 10:59 PM Wang Cao < > wangcao-at-google@ffmpeg.org> > wrote: > > > On Sat, Apr 9, 2022 at 5:35 AM Paul B Mahol wrote: > > > > > On Fri, Apr 8, 2022 at 10:41 PM Wang Cao < > > wangcao-at-google@ffmpeg.org > >

Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support.

2022-04-12 Thread Mark Gaiser
On Wed, Apr 13, 2022 at 1:10 AM James Almer wrote: > > > On 4/12/2022 3:02 PM, Michael Niedermayer wrote: > > On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer wrote: > >> On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote: > >> [...] > >> > >>> +if (stat_ret < 0) {

Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support.

2022-04-12 Thread James Almer
On 4/12/2022 3:02 PM, Michael Niedermayer wrote: On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer wrote: On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote: [...] +if (stat_ret < 0) { +av_log(h, AV_LOG_INFO, "Unable to find IPFS folder. We

Re: [FFmpeg-devel] [RFC] Switching ffmpeg.c to a threaded architecture

2022-04-12 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Paul > B Mahol > Sent: Tuesday, April 12, 2022 11:29 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [RFC] Switching ffmpeg.c to a threaded > architecture > > On Mon, Apr 11,

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vbn(dec|enc): Remove empty close function

2022-04-12 Thread Marton Balint
On Tue, 12 Apr 2022, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavcodec/vbndec.c | 6 -- libavcodec/vbnenc.c | 6 -- 2 files changed, 12 deletions(-) Thanks, all the VBN patches in this series LGTM. Regards, Marton diff --git a/libavcodec/vbndec.c

[FFmpeg-devel] [PATCH v2 2/2] avcodec/libsvtav1: only pass bit rate back to avctx if it'll get used

2022-04-12 Thread Jan Ekström
SVT-AV1 has bit rate based rate control modes as non-zero. This way we can filter out the default value for this value - which is nonzero. --- libavcodec/libsvtav1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index

[FFmpeg-devel] [PATCH v2 1/2] avcodec/libsvtav1: signal CPB properties through side data

2022-04-12 Thread Jan Ekström
This way values such as maxrate/bufsize can be utilized further down the chain. Only sets the average bit rate if the rate control mode is nonzero, which marks bit rate based rate control instead of constant quantizer or CRF. --- libavcodec/libsvtav1.c | 8 1 file changed, 8

Re: [FFmpeg-devel] [PATCH] avfilter/alimiter: Add "flush_buffer" option to flush the remaining valid data to the output

2022-04-12 Thread Paul B Mahol
On Mon, Apr 11, 2022 at 10:59 PM Wang Cao wrote: > On Sat, Apr 9, 2022 at 5:35 AM Paul B Mahol wrote: > > > On Fri, Apr 8, 2022 at 10:41 PM Wang Cao < > wangcao-at-google@ffmpeg.org > > > > > wrote: > > > > > On Fri, Apr 8, 2022 at 11:40 AM Paul B Mahol wrote: > > > > > > > On Thu, Apr 7,

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/mss12: Constify slice context->parent context pointer

2022-04-12 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 5/5] avcodec/mss12: Constify slice context->parent context pointer

2022-04-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mss12.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mss12.h b/libavcodec/mss12.h index 6f68fc3db6..27aa2d56b1 100644 --- a/libavcodec/mss12.h +++ b/libavcodec/mss12.h @@ -68,7 +68,7 @@ typedef struct PixContext {

[FFmpeg-devel] [PATCH 4/5] avcodec/vbnenc: Add AV_CODEC_CAP_DR1

2022-04-12 Thread Andreas Rheinhardt
This encoder uses ff_get_encode_buffer(). Signed-off-by: Andreas Rheinhardt --- libavcodec/vbnenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vbnenc.c b/libavcodec/vbnenc.c index ec04566a32..de35a44d3f 100644 --- a/libavcodec/vbnenc.c +++

[FFmpeg-devel] [PATCH 3/5] avcodec/vbn(dec|enc): Avoid always-false checks

2022-04-12 Thread Andreas Rheinhardt
Do this by switching to bytestream2_(get|put)_le32u() from bytestream2_(get|put)_le32(); it has after all already been checked that the packet contains at least a full header, making all the implicit checks in bytestream2_(get|put)_le32() dead code. Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH 2/5] avcodec/vbn(dec|enc): Avoid leaving stale pointers in context

2022-04-12 Thread Andreas Rheinhardt
Therefore move the (Get|Put)ByteContext from the context to the stack. It is transient anyway. Signed-off-by: Andreas Rheinhardt --- libavcodec/vbndec.c | 11 --- libavcodec/vbnenc.c | 3 +-- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/libavcodec/vbndec.c

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vbn(dec|enc): Remove empty close function

2022-04-12 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/5] avcodec/vbn(dec|enc): Remove empty close function

2022-04-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/vbndec.c | 6 -- libavcodec/vbnenc.c | 6 -- 2 files changed, 12 deletions(-) diff --git a/libavcodec/vbndec.c b/libavcodec/vbndec.c index d6f8121e12..916421925d 100644 --- a/libavcodec/vbndec.c +++ b/libavcodec/vbndec.c @@ -176,11 +176,6

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-04-12 Thread Tristan Matthews
On Tue, Apr 12, 2022 at 2:05 PM Paul B Mahol wrote: > On Tue, Apr 12, 2022 at 7:43 PM Tristan Matthews > wrote: > > > Hi, > > > > On Mon, Apr 11, 2022 at 2:02 PM Paul B Mahol wrote: > > > > > On Sat, Apr 9, 2022 at 9:21 PM Paul B Mahol wrote: > > > > > > > > > > > will apply soon > > > > > >

Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support.

2022-04-12 Thread Mark Gaiser
On Tue, Apr 12, 2022 at 8:03 PM Michael Niedermayer wrote: > On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer wrote: > > On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote: > > [...] > > > > > +if (stat_ret < 0) { > > > > > +av_log(h, AV_LOG_INFO,

Re: [FFmpeg-devel] [PATCH] avfilter: add feedback video filter

2022-04-12 Thread Paul B Mahol
On Tue, Apr 12, 2022 at 7:17 PM Michael Niedermayer wrote: > On Mon, Apr 11, 2022 at 07:24:46PM +0200, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > doc/filters.texi | 38 + > > libavfilter/Makefile | 1 + > > libavfilter/allfilters.c | 1 + > >

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-04-12 Thread Paul B Mahol
On Tue, Apr 12, 2022 at 7:43 PM Tristan Matthews wrote: > Hi, > > On Mon, Apr 11, 2022 at 2:02 PM Paul B Mahol wrote: > > > On Sat, Apr 9, 2022 at 9:21 PM Paul B Mahol wrote: > > > > > > > > will apply soon > > > > > > > > > Forgot to apply, will apply in next 24h. > > > > Am I missing

Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support.

2022-04-12 Thread Michael Niedermayer
On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer wrote: > On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote: > [...] > > > +if (stat_ret < 0) { > > > +av_log(h, AV_LOG_INFO, "Unable to find IPFS folder. We > > tried:\n"); > > +av_log(h,

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-04-12 Thread Tristan Matthews
Hi, On Mon, Apr 11, 2022 at 2:02 PM Paul B Mahol wrote: > On Sat, Apr 9, 2022 at 9:21 PM Paul B Mahol wrote: > > > > > will apply soon > > > > > Forgot to apply, will apply in next 24h. > Am I missing something obvious or is there a default that's maybe not set? Getting: ./ffmpeg_g -loglevel

Re: [FFmpeg-devel] [PATCH] avfilter: add feedback video filter

2022-04-12 Thread Michael Niedermayer
On Mon, Apr 11, 2022 at 07:24:46PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 38 + > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_feedback.c | 312 ++ > 4 files

[FFmpeg-devel] [PATCH v2 2/2] avcodec: add common V4L2 request API code

2022-04-12 Thread xademax
From: Jonas Karlman Co-authored-by: Elie ROUDNINSKI --- configure | 7 + libavcodec/Makefile | 3 +- libavcodec/hwconfig.h | 2 + libavcodec/v4l2_buffers.c | 8 +- libavcodec/v4l2_context.c | 80 ++-- libavcodec/v4l2_context.h | 5 +-

[FFmpeg-devel] [PATCH v2 1/2] avutil/buffer: add av_buffer_pool_flush()

2022-04-12 Thread xademax
From: Jonas Karlman Co-authored-by: Elie ROUDNINSKI --- doc/APIchanges | 3 +++ libavutil/buffer.c | 7 +++ libavutil/buffer.h | 5 + libavutil/version.h | 4 ++-- 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index

[FFmpeg-devel] [PATCH v2 0/2] Add common V4L2 request API code

2022-04-12 Thread xademax
From: Elie ROUDNINSKI This is the second iteration of https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=2898 but only covering the common V4L2 request API code without the support for h264 codec. Changes in v2: * Addressed some styling comments * Removed libudev dependency * Device

Re: [FFmpeg-devel] [PATCH 01/10] avformat/hls: fix repeated requests for media init section

2022-04-12 Thread zhilizhao(赵志立)
> On Apr 12, 2022, at 9:26 PM, zhilizhao(赵志立) wrote: > > > >> On Apr 12, 2022, at 7:45 PM, myp...@gmail.com wrote: >> >> On Tue, Apr 12, 2022 at 4:15 PM Zhao Zhili wrote: >>> >>> --- >>> libavformat/hls.c | 59 --- >>> 1 file changed, 40

Re: [FFmpeg-devel] [PATCH 01/10] avformat/hls: fix repeated requests for media init section

2022-04-12 Thread zhilizhao(赵志立)
> On Apr 12, 2022, at 7:45 PM, myp...@gmail.com wrote: > > On Tue, Apr 12, 2022 at 4:15 PM Zhao Zhili wrote: >> >> --- >> libavformat/hls.c | 59 --- >> 1 file changed, 40 insertions(+), 19 deletions(-) >> > Can these patches handle multiple

Re: [FFmpeg-devel] [PATCH] avutil/mem: fix doc for reallocs

2022-04-12 Thread Michael Niedermayer
On Sat, Apr 02, 2022 at 01:05:37AM +0800, Zhao Zhili wrote: > The doc says those function are like av_free if size or nmemb is > zero. It doesn't match the code. av_realloc() realloc one byte if > size is zero, which was added by 91ff05f6ac5 ten years ago. > realloc() itself in C is

Re: [FFmpeg-devel] [PATCH 01/10] avformat/hls: fix repeated requests for media init section

2022-04-12 Thread myp...@gmail.com
On Tue, Apr 12, 2022 at 4:15 PM Zhao Zhili wrote: > > --- > libavformat/hls.c | 59 --- > 1 file changed, 40 insertions(+), 19 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 83ff4cc607..67c9650e0b 100644 > ---

Re: [FFmpeg-devel] [PATCH] avcodec/openh264: return (DE|EN)CODER_NOT_FOUND if version check fails

2022-04-12 Thread Neal Gompa
On Fri, Feb 18, 2022 at 7:53 AM Andreas Schneider wrote: > > Signed-off-by: Andreas Schneider > --- > libavcodec/libopenh264dec.c | 2 +- > libavcodec/libopenh264enc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libopenh264dec.c

Re: [FFmpeg-devel] [PATCH] doc: install css files along html docs

2022-04-12 Thread Timo Rothenpieler
On 07/04/2022 20:12, Timo Rothenpieler wrote: --- doc/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/Makefile b/doc/Makefile index 58ca3fabd8..0f09783699 100644 --- a/doc/Makefile +++ b/doc/Makefile @@ -27,6 +27,9 @@ HTMLPAGES = $(AVPROGS-yes:%=doc/%.html)

Re: [FFmpeg-devel] [PATCH] avutil/mem: fix doc for reallocs

2022-04-12 Thread zhilizhao(赵志立)
Ping. > On Apr 2, 2022, at 1:05 AM, Zhao Zhili wrote: > > The doc says those function are like av_free if size or nmemb is > zero. It doesn't match the code. av_realloc() realloc one byte if > size is zero, which was added by 91ff05f6ac5 ten years ago. > realloc() itself in C is

Re: [FFmpeg-devel] [RFC] Switching ffmpeg.c to a threaded architecture

2022-04-12 Thread Paul B Mahol
On Mon, Apr 11, 2022 at 10:58 PM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Paul > > B Mahol > > Sent: Monday, April 11, 2022 10:52 PM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [RFC]

Re: [FFmpeg-devel] [PATCH 05/10] avformat/hls: fix leak of variant when dynarray_add fail

2022-04-12 Thread zhilizhao(赵志立)
> On Apr 12, 2022, at 4:42 PM, Steven Liu wrote: > > Zhao Zhili 于2022年4月12日周二 16:16写道: >> >> --- >> libavformat/hls.c | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/hls.c b/libavformat/hls.c >> index d5c3009d07..b5cdf158c6 100644 >> ---

Re: [FFmpeg-devel] [PATCH 05/10] avformat/hls: fix leak of variant when dynarray_add fail

2022-04-12 Thread Steven Liu
Zhao Zhili 于2022年4月12日周二 16:16写道: > > --- > libavformat/hls.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index d5c3009d07..b5cdf158c6 100644 > --- a/libavformat/hls.c > +++ b/libavformat/hls.c > @@ -366,8 +366,16

Re: [FFmpeg-devel] [PATCH RFC] avformat/hls: check IV size inside EXT-X-KEY

2022-04-12 Thread Steven Liu
Zhao Zhili 于2022年4月12日周二 16:28写道: > > IV should always be 128 bits. If the IV attribute was truncated > inside EXT-X-KEY, padding on the left which is the same as when > using sequence number as IV. > --- > I'm not sure which method is better: do padding or just return > AVERROR_INVALIDDATA? > >

[FFmpeg-devel] [PATCH RFC] avformat/hls: check IV size inside EXT-X-KEY

2022-04-12 Thread Zhao Zhili
IV should always be 128 bits. If the IV attribute was truncated inside EXT-X-KEY, padding on the left which is the same as when using sequence number as IV. --- I'm not sure which method is better: do padding or just return AVERROR_INVALIDDATA? libavformat/hls.c | 8 +++- 1 file changed, 7

[FFmpeg-devel] [PATCH] avfilter: add pixelize video filter

2022-04-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 29 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_pixelize.c | 348 ++ 4 files changed, 379 insertions(+) create mode 100644 libavfilter/vf_pixelize.c

[FFmpeg-devel] [PATCH 10/10] avformat/hls: check dynarray_add error when add stream

2022-04-12 Thread Zhao Zhili
--- libavformat/hls.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index c102e36f52..4ab565f8e0 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1882,7 +1882,10 @@ static int update_streams_from_subdemuxer(AVFormatContext

[FFmpeg-devel] [PATCH 09/10] avformat/hls: do error check in add_renditions_to_variant

2022-04-12 Thread Zhao Zhili
--- libavformat/hls.c | 49 +-- 1 file changed, 35 insertions(+), 14 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index b9e2e8a04d..c102e36f52 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1666,9 +1666,10 @@ reload:

[FFmpeg-devel] [PATCH 08/10] avformat/hls: fix leak of segments when dynarray_add fail

2022-04-12 Thread Zhao Zhili
--- libavformat/hls.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 65937120d5..b9e2e8a04d 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1024,7 +1024,12 @@ static int parse_playlist(HLSContext *c, const char

[FFmpeg-devel] [PATCH 07/10] avformat/hls: extract free_segment method

2022-04-12 Thread Zhao Zhili
--- libavformat/hls.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3ed6007d0d..65937120d5 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -225,13 +225,18 @@ typedef struct HLSContext { HLSCryptoContext

[FFmpeg-devel] [PATCH 05/10] avformat/hls: fix leak of variant when dynarray_add fail

2022-04-12 Thread Zhao Zhili
--- libavformat/hls.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index d5c3009d07..b5cdf158c6 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -366,8 +366,16 @@ static struct variant *new_variant(HLSContext *c,

[FFmpeg-devel] [PATCH 06/10] avformat/hls: fix leak of rendition when dynarray_add fail

2022-04-12 Thread Zhao Zhili
--- libavformat/hls.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index b5cdf158c6..3ed6007d0d 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -556,7 +556,10 @@ static struct rendition

[FFmpeg-devel] [PATCH 04/10] avformat/hls: fix leak of playlist when dynarray_add fail

2022-04-12 Thread Zhao Zhili
--- libavformat/hls.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index ecb6237d2e..d5c3009d07 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -330,7 +330,10 @@ static struct playlist *new_playlist(HLSContext *c, const

[FFmpeg-devel] [PATCH 02/10] avformat/hls: fix leak of init section when dynarray_add fail

2022-04-12 Thread Zhao Zhili
When av_dynarray_add failed, pls->init_sections will be freed, which leads to leak of all entries of pls->init_sections. --- libavformat/hls.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 67c9650e0b..e249810bce 100644 ---

[FFmpeg-devel] [PATCH 03/10] avformat/hls: extract free_playlist method

2022-04-12 Thread Zhao Zhili
--- libavformat/hls.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index e249810bce..ecb6237d2e 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -253,30 +253,35 @@ static void

[FFmpeg-devel] [PATCH 01/10] avformat/hls: fix repeated requests for media init section

2022-04-12 Thread Zhao Zhili
--- libavformat/hls.c | 59 --- 1 file changed, 40 insertions(+), 19 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 83ff4cc607..67c9650e0b 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -407,48 +407,65 @@ struct