Re: [FFmpeg-devel] [PATCH v7 2/3] avformat/os_support: Support long file names on Windows

2022-05-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of nil- > admir...@mailo.com > Sent: Wednesday, May 25, 2022 9:17 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v7 2/3] avformat/os_support: Support > long file names on Windows > > > No, it is intended and

[FFmpeg-devel] [PATCH] avcodec/vp9: ipred_hd_16x16_16 avx2 implementation

2022-05-25 Thread FacelessLake
From: Semen Belozerov --- libavcodec/x86/vp9dsp_init_16bpp.c| 2 + libavcodec/x86/vp9intrapred_16bpp.asm | 54 +++ 2 files changed, 56 insertions(+) diff --git a/libavcodec/x86/vp9dsp_init_16bpp.c b/libavcodec/x86/vp9dsp_init_16bpp.c index b17826326f..e5afea1512

[FFmpeg-devel] [PATCH] qsv: check for libmfx.pc instead of mfx.pc

2022-05-25 Thread Haihao Xiang
This fixed the regression caused by commit 478e1a98a Reported-by: Timo Rothenpieler Signed-off-by: Haihao Xiang --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 6cf7d89674..5a167613a4 100755 --- a/configure +++ b/configure @@ -6565,7

[FFmpeg-devel] [PATCH] avcodec/pcm-dvdenc: Mark unreachable defaults

2022-05-25 Thread Michael Niedermayer
Helps: CID1441929 Helps: CID1441931 Signed-off-by: Michael Niedermayer --- libavcodec/pcm-dvdenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/pcm-dvdenc.c b/libavcodec/pcm-dvdenc.c index f18855cfa7..6bab1e0aaa 100644 --- a/libavcodec/pcm-dvdenc.c +++

Re: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx

2022-05-25 Thread Xiang, Haihao
On Wed, 2022-05-25 at 12:22 -0400, Leo Izen wrote: > > On 5/25/22 12:05, Timo Rothenpieler wrote: > > > > > > On 22/05/2022 14:19, Haihao Xiang wrote: > > > libmfx 1.28 was released 3 years ago, it is easy to get a greater > > > version than 1.28. We may remove lots of compile-time checks if

Re: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx

2022-05-25 Thread Xiang, Haihao
On Wed, 2022-05-25 at 18:05 +0200, Timo Rothenpieler wrote: > > On 22/05/2022 14:19, Haihao Xiang wrote: > > libmfx 1.28 was released 3 years ago, it is easy to get a greater > > version than 1.28. We may remove lots of compile-time checks if adding > > the requirement for the minimal version in

Re: [FFmpeg-devel] [PATCH v4] libx264: Set min build version to 158

2022-05-25 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, May 25, 2022 at 11:05:39AM +, Matt Oliver wrote: >> From: Matt Oliver >> >> Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" >> >> Setting X264_API_IMPORTS only affects msvc builds and it breaks >> linking to static builds (although is required for

[FFmpeg-devel] [PATCH] avcodec/remove_extradata_bsf: add a list of supported codec ids

2022-05-25 Thread James Almer
There's no point allowing the use of this filter for codecs where it will silently do nothing. Signed-off-by: James Almer --- libavcodec/remove_extradata_bsf.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/libavcodec/remove_extradata_bsf.c

[FFmpeg-devel] [PATCH] fate/ffmpeg: Fix test requirements

2022-05-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/Makefile| 1 + tests/fate/ffmpeg.mak | 122 +- 2 files changed, 49 insertions(+), 74 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index 5677364471..035bdf783e 100644 --- a/tests/Makefile

[FFmpeg-devel] [PATCH v2] mfenc: Use dlopen instead of LoadLibrary for loading mfplat.dll

2022-05-25 Thread Martin Storsjö
The dlopen wrapper contains code to make loading libraries safer, to avoid loading a potentially malicious DLL with the same name. Signed-off-by: Martin Storsjö --- v2: Use dlsym too, for consistency. --- libavcodec/mfenc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] mfenc: Use dlopen instead of LoadLibrary for loading mfplat.dll

2022-05-25 Thread Martin Storsjö
On Wed, 25 May 2022, Timo Rothenpieler wrote: On 25/05/2022 23:35, Martin Storsjö wrote: The dlopen wrapper contains code to make loading libraries safer, to avoid loading a potentially malicious DLL with the same name. Signed-off-by: Martin Storsjö --- libavcodec/mfenc.c | 5 +++-- 1

Re: [FFmpeg-devel] [PATCH] mfenc: Use dlopen instead of LoadLibrary for loading mfplat.dll

2022-05-25 Thread Timo Rothenpieler
On 25/05/2022 23:35, Martin Storsjö wrote: The dlopen wrapper contains code to make loading libraries safer, to avoid loading a potentially malicious DLL with the same name. Signed-off-by: Martin Storsjö --- libavcodec/mfenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[FFmpeg-devel] [PATCH] mfenc: Use dlopen instead of LoadLibrary for loading mfplat.dll

2022-05-25 Thread Martin Storsjö
The dlopen wrapper contains code to make loading libraries safer, to avoid loading a potentially malicious DLL with the same name. Signed-off-by: Martin Storsjö --- libavcodec/mfenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/mfenc.c

Re: [FFmpeg-devel] [PATCH v6] avcodec/mfenc: Dynamically load MFPlat.DLL

2022-05-25 Thread Martin Storsjö
On Wed, 25 May 2022, Timo Rothenpieler wrote: On 25/05/2022 22:51, Martin Storsjö wrote: On Wed, 25 May 2022, Trystan Mata wrote: Changes since the v5:  - Library handle and function pointer are back in MFContext.    - MFTEnumEx has been move to it too.  - dlopen and dlclose are preferred.

Re: [FFmpeg-devel] [PATCH v6] avcodec/mfenc: Dynamically load MFPlat.DLL

2022-05-25 Thread Timo Rothenpieler
On 25/05/2022 22:51, Martin Storsjö wrote: On Wed, 25 May 2022, Trystan Mata wrote: Changes since the v5:  - Library handle and function pointer are back in MFContext.    - MFTEnumEx has been move to it too.  - dlopen and dlclose are preferred. This will avoid multiple look up on one context.

Re: [FFmpeg-devel] [PATCH v6] avcodec/mfenc: Dynamically load MFPlat.DLL

2022-05-25 Thread Martin Storsjö
On Wed, 25 May 2022, Trystan Mata wrote: Changes since the v5: - Library handle and function pointer are back in MFContext. - MFTEnumEx has been move to it too. - dlopen and dlclose are preferred. This will avoid multiple look up on one context. And each context will have his own library

Re: [FFmpeg-devel] [PATCH v7 2/3] avformat/os_support: Support long file names on Windows

2022-05-25 Thread nil-admirari
> No, it is intended and expected that the structs are different. > ... > That's why the structs are different and the fields of > win32_stat always large enough, no matter which struct > is being used internally. Please document that there is a potential difference in time types and that the

Re: [FFmpeg-devel] [PATCH v7 2/3] avformat/os_support: Support long file names on Windows

2022-05-25 Thread Martin Storsjö
On Wed, 25 May 2022, nil-admir...@mailo.com wrote: + struct win32_stat + { + _dev_t st_dev; /* ID of device containing file */ + _ino_t st_ino; /* inode number */ + unsigned short st_mode; /* protection */ + short st_nlink; /* number of hard links */ + short st_uid; /* user ID of owner */ +

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2022-05-25 Thread Tomas Härdin
tis 2022-05-24 klockan 15:36 +0200 skrev Paul B Mahol: > > +    c->current_q = av_malloc_array((avctx->width + 31) / 32, > sizeof(*c->current_q)); > +    if (!c->current_q) > +    return AVERROR(ENOMEM); You can exploit BINK_MAX_WIDTH and BINK_MAX_HEIGHT to make the size of these arrays

[FFmpeg-devel] [PATCH] avutil/avframe: fix channel layout checks in av_frame_copy()

2022-05-25 Thread James Almer
Normally, both the source and dest frame would have only the old API fields set, only the new API fields set, or both set. But in some cases, like when calling av_frame_ref() using a non reference counted source frame where only the old channel layout API fields were populated, the result would be

[FFmpeg-devel] [PATCH] configure: fix libmfx detection with mfx_dispatch

2022-05-25 Thread Leo Izen
libmfx detection changed from libmfx.pc to mfx.pc in commit 478e1a98a289bbc777bddc02fdcefeaa3c416a63 but it is not installed by mfx_dispatch, which breaks builds that use this library. This patch also fixes the fallback linking to -lmfx instead of -llibmfx (which is incorrect). --- configure | 4

Re: [FFmpeg-devel] [PATCH v2] avcodec/libaomenc: Add unmet target level warning

2022-05-25 Thread Bohan Li
Thanks for the reply, James! This is indeed not the intended behaviour, but it is due to libaom not initializing all the indices correctly. I've submitted a patch for review in libaom that fixes this, and after that patch the levels are only logged when a target level is given with this ffmpeg

Re: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx

2022-05-25 Thread Leo Izen
On 5/25/22 12:05, Timo Rothenpieler wrote: On 22/05/2022 14:19, Haihao Xiang wrote: libmfx 1.28 was released 3 years ago, it is easy to get a greater version than 1.28. We may remove lots of compile-time checks if adding the requirement for the minimal version in the configure script. ---  

[FFmpeg-devel] [PATCH v2] avformat/jpegxl_probe: fix incorrect cw_mask and extensions probing

2022-05-25 Thread Leo Izen
- Fix incorrectly skipping over the upX_weights if the cw_mask is present and it is not a multiple of 4. - Fix not skipping over the extensions payload if an extension is present. --- libavformat/jpegxl_probe.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx

2022-05-25 Thread Timo Rothenpieler
On 22/05/2022 14:19, Haihao Xiang wrote: libmfx 1.28 was released 3 years ago, it is easy to get a greater version than 1.28. We may remove lots of compile-time checks if adding the requirement for the minimal version in the configure script. --- configure | 7 +-

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc1_loopfilter: Factor duplicate code in vc1_b_h_intfi_loop_filter()

2022-05-25 Thread Michael Niedermayer
On Tue, May 24, 2022 at 08:50:51PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1435168 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vc1_loopfilter.c | 5 + > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH v7 2/3] avformat/os_support: Support long file names on Windows

2022-05-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of nil- > admir...@mailo.com > Sent: Wednesday, May 25, 2022 4:48 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v7 2/3] avformat/os_support: Support > long file names on Windows > > > + struct win32_stat > > +

Re: [FFmpeg-devel] [PATCH v7 2/3] avformat/os_support: Support long file names on Windows

2022-05-25 Thread nil-admirari
> + struct win32_stat > + { > + _dev_t st_dev; /* ID of device containing file */ > + _ino_t st_ino; /* inode number */ > + unsigned short st_mode; /* protection */ > + short st_nlink; /* number of hard links */ > + short st_uid; /* user ID of owner */ > + short st_gid; /* group ID of owner */ > +

[FFmpeg-devel] [PATCH v6 1/1] avutil/csp: create public API for colorspace structs

2022-05-25 Thread Leo Izen
This commit moves some of the functionality from avfilter/colorspace into avutil/csp and exposes it as a public API so it can be used by libavcodec and/or libavformat. It also converts those structs from double values to AVRational to make regression testing easier and more consistent. ---

[FFmpeg-devel] [PATCH v6 0/1] avutil/csp: create public API for colorspace structs

2022-05-25 Thread Leo Izen
Changes in v6: - Reordered avutil/csp.h functions to be in alphabetical order, as requested by Lynne on IRC (which also matches the order they occur in csp.c) - Clarified that RGB->YUV matrix works for similar ones too e.g. YCoCg Changes in v5: - Unmark as [WIP], ready for review and merging -

[FFmpeg-devel] [PATCH v2] libavcodec/qsvenc: Add min/max QP control options for I/P/B frame

2022-05-25 Thread Wenbin Chen
From: Yue Heng To do more accurate QP control, add min/max QP control on I/P/B frame separately to qsv encoder. qmax and qmin still work but newly-added options have higher priority. Signed-off-by: Yue Heng Signed-off-by: Wenbin Chen --- doc/encoders.texi| 36

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Add min/max QP control options for I/P/B frame

2022-05-25 Thread Chen, Wenbin
> On Fri, 2022-05-06 at 10:19 +0800, Wenbin Chen wrote: > > From: Yue Heng > > > > To do more accurate QP control, add min/max QP control on I/P/B frame > > separately to qsv encoder. qmax and qmin still work but newly-added > > options have higher priority. > > > > Signed-off-by: Yue Heng > >

[FFmpeg-devel] [PATCH v4] libx264: Set min build version to 158

2022-05-25 Thread Matt Oliver
From: Matt Oliver Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since build 158

[FFmpeg-devel] [PATCH v6] avcodec/mfenc: Dynamically load MFPlat.DLL

2022-05-25 Thread Trystan Mata
Changes since the v5: - Library handle and function pointer are back in MFContext. - MFTEnumEx has been move to it too. - dlopen and dlclose are preferred. This will avoid multiple look up on one context. And each context will have his own library handle. Also, sorry for the e-mail

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: hevc_sao reschedule slightly

2022-05-25 Thread Martin Storsjö
On Wed, 25 May 2022, J. Dekker wrote: Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_sao_neon.S | 30 +++ 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_sao_neon.S b/libavcodec/aarch64/hevcdsp_sao_neon.S index

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: add hevc horizontal qpel/uni/bi

2022-05-25 Thread Martin Storsjö
On Tue, 24 May 2022, J. Dekker wrote: libavcodec/aarch64/Makefile | 1 + libavcodec/aarch64/hevcdsp_init_aarch64.c | 43 +- libavcodec/aarch64/hevcdsp_qpel_neon.S| 520 ++ 3 files changed, 563 insertions(+), 1 deletion(-) create mode 100644

Re: [FFmpeg-devel] [PATCH v3] libx264: Set min build version to 158

2022-05-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, May 25, 2022 11:39 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v3] libx264: Set min build version to > 158 > > Matt Oliver: > > From: Matt Oliver > > > > Was

[FFmpeg-devel] [GASPP] [PATCH] Ignore trailing whitespace in .ifc directives

2022-05-25 Thread Martin Storsjö
This fixes handling of cases like ".ifc \foo, bar // comment", where there was trailing whitespace after the condition (before the comment which already was stripped out at this point). --- Will apply after a couple days. This fixes the "lavc/aarch64: add hevc horizontal qpel/uni/bi" patch when

Re: [FFmpeg-devel] [PATCH v3] libx264: Set min build version to 158

2022-05-25 Thread Andreas Rheinhardt
Matt Oliver: > From: Matt Oliver > > Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" > > Setting X264_API_IMPORTS only affects msvc builds and it breaks > linking to static builds (although is required for shared builds). > This flag is set by x264 in its pkgconfig as required

[FFmpeg-devel] [PATCH v3] libx264: Set min build version to 158

2022-05-25 Thread Matt Oliver
From: Matt Oliver Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since build 158

[FFmpeg-devel] [PATCH v2] libx264: Set min build version to 158

2022-05-25 Thread softworkz
From: softworkz Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since build 158

[FFmpeg-devel] [PATCH] lavc/aarch64: hevc_sao reschedule slightly

2022-05-25 Thread J. Dekker
Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_sao_neon.S | 30 +++ 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_sao_neon.S b/libavcodec/aarch64/hevcdsp_sao_neon.S index efd8112af4..39056d76ee 100644 ---

Re: [FFmpeg-devel] [PATCH v2 2/2] swscale/aarch64: add hscale specializations

2022-05-25 Thread Martin Storsjö
On Wed, 25 May 2022, Martin Storsjö wrote: On Wed, 25 May 2022, Swinney, Jonathan wrote: This patch adds code to support specializations of the hscale function and adds a specialization for filterSize == 4. ff_hscale8to15_4_neon is a complete rewrite. Since the main bottleneck here is

Re: [FFmpeg-devel] [PATCH v2 2/2] swscale/aarch64: add hscale specializations

2022-05-25 Thread Martin Storsjö
On Wed, 25 May 2022, Swinney, Jonathan wrote: This patch adds code to support specializations of the hscale function and adds a specialization for filterSize == 4. ff_hscale8to15_4_neon is a complete rewrite. Since the main bottleneck here is loading the data from src, this data is loaded a

Re: [FFmpeg-devel] [PATCH v2 2/2] swscale/aarch64: add hscale specializations

2022-05-25 Thread Martin Storsjö
On Wed, 25 May 2022, Swinney, Jonathan wrote: This patch adds code to support specializations of the hscale function and adds a specialization for filterSize == 4. ff_hscale8to15_4_neon is a complete rewrite. Since the main bottleneck here is loading the data from src, this data is loaded a

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_vpp_qsv: set outlink to EOF correctly

2022-05-25 Thread Xiang, Haihao
On Thu, 2022-05-12 at 09:18 +0800, Fei Wang wrote: > 1. Return error if filter frame fail before set outlink to EOF in none > pass through mode. > 2. Set outlink to EOF before return success in pass through mode. > > Fix endless cmd: > > ffmpeg -hwaccel qsv -qsv_device /dev/dri/renderD128 >

Re: [FFmpeg-devel] [PATCH v2 1/2] checkasm: added additional dstW tests for hscale

2022-05-25 Thread Martin Storsjö
On Wed, 25 May 2022, Swinney, Jonathan wrote: Signed-off-by: Jonathan Swinney --- tests/checkasm/sw_scale.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c index

Re: [FFmpeg-devel] [PATCH] Update ReadMe.md for PR submission and reference Developer Documentation

2022-05-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Paul B > Mahol > Sent: Wednesday, May 25, 2022 9:30 AM > To: FFmpeg development discussions and patches > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH] Update ReadMe.md for PR submission and > reference Developer

Re: [FFmpeg-devel] [PATCH v2 0/2] checkasm: added additional dstW tests for hscale

2022-05-25 Thread Martin Storsjö
On Wed, 25 May 2022, Swinney, Jonathan wrote: This is a resubmission of changes to the hscale function for aarch64. I added a test as a separate patch so that it would be easier to get consistent before and after performance data. After Martin already submitted the improvement to the final

[FFmpeg-devel] [PATCH] checkasm: Silence warnings about unused return value from read()

2022-05-25 Thread Martin Storsjö
This codepath is enabled by default on arm, if the linux perf API is available, unless disabled with --disable-linux-perf. --- tests/checkasm/checkasm.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h index

Re: [FFmpeg-devel] [PATCH] checkasm: improve hevc_sao test

2022-05-25 Thread Martin Storsjö
On Wed, 25 May 2022, J. Dekker wrote: On 24 May 2022, at 22:27, Martin Storsjö wrote: On Tue, 17 May 2022, J. Dekker wrote: The HEVC decoder can call these functions with smaller widths than the functions themselves are designed to operate on so we should only check the relevant output

Re: [FFmpeg-devel] [PATCH v7 0/3] Support long file names on Windows

2022-05-25 Thread Martin Storsjö
On Tue, 24 May 2022, ffmpegagent wrote: This patchset adds support for long file and directory paths on Windows. The implementation follows the same logic that .NET is using internally, with the only exception that it doesn't expand short path components in 8.3 format. .NET does this as the

Re: [FFmpeg-devel] [PATCH] Update ReadMe.md for PR submission and reference Developer Documentation

2022-05-25 Thread Paul B Mahol
On Wed, May 25, 2022 at 2:24 AM Soft Works wrote: > > > > -Original Message- > > From: softworkz > > Sent: Thursday, February 3, 2022 10:28 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: softworkz ; softworkz > > Subject: [PATCH] Update ReadMe.md for PR submission and reference > >

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Add min/max QP control options for I/P/B frame

2022-05-25 Thread Xiang, Haihao
On Fri, 2022-05-06 at 10:19 +0800, Wenbin Chen wrote: > From: Yue Heng > > To do more accurate QP control, add min/max QP control on I/P/B frame > separately to qsv encoder. qmax and qmin still work but newly-added > options have higher priority. > > Signed-off-by: Yue Heng > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] checkasm: improve hevc_sao test

2022-05-25 Thread J. Dekker
On 24 May 2022, at 22:27, Martin Storsjö wrote: > On Tue, 17 May 2022, J. Dekker wrote: > >> The HEVC decoder can call these functions with smaller widths than the >> functions themselves are designed to operate on so we should only check >> the relevant output >> >> Signed-off-by: J. Dekker

Re: [FFmpeg-devel] [PATCH v6 2/2] avformat/os_support: Support long file names on Windows

2022-05-25 Thread Martin Storsjö
On Tue, 24 May 2022, Soft Works wrote: -Original Message- From: Martin Storsjö Sent: Tuesday, May 24, 2022 10:59 PM To: softworkz Cc: ffmpeg-devel@ffmpeg.org; Soft Works ; Hendrik Leppkes Subject: Re: [PATCH v6 2/2] avformat/os_support: Support long file names on Windows +

Re: [FFmpeg-devel] [PATCH v5] avcodec/mfenc: Dynamically load MFPlat.DLL

2022-05-25 Thread Trystan Mata
Firstly, thank you for your review. > You shouldn't use win32_dlopen directly (there's no preexisting code that > does that). If you want to use the helpers from w32dlfcn.h, call dlopen > and dlclose, which then redirect to those functions. But here I don't see > any need to use that wrapper

[FFmpeg-devel] [PATCH v5] avcodec/mfenc: Dynamically load MFPlat.DLL

2022-05-25 Thread Trystan Mata
Firstly, thank you for your review. > You shouldn't use win32_dlopen directly (there's no preexisting code that > does that). If you want to use the helpers from w32dlfcn.h, call dlopen > and dlclose, which then redirect to those functions. But here I don't see > any need to use that