[FFmpeg-devel] [PATCH 20/20] avcodec/snowdec: Remove debug code

The Snow decoder checks two bits of AVCodecContext.debug via numerical constants, not defines. One of these constants (512) used to be equivalent to FF_DEBUG_PTS which has been removed in 302554835e39b79b977ed60c9afe81b44590dfef (merged in 6e69525e6984d51165de0b17b796bbc29f9dd6e7). It is unlikely

[FFmpeg-devel] [PATCH 19/20] avcodec/snow: Reindent after previous commit

Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/snow.c b/libavcodec/snow.c index 52ab39bfd4..ca43550f20 100644 --- a/libavcodec/snow.c +++ b/libavcodec/snow.c @@ -539,12 +539,12 @@ int ff_snow_comm

[FFmpeg-devel] [PATCH 18/20] avcodec/snow: Only allocate x_coeffs for decoder

Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.c| 17 +++-- libavcodec/snowdec.c | 9 + 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/libavcodec/snow.c b/libavcodec/snow.c index dcd6d67ad5..52ab39bfd4 100644 --- a/libavcodec/snow.c +++ b/libavcod

[FFmpeg-devel] [PATCH 17/20] avcodec/snow: Remove outdated assert

It comes from a time before frames were refcounted; it has indeed been added in a follow-up commit to c13e490dce1a66d79e1f053d8a38fb9b2eb53267: "codec_release_buffer: fix handling of non user buffers". This type of check is obsolete now. Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.c |

[FFmpeg-devel] [PATCH 16/20] avcodec/snow: Move allocating encoder-only buffers to snowenc.c

Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.c| 23 +-- libavcodec/snowenc.c | 16 +++- 2 files changed, 24 insertions(+), 15 deletions(-) diff --git a/libavcodec/snow.c b/libavcodec/snow.c index 7fb1660dd6..7e93005492 100644 --- a/libavcodec/snow.c +

[FFmpeg-devel] [PATCH 15/20] avcodec/snowdec: Don't zero encoder-only buffer

Maybe zeroing spatial_idwt_buffer was intended? Signed-off-by: Andreas Rheinhardt --- libavcodec/snowdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/snowdec.c b/libavcodec/snowdec.c index 96221b9802..17c7ccaf2c 100644 --- a/libavcodec/snowdec.c +++ b/libavcodec/snowdec.c @@ -

[FFmpeg-devel] [PATCH 14/20] avcodec/snow: Only allocate mconly_picture for the decoder

And use its presence to check whether buffers should be allocated for it in ff_snow_common_init_after_header(). Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.c| 18 +- libavcodec/snowdec.c | 15 ++- 2 files changed, 23 insertions(+), 10 deletions(-) diff

[FFmpeg-devel] [PATCH 13/20] avcodec/snow: Move freeing encoder-only buffers to snowenc.c

Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.c| 8 libavcodec/snowenc.c | 12 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/libavcodec/snow.c b/libavcodec/snow.c index 4a6c781a95..f55b3310ac 100644 --- a/libavcodec/snow.c +++ b/libavcodec/snow

[FFmpeg-devel] [PATCH 12/20] avcodec/snow: Move initializing HpelDSPContext to snowenc.c

Only used by the encoder. Signed-off-by: Andreas Rheinhardt --- configure| 2 +- libavcodec/snow.c| 1 - libavcodec/snowenc.c | 2 ++ 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index f3fd91f592..bccbf1bdbf 100755 --- a/configure +++ b/con

[FFmpeg-devel] [PATCH 11/20] avcodec/snow: Move decoder/encoder-only inline funcs to snow(dec|enc).c

Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.h| 219 --- libavcodec/snowdec.c | 147 + libavcodec/snowenc.c | 64 + 3 files changed, 211 insertions(+), 219 deletions(-) diff --git a/libavcodec/snow.h b/

[FFmpeg-devel] [PATCH 10/20] avcodec/snow: Move initializing QpelDSPContext to snowenc.c

Only used by the encoder. Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.c| 25 - libavcodec/snowenc.c | 26 ++ 2 files changed, 26 insertions(+), 25 deletions(-) diff --git a/libavcodec/snow.c b/libavcodec/snow.c index cde09902c3..c9bc

[FFmpeg-devel] [PATCH 09/20] avcodec/snow: Move initializing MotionEstContext to snowenc.c

Only used by the encoder. Signed-off-by: Andreas Rheinhardt --- configure| 2 +- libavcodec/snow.c| 2 -- libavcodec/snowenc.c | 2 ++ 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index b16a46cab8..f3fd91f592 100755 --- a/configure +++ b/co

Re: [FFmpeg-devel] [PATCH] checkasm: RISC-V 64-bit assembler test harness

Oct 6, 2022, 21:15 by r...@remlab.net: > --- > tests/checkasm/Makefile | 1 + > tests/checkasm/checkasm.h | 10 ++ > tests/checkasm/riscv/checkasm.S | 178 > 3 files changed, 189 insertions(+) > create mode 100644 tests/checkasm/riscv/checkasm.S

Re: [FFmpeg-devel] [PATCH 1/9] checkasm/vc1dsp: Use declare_func_emms only when needed

Andreas Rheinhardt: > There is no MMX code for vc1_inv_trans_8x8 or > vc1_unescape_buffer, so use declare_func instead of > declare_func_emms() to also test that we are not in MMX > mode after return. > > Signed-off-by: Andreas Rheinhardt > --- > tests/checkasm/vc1dsp.c | 4 ++-- > 1 file change

[FFmpeg-devel] [PATCH] avcoved/librav1e: support setting sample aspect ratio

Signed-off-by: James Almer --- libavcodec/librav1e.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c index 0601efed2c..5f552cd891 100644 --- a/libavcodec/librav1e.c +++ b/libavcodec/librav1e.c @@ -298,6 +298,11 @@ static av_cold int librav1e_

[FFmpeg-devel] [PATCH] aarch64: Implement stack spilling in a consistent way.

From: Reimar Döffinger Currently it is done in several different ways, which might cause needless dependencies or in case of tx_float_neon.S is incorrect. Signed-off-by: Reimar Döffinger --- libavcodec/aarch64/fft_neon.S | 3 +- libavcodec/aarch64/h264idct_neon.S | 6 +- libavco

[FFmpeg-devel] [PATCH 7/8] configure: Remove unnecessary wmavoice->mdct dependency

Signed-off-by: Andreas Rheinhardt --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 636141ae1e..ad960452d0 100755 --- a/configure +++ b/configure @@ -3000,7 +3000,7 @@ wmav1_decoder_select="mdct sinewin wma_freqs" wmav1_encoder_select="

[FFmpeg-devel] [PATCH 8/8] configure: Add (dnxhd|snow)_encoder->videodsp dependency

These encoders currently rely on an implicit dependency via mpegvideo. Signed-off-by: Andreas Rheinhardt --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index ad960452d0..b16a46cab8 100755 --- a/configure +++ b/configure @@ -2811,7 +281

[FFmpeg-devel] [PATCH 6/8] configure: Remove unnecessary qdm2_decoder->mdct dependency

Signed-off-by: Andreas Rheinhardt --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 0d166de7a2..636141ae1e 100755 --- a/configure +++ b/configure @@ -2929,7 +2929,7 @@ prores_encoder_select="fdctdsp" prores_aw_encoder_select="fdctdsp"

[FFmpeg-devel] [PATCH 4/8] configure: Remove unnecessary me_cmp dependencies

Signed-off-by: Andreas Rheinhardt --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 406ac996b7..689a6111c5 100755 --- a/configure +++ b/configure @@ -2749,7 +2749,7 @@ intrax8_select="blockdsp wmv2dsp" iso_media_select="mpeg4audio" mdc

[FFmpeg-devel] [PATCH 5/8] configure: Remove unnecessary binkaudio dependencies

The binkaudio decoders don't need mdct or sinewin at all; and binkaudio_dct doesn't need rdft directly (but nevertheless uses it indirectly via dct). Signed-off-by: Andreas Rheinhardt --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure inde

[FFmpeg-devel] [PATCH 3/8] configure: Add mpegvideoenc->fdctdsp dependency

Currently masked by an unnecessary me_cmp->fdctdsp dependency. Signed-off-by: Andreas Rheinhardt --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index c983c689ec..406ac996b7 100755 --- a/configure +++ b/configure @@ -2755,7 +2755,7 @@ mpega

[FFmpeg-devel] [PATCH 2/8] configure: Add missing prores_(aw|ks)_encoder->fdctdsp dependencies

Fixes builds with --disable-everything --disable-faan. Signed-off-by: Andreas Rheinhardt --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 2c4f5043d5..c983c689ec 100755 --- a/configure +++ b/configure @@ -2926,6 +2926,8 @@ png_decoder_select="inflate

[FFmpeg-devel] [PATCH 1/8] configure: Remove dependencies of inexistant rtjpeg decoder

rtjpeg is a mode of nuv and not a decoder in its own right. Signed-off-by: Andreas Rheinhardt --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index ab6ff27249..2c4f5043d5 100755 --- a/configure +++ b/configure @@ -2934,7 +2934,6 @@ ralf_decoder_select="golo

Re: [FFmpeg-devel] [PATCH 1/2] avutil/pixfmt.h: add native-endian RGB32F and RGBA32F formats

On Sun, Oct 02, 2022 at 03:58:34AM -0400, Leo Izen wrote: > Add an AV_PIX_FMT_NE macro for RGB32FBE/RGB32FLE and also one for > RGBA32FBE/RGBA32FLE for packed 32-bit float RGB samples, and also > packed 32-bit float RGBA samples, respectively. > > Signed-off-by: Leo Izen > --- > libavutil/pixfmt

Re: [FFmpeg-devel] [PATCH] tx_float_neon: Do not access outside stack.

Le sunnuntaina 9. lokakuuta 2022, 19.36.24 EEST Reimar Döffinger a écrit : > > While this fixes the ABI violation, it introduces multiple data > > dependencies on stack pointer due to write-back. > > That is true in principle, this is not done consistently at all. I have not checked the FFmpeg co

Re: [FFmpeg-devel] [PATCH] tx_float_neon: Do not access outside stack.

> On 9 Oct 2022, at 16:11, Rémi Denis-Courmont wrote: > > Le sunnuntaina 9. lokakuuta 2022, 16.14.47 EEST Reimar Döffinger a écrit : >> Use load/store instructions that modify sp to save >> registers to stack, like it is done for all other >> functions. >> At least valgrind complains about the

Re: [FFmpeg-devel] [PATCH v2] avutil/attributes_internal: Add visibility pragma

Andreas Rheinhardt: > GCC 4.0 not only added a visibility attribute, but also > a pragma to set it for a whole region of code.* > This commit exposes this via macros. > > *: See https://gcc.gnu.org/gcc-4.0/changes.html > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/attributes_internal.

Re: [FFmpeg-devel] [PATCH] tx_float_neon: Do not access outside stack.

Le sunnuntaina 9. lokakuuta 2022, 16.14.47 EEST Reimar Döffinger a écrit : > Use load/store instructions that modify sp to save > registers to stack, like it is done for all other > functions. > At least valgrind complains about the current code. > --- > libavutil/aarch64/tx_float_neon.S | 16

[FFmpeg-devel] [PATCH] tx_float_neon: Do not access outside stack.

Use load/store instructions that modify sp to save registers to stack, like it is done for all other functions. At least valgrind complains about the current code. --- libavutil/aarch64/tx_float_neon.S | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavutil/a

Re: [FFmpeg-devel] [PATCH 0/2] RGB(A)32F in libjxl

On 10/2/22 03:58, Leo Izen wrote: FFmpeg has supported these pixel formats since 7bb0afc245d093b0 and libjxl supports receiving/sending these pixel formats so it makes sense to add support to the libjxl wrapper for these formats. Bumping for review. - Leo Izen ___