Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-18 Thread Anton Khirnov
Quoting James Almer (2023-01-18 22:23:43) > On 1/18/2023 4:28 PM, Anton Khirnov wrote: > > Quoting James Almer (2023-01-16 14:38:14) > >> It's been a while since the last bump, so it's time to do some cleaning and > >> remove deprecated APIs. This will also give us an "Open ABI season" in > >>

Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-01-18 Thread Prakash
The problem with int milliseconds is you lose the microseconds precision. Sometimes there are multiple log lines within the same millisecond. I can definitely move the timestamp as the first field of the log line. Let me fix the patch file. -Prakash. On Wed, Jan 18, 2023 at 12:51 AM Tobias Rapp

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-18 Thread James Almer
On 1/18/2023 4:28 PM, Anton Khirnov wrote: Quoting James Almer (2023-01-16 14:38:14) It's been a while since the last bump, so it's time to do some cleaning and remove deprecated APIs. This will also give us an "Open ABI season" in which we can do breaking changes (like changing public struct

Re: [FFmpeg-devel] [PATCH 3/2] cbs_av1: Remove constraint on MDCV luminance values

2023-01-18 Thread James Almer
On 1/18/2023 5:35 PM, Mark Thompson wrote: While desiring min to be less than max feels entirely sensible, unfortunately the standard does not actually have this requirement. Huh, it really doesn't. --- Some of the Argon coverage streams test this.  libavcodec/cbs_av1_syntax_template.c | 7

[FFmpeg-devel] [PATCH 3/2] cbs_av1: Remove constraint on MDCV luminance values

2023-01-18 Thread Mark Thompson
While desiring min to be less than max feels entirely sensible, unfortunately the standard does not actually have this requirement. --- Some of the Argon coverage streams test this. libavcodec/cbs_av1_syntax_template.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-18 Thread Anton Khirnov
Quoting James Almer (2023-01-16 14:38:14) > It's been a while since the last bump, so it's time to do some cleaning and > remove deprecated APIs. This will also give us an "Open ABI season" in which > we > can do breaking changes (like changing public struct offsets, public enum > values, adding

[FFmpeg-devel] [PATCH] avformat/assenc: fix incorrect copy of null terminator

2023-01-18 Thread Tim Angus
When writing a subtitle SSA/ASS subtitle file, the AVCodecParameters::extradata buffer is written directly to the output, potentially including a null terminating character, which is sometimes present. The result is the output having a null character in the middle; this is addressed here by

[FFmpeg-devel] [PATCH 0/1] Handle ASS format subtitle encoding ambiguity

2023-01-18 Thread Tim Angus
Some matroska files embed ASS format subtitles. The header for said subtitles include the header for the subtitle stream in the "codec private data" section. It appears to be optional whether or not the last byte of this data is 0, i.e. a null terminator for the string data. Using ffmpeg to

Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support

2023-01-18 Thread Jerome Martinez
On 18/01/2023 11:12, Tomas Härdin wrote: mån 2023-01-16 klockan 15:17 +0100 skrev Jerome Martinez: [...] I think it may be relevant to keep the exact same code for the exact same purpose. Would be no more relevant if version and micro_version can be taken from FFV1Context. Perhaps we can have

[FFmpeg-devel] [PATCH] avcodec/libjxldec: fix gamma22 and gamma28 recognization

2023-01-18 Thread Leo Izen
Gamma 2.2 and Gamma 2.8 are tagged in the file as 0.45455 and 0.35714, respectively (i.e. 1/2.2 and 1/2.8). Trying to identify them as 2.2 and 2.8 instead of these values will cause the transfer function to not properly be recognized. This patch fixes this. --- libavcodec/libjxldec.c | 4 ++-- 1

Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support

2023-01-18 Thread Jerome Martinez
On 18/01/2023 14:40, Tomas Härdin wrote: Creating a new subthread because I just noticed something I am a bit lost there because the line of code below is not part of this FFV1 patch. Additionally, none on my patches (FFV1 of MXF stored/sampled/displayed fix) modifies the discussed behavior

Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support

2023-01-18 Thread Tomas Härdin
Creating a new subthread because I just noticed something > +//Stored height > mxf_write_local_tag(s, 4, 0x3202); > avio_wb32(pb, stored_height>>sc->interlaced); > Won't this be incorrect for files whose dimensions are multiples of 16 but not multiples of 32? Isn't each field

Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support

2023-01-18 Thread Tomas Härdin
mån 2023-01-16 klockan 15:17 +0100 skrev Jerome Martinez: > On 16/01/2023 15:00, Tomas Härdin wrote: > > > > > +    ff_build_rac_states(, 0.05 * (1LL << 32), 256 - 8); > > (1LL << 32) / 20 ? > > Could be, I don't really care, but this line is copied from ffv1dec.c Yeah I figured as much

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-18 Thread Tomas Härdin
mån 2023-01-16 klockan 15:28 +0100 skrev Jerome Martinez: > On 16/01/2023 14:50, Tomas Härdin wrote: > > lör 2023-01-14 klockan 16:48 +0100 skrev Jerome Martinez: > > > Before the patch: > > > - stored values were rounded to upper 16 multiple also for > > > formats > > > not > > > using

Re: [FFmpeg-devel] [PATCH] lavu/video_enc_params: Avoid relying on an undefined C construct

2023-01-18 Thread Anton Khirnov
Quoting Martin Storsjö (2023-01-15 23:47:41) > The construct of using offsetof on a (potentially anonymous) struct > defined within the offsetof expression, while supported by all > current compilers, has been declared explicitly undefined by the > C standards committee [1]. > > Current Clang git

Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-01-18 Thread Tobias Rapp
On 17/01/2023 22:52, Prakash wrote: libavutil/log: Support for logging timestamps in the log. Add 'time' flag to the -loglevel option to turn on timestamp logging. Useful for troubleshooting where time is spent from the log files. Signed-off-by: Prakash Duggaraju The commit message seems to