Re: [FFmpeg-devel] [PATCH v3 3/5] avformat/hls: relay programs to child muxers

2023-02-17 Thread Gyan Doshi
On 2023-02-18 03:31 am, Marton Balint wrote: On Fri, 17 Feb 2023, Gyan Doshi wrote: --- libavformat/hlsenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index e1f96feda3..cf2b36da01 100644 --- a/libavformat/hlsenc.c +++

[FFmpeg-devel] [PATCH v4 5/5] avformat/tee: relay programs to child muxers

2023-02-17 Thread Gyan Doshi
--- libavformat/tee.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/tee.c b/libavformat/tee.c index cb555f52fd..e81f9ba706 100644 --- a/libavformat/tee.c +++ b/libavformat/tee.c @@ -295,6 +295,14 @@ FF_ENABLE_DEPRECATION_WARNINGS } } +for (i = 0; i <

[FFmpeg-devel] [PATCH v4 4/5] avformat/segment: relay programs to child muxers

2023-02-17 Thread Gyan Doshi
--- libavformat/segment.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 2a82f39f31..d7f3fb5deb 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -186,6 +186,14 @@ FF_ENABLE_DEPRECATION_WARNINGS } } +

[FFmpeg-devel] [PATCH v4 3/5] avformat/hls: relay programs to child muxers

2023-02-17 Thread Gyan Doshi
--- libavformat/hlsenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index e1f96feda3..74db447085 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -911,6 +911,14 @@ FF_ENABLE_DEPRECATION_WARNINGS st->id =

[FFmpeg-devel] [PATCH v4 2/5] avformat: add av_program_copy()

2023-02-17 Thread Gyan Doshi
Helper to transfer programs from one muxing context to another. --- doc/APIchanges | 3 ++ libavformat/avformat.c | 66 ++ libavformat/avformat.h | 22 ++ libavformat/version.h | 3 +- 4 files changed, 93 insertions(+), 1 deletion(-)

[FFmpeg-devel] [PATCH v4 1/5] avformat: add av_program_add_stream_index2()

2023-02-17 Thread Gyan Doshi
av_program_add_stream_index() added in 526efa10534 may fail to carry out its purpose but the lack of a return value stops callers from catching any error. Fixed in new function. --- As suggested by Andreas in https://ffmpeg.org/pipermail/ffmpeg-devel/2023-February/306645.html doc/APIchanges

[FFmpeg-devel] [PATCH v2 4/4] avcodec/version: bump minor version to accommodate spatial audio detection

2023-02-17 Thread Marth64
Signed-off-by: Marth64 --- doc/APIchanges | 6 ++ libavcodec/version.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 29161e30bf..35ff906662 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,6 +2,12 @@ The last version

[FFmpeg-devel] [PATCH v2 3/4] avcodec/dca_xll: add detection of DTS:X and DTS:X IMAX

2023-02-17 Thread Marth64
Signed-off-by: Marth64 --- libavcodec/avcodec.h | 15 +-- libavcodec/dca_syncwords.h | 3 +++ libavcodec/dca_xll.c | 26 +- libavcodec/dca_xll.h | 3 +++ libavcodec/profiles.c | 14 -- 5 files changed, 48 insertions(+), 13

[FFmpeg-devel] [PATCH v2 2/4] avcodec/mlpdec: add detection of Atmos spatial extension profile in TrueHD

2023-02-17 Thread Marth64
Signed-off-by: Marth64 --- libavcodec/avcodec.h| 2 ++ libavcodec/codec_desc.c | 1 + libavcodec/mlpdec.c | 11 +++ libavcodec/profiles.c | 5 + libavcodec/profiles.h | 1 + 5 files changed, 20 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h

[FFmpeg-devel] [PATCH v2 1/4] avcodec/eac3dec: add detection of Atmos spatial extension profile

2023-02-17 Thread Marth64
Signed-off-by: Marth64 --- libavcodec/ac3dec.c | 3 +++ libavcodec/ac3dec.h | 1 + libavcodec/avcodec.h| 2 ++ libavcodec/codec_desc.c | 1 + libavcodec/eac3dec.c| 11 ++- libavcodec/profiles.c | 5 + libavcodec/profiles.h | 1 + 7 files changed, 23

Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct

2023-02-17 Thread Hendrik Leppkes
On Fri, Feb 17, 2023 at 7:45 PM Lynne wrote: > > Feb 17, 2023, 18:08 by jamr...@gmail.com: > > > On 2/17/2023 1:54 PM, Lynne wrote: > > > >> This reverts commit 26cb36f35746fe6ef53688b119852bfa6d555f62. > >> > >> All filters and all codecs (except wmavoice) have been ported for the > >> lavu/tx

[FFmpeg-devel] trac updating bits

2023-02-17 Thread Michael Niedermayer
Hi It appears that a bunch of static files for our trac where missed during previous updates. I re-deployed them so we should have the latest files now (this is css / js stuff mostly) I didnt notice any change in looks, but if something broke today then this is where to look first i kept the

Re: [FFmpeg-devel] Trac votes and priority

2023-02-17 Thread Michael Niedermayer
On Fri, Feb 17, 2023 at 11:29:04PM +0100, Michael Niedermayer wrote: > Hi > > On Fri, Feb 17, 2023 at 12:25:07PM -0600, Brad Isbell wrote: > > I think that if Trac ticket priority is to be used, it should first be > > working. Currently, if you try to vote on a ticket, a `500 Internal > > Server

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-17 Thread Marth64
Yes will take care of it, np On Fri, Feb 17, 2023 at 4:42 PM James Almer wrote: > On 2/17/2023 4:46 PM, Marth64 wrote: > > Signed-off-by: Marth64 > > --- > > Update doc/APIchanges and update libavcodec minor version > > > > doc/APIchanges | 4 > > libavcodec/ac3dec.c

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-17 Thread James Almer
On 2/17/2023 4:46 PM, Marth64 wrote: Signed-off-by: Marth64 --- Update doc/APIchanges and update libavcodec minor version doc/APIchanges | 4 libavcodec/ac3dec.c| 4 libavcodec/ac3dec.h| 1 + libavcodec/avcodec.h | 18 --

Re: [FFmpeg-devel] Trac votes and priority

2023-02-17 Thread Michael Niedermayer
Hi On Fri, Feb 17, 2023 at 12:25:07PM -0600, Brad Isbell wrote: > I think that if Trac ticket priority is to be used, it should first be > working. Currently, if you try to vote on a ticket, a `500 Internal > Server Error` occurs in the background. it seemed to work when i tryied but it seems

Re: [FFmpeg-devel] [PATCH v3 3/5] avformat/hls: relay programs to child muxers

2023-02-17 Thread Marton Balint
On Fri, 17 Feb 2023, Gyan Doshi wrote: --- libavformat/hlsenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index e1f96feda3..cf2b36da01 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -911,6 +911,14 @@

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/af_pan: use the new swr used channel layout option

2023-02-17 Thread Paul B Mahol
set LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 3/3] avfilter/af_pan: use the new swr used channel layout option

2023-02-17 Thread James Almer
Fixes ticket #10180 Signed-off-by: James Almer --- libavfilter/af_pan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c index 067f646805..4672648d46 100644 --- a/libavfilter/af_pan.c +++ b/libavfilter/af_pan.c @@ -313,7 +313,7 @@

[FFmpeg-devel] [PATCH 2/3] swresample/swresample: add a used channel layout option using the new API

2023-02-17 Thread James Almer
Replaces the "used channel count" option, which is now deprecated. Signed-off-by: James Almer --- doc/resampler.texi | 4 +-- libswresample/options.c | 6 ++-- libswresample/rematrix.c| 2 +- libswresample/swresample.c | 56

[FFmpeg-devel] [PATCH 1/3] doc/resampler.texi: add missing swr channel layout options

2023-02-17 Thread James Almer
Signed-off-by: James Almer --- doc/resampler.texi | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/doc/resampler.texi b/doc/resampler.texi index 5ed3f4377a..d55654e7bc 100644 --- a/doc/resampler.texi +++ b/doc/resampler.texi @@ -11,16 +11,6 @@ programmatic use.

[FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-17 Thread Marth64
Signed-off-by: Marth64 --- Update doc/APIchanges and update libavcodec minor version doc/APIchanges | 4 libavcodec/ac3dec.c| 4 libavcodec/ac3dec.h| 1 + libavcodec/avcodec.h | 18 -- libavcodec/codec_desc.c| 2 ++

Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-02-17 Thread Prakash
Logging timestamps is a basic functionality any logging framework/infrastructure should support. If I am using ffmpeg as a binary then I would need this functionality built in. Agree that the code in log.c can definitely be simplified but didn't want to make any changes with potential for breaking

Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct

2023-02-17 Thread Lynne
Feb 17, 2023, 18:08 by jamr...@gmail.com: > On 2/17/2023 1:54 PM, Lynne wrote: > >> This reverts commit 26cb36f35746fe6ef53688b119852bfa6d555f62. >> >> All filters and all codecs (except wmavoice) have been ported for the >> lavu/tx API. >> >> The noise should be minimal. >> > > It isn't. I'm

Re: [FFmpeg-devel] Trac votes and priority

2023-02-17 Thread Andreas Rheinhardt
Michael Niedermayer: > Hi > > Trac allows users to vote for tickets, should we bump tickets priority > to important once they surpass some threshold of votes ? > Should there be a difference betweem defects and enhancements ? > We are a project of volunteers, not a company where your boss can

Re: [FFmpeg-devel] Trac votes and priority

2023-02-17 Thread Brad Isbell
I think that if Trac ticket priority is to be used, it should first be working. Currently, if you try to vote on a ticket, a `500 Internal Server Error` occurs in the background. I don't think that popularity of a ticket always indicates priority or urgency. Security bugs are a good example...

Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct

2023-02-17 Thread James Almer
On 2/17/2023 1:54 PM, Lynne wrote: This reverts commit 26cb36f35746fe6ef53688b119852bfa6d555f62. All filters and all codecs (except wmavoice) have been ported for the lavu/tx API. The noise should be minimal. It isn't. I'm getting more than two thousand lines of warnings after applying this

[FFmpeg-devel] [PATCH v3 5/5] avformat/tee: relay programs to child muxers

2023-02-17 Thread Gyan Doshi
--- libavformat/tee.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/tee.c b/libavformat/tee.c index cb555f52fd..a917cb0244 100644 --- a/libavformat/tee.c +++ b/libavformat/tee.c @@ -295,6 +295,14 @@ FF_ENABLE_DEPRECATION_WARNINGS } } +for (i = 0; i <

[FFmpeg-devel] [PATCH v3 4/5] avformat/segment: relay programs to child muxers

2023-02-17 Thread Gyan Doshi
--- libavformat/segment.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 2a82f39f31..5017fb628d 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -186,6 +186,14 @@ FF_ENABLE_DEPRECATION_WARNINGS } } +

[FFmpeg-devel] [PATCH v3 3/5] avformat/hls: relay programs to child muxers

2023-02-17 Thread Gyan Doshi
--- libavformat/hlsenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index e1f96feda3..cf2b36da01 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -911,6 +911,14 @@ FF_ENABLE_DEPRECATION_WARNINGS st->id =

[FFmpeg-devel] [PATCH v3 2/5] avformat: add av_program_copy()

2023-02-17 Thread Gyan Doshi
Helper to transfer programs from one muxing context to another. --- doc/APIchanges | 3 ++ libavformat/avformat.c | 66 ++ libavformat/avformat.h | 22 ++ libavformat/version.h | 3 +- 4 files changed, 93 insertions(+), 1 deletion(-)

[FFmpeg-devel] [PATCH v3 1/5] avformat: add av_program_add_stream_index2()

2023-02-17 Thread Gyan Doshi
av_program_add_stream_index() added in 526efa10534 may fail to carry out its purpose but the lack of a return value stops callers from catching any error. Fixed in new function. --- As suggested by Andreas in https://ffmpeg.org/pipermail/ffmpeg-devel/2023-February/306645.html doc/APIchanges

[FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct

2023-02-17 Thread Lynne
This reverts commit 26cb36f35746fe6ef53688b119852bfa6d555f62. All filters and all codecs (except wmavoice) have been ported for the lavu/tx API. The noise should be minimal. Patch attached. >From 5459ae39a729c69939de65392373d4f9cdf47246 Mon Sep 17 00:00:00 2001 From: Lynne Date: Fri, 17 Feb

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-17 Thread Lynne
Feb 17, 2023, 16:45 by mich...@niedermayer.cc: > On Fri, Feb 17, 2023 at 12:52:21PM +0100, Lynne wrote: > >> Feb 17, 2023, 12:05 by kier...@obe.tv: >> >> > On Fri, 17 Feb 2023 at 09:09, Jean-Baptiste Kempf >> > wrote: >> > >> >> Hello, >> >> >> >> On Fri, 17 Feb 2023, at 04:43, Lynne wrote: >>

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-17 Thread Michael Niedermayer
On Fri, Feb 17, 2023 at 12:52:21PM +0100, Lynne wrote: > Feb 17, 2023, 12:05 by kier...@obe.tv: > > > On Fri, 17 Feb 2023 at 09:09, Jean-Baptiste Kempf wrote: > > > >> Hello, > >> > >> On Fri, 17 Feb 2023, at 04:43, Lynne wrote: > >> > This small patchset mostly rewrites Vulkan to enable using

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-17 Thread Marth64
I can do the doc update, just not sure how to do the version. Is there an example? (Or is this not something I can do). Thank you! On Fri, Feb 17, 2023 at 04:59 Anton Khirnov wrote: > Quoting Marth64 (2023-02-12 01:31:41) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > > index

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-17 Thread Lynne
Feb 17, 2023, 12:05 by kier...@obe.tv: > On Fri, 17 Feb 2023 at 09:09, Jean-Baptiste Kempf wrote: > >> Hello, >> >> On Fri, 17 Feb 2023, at 04:43, Lynne wrote: >> > This small patchset mostly rewrites Vulkan to enable using multiplane >> images, >> >> This is not small. We're talking about

Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-02-17 Thread Lynne
Feb 17, 2023, 12:08 by an...@khirnov.net: > Quoting Prakash (2023-02-17 01:16:04) > >> Moved the timestamp to the front (before loglevel but after the prefix if >> present, so the timestamp has the same color as log line based on log >> level). Updated the patch and attached again. >> >> >> From

Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-02-17 Thread Anton Khirnov
Quoting Prakash (2023-02-17 01:16:04) > Moved the timestamp to the front (before loglevel but after the prefix if > present, so the timestamp has the same color as log line based on log > level). Updated the patch and attached again. > > > From 04857a7bf0d4cf24a479e795a55a61ab2e2f618e Mon Sep

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-17 Thread Kieran Kunhya
On Fri, 17 Feb 2023 at 09:09, Jean-Baptiste Kempf wrote: > Hello, > > On Fri, 17 Feb 2023, at 04:43, Lynne wrote: > > This small patchset mostly rewrites Vulkan to enable using multiplane > images, > > This is not small. We're talking about thousands of lines of code; > > And this changes

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-17 Thread Anton Khirnov
Quoting Marth64 (2023-02-12 01:31:41) > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 755e543fac..2d3a7a4625 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -1616,12 +1616,18 @@ typedef struct AVCodecContext { > #define FF_PROFILE_DNXHR_HQX 4 >

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-17 Thread Lynne
Feb 17, 2023, 10:45 by h.lepp...@gmail.com: > On Fri, Feb 17, 2023 at 10:09 AM Jean-Baptiste Kempf > wrote: > >> >> Hello, >> >> On Fri, 17 Feb 2023, at 04:43, Lynne wrote: >> > This small patchset mostly rewrites Vulkan to enable using multiplane >> > images, >> >> This is not small. We're

Re: [FFmpeg-devel] [PATCH 4/6] avformat/wavdec: s337m support

2023-02-17 Thread Nicolas Gaullier
>> +#if CONFIG_S337M_DEMUXER >> +    {"non_pcm_mode", "Chooses what to do with s337m", >> OFFSET(non_pcm_mode), AV_OPT_TYPE_INT, {.i64 = 1}, 0, 1, DEC, >> "non_pcm_mode"}, >> +    {"copy"    , "Pass s337m through unchanged", 0, >> AV_OPT_TYPE_CONST, {.i64 = 0}, 0, 1, DEC, "non_pcm_mode"}, >>

Re: [FFmpeg-devel] [PATCH 3/6] avformat/s337m: New ff_s337m_probe()

2023-02-17 Thread Nicolas Gaullier
> The logic here is a bit hairy and I don't have time atm to digest it, but is > it entirely contained in S337m or would one need to read other specs too? > >/Tomas ff_s337m_probe is very similar to s337m_probe: what mainly differs is the input parameters. The one little thing I added is the

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-17 Thread Hendrik Leppkes
On Fri, Feb 17, 2023 at 10:09 AM Jean-Baptiste Kempf wrote: > > Hello, > > On Fri, 17 Feb 2023, at 04:43, Lynne wrote: > > This small patchset mostly rewrites Vulkan to enable using multiplane > > images, > > This is not small. We're talking about thousands of lines of code; > > And this changes

Re: [FFmpeg-devel] [PATCH 2/6] avformat/s337m: Consider container bit resolution

2023-02-17 Thread Nicolas Gaullier
>> @@ -56,6 +56,12 @@ static int s337m_get_offset_and_codec(void *avc, >> avpriv_report_missing_feature(avc, "Data type %#x in >> SMPTE 337M", data_type & 0x1F); >> return AVERROR_PATCHWELCOME; >> } >> +    if (container_word_bits && >> +    !(container_word_bits ==

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-17 Thread Jean-Baptiste Kempf
Hello, On Fri, 17 Feb 2023, at 04:43, Lynne wrote: > This small patchset mostly rewrites Vulkan to enable using multiplane images, This is not small. We're talking about thousands of lines of code; And this changes numerous h264 and hevc headers, and adds callback to the make AVHWAccel. And