Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-22 Thread Kieran Kunhya
FFmpeg is not the place for SDR. SDR is as large and complex as the entirety of multimedia. What next, is FFmpeg going to implement TCP in userspace, Wifi, Ethernet, an entire 4G and 5G stack? All without any separation of layers (the problem you currently have)? Kieran

Re: [FFmpeg-devel] [PATCH] libaformat: fix incorrect handling of incomplete AVBPrint.

2023-06-22 Thread James Almer
On 6/22/2023 6:04 PM, reimar.doeffin...@gmx.de wrote: diff --git a/libavformat/realtextdec.c b/libavformat/realtextdec.c index c281dec346..9f6aab789e 100644 --- a/libavformat/realtextdec.c +++ b/libavformat/realtextdec.c @@ -80,6 +80,11 @@ static int realtext_read_header(AVFormatContext *s)

Re: [FFmpeg-devel] [PATCH] avutil/softfloat: Basic documentation for av_sincos_sf()

2023-06-22 Thread Michael Niedermayer
On Tue, Jun 20, 2023 at 01:39:50AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/softfloat.h | 4 > 1 file changed, 4 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully

Re: [FFmpeg-devel] [PATCH 3/3] avutil/softfloat: fix av_sincos_sf()

2023-06-22 Thread Michael Niedermayer
On Tue, Jun 20, 2023 at 01:04:24AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/softfloat.h | 2 +- > libavutil/tests/softfloat.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) will apply [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust threshold for speex

2023-06-22 Thread Michael Niedermayer
On Tue, Jun 20, 2023 at 01:04:23AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 59731/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SPEEX_fuzzer-4809436670328832 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/utils: fix 2 integer overflows in get_audio_frame_duration()

2023-06-22 Thread Michael Niedermayer
On Sun, Jun 18, 2023 at 11:50:17PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 256 * 668003712 cannot be represented in type > 'int' > Fixes: > 59819/clusterfuzz-testcase-minimized-ffmpeg_dem_MATROSKA_fuzzer-4674636538052608 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH 7/7] avcodec/evc_ps: use unsigned types in structs where corresponds

2023-06-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/evc_ps.c | 70 +-- libavcodec/evc_ps.h | 277 ++-- 2 files changed, 171 insertions(+), 176 deletions(-) diff --git a/libavcodec/evc_ps.c b/libavcodec/evc_ps.c index 156f76554a..cd699d6ad5 100644 ---

[FFmpeg-devel] [PATCH 6/7] avcodec/evc_parse: use unsigned types in structs where corresponds

2023-06-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/evc_parse.h | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/libavcodec/evc_parse.h b/libavcodec/evc_parse.h index 0f142976f5..9554622fee 100644 --- a/libavcodec/evc_parse.h +++

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: check the return value of avio_close_dyn_buf()

2023-06-22 Thread Michael Niedermayer
On Tue, Jun 20, 2023 at 05:26:58PM -0300, James Almer wrote: > Fixes ticket #10424. > > Signed-off-by: James Almer > --- > libavformat/id3v2.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-22 Thread Michael Niedermayer
On Thu, Jun 22, 2023 at 01:42:39PM -0300, James Almer wrote: > On 6/22/2023 1:26 PM, Michael Niedermayer wrote: > > On Thu, Jun 22, 2023 at 12:10:06PM -0300, James Almer wrote: > > > On 6/22/2023 12:05 PM, Michael Niedermayer wrote: > > > > On Thu, Jun 22, 2023 at 10:55:44AM -0300, James Almer

[FFmpeg-devel] [PATCH] libaformat: fix incorrect handling of incomplete AVBPrint.

2023-06-22 Thread Reimar . Doeffinger
From: Reimar Döffinger Change some internal APIs a bit to make it harder to make such mistakes. In particular, have the read chunk functions return an error when the result is incomplete. This might be less flexible, but since there has been no use-case for that so far, avoiding coding mistakes

[FFmpeg-devel] [PATCH v3] avformat: add Software Defined Radio support

2023-06-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- configure|4 + doc/demuxers.texi| 71 ++ libavdevice/Makefile |2 + libavdevice/alldevices.c |2 + libavdevice/sdrdemux.c | 1849 ++ 5 files changed, 1928 insertions(+) create

[FFmpeg-devel] [PATCH 5/5] avformat/evc: remove duplicate defines

2023-06-22 Thread James Almer
Signed-off-by: James Almer --- libavformat/evc.c | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/evc.c b/libavformat/evc.c index 1803069a7d..6e638c4c90 100644 --- a/libavformat/evc.c +++ b/libavformat/evc.c @@ -28,10 +28,6 @@ #include "evc.h" #include "avio_internal.h" -//

[FFmpeg-devel] [PATCH 4/5] avformat/evc: add range checks to evcc_parse_sps and return proper error codes

2023-06-22 Thread James Almer
Signed-off-by: James Almer --- libavformat/evc.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavformat/evc.c b/libavformat/evc.c index 9d0fe8d84c..1803069a7d 100644 --- a/libavformat/evc.c +++ b/libavformat/evc.c @@ -88,17 +88,19 @@ static int

[FFmpeg-devel] [PATCH 3/5] avformat/evc: remove duplicate check

2023-06-22 Thread James Almer
Signed-off-by: James Almer --- libavformat/evc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/evc.c b/libavformat/evc.c index 1c72b141bd..9d0fe8d84c 100644 --- a/libavformat/evc.c +++ b/libavformat/evc.c @@ -226,9 +226,6 @@ static int evcc_write(AVIOContext *pb,

[FFmpeg-devel] [PATCH 2/5] avformat/evc: remove unnecessary struct

2023-06-22 Thread James Almer
And don't use get_ue_golomb_long() for known small values. Signed-off-by: James Almer --- libavformat/evc.c | 67 ++- 1 file changed, 14 insertions(+), 53 deletions(-) diff --git a/libavformat/evc.c b/libavformat/evc.c index f6e53aa6cf..1c72b141bd

[FFmpeg-devel] [PATCH 1/5] avcodec/evc_frame_merge: ensure the assembled buffer fits in an AVPacket

2023-06-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/evc_frame_merge_bsf.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavcodec/evc_frame_merge_bsf.c b/libavcodec/evc_frame_merge_bsf.c index 121f93c0b0..3e1258c6c9 100644 --- a/libavcodec/evc_frame_merge_bsf.c +++

Re: [FFmpeg-devel] [RFC] SDR

2023-06-22 Thread Michael Niedermayer
On Thu, Jun 22, 2023 at 07:43:11PM +0200, Michael Niedermayer wrote: > On Thu, Jun 22, 2023 at 06:09:47PM +0200, Anton Khirnov wrote: [...] > > 3) sdr_read_header() and sdr_read_packet() are giant, hideous, and > > unreadable. > > I disagree that they are hideous and unreadable. In fact its

Re: [FFmpeg-devel] [RFC] SDR

2023-06-22 Thread Michael Niedermayer
On Thu, Jun 22, 2023 at 06:09:47PM +0200, Anton Khirnov wrote: > Hi, > I'm sorry to say, the patch at its current state is quite far from > something I'd consider acceptable for git master. > > 1) Given that there are sdr and sdrfile demuxers, it seems to me that > the transport layer should be

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/evc_frame_merge: properly support packets with more than one NALU

2023-06-22 Thread James Almer
On 6/21/2023 1:59 PM, James Almer wrote: Parse through all NALUs in a packet, pull new ones when a complete AU could not be assembled, or keep them around if an AU was assembled while data remained in them. Signed-off-by: James Almer --- libavcodec/evc_frame_merge_bsf.c | 110

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-22 Thread Carotti, Elias
On Thu, 2023-06-22 at 10:44 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Quoting Carotti, Elias (2023-06-21 17:53:09) > > + > > +  

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-22 Thread James Almer
On 6/22/2023 1:26 PM, Michael Niedermayer wrote: On Thu, Jun 22, 2023 at 12:10:06PM -0300, James Almer wrote: On 6/22/2023 12:05 PM, Michael Niedermayer wrote: On Thu, Jun 22, 2023 at 10:55:44AM -0300, James Almer wrote: On 6/22/2023 10:43 AM, Michael Niedermayer wrote: On Mon, Jun 19, 2023

Re: [FFmpeg-devel] [PATCH] vulkan_decode: use the hwfc->user_opaque field to store the profile

2023-06-22 Thread Lynne
Jun 18, 2023, 14:20 by d...@lynne.ee: > Patch attached. > Pushed, alongside the 3 other memleak-fixing patches. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-22 Thread Michael Niedermayer
On Thu, Jun 22, 2023 at 12:10:06PM -0300, James Almer wrote: > On 6/22/2023 12:05 PM, Michael Niedermayer wrote: > > On Thu, Jun 22, 2023 at 10:55:44AM -0300, James Almer wrote: > > > On 6/22/2023 10:43 AM, Michael Niedermayer wrote: > > > > On Mon, Jun 19, 2023 at 12:28:05AM +0200, Michael

Re: [FFmpeg-devel] [PATCH] vulkan/av1: fix tile upload offsets.

2023-06-22 Thread Lynne
Jun 21, 2023, 01:51 by airl...@gmail.com: > From: Dave Airlie > > This fixes decoding av1-1-b8-22-svc-L2T1.ivf > while not breaking other videos. > --- > libavcodec/vulkan_av1.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vulkan_av1.c

Re: [FFmpeg-devel] [RFC] SDR

2023-06-22 Thread Anton Khirnov
Hi, I'm sorry to say, the patch at its current state is quite far from something I'd consider acceptable for git master. 1) Given that there are sdr and sdrfile demuxers, it seems to me that the transport layer should be split into a protocol rather than be inside the demuxer 2) Threading inside

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-22 Thread James Almer
On 6/22/2023 12:05 PM, Michael Niedermayer wrote: On Thu, Jun 22, 2023 at 10:55:44AM -0300, James Almer wrote: On 6/22/2023 10:43 AM, Michael Niedermayer wrote: On Mon, Jun 19, 2023 at 12:28:05AM +0200, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- configure

Re: [FFmpeg-devel] [RFC] SDR

2023-06-22 Thread Thilo Borgmann
Am 22.06.23 um 17:01 schrieb James Almer: On 6/22/2023 11:57 AM, Michael Niedermayer wrote: Hi all My humble opinion(s) and plan(s) about SDR FFmpeg as a multimedia framework should support SDR. The only practical way to support SDR in FFmpeg ATM is through a demuxer (or equivalent) Not

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-22 Thread Michael Niedermayer
On Thu, Jun 22, 2023 at 10:55:44AM -0300, James Almer wrote: > On 6/22/2023 10:43 AM, Michael Niedermayer wrote: > > On Mon, Jun 19, 2023 at 12:28:05AM +0200, Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > > --- > > > configure|4 + > > >

Re: [FFmpeg-devel] [RFC] SDR

2023-06-22 Thread James Almer
On 6/22/2023 11:57 AM, Michael Niedermayer wrote: Hi all My humble opinion(s) and plan(s) about SDR FFmpeg as a multimedia framework should support SDR. The only practical way to support SDR in FFmpeg ATM is through a demuxer (or equivalent) Not everyone is happy about a SDR demuxer. The

[FFmpeg-devel] [RFC] SDR

2023-06-22 Thread Michael Niedermayer
Hi all My humble opinion(s) and plan(s) about SDR FFmpeg as a multimedia framework should support SDR. The only practical way to support SDR in FFmpeg ATM is through a demuxer (or equivalent) Not everyone is happy about a SDR demuxer. The "active" code could be in the demuxer itself or an

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/jpegxl_parser: add JPEG XL parser

2023-06-22 Thread James Almer
On 6/21/2023 9:43 PM, Leo Izen wrote: +static int jpegxl_parse(AVCodecParserContext *s, AVCodecContext *avctx, +const uint8_t **poutbuf, int *poutbuf_size, +const uint8_t *buf, int buf_size) +{ +JXLParseContext *ctx = s->priv_data; +int

Re: [FFmpeg-devel] [PATCH] libavformat/mpegts.c: fix hardcoded 5-bytes skip for metadata streams.

2023-06-22 Thread Romain Beauxis
Le mer. 21 juin 2023 à 03:32, Anton Khirnov a écrit : > > Quoting to...@rastageeks.org (2023-06-20 07:09:33) > > From: Romain Beauxis > > > > Before the introduction of AV_CODEC_ID_TIMED_ID3 for timed_id3 metadata streams > > in mpegts (commit 4a4437c0fbc8f7afe0c533070395a42e56b4ee75),

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-22 Thread James Almer
On 6/22/2023 10:43 AM, Michael Niedermayer wrote: On Mon, Jun 19, 2023 at 12:28:05AM +0200, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- configure|4 + doc/demuxers.texi| 71 ++ libavformat/Makefile |2 + libavformat/allformats.c

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-22 Thread Michael Niedermayer
On Mon, Jun 19, 2023 at 12:28:05AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > configure|4 + > doc/demuxers.texi| 71 ++ > libavformat/Makefile |2 + > libavformat/allformats.c |2 + > libavformat/sdrdemux.c | 1739

Re: [FFmpeg-devel] [PATCH v2 4/4] decklink_enc: add support for SMPTE 2038 VANC packet output

2023-06-22 Thread Devin Heitmueller
On Tue, Jun 6, 2023 at 2:56 PM Devin Heitmueller wrote: > You indicated in patch 0/4 that you had some additional > feedback/comments on this patch series. Could you please provide > them? I've got other data formats I'm working on support for (i.e. > SCTE-104) which depend on the common

Re: [FFmpeg-devel] [PATCH 0/7] Misc AFD improvements and support for Bar Data

2023-06-22 Thread Devin Heitmueller
Does anyone else have any comments on this series that would prevent it from being merged upstream? If not, I can rebase the drawtext patch so there are no conflicts. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-22 Thread Anton Khirnov
Quoting Carotti, Elias (2023-06-21 17:53:09) > + > +/** > + * Provide macro block encoder-specific hinting information for the > encoder > + * processing. It can be used to pass information about which macroblock > + * can be skipped because it hasn't changed from the