[FFmpeg-devel] [PATCH] web: remove myself from FFmpeg consulting page

2023-12-06 Thread Paul B Mahol
Attached. From dbee6548020b42f4559042fd6a50fa4fa35121ff Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Thu, 7 Dec 2023 08:45:23 +0100 Subject: [PATCH] remove myself from FFmpeg consulting page --- src/consulting | 12 1 file changed, 12 deletions(-) diff --git a/src/consulting

Re: [FFmpeg-devel] [PATCH] doc/examples/qsv_transcode: EINVAL is more appropriate and ENAVAIL will fail build with visual studio

2023-12-06 Thread Xiang, Haihao
On Do, 2023-12-07 at 06:44 +, hung kuishing wrote: > Signed-off-by: clarkh > --- >  doc/examples/qsv_transcode.c | 8 >  1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/doc/examples/qsv_transcode.c b/doc/examples/qsv_transcode.c > index 48128b200c..972126800b 100644

[FFmpeg-devel] [PATCH] MAINTAINERS: remove myself from FFmpeg

2023-12-06 Thread Paul B Mahol
Attached. From b249499fccb49705ade14362875ebf4d22628fa4 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Thu, 7 Dec 2023 08:27:14 +0100 Subject: [PATCH] MAINTAINERS: remove myself from FFmpeg Signed-off-by: Paul B Mahol --- MAINTAINERS | 55

Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-06 Thread Anton Khirnov
Quoting James Almer (2023-12-06 21:49:45) > On 12/2/2023 12:53 PM, Anton Khirnov wrote: > > Its author not only failed to add any tests, as is required by the > > development rules, but continues to actively refuse to do so. > > > > Untested decoders are worse than useless, so remove it. > > ---

[FFmpeg-devel] [PATCH] doc/examples/qsv_transcode: EINVAL is more appropriate and ENAVAIL will fail build with visual studio

2023-12-06 Thread hung kuishing
Signed-off-by: clarkh --- doc/examples/qsv_transcode.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/examples/qsv_transcode.c b/doc/examples/qsv_transcode.c index 48128b200c..972126800b 100644 --- a/doc/examples/qsv_transcode.c +++ b/doc/examples/qsv_transcode.c

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec.c Fix for ticket #7395

2023-12-06 Thread Steven Liu
Evgeniy Pantyuhin via ffmpeg-devel 于2023年12月7日周四 04:32写道: > > Signed-off-by: Evgeniy > --- > libavformat/dashdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 29d4680..36e4719 100644 > --- a/libavformat/dashdec.c

Re: [FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-06 Thread Vittorio Giovara
On Wed, Dec 6, 2023 at 3:23 AM Marton Balint wrote: > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index 2cfb3fcf97..f9b18a2c35 100644 > --- a/libavcodec/decode.c > +++ b/libavcodec/decode.c > @@ -1675,6 +1675,12 @@ FF_ENABLE_DEPRECATION_WARNINGS > >

Re: [FFmpeg-devel] [PATCH v2 1/3] lavu/hwcontext_d3d11va: Add option vendor_id

2023-12-06 Thread Xiang, Haihao
On Di, 2023-12-05 at 08:18 +, Xiang, Haihao wrote: > On Di, 2023-11-28 at 12:42 +0800, Xiang, Haihao wrote: > > From: Artem Galin > > > > User may choose the hardware via option vendor_id when multiple > > hardwares are available. > > > > Signed-off-by: Artem Galin > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] tests/fate: add pixelize filter tests

2023-12-06 Thread Michael Niedermayer
On Wed, Dec 06, 2023 at 11:20:06AM +0100, Paul B Mahol wrote: > Attached. > fate/filter-video.mak|9 + > ref/fate/filter-pixelize-avg |1 + > ref/fate/filter-pixelize-max |1 + > ref/fate/filter-pixelize-min |1 + > 4 files changed, 12 insertions(+) >

Re: [FFmpeg-devel] [PATCH] tests/fate: add median filter test

2023-12-06 Thread Michael Niedermayer
On Wed, Dec 06, 2023 at 12:21:02PM +0100, Paul B Mahol wrote: > Attached. > fate/filter-video.mak |3 +++ > ref/fate/filter-median |1 + > 2 files changed, 4 insertions(+) > 13f347a427b22bbb5ea4959ad092435d6f10c8d9 > 0001-tests-fate-add-median-filter-test.patch > From

Re: [FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-06 Thread Ronald S. Bultje
Hi, On Wed, Dec 6, 2023 at 3:23 AM Marton Balint wrote: > Signed-off-by: Marton Balint > --- > doc/APIchanges | 3 +++ > doc/codecs.texi| 14 ++ > libavcodec/avcodec.h | 4 > libavcodec/decode.c| 6 ++ > libavcodec/options_table.h

Re: [FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:20 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > doc/APIchanges | 3 +++ > doc/codecs.texi| 14 ++ > libavcodec/avcodec.h | 4 > libavcodec/decode.c| 6 ++ >

Re: [FFmpeg-devel] [PATCH v2 6/7] avutil/imgutils: add new function av_image_fill_color()

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:19 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > doc/APIchanges | 3 +++ > libavutil/imgutils.c | 4 ++-- > libavutil/imgutils.h | 30 ++ > libavutil/version.h | 2 +- > 4 files changed, 36

Re: [FFmpeg-devel] [PATCH v2 5/7] avutil/imgutils: factorize a fill color function

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:18 +0100, Marton Balint wrote: > In preparation for making it public. > > Signed-off-by: Marton Balint > --- > libavutil/imgutils.c | 103 +++ > 1 file changed, 64 insertions(+), 39 deletions(-) LGTM, thanks.

Re: [FFmpeg-devel] [PATCH v6 01/14] vvcdec: add vvc decoder stub

2023-12-06 Thread James Almer
On 12/5/2023 11:45 AM, Nuo Mi wrote: --- configure | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/vvc/Makefile | 4 + libavcodec/vvc/vvcdec.c | 62 libavcodec/vvc/vvcdec.h | 204

Re: [FFmpeg-devel] [PATCH v2 4/7] avutil/imgutils: add support for 32bit pixel format for av_image_fill_black()

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:17 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/imgutils.c| 33 +++-- > tests/ref/fate/imgutils | 24 > 2 files changed, 35 insertions(+), 22 deletions(-) LGTM, thanks.

Re: [FFmpeg-devel] [PATCH v2 3/7] avutil/imgutils: fix av_image_fill_black() for some pixel formats

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:16 +0100, Marton Balint wrote: > - Fixes YA formats, because previous code always assumed alpha as the 4th > component. > - Fixes PAL format (as long as 0 is black, as in a systematic palette), > because > previous code assumed it as limited Y. > - Fixes XYZ

Re: [FFmpeg-devel] [PATCH v2 2/7] avutil/tests/imgutils: add tests for av_image_fill_black()

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:15 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/tests/imgutils.c | 61 +-- > tests/ref/fate/imgutils| 217 + > 2 files changed, 269 insertions(+), 9 deletions(-) LGTM, thanks.

Re: [FFmpeg-devel] [PATCH v2 1/7] avutil/tests/imgutils: factorize basic tests to new function

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:14 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/tests/imgutils.c | 68 ++ > 1 file changed, 39 insertions(+), 29 deletions(-) LGTM, thanks. ___

Re: [FFmpeg-devel] [PATCH v7 0/7] webp: add support for animated WebP decoding

2023-12-06 Thread Michael Niedermayer
On Wed, Dec 06, 2023 at 02:34:58AM +0100, Thilo Borgmann via ffmpeg-devel wrote: > Still images fixed, includes FATE tests, VP8 decoder decoupled so there are > no more data races, fixed more asserts, fixed ffprobe regression. > > Patch 5/7 is still there for making changes in lavc/webp

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Anton Khirnov
Quoting Cosmin Stejerean via ffmpeg-devel (2023-12-06 21:29:11) > There is still a penalty as you could do asetnsamples without multi-threading > and get even higher performance, > but given the general benefits of multi-threading and the fact that it's > possible to increase the performance of

Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-06 Thread Vittorio Giovara
I ain't reading all of that Happy for you Or sorry that happened On Wed, Dec 6, 2023 at 3:47 PM Nicolas George wrote: > Vittorio Giovara (12023-12-05): > > Your attitude for "omgfeatures" is also pretty toxic, there are heaps of > > literature about feature creep and how important it is to

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Vittorio Giovara
On Wed, Dec 6, 2023 at 3:14 PM Nicolas George wrote: > Lie. > A summary of your proposal or a link to your suggestion would be appreciated. Without reference we're all shouting in the void. > I guess now that your side holds most of the power the mask is off. > > This mail you just sent

Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-06 Thread James Almer
On 12/2/2023 12:53 PM, Anton Khirnov wrote: Its author not only failed to add any tests, as is required by the development rules, but continues to actively refuse to do so. Untested decoders are worse than useless, so remove it. --- Changelog | 2 +- libavcodec/Makefile|

Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-06 Thread Nicolas George
Vittorio Giovara (12023-12-05): > Your attitude for "omgfeatures" is also pretty toxic, there are heaps of > literature about feature creep and how important it is to remove dead code. You should read said literature before quoting it, you would learn the difference between more features and

[FFmpeg-devel] [PATCH] libavformat/dashdec.c Fix for ticket #7395

2023-12-06 Thread Evgeniy Pantyuhin via ffmpeg-devel
Signed-off-by: Evgeniy --- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 29d4680..36e4719 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -768,7 +768,7 @@ static int

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Anton Khirnov
Also, the numbers I'm seeing on my 16-core Ryzen 9 5950X are quite different: * 5.0, your command:speed=3.25e+03x * 5.0, filter_complex: speed=5.29e+03x * 5.1, your command:speed=3.2e+03x * 5.1, filter_complex: speed=5.2e+03x * 6.0, your command:speed=2.44e+03x * 6.0, filter_complex:

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Cosmin Stejerean via ffmpeg-devel
> On Dec 6, 2023, at 11:36 AM, Anton Khirnov wrote: > >> In some cases the performance penalty because of threading is quite >> significant: >> >> Example command line: >> >> ffmpeg -f lavfi -i sine -af volume=6dB -f null none >> >> After latest threading changes: speed=810x >> Before

[FFmpeg-devel] [ANNOUNCEMENT] Left FFmpeg; starting Librempeg

2023-12-06 Thread Paul B Mahol
Today, effectively immediately, I officially Ieft the FFmpeg project. For new decoders/encoders/muxers/demuxers/filters/fixes/speedups/tests/cleanups etc. look at Librempeg project on github, source code will appear soon there. See you there. ___

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Michael Niedermayer
On Wed, Dec 06, 2023 at 11:27:06AM +0100, Anton Khirnov wrote: > Hi, > this should hopefully be the last version of this set. If nobody has new > comments, I will push it in a few days. I have a case that becomes really non deterministic for i in `seq 10` ; do ./ffmpeg -v 0 -bitexact -i

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: introduce textutils

2023-12-06 Thread Nicolas George
Stefano Sabatini (12023-11-30): > Generalize drawtext utilities to make them usable in other filters. > This will be needed to introduce the QR code source and filter without > duplicating functionality. > --- > libavfilter/Makefile | 2 +- > libavfilter/textutils.c | 379

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Nicolas George
Anton Khirnov (12023-12-06): > Would guess this is caused by overhead from tons of tiny frames. So > 1) generate larger frames > 2) use -filter_complex with no inputs instead of -f lavfi to eliminate >all overhead from demuxing, decoding, and demux-decode/decode-filter >inter-thread

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Nicolas George
Anton Khirnov (12023-12-06): > As usual when someone disagrees with him, Nicolas converged to being > utterly unreasonable and deaf to all arguments. I see no point in Ad-hominem attack. > discussing this with him any further and intend to push the set > tomorrow, unless somebody else has

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Vittorio Giovara
On Wed, Dec 6, 2023 at 5:30 AM Anton Khirnov wrote: > Hi, > this should hopefully be the last version of this set. If nobody has new > comments, I will push it in a few days. > LGTM -- Vittorio ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] tools/general_assembly: implement extra GA members

2023-12-06 Thread Michael Niedermayer
On Thu, Nov 23, 2023 at 10:14:23AM +0100, Anton Khirnov wrote: > --- > tools/general_assembly.pl | 20 +--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/tools/general_assembly.pl b/tools/general_assembly.pl > index 4c3208ccac..3bf65f3405 100755 > ---

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Anton Khirnov
Quoting Marton Balint (2023-12-06 20:29:01) > > > On Wed, 6 Dec 2023, Anton Khirnov wrote: > > > Hi, > > this should hopefully be the last version of this set. If nobody has new > > comments, I will push it in a few days. > > In some cases the performance penalty because of threading is quite

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Marton Balint
On Wed, 6 Dec 2023, Anton Khirnov wrote: Hi, this should hopefully be the last version of this set. If nobody has new comments, I will push it in a few days. In some cases the performance penalty because of threading is quite significant: Example command line: ffmpeg -f lavfi -i sine

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC/CC elections

2023-12-06 Thread Michael Niedermayer
On Wed, Dec 06, 2023 at 09:25:43AM +0100, Anton Khirnov wrote: > Quoting Niklas Haas (2023-12-05 12:01:48) > > On Tue, 05 Dec 2023 11:07:33 +0100 Anton Khirnov wrote: > > > Hi all, > > > Both elections have now concluded. > > > > > > We have 36 votes for the CC election (70% turnout) and 38

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix string comparison bug

2023-12-06 Thread Kyle Swanson
Hi, On Mon, Dec 4, 2023 at 7:59 AM Nil Fons Miret via ffmpeg-devel wrote: > > The libvmaf filter was doing substring checks in place of string > equality comparisons. This led to a bug when the user specified the > pooling method "harmonic_mean", since "mean" was checked first and the >

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: replace deprecated AVCaptureDevice

2023-12-06 Thread Thilo Borgmann via ffmpeg-devel
Am 06.12.23 um 13:03 schrieb xufuji456 via ffmpeg-devel: Building with iOS platform, the compiler has a warning: "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead" Signed-off-by: xufuji456 <839789...@qq.com> ---

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Anton Khirnov
Hi all, As usual when someone disagrees with him, Nicolas converged to being utterly unreasonable and deaf to all arguments. I see no point in discussing this with him any further and intend to push the set tomorrow, unless somebody else has substantial objections. I've considered asking for a

Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/vf_bwdif: consider chroma subsampling when enforcing minimum dimensions

2023-12-06 Thread Cosmin Stejerean via ffmpeg-devel
> On Dec 6, 2023, at 02:44, Philip Langdale via ffmpeg-devel > wrote: > > On Sat, 2 Dec 2023 23:02:36 +0100 > Thomas Mundt wrote: > >> >> LGTM, thanks. >> > > I am going to squash the three commits and push. There's no real need > to put each filter in a separate diff when the logical

Re: [FFmpeg-devel] [PATCH 06/25] fftools/ffmpeg_filter: configure buffersrc with csp/range

2023-12-06 Thread Anton Khirnov
Quoting Niklas Haas (2023-11-09 13:19:38) > From: Niklas Haas > > Propagates input metadata to the input filter graph. > --- > fftools/ffmpeg_filter.c | 24 +--- > 1 file changed, 21 insertions(+), 3 deletions(-) Looks ok -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH 05/25] avfilter/buffersrc: add color_space/range parameters

2023-12-06 Thread Anton Khirnov
Quoting Niklas Haas (2023-11-09 13:19:37) > @@ -328,6 +341,30 @@ static const AVOption buffer_options[] = { > { "pixel_aspect", "sample aspect ratio",OFFSET(pixel_aspect), > AV_OPT_TYPE_RATIONAL, { .dbl = 0 }, 0, DBL_MAX, V }, > { "time_base", NULL,

Re: [FFmpeg-devel] [PATCH 03/25] avfilter: add negotiation API for color space/range

2023-12-06 Thread Anton Khirnov
Quoting Niklas Haas (2023-11-09 13:19:35) > diff --git a/doc/APIchanges b/doc/APIchanges > index 12383a28d3..ce3f90a674 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -2,6 +2,14 @@ The last version increases of all libraries were on > 2023-02-09 > > API changes, most recent first: >

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-06 Thread Nicolas George
James Almer (12023-12-06): > I honestly can't believe you're arguing this. Yet I do, so I suggest you think a little harder to understand why I do. > And being condescending will not help your case. Can you tell that to Anton too please? > If i request -bitexact, i want bitexact output,

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-06 Thread Martin Storsjö
On Wed, 6 Dec 2023, Timo Rothenpieler wrote: On 06/12/2023 14:25, Martin Storsjö wrote: On Sun, 3 Dec 2023, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-06 Thread Timo Rothenpieler
On 06/12/2023 14:25, Martin Storsjö wrote: On Sun, 3 Dec 2023, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-06 Thread Martin Storsjö
On Sun, 3 Dec 2023, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-06 Thread James Almer
On 12/6/2023 9:55 AM, Nicolas George wrote: Anton Khirnov (12023-12-04): Which of these are you saying is correct? I do not know? Do you think I am able to reverse MD5 mentally? I am flattered, but I am sorry to confess I am not. Why do you not look at the resulting videos to judge for

Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: fix OOM case for default activate

2023-12-06 Thread Nicolas George
Paul B Mahol (12023-12-01): > From 2ea2a0df61cbd5519a1c1e88be27a3f8eb883aac Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Fri, 1 Dec 2023 16:59:07 +0100 > Subject: [PATCH] avfilter/avfilter: fix OOM case for default activate > > Fixes OOM when caller keeps adding frames into filtergraph

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: Set default bitrate to 2M

2023-12-06 Thread Zhao Zhili
> On Dec 6, 2023, at 20:26, Timo Rothenpieler wrote: > > On 06/12/2023 07:51, Xiang, Haihao wrote: >> On Di, 2023-12-05 at 12:47 +0100, Timo Rothenpieler wrote: >>> On 05.12.2023 09:15, Xiang, Haihao wrote: From: Haihao Xiang 2M is suitable for more cases, e.g. 4K video.

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Nicolas George
Anton Khirnov (12023-12-06): > After weeks of discussion, you have NOT suggested any workable > alternative. Indeed. And the reason for that is that all the time I have available on this is spent debunking your libel about the current logic. > Producing unpredictable output generally means

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-06 Thread Timo Rothenpieler
On 06/12/2023 13:31, James Almer wrote: On 12/3/2023 5:10 PM, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-06 Thread Nicolas George
Anton Khirnov (12023-12-04): > Which of these are you saying is correct? I do not know? Do you think I am able to reverse MD5 mentally? I am flattered, but I am sorry to confess I am not. Why do you not look at the resulting videos to judge for yourself? But to do that, you will need to remember

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-06 Thread James Almer
On 12/6/2023 9:50 AM, Ronald S. Bultje wrote: Hi, On Sun, Dec 3, 2023 at 3:10 PM Timo Rothenpieler wrote: So if the compiler does a copy in decode_cpe() with avx instructions, but ffmpeg is built with --disable-avx Ehm... What? That seems like the core bug then? --disable-avx will

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-06 Thread Ronald S. Bultje
Hi, On Sun, Dec 3, 2023 at 3:10 PM Timo Rothenpieler wrote: > So if the compiler does a copy > in decode_cpe() with avx instructions, but ffmpeg is built with > --disable-avx > Ehm... What? That seems like the core bug then? Ronald ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-06 Thread James Almer
On 12/3/2023 5:10 PM, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Anton Khirnov
Quoting Nicolas George (2023-12-06 13:10:41) > I have offered Anton my help. After weeks of discussion, you have NOT suggested any workable alternative. The single suggestion I did see from you * was already implemented * did not address the issues at all > But first he needs to acknowledge

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-06 Thread Timo Rothenpieler
On 03/12/2023 21:10, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: Set default bitrate to 2M

2023-12-06 Thread Timo Rothenpieler
On 06/12/2023 07:51, Xiang, Haihao wrote: On Di, 2023-12-05 at 12:47 +0100, Timo Rothenpieler wrote: On 05.12.2023 09:15, Xiang, Haihao wrote: From: Haihao Xiang 2M is suitable for more cases, e.g. 4K video. Signed-off-by: Haihao Xiang ---   libavcodec/qsvenc_av1.c   | 2 +-  

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Nicolas George
Zhao Zhili (12023-12-06): > For such large patch set, it’s almost impossible to not break any corner case. Yes, that is what review is for. > Considering the improvements the patch set brings into fftools, those corner > cases can be fixed after merge. That means never. No. > And any body can

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Zhao Zhili
> On Dec 6, 2023, at 18:55, Nicolas George wrote: > > Anton Khirnov (12023-12-06): >> this should hopefully be the last version of this set. If nobody has new >> comments, I will push it in a few days. > > Absolutely not: you cannot push until consensus is reached, and > consensus is not

[FFmpeg-devel] [PATCH] avdevice/avfoundation: replace deprecated AVCaptureDevice

2023-12-06 Thread xufuji456 via ffmpeg-devel
Building with iOS platform, the compiler has a warning: "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead" Signed-off-by: xufuji456 <839789...@qq.com> --- libavdevice/avfoundation.m | 23 ++- 1 file changed,

Re: [FFmpeg-devel] [PATCH 10/10] fftools/ffmpeg: convert to a threaded architecture

2023-12-06 Thread Anton Khirnov
Quoting Paul B Mahol (2023-12-06 12:22:48) > On Wed, Dec 6, 2023 at 11:32 AM Anton Khirnov wrote: > > > Change the main loop and every component (demuxers, decoders, filters, > > encoders, muxers) to use the previously added transcode scheduler. Every > > instance of every such component was

[FFmpeg-devel] [PATCH] tests/fate: add median filter test

2023-12-06 Thread Paul B Mahol
Attached. From 2c54553b83f2b67f781c67cb72deb4a5f267a8f1 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Wed, 6 Dec 2023 12:17:54 +0100 Subject: [PATCH] tests/fate: add median filter test Signed-off-by: Paul B Mahol --- tests/fate/filter-video.mak | 3 +++ tests/ref/fate/filter-median | 1 +

Re: [FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Nicolas George
Anton Khirnov (12023-12-06): > this should hopefully be the last version of this set. If nobody has new > comments, I will push it in a few days. Absolutely not: you cannot push until consensus is reached, and consensus is not reached since you are still breaking the sparseness of sub2video

[FFmpeg-devel] [PATCH] web: add a news entry for ffmpeg CLI threading

2023-12-06 Thread Anton Khirnov
--- src/index | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/index b/src/index index 0d68db5..22f6844 100644 --- a/src/index +++ b/src/index @@ -35,6 +35,20 @@ News + December xxth, 2023, multi-threaded ffmpeg CLI tool + + Thanks to a major refactoring of

Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/vf_bwdif: consider chroma subsampling when enforcing minimum dimensions

2023-12-06 Thread Philip Langdale via ffmpeg-devel
On Sat, 2 Dec 2023 23:02:36 +0100 Thomas Mundt wrote: > > LGTM, thanks. > I am going to squash the three commits and push. There's no real need to put each filter in a separate diff when the logical change is identical in all three. Thanks, --phil

[FFmpeg-devel] [PATCH 10/10] fftools/ffmpeg: convert to a threaded architecture

2023-12-06 Thread Anton Khirnov
Change the main loop and every component (demuxers, decoders, filters, encoders, muxers) to use the previously added transcode scheduler. Every instance of every such component was already running in a separate thread, but now they can actually run in parallel. Changes the results of

[FFmpeg-devel] [PATCH 09/10] fftools/ffmpeg: add thread-aware transcode scheduling infrastructure

2023-12-06 Thread Anton Khirnov
See the comment block at the top of fftools/ffmpeg_sched.h for more details on what this scheduler is for. This commit adds the scheduling code itself, along with minimal integration with the rest of the program: * allocating and freeing the scheduler * passing it throughout the call stack in

[FFmpeg-devel] [PATCH 08/10] fftools/ffmpeg_enc: move encoding to a separate thread

2023-12-06 Thread Anton Khirnov
As for the analogous decoding change, this is only a preparatory step to a fully threaded architecture and does not yet make encoding truly parallel. The main thread will currently submit a frame and wait until it has been fully processed by the encoder before moving on. That will change in future

[FFmpeg-devel] [PATCH 07/10] fftools/ffmpeg_demux: switch from AVThreadMessageQueue to ThreadQueue

2023-12-06 Thread Anton Khirnov
* the code is made shorter and simpler * avoids constantly allocating and freeing AVPackets, thanks to ThreadQueue integration with ObjPool * is consistent with decoding/filtering/muxing * reduces the diff in the future switch to thread-aware scheduling This makes ifile_get_packet() always

[FFmpeg-devel] [PATCH 06/10] fftools/ffmpeg_mux: move bitstream filtering to the muxer thread

2023-12-06 Thread Anton Khirnov
This will be the appropriate place for it after the rest of transcoding is switched to a threaded architecture. --- fftools/ffmpeg_mux.c | 112 ++- 1 file changed, 67 insertions(+), 45 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c

[FFmpeg-devel] [PATCH 04/10] fftools/ffmpeg_filter: reindent

2023-12-06 Thread Anton Khirnov
--- fftools/ffmpeg_filter.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 1800296aa4..1df1212442 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -2526,17 +2526,17 @@ static int

[FFmpeg-devel] [PATCH 05/10] fftools/ffmpeg_mux: add muxing thread private data

2023-12-06 Thread Anton Khirnov
To be used for data that never needs to be visible outside of the muxer thread. Start by moving the muxed AVPacket in there. --- fftools/ffmpeg_mux.c | 44 +++- 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg_mux.c

[FFmpeg-devel] [PATCH 02/10] fftools/ffmpeg_filter: move filtering to a separate thread

2023-12-06 Thread Anton Khirnov
As previously for decoding, this is merely "scaffolding" for moving to a fully threaded architecture and does not yet make filtering truly parallel - the main thread will currently wait for the filtering thread to finish its work before continuing. That will change in future commits after encoders

[FFmpeg-devel] [PATCH v3] ffmpeg CLI multithreading

2023-12-06 Thread Anton Khirnov
Hi, this should hopefully be the last version of this set. If nobody has new comments, I will push it in a few days. Cheers, -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

[FFmpeg-devel] [PATCH 01/10] fftools/ffmpeg_filter: make sub2video heartbeat more robust

2023-12-06 Thread Anton Khirnov
Avoid making decisions based on current graph input state, which makes the output dependent on the order in which the frames from different inputs are interleaved. Makes the output of fate-filter-overlay-dvdsub-2397 more correct - the subtitle appears two frames later, which is closer to its PTS

[FFmpeg-devel] [PATCH 03/10] fftools/ffmpeg_filter: buffer sub2video heartbeat frames like other frames

2023-12-06 Thread Anton Khirnov
Otherwise they'd be silently ignored if received by the filtering thread before the filtergraph can be initialized, which would make the output dependent on the order in which frames from different inputs arrive. --- fftools/ffmpeg_filter.c | 43 - 1 file

[FFmpeg-devel] [PATCH] tests/fate: add pixelize filter tests

2023-12-06 Thread Paul B Mahol
Attached. From c17589e4fc6b38013d6b0b14feeac50e00bb3305 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Wed, 6 Dec 2023 11:18:35 +0100 Subject: [PATCH] tests/fate: add pixelize filter tests Signed-off-by: Paul B Mahol --- tests/fate/filter-video.mak| 9 +

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC/CC elections

2023-12-06 Thread Anton Khirnov
Quoting Niklas Haas (2023-12-05 12:01:48) > On Tue, 05 Dec 2023 11:07:33 +0100 Anton Khirnov wrote: > > Hi all, > > Both elections have now concluded. > > > > We have 36 votes for the CC election (70% turnout) and 38 votes for TC > > (75% turnout); raw votes in CSV format are attached. > > > >

[FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-06 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ doc/codecs.texi| 14 ++ libavcodec/avcodec.h | 4 libavcodec/decode.c| 6 ++ libavcodec/options_table.h | 1 + libavcodec/version.h | 2 +- 6 files changed, 29

[FFmpeg-devel] [PATCH v2 6/7] avutil/imgutils: add new function av_image_fill_color()

2023-12-06 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/imgutils.c | 4 ++-- libavutil/imgutils.h | 30 ++ libavutil/version.h | 2 +- 4 files changed, 36 insertions(+), 3 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index

[FFmpeg-devel] [PATCH v2 5/7] avutil/imgutils: factorize a fill color function

2023-12-06 Thread Marton Balint
In preparation for making it public. Signed-off-by: Marton Balint --- libavutil/imgutils.c | 103 +++ 1 file changed, 64 insertions(+), 39 deletions(-) diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c index 67119b0870..278e30ee0f 100644 ---

[FFmpeg-devel] [PATCH v2 4/7] avutil/imgutils: add support for 32bit pixel format for av_image_fill_black()

2023-12-06 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/imgutils.c| 33 +++-- tests/ref/fate/imgutils | 24 2 files changed, 35 insertions(+), 22 deletions(-) diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c index 5e401139c8..67119b0870 100644

[FFmpeg-devel] [PATCH v2 3/7] avutil/imgutils: fix av_image_fill_black() for some pixel formats

2023-12-06 Thread Marton Balint
- Fixes YA formats, because previous code always assumed alpha as the 4th component. - Fixes PAL format (as long as 0 is black, as in a systematic palette), because previous code assumed it as limited Y. - Fixes XYZ format because it does not need nonzero chroma components - Fixes xv30be as

[FFmpeg-devel] [PATCH v2 2/7] avutil/tests/imgutils: add tests for av_image_fill_black()

2023-12-06 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/tests/imgutils.c | 61 +-- tests/ref/fate/imgutils| 217 + 2 files changed, 269 insertions(+), 9 deletions(-) diff --git a/libavutil/tests/imgutils.c b/libavutil/tests/imgutils.c index

[FFmpeg-devel] [PATCH v2 1/7] avutil/tests/imgutils: factorize basic tests to new function

2023-12-06 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/tests/imgutils.c | 68 ++ 1 file changed, 39 insertions(+), 29 deletions(-) diff --git a/libavutil/tests/imgutils.c b/libavutil/tests/imgutils.c index 748bd6c9d2..1e2bb3fa01 100644 --- a/libavutil/tests/imgutils.c