[FFmpeg-devel] [PATCH v2 2/2] avcodec/vaapi_encode_h265: use is_reference to fill reference_pic_flag

2024-03-04 Thread tong1 . wu-at-intel . com
From: Tong Wu This codec supports FLAG_B_PICTURE_REFERENCES. We need to fill reference_pic_flag with pic->is_reference. Signed-off-by: Tong Wu --- libavcodec/vaapi_encode_h265.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c

[FFmpeg-devel] [PATCH v2 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag

2024-03-04 Thread tong1 . wu-at-intel . com
From: Tong Wu This codec supports FLAG_B_PICTURE_REFERENCES. We need to correctly fill the reference_pic_flag with is_reference variable instead of 0 for B frames. Signed-off-by: Tong Wu --- libavcodec/vaapi_encode_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH v2 3/6] avutil/jni: use size_t to store structure offsets

2024-03-04 Thread Matthieu Bouron
On Mon, Mar 04, 2024 at 09:10:49PM +0100, Andreas Rheinhardt wrote: > Matthieu Bouron: > > --- > > libavcodec/ffjni.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/ffjni.h b/libavcodec/ffjni.h > > index 6027bac0ab..d5894609ed 100644 > > ---

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag

2024-03-04 Thread Xiang, Haihao
On Di, 2024-02-27 at 11:48 +0800, tong1.wu-at-intel@ffmpeg.org wrote: > From: Tong Wu > > This codec supports FLAG_B_PICTURE_REFERENCES. We need to correctly fill > the reference_pic_flag with is_reference variable instead of 0 for B > frames. > > Signed-off-by: Tong Wu > --- >  

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: use is_reference to fill reference_pic_flag

2024-03-04 Thread Xiang, Haihao
On Di, 2024-02-27 at 11:48 +0800, tong1.wu-at-intel@ffmpeg.org wrote: > From: Tong Wu > > This codec supports FLAG_B_PICTURE_REFERENCES. We need to fill > reference_pic_flag with pic->is_reference. > > Signed-off-by: Tong Wu > --- >  libavcodec/vaapi_encode_h265.c | 8 >  1 file

[FFmpeg-devel] [PATCH 1/1] avformat/gopher: Add audio and video itemtypes

2024-03-04 Thread Christian Lee Seibold
The 's', ';', and '<' itemtypes are used for audio and video by Gophernicus and Gopher+. Signed-off-by: Christian Lee Seibold --- libavformat/gopher.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/gopher.c b/libavformat/gopher.c index 9497ffacf2..97ac9028a1 100644 ---

Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the bitstream position check

2024-03-04 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of Dai, > Jianhui J > Sent: Friday, February 23, 2024 8:43 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the > bitstream position check > > > > >

[FFmpeg-devel] [PATCH] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-03-04 Thread Sean McGovern
Iterate over 'pmax' instead of 'num_swb'. --- libavcodec/aacenc_pred.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacenc_pred.c b/libavcodec/aacenc_pred.c index a486c44d42..c5b8aa9665 100644 --- a/libavcodec/aacenc_pred.c +++ b/libavcodec/aacenc_pred.c @@

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-04 Thread Michael Niedermayer
On Mon, Mar 04, 2024 at 10:45:02AM +0100, Vittorio Giovara wrote: > On Mon, Mar 4, 2024 at 1:57 AM Michael Niedermayer > wrote: > > > On Sun, Mar 03, 2024 at 03:49:33AM +0100, Michael Niedermayer wrote: > > [...] > > > > > +If a TC member is aware of a conflict of interest with regards to the >

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-04 Thread Michael Niedermayer
On Mon, Mar 04, 2024 at 10:15:31PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-03-04 00:36:21) > > [words words] > > Again - why do you personally need so many choices? Just one should be > enough. If someone else wants some other choice on the ballot, they > should ask for

Re: [FFmpeg-devel] [PATCH 2/3] doc/community: Conflict of interest recusal requirement (Similar to mid part of Antons proposal)

2024-03-04 Thread Michael Niedermayer
On Mon, Mar 04, 2024 at 10:42:02AM +0100, Vittorio Giovara wrote: > On Mon, Mar 4, 2024 at 1:46 AM Michael Niedermayer > wrote: > > > > Again, the effective way to work-around this problem is to keep a large > > and > > > diverse enough TC membership to offset the one or few hypothetical > >

[FFmpeg-devel] [PATCH 7/9 v3] fate/mov: print stream group information for avif/heic tests

2024-03-04 Thread James Almer
Signed-off-by: James Almer --- tests/fate-run.sh | 13 ++ tests/fate/mov.mak| 12 +- .../ref/fate/mov-heic-demux-still-image-grid | 162 -- .../ref/fate/mov-heic-demux-still-image-iovl | 100 ++- 4 files changed,

[FFmpeg-devel] [PATCH 9/9] fate/mov: add a heic test with a derived image using a single item twice

2024-03-04 Thread James Almer
Signed-off-by: James Almer --- tests/fate/mov.mak| 6 ++ .../fate/mov-heic-demux-still-image-iovl-2| 73 +++ 2 files changed, 79 insertions(+) create mode 100644 tests/ref/fate/mov-heic-demux-still-image-iovl-2 diff --git a/tests/fate/mov.mak

[FFmpeg-devel] [PATCH 6/9] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-04 Thread James Almer
Signed-off-by: James Almer --- fftools/ffprobe.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index ff05c4c1db..e736023bcd 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -209,6

[FFmpeg-devel] [PATCH 8/9 v2] fate/mov: use framecrc for the remaining avif/heic tests

2024-03-04 Thread James Almer
Put them in sync with the other tests. Signed-off-by: James Almer --- tests/fate/mov.mak| 21 ++- .../fate/mov-avif-demux-still-image-1-item| 8 ++- .../mov-avif-demux-still-image-multiple-items | 8 ++-

[FFmpeg-devel] [PATCH 5/9 v2] fate/mov: print stream group information for iamf tests

2024-03-04 Thread James Almer
Signed-off-by: James Almer --- tests/fate/mov.mak | 12 +- tests/ref/fate/mov-mp4-iamf-5_1_4 | 318 + tests/ref/fate/mov-mp4-iamf-7_1_4 | 362 tests/ref/fate/mov-mp4-iamf-ambisonic_1 | 230 +++

[FFmpeg-devel] [PATCH 4/9 v2] fate/iamf: print stream group information

2024-03-04 Thread James Almer
Signed-off-by: James Almer --- tests/fate/iamf.mak | 8 ++-- tests/ref/fate/iamf-5_1_4 | 60 + tests/ref/fate/iamf-7_1_4 | 68 + tests/ref/fate/iamf-ambisonic_1 | 44 +

[FFmpeg-devel] [PATCH 3/9 v3] fftools/ffprobe: add support for Stream Groups

2024-03-04 Thread James Almer
Signed-off-by: James Almer --- Changelog | 1 + doc/ffprobe.xsd | 1 + fftools/ffprobe.c | 147 -- tests/ref/fate/cavs-demux | 2 +-

[FFmpeg-devel] [PATCH 1/9 v2] fftools/ffprobe: fix printing side data components and pieces

2024-03-04 Thread James Almer
Components and pieces are side data specific fields and there's a variable amount of them. They also need to be identified in some form, so print a type too. Signed-off-by: James Almer --- fftools/ffprobe.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-)

[FFmpeg-devel] [PATCH 2/9] avformat/avformat: add a function to return the name of stream groups

2024-03-04 Thread James Almer
Signed-off-by: James Almer --- Missing version bump and APIChanges entry. libavformat/avformat.c | 10 ++ libavformat/avformat.h | 5 + 2 files changed, 15 insertions(+) diff --git a/libavformat/avformat.c b/libavformat/avformat.c index eb898223d2..98dfac2f89 100644 ---

Re: [FFmpeg-devel] [PATCH 05/29] lavu/opt: distinguish between native and foreign access for AVOption fields

2024-03-04 Thread Marton Balint
On Mon, 4 Mar 2024, Anton Khirnov wrote: Native access is from the code that declared the options, foreign access is from code that is using the options. Forbid foreign access to AVOption.offset/default_val, for which there is no good reason, and which should allow us more freedom in

Re: [FFmpeg-devel] [PATCH 06/29] lavu/opt: add array options

2024-03-04 Thread Marton Balint
On Mon, 4 Mar 2024, Anton Khirnov wrote: --- doc/APIchanges| 3 + libavutil/opt.c | 362 +- libavutil/opt.h | 62 +++- libavutil/tests/opt.c | 51 ++ tests/ref/fate/opt| 35 +++- 5 files changed, 468 insertions(+), 45

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-04 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-03-04 00:36:21) > [words words] Again - why do you personally need so many choices? Just one should be enough. If someone else wants some other choice on the ballot, they should ask for it. -- Anton Khirnov ___

Re: [FFmpeg-devel] [PATCH 06/29] lavu/opt: add array options

2024-03-04 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-04 14:29:59) > Anton Khirnov: > > --- > > doc/APIchanges| 3 + > > libavutil/opt.c | 362 +- > > libavutil/opt.h | 62 +++- > > libavutil/tests/opt.c | 51 ++ > > tests/ref/fate/opt|

Re: [FFmpeg-devel] [PATCH v2 3/6] avutil/jni: use size_t to store structure offsets

2024-03-04 Thread Andreas Rheinhardt
Matthieu Bouron: > --- > libavcodec/ffjni.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/ffjni.h b/libavcodec/ffjni.h > index 6027bac0ab..d5894609ed 100644 > --- a/libavcodec/ffjni.h > +++ b/libavcodec/ffjni.h > @@ -24,6 +24,7 @@ > #define

Re: [FFmpeg-devel] [PATCH v2 2/6] avformat: add Android content resolver protocol support

2024-03-04 Thread Matthieu Bouron
On Tue, Feb 27, 2024 at 03:50:38PM +0100, Matthieu Bouron wrote: > Handles Android content-uri starting with content://. > --- [...] New patch attached (I moved an unrelated chunk to the previous commit). >From 6ef059b721c1b1635565cc9e7d836be4733c928d Mon Sep 17 00:00:00 2001 From: Matthieu

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

2024-03-04 Thread Matthieu Bouron
On Mon, Mar 04, 2024 at 05:35:36PM +0100, Matthieu Bouron wrote: > On Mon, Mar 4, 2024 at 4:11 PM Matthieu Bouron > wrote: > > > > On Mon, Mar 4, 2024 at 12:29 PM Andreas Rheinhardt > > wrote: [...] > > > > > > I am against adding stub functions on platforms where they are known to > > > be

[FFmpeg-devel] [PATCH] fftools/ffprobe: fix printing side data components and pieces

2024-03-04 Thread James Almer
Components and pieces are side data specific fields and there's a variable amount of them. They also need to be identified in some form, so print a type too. Signed-off-by: James Almer --- You can see the difference with ffprobe -show_frames -of compact $fate_samples/mov/dovi-p7.mp4 ffprobe

[FFmpeg-devel] [PATCH] lavc: move AVCodecContext.pts_correction* to DecodeContext

2024-03-04 Thread James Almer
From: Anton Khirnov These fields are documented to be non-public and are only used in decode.c Signed-off-by: James Almer --- libavcodec/avcodec.h | 10 -- libavcodec/decode.c | 37 ++--- 2 files changed, 22 insertions(+), 25 deletions(-) diff --git

[FFmpeg-devel] [PATCH 2/2] avformat/avformat: Reorder AVFormatContext fields

2024-03-04 Thread James Almer
Move related fields closer together. Signed-off-by: James Almer --- libavformat/avformat.h | 222 - 1 file changed, 111 insertions(+), 111 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index d74db17df1..f28db099d4 100644 ---

[FFmpeg-devel] [PATCH 1/2] avformat/avformat: remove AVFormatContext.ts_id

2024-03-04 Thread James Almer
It's been replaced by a demuxer exported private option. Signed-off-by: James Almer --- libavformat/avformat.h | 6 -- libavformat/mpegts.c | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 1ae4c37d45..d74db17df1

[FFmpeg-devel] [PATCH5] avcodec/codec_par: Reorder AVCodecParameters fields

2024-03-04 Thread James Almer
Move related fields closer together. Signed-off-by: James Almer --- libavcodec/codec_par.h | 59 +- 1 file changed, 29 insertions(+), 30 deletions(-) diff --git a/libavcodec/codec_par.h b/libavcodec/codec_par.h index fa6851294f..f4b9bb5c06 100644 ---

Re: [FFmpeg-devel] [PATCH] configure: do not specify -ldvdread, as pkg-config check is already done

2024-03-04 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/parser: merge packets from the same frame

2024-03-04 Thread Nicolas Gaullier
>De : ffmpeg-devel De la part de Michael >Niedermayer >Envoyé : dimanche 3 mars 2024 23:07 >À : FFmpeg development discussions and patches >Objet : Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/parser: merge packets from >the same frame > >On Fri, Mar 01, 2024 at 02:39:19PM +0100, Nicolas Gaullier

[FFmpeg-devel] [PATCH] configure: do not specify -ldvdread, as pkg-config check is already done

2024-03-04 Thread Marth64
Reported-by: BtbN Signed-off-by: Marth64 --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index db7dc89755..bbf1a70731 100755 --- a/configure +++ b/configure @@ -6782,7 +6782,7 @@ enabled libdavs2 && require_pkg_config libdavs2

[FFmpeg-devel] [PATCH v3 5/5] lavf/demux: duplicate side_data in parse_packet()

2024-03-04 Thread Nicolas Gaullier
Signed-off-by: Nicolas Gaullier --- libavformat/demux.c | 25 ++- tests/ref/fate/concat-demuxer-simple2-lavf-ts | 164 +- tests/ref/fate/ts-demux | 8 +- 3 files changed, 106 insertions(+), 91 deletions(-) diff --git

[FFmpeg-devel] [PATCH v3 2/5] avcodec/parser: reindent after previous commit

2024-03-04 Thread Nicolas Gaullier
Signed-off-by: Nicolas Gaullier --- libavcodec/parser.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/parser.c b/libavcodec/parser.c index 90461075fd..496ebbc231 100644 --- a/libavcodec/parser.c +++ b/libavcodec/parser.c @@ -144,14 +144,14 @@ int

[FFmpeg-devel] [PATCH v3 0/5] avcodec/parser: fix fetch_timestamp in a scenario with unaligned packets

2024-03-04 Thread Nicolas Gaullier
Updated from v2: patch 1: fix audio case where pts=AV_NOPTS_VALUE but dts exists (thanks to Michael) now pass fate with --assert-level=2 patch 5: add inline comments and moved a line to make it more easy to read (thanks to James) Thank you for this review Nicolas Gaullier (5):

[FFmpeg-devel] [PATCH v3 3/5] avcodec/parser: fix fetch_timestamp in a scenario with unaligned packets

2024-03-04 Thread Nicolas Gaullier
Fix fetch_timestamp when the frame start is in a previous packet. Signed-off-by: Nicolas Gaullier --- libavcodec/parser.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/parser.c b/libavcodec/parser.c index 496ebbc231..3c22fdcc2f 100644 ---

[FFmpeg-devel] [PATCH v3 1/5] avcodec/parser: merge packets from the same frame

2024-03-04 Thread Nicolas Gaullier
The mpegts demuxer splits packets according to its max_packet_size. This currently fills the AVCodecParserContext s->cur_frame_* arrays with kind of 'empty' entries: no pts/dts. This patch merges these entries, so the parser behaviour is independent from the demuxer settings. This patch is

[FFmpeg-devel] [PATCH v3 4/5] avcodec/h264_parser: fix start of packet for some broken streams

2024-03-04 Thread Nicolas Gaullier
Signed-off-by: Nicolas Gaullier --- libavcodec/h264_parser.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c index 94cfbc481e..6b721ec253 100644 --- a/libavcodec/h264_parser.c +++ b/libavcodec/h264_parser.c @@

Re: [FFmpeg-devel] [PATCH 0/3] Fix /// comments that should be ///

2024-03-04 Thread Stefano Sabatini
On date Monday 2024-03-04 17:49:27 +0100, Andreas Rheinhardt wrote: > Stefano Sabatini: > > On date Wednesday 2024-02-28 17:09:38 +, Andrew Sayers wrote: > >> This is the first in a planned series of patch series aimed at > >> fixing documentation issues, especially doxygen rendering. > >> I

Re: [FFmpeg-devel] [PATCH 0/3] Fix /// comments that should be ///

2024-03-04 Thread Andreas Rheinhardt
Stefano Sabatini: > On date Wednesday 2024-02-28 17:09:38 +, Andrew Sayers wrote: >> This is the first in a planned series of patch series aimed at >> fixing documentation issues, especially doxygen rendering. >> I hope to post more as time allows in the coming days. >> >> The first patch

Re: [FFmpeg-devel] [PATCH] all: fix "@param foo[in/out]" to "@param[in, out] foo"

2024-03-04 Thread Stefano Sabatini
On date Thursday 2024-02-29 15:58:58 +, Andrew Sayers wrote: > Fix a few invalid doxygen comments: > > /** > * @param[in,out] correctly_formatted > * @param incorrect1[in] - [in] must come immediately after @param > * @param incorrect2[in/out] - '/' must be ',' > */ >

Re: [FFmpeg-devel] [PATCH] all: fix "param"s that should be "@param"

2024-03-04 Thread Stefano Sabatini
On date Thursday 2024-02-29 15:51:33 +, Andrew Sayers wrote: > Actual command: sed -i -e "s/\(^ *\\* \)\(param[^a-z]\)/\1@\2/" $( git grep > -l "^ *\\* param[^a-z]" ) > > Signed-off-by: Andrew Sayers > --- > libavcodec/evrcdec.c | 10 +- > libavutil/bprint.h | 12 ++-- >

Re: [FFmpeg-devel] [PATCH 0/3] Fix /// comments that should be ///

2024-03-04 Thread Stefano Sabatini
On date Wednesday 2024-02-28 17:09:38 +, Andrew Sayers wrote: > This is the first in a planned series of patch series aimed at > fixing documentation issues, especially doxygen rendering. > I hope to post more as time allows in the coming days. > > The first patch reflects the output of a

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: fix -pgc and -pg options

2024-03-04 Thread Marth64
Looks like v2 made it in. All good here. Thanks, Stefano ! On Mon, Mar 4, 2024 at 3:43 AM Stefano Sabatini wrote: > On date Monday 2024-03-04 10:24:42 +0100, Stefano Sabatini wrote: > > On date Saturday 2024-03-02 20:29:13 -0600, Marth64 wrote: > > > In merged DVD patch, -pgc and -pg options

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

2024-03-04 Thread Matthieu Bouron
On Mon, Mar 4, 2024 at 4:11 PM Matthieu Bouron wrote: > > On Mon, Mar 4, 2024 at 12:29 PM Andreas Rheinhardt > wrote: > > > > Matthieu Bouron: > > > This will allow users to pass the Android ApplicationContext which is > > > mandatory > > > to retrieve the ContentResolver responsible to

Re: [FFmpeg-devel] [PATCH 1/4] avformat/aviobuf: Move code specific to URLContexts to avio.c

2024-03-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This separates the URL-layer adjacent parts of the code > from the parts that are also usable with custom IO. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/avio.c| 191 +- > libavformat/aviobuf.c | 186

[FFmpeg-devel] [PATCH 1/2] lavfi: deprecate avfilter_link_free()

2024-03-04 Thread Anton Khirnov
It never makes sense for this function to be called by users. --- libavfilter/avfilter.c | 11 +-- libavfilter/avfilter.h | 5 - libavfilter/version_major.h | 1 + 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/libavfilter/avfilter.c

[FFmpeg-devel] [PATCH 2/2] lavfi: deprecate avfilter_config_links()

2024-03-04 Thread Anton Khirnov
It never makes sense for this function to be called by users. --- libavfilter/avfilter.c | 8 ++-- libavfilter/avfilter.h | 8 +++- libavfilter/avfiltergraph.c | 2 +- libavfilter/f_streamselect.c | 2 +- libavfilter/internal.h | 8 5 files changed, 19

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

2024-03-04 Thread Matthieu Bouron
On Mon, Mar 4, 2024 at 12:29 PM Andreas Rheinhardt wrote: > > Matthieu Bouron: > > This will allow users to pass the Android ApplicationContext which is > > mandatory > > to retrieve the ContentResolver responsible to resolve/open Android > > content-uri. > > --- > > libavcodec/jni.c | 40

[FFmpeg-devel] [PATCH] lavc: move AVCodecContext.pts_correction* to DecodeContext

2024-03-04 Thread Anton Khirnov
These fields are documented to be non-public and are only used in decode.c --- libavcodec/avcodec.h | 10 -- libavcodec/decode.c | 37 ++--- 2 files changed, 22 insertions(+), 25 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-04 Thread Derek Buitenhuis
On 3/4/2024 1:06 PM, Anton Khirnov wrote: > +/** > + * Decoding only. May be set by the caller before avcodec_open2() to an > + * av_malloc()'ed array (or via AVOptions). Owned and freed by the > decoder > + * afterwards. > + * > + * By default, when some side data type is

[FFmpeg-devel] [PATCH v5 3/3] fate/flvenc: support enhanced flv PacketTypeMetadata

2024-03-04 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- tests/fate/lavf-container.mak| 2 ++ tests/ref/fate/enhanced-flv-hevc | 4 ++-- tests/ref/fate/enhanced-flv-vp9 | 4 ++-- tests/ref/lavf-fate/hevc.flv | 3 +++ 4 files changed, 9 insertions(+), 4

[FFmpeg-devel] [PATCH v5 2/3] avformat/flvenc: support enhanced flv PacketTypeMetadata

2024-03-04 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- libavformat/flvenc.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index f6d10f331c..261e5d800c 100644 ---

[FFmpeg-devel] [PATCH v5 1/3] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-03-04 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- libavformat/flvdec.c | 177 ++- 1 file changed, 176 insertions(+), 1 deletion(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index e25b5bd163..2a0aec7291

Re: [FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-03-04 Thread Andreas Rheinhardt
Anton Khirnov: > From: Niklas Haas > > For consistency, even though this cannot be overriden at the packet > level. > --- > libavcodec/mpeg12dec.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c >

Re: [FFmpeg-devel] [PATCH 06/29] lavu/opt: add array options

2024-03-04 Thread Andreas Rheinhardt
Anton Khirnov: > --- > doc/APIchanges| 3 + > libavutil/opt.c | 362 +- > libavutil/opt.h | 62 +++- > libavutil/tests/opt.c | 51 ++ > tests/ref/fate/opt| 35 +++- > 5 files changed, 468 insertions(+), 45 deletions(-) >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dovi_rpu: implement support for profile 10

2024-03-04 Thread Niklas Haas
On Mon, 04 Mar 2024 14:06:51 +0100 Andreas Rheinhardt wrote: > Niklas Haas: > > From: Niklas Haas > > > > Instead of the nal_prefix, this profile inside wraps the RPU inside an > > EMDF header, as specified in ETSI TS 102 366. This particular usage is > > supposedly specified in ETSI TS 103

[FFmpeg-devel] [PATCH 29/29] tests/fate/matroska: add tests for side data preference

2024-03-04 Thread Anton Khirnov
Cf. #10857 --- tests/fate/matroska.mak | 6 + tests/ref/fate/matroska-side-data-pref-codec | 255 ++ tests/ref/fate/matroska-side-data-pref-global | 255 ++ 3 files changed, 516 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH 16/29] avcodec/mjpegdec: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas --- libavcodec/mjpegdec.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 81f724d230..43b36d0a8f 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@ -2840,16 +2840,18 @@

[FFmpeg-devel] [PATCH 21/29] avcodec/libdav1d: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas Signed-off-by: Anton Khirnov --- libavcodec/libdav1d.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 78a5c63bf4..3714137ed0 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@ -561,8

[FFmpeg-devel] [PATCH 22/29] avcodec/dpx: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas If the time code side data is overridden by the packet level, we also make sure not to update `p->metadata` to a mismatched timecode. --- libavcodec/dpx.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/libavcodec/dpx.c

[FFmpeg-devel] [PATCH 24/29] avcodec/h2645_sei: use ff_frame_new_side_data_from_buf

2024-03-04 Thread Anton Khirnov
From: Niklas Haas For consistency, even though this cannot be overriden at the packet level. Signed-off-by: Anton Khirnov --- libavcodec/h2645_sei.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c index

[FFmpeg-devel] [PATCH 27/29] avcodec/hevcdec: switch to ff_frame_new_side_data_from_buf

2024-03-04 Thread Anton Khirnov
From: Niklas Haas For consistency, even though this cannot be overriden at the packet level. Signed-off-by: Anton Khirnov --- libavcodec/hevcdec.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index

[FFmpeg-devel] [PATCH 28/29] lavc/*dec: use side data preference for mastering display/content light metadata

2024-03-04 Thread Anton Khirnov
--- libavcodec/av1dec.c| 46 +++- libavcodec/h2645_sei.c | 96 +++--- libavcodec/libdav1d.c | 47 - libavcodec/pngdec.c| 54 ++-- libavcodec/qsvdec.c| 50 +- 5 files

[FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-03-04 Thread Anton Khirnov
From: Niklas Haas For consistency, even though this cannot be overriden at the packet level. --- libavcodec/mpeg12dec.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 3a2f17e508..aa116336dd 100644 ---

[FFmpeg-devel] [PATCH 26/29] avcodec/mjpegdec: use ff_frame_new_side_data

2024-03-04 Thread Anton Khirnov
From: Niklas Haas For consistency, even though this can't (yet) be overriden at the packet level. --- libavcodec/mjpegdec.c | 66 ++- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index

[FFmpeg-devel] [PATCH 18/29] avcodec/pngdec: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas --- libavcodec/pngdec.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 026da30c25..8f409c74b8 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -660,6 +660,7 @@ static int

[FFmpeg-devel] [PATCH 17/29] avcodec/mpeg12dec: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas We only need to consider side data types that may possibly come from the packet. Signed-off-by: Anton Khirnov --- libavcodec/mpeg12dec.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/libavcodec/mpeg12dec.c

[FFmpeg-devel] [PATCH 19/29] avcodec/tiff: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas --- libavcodec/tiff.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 71cb703821..cb4d378753 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1706,11 +1706,11 @@ static int

[FFmpeg-devel] [PATCH 20/29] avcodec/webp: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas --- libavcodec/webp.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 54b3fde6dc..9308ea2b69 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -1500,11 +1500,16 @@ exif_end:

[FFmpeg-devel] [PATCH 25/29] avcodec/snowdec: use ff_frame_new_side_data

2024-03-04 Thread Anton Khirnov
From: Niklas Haas For consistency, even though this cannot be overriden at the packet level. --- libavcodec/snowdec.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/snowdec.c b/libavcodec/snowdec.c index 70fbab9a49..97aea748b6 100644 ---

[FFmpeg-devel] [PATCH 04/29] lavu/opt: factor per-type dispatch out of av_opt_copy()

2024-03-04 Thread Anton Khirnov
Will be useful in following commits. --- libavutil/opt.c | 89 ++--- 1 file changed, 48 insertions(+), 41 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 051a121331..d18a1c63b7 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@

[FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-04 Thread Anton Khirnov
This and the following commits fix #10857 --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 20 libavcodec/decode.c| 36 libavcodec/options_table.h | 13 + 4 files changed, 72 insertions(+) diff

[FFmpeg-devel] [PATCH 13/29] lavc/hevcdec: pass an actual codec context to ff_h2645_sei_to_frame()

2024-03-04 Thread Anton Khirnov
Needed by following commit. --- libavcodec/hevcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index b5311ae510..17c6a9212f 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -2778,7 +2778,7 @@ static int

[FFmpeg-devel] [PATCH 14/29] avcodec/hevcdec: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas If the time code side data is overridden by the packet level, we also make sure not to update `out->metadata` to a mismatched timecode. Signed-off-by: Anton Khirnov --- libavcodec/hevcdec.c | 40 +--- 1 file changed, 21 insertions(+), 19

[FFmpeg-devel] [PATCH 09/29] lavc: add content light/mastering display side data wrappers

2024-03-04 Thread Anton Khirnov
--- libavcodec/decode.c | 25 + libavcodec/decode.h | 21 + 2 files changed, 46 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index f3e8b72be7..105c9c5c39 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -35,6 +35,7

[FFmpeg-devel] [PATCH 05/29] lavu/opt: distinguish between native and foreign access for AVOption fields

2024-03-04 Thread Anton Khirnov
Native access is from the code that declared the options, foreign access is from code that is using the options. Forbid foreign access to AVOption.offset/default_val, for which there is no good reason, and which should allow us more freedom in extending their semantics in a compatible way. ---

[FFmpeg-devel] [PATCH 12/29] avcodec/h264_slice: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas If the time code side data is overridden by the packet level, we also make sure not to update `out->metadata` to a mismatched timecode. --- libavcodec/h264_slice.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git

[FFmpeg-devel] [PATCH 15/29] avcodec/libjxldec: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas Also fixes a memory leak where the side data was previously not properly cleaned up on OOM. Signed-off-by: Anton Khirnov --- libavcodec/libjxldec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/libjxldec.c b/libavcodec/libjxldec.c

[FFmpeg-devel] [PATCH 10/29] avcodec/av1dec: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas --- libavcodec/av1dec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 704b9d6298..af80ee0b17 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -954,8 +954,9 @@ static int

[FFmpeg-devel] [PATCH 11/29] avcodec/cri: respect side data preference

2024-03-04 Thread Anton Khirnov
From: Niklas Haas This function was already ignoring OOM errors. --- libavcodec/cri.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cri.c b/libavcodec/cri.c index c4eb468610..990e52ac99 100644 --- a/libavcodec/cri.c +++ b/libavcodec/cri.c @@ -398,8 +398,8 @@

[FFmpeg-devel] [PATCH 06/29] lavu/opt: add array options

2024-03-04 Thread Anton Khirnov
--- doc/APIchanges| 3 + libavutil/opt.c | 362 +- libavutil/opt.h | 62 +++- libavutil/tests/opt.c | 51 ++ tests/ref/fate/opt| 35 +++- 5 files changed, 468 insertions(+), 45 deletions(-) diff --git a/doc/APIchanges

[FFmpeg-devel] [PATCH 08/29] avcodec: add internal side data wrappers

2024-03-04 Thread Anton Khirnov
From: Niklas Haas The signature of these wrappers is more complicated due to a need to distinguish between "failed allocating side data" and "side data was already present". Signed-off-by: Anton Khirnov --- libavcodec/decode.c | 66 +

[FFmpeg-devel] [PATCH 02/29] lavu/opt: factor per-type dispatch out of av_opt_set()

2024-03-04 Thread Anton Khirnov
Will be useful in following commits. --- libavutil/opt.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index dac00478ee..b372c76120 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -494,13 +494,11

[FFmpeg-devel] [PATCH 03/29] libavutil/opt: rework figuring out option sizes

2024-03-04 Thread Anton Khirnov
Replace the opt_size() function, currently only called from av_opt_copy(), with * a constant array of element sizes * a function that signals whether an option type is POD (i.e. memcpyable) or not Will be useful in following commits. --- libavutil/opt.c | 100

[FFmpeg-devel] [PATCH 01/29] lavu/opt: factor per-type dispatch out of av_opt_get()

2024-03-04 Thread Anton Khirnov
Will be useful in following commits. --- libavutil/opt.c | 220 ++-- 1 file changed, 121 insertions(+), 99 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index d68184c2cc..dac00478ee 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dovi_rpu: implement support for profile 10

2024-03-04 Thread Andreas Rheinhardt
Niklas Haas: > From: Niklas Haas > > Instead of the nal_prefix, this profile inside wraps the RPU inside an > EMDF header, as specified in ETSI TS 102 366. This particular usage is > supposedly specified in ETSI TS 103 572, at least according to European > Patent EP 3 588 964 A1, but I could not

[FFmpeg-devel] [PATCH 2/2] avcodec/hq_hqa: Make VLC tables static

2024-03-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/hq_hqa.c | 35 +-- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git a/libavcodec/hq_hqa.c b/libavcodec/hq_hqa.c index 510a66fd91..096fb65dc7 100644 --- a/libavcodec/hq_hqa.c +++ b/libavcodec/hq_hqa.c @@

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: fix boundary strength when IBC involved

2024-03-04 Thread Nuo Mi
On Sat, Mar 2, 2024 at 10:05 PM Nuo Mi wrote: > The following cases should set bs to 1: > If the prediction modes are not the same. > If both prediction modes are MODE_IBC, but the motion vector delta is > larger than 8 of 1/16 pixels. > see 8.8.3.5 > > How to reproduce it: > vvencapp -i

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: fix undefined behaviours for derive_affine_mvc

2024-03-04 Thread Nuo Mi
On Sun, Mar 3, 2024 at 10:04 PM Nuo Mi wrote: > libavcodec/vvc/vvc_inter.c:823:18: runtime error: signed integer overflow: > 1426128896 + 1426128896 cannot be represented in type 'int' > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior > libavcodec/vvc/vvc_inter.c:823:18 > > Suggested-by:

[FFmpeg-devel] [PATCH 1/2] avcodec/hq_hqadata: Move data in a header

2024-03-04 Thread Andreas Rheinhardt
It is only used by hq_hqa.c, so said header can simply be included there. Also move the code to initialize the VLCs to hq_hqa.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 3 +- libavcodec/hq_hqa.c | 39 +++

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dovi_rpu: implement support for profile 10

2024-03-04 Thread Niklas Haas
On Sun, 25 Feb 2024 12:44:49 +0100 Niklas Haas wrote: > From: Niklas Haas > > Instead of the nal_prefix, this profile inside wraps the RPU inside an > EMDF header, as specified in ETSI TS 102 366. This particular usage is > supposedly specified in ETSI TS 103 572, at least according to European

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

2024-03-04 Thread Andreas Rheinhardt
Matthieu Bouron: > This will allow users to pass the Android ApplicationContext which is > mandatory > to retrieve the ContentResolver responsible to resolve/open Android > content-uri. > --- > libavcodec/jni.c | 40 > libavcodec/jni.h | 17

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils: Inline print_error()

2024-03-04 Thread Stefano Sabatini
On date Sunday 2024-03-03 23:46:24 +0100, Andreas Rheinhardt wrote: > It is only used by ffprobe (once) and ffplay (twice); > inlining it avoids including it unnecessarily into ffmpeg. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/cmdutils.c | 5 - > fftools/cmdutils.h | 5 - >

Re: [FFmpeg-devel] [PATCH] doc/demuxers: emphasize that DVD demuxer does not do decryption

2024-03-04 Thread Stefano Sabatini
On date Sunday 2024-03-03 14:49:36 -0600, Marth64 wrote: > Signed-off-by: Marth64 > --- > doc/demuxers.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/demuxers.texi b/doc/demuxers.texi > index 905828d852..f4bac8f3b3 100644 > --- a/doc/demuxers.texi > +++ b/doc/demuxers.texi

Re: [FFmpeg-devel] [PATCH 1/8 v2] fftools/ffprobe: add support for Stream Groups

2024-03-04 Thread Stefano Sabatini
On date Sunday 2024-03-03 15:09:19 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > doc/ffprobe.xsd | 1 + > fftools/ffprobe.c | 145 -- > tests/ref/fate/cavs-demux | 2 +- >

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-04 Thread Vittorio Giovara
On Mon, Mar 4, 2024 at 1:57 AM Michael Niedermayer wrote: > On Sun, Mar 03, 2024 at 03:49:33AM +0100, Michael Niedermayer wrote: > [...] > > > +If a TC member is aware of a conflict of interest with regards to the > case, they must announce it > > +and recuse themselves from the TC discussion

  1   2   >