Re: [FFmpeg-devel] [PATCH] doc/community: rule to avoid conflict of interest and prejudice in TC

2024-03-21 Thread Gyan Doshi
Ping. Anton announced to have a vote on 4th Mar for changing the rule [1]. That's long past. It is holding up the consideration of the matter I raised [2] to the TC. Regards, Gyan [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2024-March/322464.html [2]:

Re: [FFmpeg-devel] [RFC] Channels

2024-03-21 Thread James Almer
On 3/21/2024 11:25 PM, Michael Niedermayer wrote: Hi all we have code like st->codecpar->ch_layout.nb_channels = avio_rb32(pb); and then somewhere there is some code that uses this by first allocating an array and that then hits OOM (it was this here: map = av_calloc(nb_channels,

[FFmpeg-devel] [RFC] Channels

2024-03-21 Thread Michael Niedermayer
Hi all we have code like st->codecpar->ch_layout.nb_channels = avio_rb32(pb); and then somewhere there is some code that uses this by first allocating an array and that then hits OOM (it was this here: map = av_calloc(nb_channels, sizeof(*channel_layout->u.map));) is anyone against adding a

Re: [FFmpeg-devel] [PATCH] doc: Add libtoch backend option to dnn_processing

2024-03-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > wenbin.chen-at-intel@ffmpeg.org > Sent: Thursday, March 21, 2024 2:51 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] doc: Add libtoch backend option to > dnn_processing > > From: Wenbin Chen > >

Re: [FFmpeg-devel] [PATCH v2] configure: Explicitly check for static_assert

2024-03-21 Thread Andreas Rheinhardt
Martin Storsjö: > On Thu, 21 Mar 2024, Andreas Rheinhardt wrote: > >> Andreas Rheinhardt: >>> C11 provides static assertions via _Static_assert and >>> provides static_assert as a convenience define for this >>> in assert.h. MSVC 19.27 declares support for C11, but does >>> not support

Re: [FFmpeg-devel] [PATCH v2] configure: Explicitly check for static_assert

2024-03-21 Thread Martin Storsjö
On Thu, 21 Mar 2024, Andreas Rheinhardt wrote: Andreas Rheinhardt: C11 provides static assertions via _Static_assert and provides static_assert as a convenience define for this in assert.h. MSVC 19.27 declares support for C11, but does not support _Static_assert, but somehow supports

Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-03-21 Thread Paul B Mahol
On Wed, Mar 20, 2024 at 11:55 PM Yiğithan Yiğit wrote: > > > On Mar 21, 2024, at 12:10 AM, Paul B Mahol wrote: > > > > Why? This is pointless. > > > > volumedetect have histogram output, float patch does not have it at all. > > Use astats filter. > > > > On Wed, Mar 20, 2024 at 9:47 PM Yiğithan

[FFmpeg-devel] [PATCH] avformat/jpegxl_anim_dec: set pos for generic index

2024-03-21 Thread Leo Izen
avpkt->pos needs to be set for generic indexing or features such as the stream_loop option will not work. Co-authored-by: Andreas Rheinhardt Signed-off-by: Leo Izen --- libavformat/jpegxl_anim_dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/jpegxl_anim_dec.c

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection

2024-03-21 Thread Rémi Denis-Courmont
Le torstaina 21. maaliskuuta 2024, 15.01.09 EET Ignjatović, Lazar (RS) a écrit : > > Your MR makes even less sense for multicast. For multicast there is no > > local address to match to an interface. So you just have to have the > > interface specified explicitly in addition to the LL group

Re: [FFmpeg-devel] [PATCH v2] configure: Explicitly check for static_assert

2024-03-21 Thread Andreas Rheinhardt
Andreas Rheinhardt: > C11 provides static assertions via _Static_assert and > provides static_assert as a convenience define for this > in assert.h. MSVC 19.27 declares support for C11, but does > not support _Static_assert, but somehow supports > static_assert. That's therefore what we use. > >

[FFmpeg-devel] [PATCH v2] configure: Explicitly check for static_assert

2024-03-21 Thread Andreas Rheinhardt
C11 provides static assertions via _Static_assert and provides static_assert as a convenience define for this in assert.h. MSVC 19.27 declares support for C11, but does not support _Static_assert, but somehow supports static_assert. That's therefore what we use. But apparently there are some old

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: fix setting HEVCHdrParams fields

2024-03-21 Thread Lynne
Mar 21, 2024, 00:17 by jamr...@gmail.com: > These were defined in a way compatible with the Vulkan HEVC acceleration, > which > expects bitmasks, yet the fields were being overwritting on each loop with the > latest read value. > > Signed-off-by: James Almer > --- > libavcodec/hevc_ps.c |

[FFmpeg-devel] [PATCH] [v4] avcodec/vaapi_encode: add customized surface alignment

2024-03-21 Thread Araz Iusubov
This commit fixes issues with AMD HEVC encoding. By default AMD hevc encoder asks for the alignment 64x16, while FFMPEG VAAPI has 16x16. Adding support for customized surface size from VASurfaceAttribAlignmentSize in VAAPI version 1.21.0 Signed-off-by: Araz Iusubov ---

Re: [FFmpeg-devel] [PATCH v7 1/5] avformat/subtitles: extend ff_subtitles_queue_insert() to support empty events

2024-03-21 Thread Marth64
Thank you Andreas, for walking me through this in detail. I will update accordingly and test. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH v7 1/5] avformat/subtitles: extend ff_subtitles_queue_insert() to support empty events

2024-03-21 Thread Andreas Rheinhardt
Marth64: > If ff_subtitles_queue_insert() were to given a NULL buffer > with 0 length, it would still attempt to grow the packet > or memcpy depending on if merge option is enabled. > > In this commit, consider a NULL buffer with 0 length as > an empty event and do not attempt to modify the

Re: [FFmpeg-devel] [PATCH v7 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-21 Thread Andreas Rheinhardt
Marth64: > RCWT (Raw Captions With Time) is a format native to ccextractor, > a commonly used OSS tool for processing 608/708 Closed Captions (CC). > RCWT can be used to archive the original extracted CC bitstream. > The muxer was added in January 2024. In this commit, add the demuxer. > > One

[FFmpeg-devel] [PATCH] configure: Explicitly check for static_assert

2024-03-21 Thread Andreas Rheinhardt
C11 provides static assertions via _Static_assert and provides static_assert as a convenience define for this in assert.h. MSVC 19.27 declares support C11, but does not support _Static_assert, but somehow supports static_assert. That's therefore what we use. But apparently there are some old GCC

[FFmpeg-devel] [PATCH] [FFmpeg-devel, v3] avcodec/vaapi_encode: add customized surface alignment

2024-03-21 Thread Araz Iusubov
This commit fixes issues with AMD HEVC encoding. By default AMD hevc encoder asks for the alignment 64x16, while FFMPEG VAAPI has 16x16. Adding support for customized surface size from VASurfaceAttribAlignmentSize in VAAPI version 1.21.0 Signed-off-by: Araz Iusubov ---

Re: [FFmpeg-devel] [PATCH v6] avcodec/libx264: fix extradata when config annexb=0

2024-03-21 Thread Zhao Zhili
Ping. Will apply this week if no more comments. > -Original Message- > From: ffmpeg-devel On Behalf Of Zhao Zhili > Sent: 2024年3月17日 11:35 > To: ffmpeg-devel@ffmpeg.org > Cc: Zhao Zhili > Subject: [FFmpeg-devel] [PATCH v6] avcodec/libx264: fix extradata when config > annexb=0 > >

[FFmpeg-devel] [PATCH] [FFmpeg-devel, v2] avcodec/vaapi_encode: add customized surface alignment

2024-03-21 Thread Araz Iusubov
This commit fixes issues with AMD HEVC encoding. By default AMD hevc encoder asks for the alignment 64x16, while FFMPEG VAAPI has 16x16. Adding support for customized surface size from VASurfaceAttribAlignmentSize in VAAPI version 1.21.0 Signed-off-by: Araz Iusubov ---

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000htdec: Check M_b / magp before using it in a shift

2024-03-21 Thread Tomas Härdin
ons 2024-03-20 klockan 21:35 +0100 skrev Tomas Härdin: > ons 2024-03-20 klockan 14:12 +0100 skrev Michael Niedermayer: > > On Wed, Mar 20, 2024 at 12:20:11PM +0100, Tomas Härdin wrote: > > > ons 2024-03-20 klockan 03:59 +0100 skrev Michael Niedermayer: > > > > Fixes: shift exponent -1 is negative

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: Avoid avio_write(pb, "", 0)

2024-03-21 Thread Kieran Kunhya
On Thu, 21 Mar 2024 at 13:13, Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Andreas Rheinhardt: > > When the compiler chooses to inline put_amf_string(pb, ""), > > the avio_write(pb, "", 0) can be avoided. Happens with > > Clang-17 with -O1 and higher and GCC 13 with -O2 and

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: Avoid avio_write(pb, "", 0)

2024-03-21 Thread Andreas Rheinhardt
Andreas Rheinhardt: > When the compiler chooses to inline put_amf_string(pb, ""), > the avio_write(pb, "", 0) can be avoided. Happens with > Clang-17 with -O1 and higher and GCC 13 with -O2 and higher > here. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/flvenc.c | 2 ++ > 1 file

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection

2024-03-21 Thread RS
> Your MR makes even less sense for multicast. For multicast there is no local > address to match to an interface. So you just have to have the interface > specified explicitly in addition to the LL group address. This is true for > both egress and ingress. I've compared ffmpeg 5.1.2 against

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: allocate only the required HEVCHdrParams within a VPS

2024-03-21 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavcodec/hevc_ps.c | 14 +- > libavcodec/hevc_ps.h | 2 +- > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c > index fb997066d9..d29cf9f372 100644 > ---

[FFmpeg-devel] [PATCH] avcodec/hevc_ps: allocate only the required HEVCHdrParams within a VPS

2024-03-21 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc_ps.c | 14 +- libavcodec/hevc_ps.h | 2 +- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index fb997066d9..d29cf9f372 100644 --- a/libavcodec/hevc_ps.c +++

[FFmpeg-devel] [PATCH 2/2] avformat/demux: Combine "Packet corrupt" logmessages

2024-03-21 Thread Andreas Rheinhardt
Otherwise these statements might be torn apart by av_logs from other threads. Signed-off-by: Andreas Rheinhardt --- libavformat/demux.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index 4345ed4c8c..e50d1a9cfe 100644 ---

[FFmpeg-devel] [PATCH 1/2] avformat/demux: Restore pkt->stream_index assert check

2024-03-21 Thread Andreas Rheinhardt
It has been moved after "st = s->streams[pkt->stream_index]" in b140b8332c617b0eef4f872f3ef90c469e99920f. Deduplicate ff_read_packet() and ff_buffer_packet() while fixing this. This also fixes shadowing in ff_read_packet(). Signed-off-by: Andreas Rheinhardt --- libavformat/demux.c | 75

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: allocate only the required HEVCHdrParams within a VPS

2024-03-21 Thread Andreas Rheinhardt
James Almer: > On 3/21/2024 8:15 AM, Andreas Rheinhardt wrote: >> James Almer: >>> Signed-off-by: James Almer >>> --- >>>   libavcodec/hevc_ps.c | 17 +++-- >>>   libavcodec/hevc_ps.h |  2 +- >>>   libavcodec/vulkan_hevc.c |  2 +- >>>   3 files changed, 17 insertions(+), 4

Re: [FFmpeg-devel] [PATCH v4 00/13] AFGS1 film grain support

2024-03-21 Thread Niklas Haas
On Mon, 18 Mar 2024 17:54:08 +0100 Niklas Haas wrote: > Changes since v3: > > - Moved metadata into common AVFilmGrainParams struct, as per James > Almer's recommendation > - Fixed width/height field validation > - Signal this metadata for AV1 (instead of setting it to unspecified) > -

Re: [FFmpeg-devel] [PATCH 1/4] fftools/ffmpeg_enc: strip DOVI config record for AV1

2024-03-21 Thread Niklas Haas
On Thu, 21 Mar 2024 11:16:57 +0100 Anton Khirnov wrote: > Quoting Niklas Haas (2024-03-19 20:16:39) > > From: Niklas Haas > > > > AV1 streams don't use configuration records, so delete them when > > encoding to AV1. Ideally this would be, as the comment suggests, handled > > at the frame-level

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: allocate only the required HEVCHdrParams within a VPS

2024-03-21 Thread James Almer
On 3/21/2024 8:15 AM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavcodec/hevc_ps.c | 17 +++-- libavcodec/hevc_ps.h | 2 +- libavcodec/vulkan_hevc.c | 2 +- 3 files changed, 17 insertions(+), 4 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/libx265: encode dovi RPUs

2024-03-21 Thread Niklas Haas
On Tue, 19 Mar 2024 19:19:29 -0400 Vittorio Giovara wrote: > On Tue, Mar 19, 2024 at 7:04 PM Niklas Haas wrote: > > > On Tue, 19 Mar 2024 21:59:53 + Cosmin Stejerean via ffmpeg-devel < > > ffmpeg-devel@ffmpeg.org> wrote: > > > > > > > > > > On Mar 19, 2024, at 2:39 PM, Derek Buitenhuis < >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/libx265: encode dovi RPUs

2024-03-21 Thread Niklas Haas
On Wed, 20 Mar 2024 23:22:03 +0200 Jan Ekström wrote: > On Wed, Mar 20, 2024 at 9:30 PM Michael Niedermayer > wrote: > > > > On Tue, Mar 19, 2024 at 08:16:42PM +0100, Niklas Haas wrote: > > > From: Niklas Haas > > > > > > libx265 supports these natively, we just need to forward them to the > >

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: allocate only the required HEVCHdrParams within a VPS

2024-03-21 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavcodec/hevc_ps.c | 17 +++-- > libavcodec/hevc_ps.h | 2 +- > libavcodec/vulkan_hevc.c | 2 +- > 3 files changed, 17 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c > index

Re: [FFmpeg-devel] [PATCH 2/2] avformat/riffdec: follow the MS docs more strictly for setting wav channel layouts

2024-03-21 Thread Tobias Rapp
On 21/03/2024 10:40, Marton Balint wrote: On Thu, 21 Mar 2024, Tobias Rapp wrote: On 19/03/2024 20:14, Marton Balint wrote:  On Tue, 19 Mar 2024, Michael Niedermayer wrote:  On Sun, Mar 17, 2024 at 08:57:29PM +0100, Marton Balint wrote:  - Only parse the defined masks in

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: add loopback decoding

2024-03-21 Thread Anton Khirnov
Quoting Gyan Doshi (2024-03-15 05:12:41) > > > On 2024-03-14 03:46 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2024-03-13 08:49:52) > > > >> Are there any limitations to loopback decoding e.g. would a vpx w/alpha > >> encode be decoded back to a alpha pix fmt? > > I don't know how vpx alpha

Re: [FFmpeg-devel] [PATCH 1/4] fftools/ffmpeg_enc: strip DOVI config record for AV1

2024-03-21 Thread Anton Khirnov
Quoting Niklas Haas (2024-03-19 20:16:39) > From: Niklas Haas > > AV1 streams don't use configuration records, so delete them when > encoding to AV1. Ideally this would be, as the comment suggests, handled > at the frame-level (and stripped by the av1 encoder), but given the > status quo of

[FFmpeg-devel] [PATCH] V2 tests/fate/filter-audio.mak: add test for ATEMPO audio filter

2024-03-21 Thread Rajiv Harlalka
Please find an updated patch for tests on the atempo audio filter From 30475d6f076d5236ee534002fffb01958ef0dfc1 Mon Sep 17 00:00:00 2001 From: Rajiv Harlalka Date: Thu, 21 Mar 2024 13:35:29 +0530 Subject: [PATCH v2] tests/fate/filter-audio.mak: add test for ATEMPO audio filter Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/2] avformat/riffdec: follow the MS docs more strictly for setting wav channel layouts

2024-03-21 Thread Marton Balint
On Thu, 21 Mar 2024, Tobias Rapp wrote: On 19/03/2024 20:14, Marton Balint wrote: On Tue, 19 Mar 2024, Michael Niedermayer wrote: On Sun, Mar 17, 2024 at 08:57:29PM +0100, Marton Balint wrote: - Only parse the defined masks in dwChannelMask, unless strict_std_compliance   is less

Re: [FFmpeg-devel] [PATCH 2/2] avformat/riffdec: follow the MS docs more strictly for setting wav channel layouts

2024-03-21 Thread Tobias Rapp
On 19/03/2024 20:14, Marton Balint wrote: On Tue, 19 Mar 2024, Michael Niedermayer wrote: On Sun, Mar 17, 2024 at 08:57:29PM +0100, Marton Balint wrote: - Only parse the defined masks in dwChannelMask, unless strict_std_compliance   is less than normal. This matches with the behaviour of

Re: [FFmpeg-devel] [PATCH v2] avformat: enable UDP IPv6 multicast interface selection

2024-03-21 Thread Rémi Denis-Courmont
Le 20 mars 2024 14:35:28 GMT+02:00, "Ignjatović, Lazar (RS)" a écrit : > Specifying egress interface is done by setting the > setsockopt(IPV6_MULTICAST_IF) to the value of the interface, not address. On > the other hand v4 for the similar option setsockopt(IP_MULTICAST_IF) sets it > by

[FFmpeg-devel] [PATCH] doc: Add libtoch backend option to dnn_processing

2024-03-21 Thread wenbin . chen-at-intel . com
From: Wenbin Chen Signed-off-by: Wenbin Chen --- doc/filters.texi | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 913365671d..20605e72b2 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -12069,11 +12069,21 @@

[FFmpeg-devel] [PATCH] tests/fate/filter-audio.mak: add test for ATEMPO audio filter

2024-03-21 Thread Rajiv Harlalka
Signed-off-by: Rajiv Harlalka --- tests/fate/filter-audio.mak | 3 ++ tests/ref/fate/filter-atempo | 70 2 files changed, 73 insertions(+) create mode 100644 tests/ref/fate/filter-atempo diff --git a/tests/fate/filter-audio.mak