This filter only had an AVClass and empty options because up until
recently, avfilter_init_str() errored out when options were provided
for a filter without an AVClass. But setting (generic) options is
necessary to take advantage of timeline support. So with
avfilter_init_str() fixed, the AVClass
It is unnecessary, because we use -Wno-maybe-unitialized with GCC
nowadays.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/ac3enc.c| 4 ++--
libavcodec/ac3enc_template.c | 4 ++--
libavcodec/bfi.c | 2 +-
libavcodec/dvdsubenc.c
GCC 9-13 do not emit warnings for this at all optimization
levels even when -Wmaybe-uninitialized is not disabled.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/avfilter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
This filter only had an AVClass and empty options because up until
recently, avfilter_init_str() errored out when options were provided
for a filter without an AVClass. But setting (generic) options is
necessary to take advantage of timeline support. So with
avfilter_init_str() fixed, the AVClass
This filter only had an AVClass and empty options because up until
recently, avfilter_init_str() errored out when options were provided
for a filter without an AVClass. But setting (generic) options is
necessary to take advantage of timeline support. So with
avfilter_init_str() fixed, the AVClass
This filter only had an AVClass and empty options because up until
recently, avfilter_init_str() errored out when options were provided
for a filter without an AVClass. But setting (generic) options is
necessary to take advantage of timeline support. So with
avfilter_init_str() fixed, the AVClass
The documentation for filter arguments states that short options must
precede long options (i.e. those of the form key=value). Yet if
process_options() encounters arguments not abiding by this, it simply
treats short options after a long option as if it were parsing short
options for the first
Signed-off-by: Andreas Rheinhardt
---
libavfilter/avfilter.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
index 856862a393..508fe1b26b 100644
--- a/libavfilter/avfilter.c
+++ b/libavfilter/avfilter.c
@@ -844,6 +844,7
Signed-off-by: Andreas Rheinhardt
---
libavcodec/tiff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
index 1b934457b5..19301d9e49 100644
--- a/libavcodec/tiff.c
+++ b/libavcodec/tiff.c
@@ -176,7 +176,7 @@ static int cmp_id_key(const
Signed-off-by: Andreas Rheinhardt
---
libavcodec/libvpxenc.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c
index 635cdf7a0e..bcbdc4981e 100644
--- a/libavcodec/libvpxenc.c
+++ b/libavcodec/libvpxenc.c
@@ -49,6 +49,9 @@
> On Mar 30, 2024, at 12:21, Andreas Rheinhardt
> wrote:
>
> Andreas Rheinhardt:
Hi Andreas,
>> Besides being redundant, freeing manually is actually harmful here,
>> as rtmp_close() may call gen_fcunpublish_stream() which dereferences
>> rt->playpath.
>>
>> Reported-by: Armin Hasitzka
>>
Andreas Rheinhardt:
> Andreas Rheinhardt:
>> Besides being redundant, freeing manually is actually harmful here,
>> as rtmp_close() may call gen_fcunpublish_stream() which dereferences
>> rt->playpath.
>>
>> Reported-by: Armin Hasitzka
>> Signed-off-by: Andreas Rheinhardt
>> ---
>>
On Sat, Mar 30, 2024 at 10:51 PM Antoine Soulier
wrote:
> I am not sure about the block:
>
>> +lc3->timestamp += lc3->dt;
>> +if (lc3->timestamp > lc3->length) {
>> +pkt->duration -= lc3->timestamp - lc3->length;
>> +lc3->timestamp = lc3->length;
>> +}
>
>
> The
The ffprobe-test file is generated via ffmpeg and several filters;
the requirements for them were missing.
Also deduplicate this while just at it.
Signed-off-by: Andreas Rheinhardt
---
tests/Makefile | 1 +
tests/fate/ffprobe.mak | 40 +---
2 files
It relies on the fate-lavf-flv test.
Signed-off-by: Andreas Rheinhardt
---
tests/fate/api.mak | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/fate/api.mak b/tests/fate/api.mak
index 688fc0f9b3..d2868e57ac 100644
--- a/tests/fate/api.mak
+++ b/tests/fate/api.mak
@@
Several other tests (e.g. concatdec) examine FATE_LAVF_CONTAINER
in order to enable or disable tests that depend on samples
created by the lavf-container tests; right now this procedure
did not account for CONFIG_FFMPEG.
Signed-off-by: Andreas Rheinhardt
---
tests/fate/lavf-container.mak | 2 +-
Signed-off-by: Andreas Rheinhardt
---
tests/fate/libswscale.mak | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tests/fate/libswscale.mak b/tests/fate/libswscale.mak
index f8572f9c37..4c29220e6f 100644
--- a/tests/fate/libswscale.mak
+++ b/tests/fate/libswscale.mak
I am not sure about the block:
> +lc3->timestamp += lc3->dt;
> +if (lc3->timestamp > lc3->length) {
> +pkt->duration -= lc3->timestamp - lc3->length;
> +lc3->timestamp = lc3->length;
> +}
The purpose is to reduce the duration of the last packet.
When converting a
On 3/29/2024 7:01 PM, Marton Balint wrote:
On Sat, 23 Mar 2024, Marton Balint wrote:
Fixes ffplay playback of unknown layouts, when SDL directly supports
the audio
format, such as:
ffplay -f lavfi anullsrc=cl=2C,aformat=s16
Without the patch, "Channel layout change is not supported"
On Sat, Mar 30, 2024 at 02:31:54PM -0300, James Almer wrote:
> On 3/30/2024 2:30 PM, Michael Niedermayer wrote:
> > On Sat, Mar 30, 2024 at 11:51:17AM -0300, James Almer wrote:
> > > On 3/30/2024 11:02 AM, Michael Niedermayer wrote:
> > > > Iam not 100% sure this is the best place to put this. But
On Sat, 30 Mar 2024 at 17:30, Michael Niedermayer
wrote:
> On Sat, Mar 30, 2024 at 11:51:17AM -0300, James Almer wrote:
> > On 3/30/2024 11:02 AM, Michael Niedermayer wrote:
> > > Iam not 100% sure this is the best place to put this. But we should
> somewhere
> > > describe what differences are
Andreas,
On Fri, Mar 29, 2024 at 12:45 PM Andreas Rheinhardt
wrote:
>
> These tests need a scale filter to convert to the prescribed
> pixel format (the native format is endian-dependent).
>
> Signed-off-by: Andreas Rheinhardt
> ---
> And now I will deduplicate this mess...
>
>
On 3/28/2024 1:52 PM, James Almer wrote:
Signed-off-by: James Almer
---
libavutil/frame.c | 19 +++
libavutil/frame.h | 24
2 files changed, 43 insertions(+)
diff --git a/libavutil/frame.c b/libavutil/frame.c
index ef1613c344..87cc8450c8 100644
---
On 3/30/2024 2:30 PM, Michael Niedermayer wrote:
On Sat, Mar 30, 2024 at 11:51:17AM -0300, James Almer wrote:
On 3/30/2024 11:02 AM, Michael Niedermayer wrote:
Iam not 100% sure this is the best place to put this. But we should somewhere
describe what differences are expected
Signed-off-by:
On Sat, Mar 30, 2024 at 11:51:17AM -0300, James Almer wrote:
> On 3/30/2024 11:02 AM, Michael Niedermayer wrote:
> > Iam not 100% sure this is the best place to put this. But we should
> > somewhere
> > describe what differences are expected
> >
> > Signed-off-by: Michael Niedermayer
> > ---
>
> i think the entry for extensions should be removed (which fixes this)
> having a ".bin" is not a strong indication that its rcwt
> Is this blocking or can it be addressed later? Also, if this needs to
> be modified the muxer should be as well.
I can address both today in a new set. .bin is
lör 2024-03-30 klockan 17:02 +0100 skrev Andreas Rheinhardt:
> > > ASS demuxer sorts its packets because
> > > there is no guarantee the text are sorted in the file
> >
> > So? I'm making a normative argument.
> >
>
> Normative about what? The ASS specification [1] explicitly says:
>
> "SSA
Tomas Härdin:
> lör 2024-03-30 klockan 15:49 +0100 skrev Nicolas George:
>> Tomas Härdin (12024-03-30):
>>> Players can implement sorting if they wish.
>>
>> API break.
>
> lavf's API provides no guarantees regarding presentation order
>>
>
>>> Finally I will note that sorting does not happen
Tomas Härdin (12024-03-30):
> lavf's API provides no guarantees regarding presentation order
It used to work, you are about to require new code from applications for
it to work. That is an API break, and pretending otherwise like you do
here is just a cop out.
> "Supposed to" is doing a lot of
On 3/28/2024 9:40 PM, James Almer wrote:
This reverts commit f6b7b473d456a6aa1c063c4261b17277e2c70ac0.
The image in the item boxes and the animation in the trak box are not
necessarely the same, so both should be exported.
Signed-off-by: James Almer
---
libavformat/mov.c | 44
lör 2024-03-30 klockan 15:49 +0100 skrev Nicolas George:
> Tomas Härdin (12024-03-30):
> > Players can implement sorting if they wish.
>
> API break.
lavf's API provides no guarantees regarding presentation order
>
> > Finally I will note that sorting does not happen when subtitles are
> >
On date Saturday 2024-03-30 00:52:12 +0100, Michael Niedermayer wrote:
> On Fri, Mar 29, 2024 at 12:47:53PM +0100, Stefano Sabatini wrote:
> > ---
> > doc/muxers.texi | 16
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/doc/muxers.texi b/doc/muxers.texi
> > index
On date Saturday 2024-03-30 01:23:53 +0100, Michael Niedermayer wrote:
> On Thu, Mar 28, 2024 at 03:11:29PM -0500, Marth64 wrote:
> [...]
>
> > +static int rcwt_probe(const AVProbeData *p)
> > +{
> > +return p->buf_size > RCWT_HEADER_SIZE &&
> > + AV_RB16(p->buf) == 0x
On 3/30/2024 11:02 AM, Michael Niedermayer wrote:
Iam not 100% sure this is the best place to put this. But we should somewhere
describe what differences are expected
Signed-off-by: Michael Niedermayer
---
src/download | 34 ++
1 file changed, 34
Tomas Härdin (12024-03-30):
> Players can implement sorting if they wish.
API break.
> One potential solution is to do this style of parsing when the input is
> non-seekable. But then we have the silly situation where streamed and
> non-streamed behavior differs considerably.
Sure, better break
lör 2024-03-30 klockan 12:44 +0100 skrev Nicolas George:
> Tomas Härdin (12024-03-30):
> > More interesting is fate-sub-srt-badsyntax. Despite the name it
> > doesn't
> > really have bad syntax, but its cues are in a random order. I guess
> > it
> > exists to test the cue sorting logic. But should
Iam not 100% sure this is the best place to put this. But we should somewhere
describe what differences are expected
Signed-off-by: Michael Niedermayer
---
src/download | 34 ++
1 file changed, 34 insertions(+)
diff --git a/src/download b/src/download
index
Andreas Rheinhardt:
> Likely broken in d7a75d21635eab4f4a1efea22945933059c2e36f.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/mips/ac3dsp_mips.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/mips/ac3dsp_mips.c b/libavcodec/mips/ac3dsp_mips.c
> index
On 3/29/2024 5:35 AM, Anton Khirnov wrote:
---
libavformat/movenc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index b97c479cc4..30cfbf6e74 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@
On Fri, Mar 29, 2024 at 6:30 PM Antoine Soulier via ffmpeg-devel <
ffmpeg-devel@ffmpeg.org> wrote:
> A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
> test purpose. This is the format implemented here.
>
> Signed-off-by: Antoine Soulier
> ---
> Changelog
Tomas Härdin (12024-03-30):
> More interesting is fate-sub-srt-badsyntax. Despite the name it doesn't
> really have bad syntax, but its cues are in a random order. I guess it
> exists to test the cue sorting logic. But should subtitle demuxers
> really sort subtitles in this way? We don't do that
On Sat, Mar 30, 2024 at 9:31 AM Tomas Härdin wrote:
> lör 2024-03-30 klockan 00:35 +0100 skrev Michael Niedermayer:
> > breaks fate here:
> >
> > --- ./tests/ref/fate/sub-srt-madness-timeshift 2024-03-29
> > 20:43:34.617419731 +0100
> > +++ tests/data/fate/sub-srt-madness-timeshift 2024-03-30
fre 2024-03-29 klockan 20:32 +0100 skrev Michael Niedermayer:
> This is kind of ugly
> Fixes: signed integer overflow: 255 * 1157565362826411919 cannot be
> represented in type 'long'
> Fixes: 67313/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-
> 6250434245230592
>
> Found-by: continuous
fre 2024-03-29 klockan 20:32 +0100 skrev Michael Niedermayer:
> Fixes: shift exponent -1 is negative
> Fixes: 65378/clusterfuzz-testcase-minimized-
> ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5457678193197056
>
> Found-by: continuous fuzzing process
>
lör 2024-03-30 klockan 00:35 +0100 skrev Michael Niedermayer:
> breaks fate here:
>
> --- ./tests/ref/fate/sub-srt-madness-timeshift 2024-03-29
> 20:43:34.617419731 +0100
> +++ tests/data/fate/sub-srt-madness-timeshift 2024-03-30
Sorry but this file is utter crap and shouldn't be part of
45 matches
Mail list logo
