Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

2018-03-21 Thread Courtland Idstrom
> > > Any way of verifying will do, even a hex editor. > > Output from Quicktime (screenshot of the movie inspector -- initial movie was created in ffmpeg, title added in quicktime, file saved: https://imgur.com/a/TPCkN) 00308ef0 00 00 00 21 75 64 74 61 00 00 00 15 6e 61 6d 65 |...!udta

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

2018-03-20 Thread Courtland Idstrom
> > > I am OK with the patch so long as it matches the behavior of how > QuickTime > > Pro (or FCP) creates files, as those are the normative references, more > > or less. > > +1 > What can I do to facilitate this? Would it help to create a couple of samples from QuickTime Pro, and perhaps show

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

2018-03-19 Thread Courtland Idstrom
> > Are you sure this is correct? The links above describe '©nam' as the > title of the content, and 'name' as 'Name of Object", whatever that is > supposed to mean. > From the spec, '©nam' appears to be a localized entry, which can also be set per-track in Quicktime (exposed via their

[FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

2018-03-19 Thread Courtland Idstrom
Track title (atom 'name') is a well defined user data atom for mov files. Existing code (for mp4) only writes title metadata if present. Relevant reference docs:

Re: [FFmpeg-devel] [PATCH] mov: add channel label support

2018-03-17 Thread Courtland Idstrom
> > > fixes channels such as DL/DR, which will now write to > LeftTotal/RightTotal > Is this correct? To the best of my understanding, this is correct; however, I'm by no means an expert on this subject, so I'd love to know if I'm wrong here. The flip-side for reading MOVs is already implemented

Re: [FFmpeg-devel] [PATCH 1/2] Add option -movflags write_track_title which will write track title metadata. This is useful in conjunction with the metadata flag to specify track title, especially for

2018-03-17 Thread Courtland Idstrom
> > > From my reading of this, the 'udta' atom can appear as a child of a > 'trak' > > atom, and can have an optional child 'name', > > Then why is it optional? > I've made this an optional movflag in attempt to be extra careful. I'm new to this code-base and am err-ing on the side of caution.

Re: [FFmpeg-devel] [PATCH 1/2] Add option -movflags write_track_title which will write track title metadata. This is useful in conjunction with the metadata flag to specify track title, especially for

2018-03-17 Thread Courtland Idstrom
wrote: > 2018-03-17 3:26 GMT+01:00, Courtland Idstrom <cidst...@telltalegames.com>: > > Example: > > ffmpeg -i in.mov -movflags write_track_title -metadata:s:a:0 > > title="Eng-FullMix" > > Is this defined by the QuickTime specification? > &g

Re: [FFmpeg-devel] [PATCH 2/2] add to changelog

2018-03-17 Thread Courtland Idstrom
? Thanks -Courtland On Sat, Mar 17, 2018 at 6:22 AM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-03-17 3:26 GMT+01:00, Courtland Idstrom <cidst...@telltalegames.com>: > > --- > > Changelog | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[FFmpeg-devel] MOV: center channel 'chan' metadata

2018-03-16 Thread Courtland Idstrom
Hi - I'm working with a post-production workflow to mux 5.1 wav audio into a mov file (each channel specified as a separate track), with correct channel assignments written as metadata. I'm able to get everything except for the Center channel to appear correctly when viewed in Quicktime, however

[FFmpeg-devel] [PATCH] mov: add channel label support

2018-03-16 Thread Courtland Idstrom
Adds the ability to support writing channel labels to mov files if the layout_tag fails, instead of printing a warning and skipping the tag. This fixes channels such as DL/DR, which will now write to LeftTotal/RightTotal instead of omitting the channel tag. --- Changelog | 1 +

[FFmpeg-devel] [PATCH 2/2] add to changelog

2018-03-16 Thread Courtland Idstrom
--- Changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Changelog b/Changelog index 7969b414c4..32a93d916a 100644 --- a/Changelog +++ b/Changelog @@ -47,7 +47,7 @@ version : - native SBC encoder and decoder - drmeter audio filter - hapqa_extract bitstream filter - +-

[FFmpeg-devel] [PATCH 1/2] Add option -movflags write_track_title which will write track title metadata. This is useful in conjunction with the metadata flag to specify track title, especially for wor

2018-03-16 Thread Courtland Idstrom
Example: ffmpeg -i in.mov -movflags write_track_title -metadata:s:a:0 title="Eng-FullMix" --- libavformat/movenc.c | 3 ++- libavformat/movenc.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 5b1e66c897..3b1a734a0a 100644