Re: [FFmpeg-devel] [PATCH] libavformat/fifo: Fix initialization of underlying AVFormatContext

On 07/13/2017 01:15 PM, Jan Sebechlebsky wrote: I'll apply the patch in a few days with modified commit message. Jan Applied... ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/fifo: Fix initialization of underlying AVFormatContext

On 07/06/2017 11:54 PM, Jan Sebechlebsky wrote: On 07/06/2017 04:28 PM, wm4 wrote: On Thu, 6 Jul 2017 16:16:12 +0200 Jan Sebechlebsky <sebechlebsky...@gmail.com> wrote: On 07/06/2017 01:15 PM, wm4 wrote: On Thu, 6 Jul 2017 13:05:14 +0200 sebechlebsky...@gmail.com wrote: For what

Re: [FFmpeg-devel] [PATCH] libavformat/fifo: Fix initialization of underlying AVFormatContext

On 07/06/2017 04:28 PM, wm4 wrote: On Thu, 6 Jul 2017 16:16:12 +0200 Jan Sebechlebsky <sebechlebsky...@gmail.com> wrote: On 07/06/2017 01:15 PM, wm4 wrote: On Thu, 6 Jul 2017 13:05:14 +0200 sebechlebsky...@gmail.com wrote: For what reason? For example RTSP muxer attempts to

Re: [FFmpeg-devel] [PATCH v2] libavformat/tee: Add fifo support for tee

On 10/31/2016 04:56 PM, Nicolas George wrote: +if (av_match_name(use_fifo, "true,y,yes,enable,enabled,on,1")) { +tee_slave->use_fifo = 1; +} else if (av_match_name(use_fifo, "false,n,no,disable,disabled,off,0")) { I am not happy about the duplication of the tests

Re: [FFmpeg-devel] [PATCH 2/2] lavf/fifo: fix undefined behaviour in deinit when destroying mutex

On 11/12/2016 02:23 AM, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/fifo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index 15435fe..8f525e5 100644 --- a/libavformat/fifo.c +++

Re: [FFmpeg-devel] [PATCH v2] libavformat/tee: Add fifo support for tee

On 10/17/2016 01:13 PM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- Thanks for noticing, I've fixed the patch (also some minor formatting issues I've noticed). doc/muxers

Re: [FFmpeg-devel] [PATCH] avformat/tests/gitignore: add fifo_muxer entry

On 10/15/2016 06:32 PM, Zhao Zhili wrote: From a3ee9afc37331315e4ec57f1ebf881779b62bf60 Mon Sep 17 00:00:00 2001 From: Zhao Zhili Date: Sun, 16 Oct 2016 00:09:25 +0800 Subject: [PATCH] avformat/tests/gitignore: add fifo_muxer entry --- libavformat/tests/.gitignore | 1 +

Re: [FFmpeg-devel] [PATCH 2/2] avformat/tee: Add FATE tests for tee

On 09/29/2016 12:49 AM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> This commit also adds new diff option for fate tests allowing do compare multiple tuples of files. Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- te

Re: [FFmpeg-devel] [PATCH 1/2] avformat/tee: Copy interrupt callback and flags to slave

On 09/29/2016 09:03 AM, Nicolas George wrote: L'octidi 8 vendémiaire, an CCXXV, sebechlebsky...@gmail.com a écrit : From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Copy interrupt callback to slave format context to allow user to interrupt IO. Copy format flags as well. Signed-off-b

Re: [FFmpeg-devel] [PATCH v5 5/5] avformat/tee: Use BSF list API

On 09/10/2016 10:48 AM, Nicolas George wrote: Le sextidi 16 fructidor, an CCXXIV, sebechlebsky...@gmail.com a écrit : From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- Changes since the last version of the patc

Re: [FFmpeg-devel] [PATCH v5 5/5] avformat/tee: Use BSF list API

On 09/05/2016 05:42 PM, Jan Sebechlebsky wrote: On 09/01/2016 09:42 PM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- Changes since the last version of the patch: -

Re: [FFmpeg-devel] [PATCH v5 5/5] avformat/tee: Use BSF list API

On 09/01/2016 09:42 PM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- Changes since the last version of the patch: - added check for avcodec_parameters_copy return value -

Re: [FFmpeg-devel] [PATCH v2 04/11] avformat/muxers: Add non-blocking mode support for av_write_trailer

On 08/26/2016 12:59 AM, Jan Sebechlebsky wrote: On 08/22/2016 04:49 PM, Michael Niedermayer wrote: On Mon, Aug 22, 2016 at 04:27:16PM +0200, Jan Sebechlebsky wrote: On 08/22/2016 09:51 AM, Michael Niedermayer wrote: On Thu, Aug 11, 2016 at 02:38:29PM +0200, sebechlebsky...@gmail.com wrote

Re: [FFmpeg-devel] [PATCH v4 5/5] avformat/tee: Use BSF list API

On 08/26/2016 12:53 AM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- I believe I have fixed handling input / output timebase and input parameters to bitstream filters list.

Re: [FFmpeg-devel] [PATCH v2 04/11] avformat/muxers: Add non-blocking mode support for av_write_trailer

On 08/22/2016 04:49 PM, Michael Niedermayer wrote: On Mon, Aug 22, 2016 at 04:27:16PM +0200, Jan Sebechlebsky wrote: On 08/22/2016 09:51 AM, Michael Niedermayer wrote: On Thu, Aug 11, 2016 at 02:38:29PM +0200, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechleb

[FFmpeg-devel] [GSoC] Tee muxer improvement project (fifo muxer)

Hello, GSoC 2016 is almost over, so I am sending brief summary of the project (links to my work are at the end of this e-mail). Original plan was to improve tee muxer so that: 1. outputs will not block each other (occasional long I/O operation on single output will not delay processing of

Re: [FFmpeg-devel] [PATCH v2 04/11] avformat/muxers: Add non-blocking mode support for av_write_trailer

On 08/22/2016 09:51 AM, Michael Niedermayer wrote: On Thu, Aug 11, 2016 at 02:38:29PM +0200, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> This makes av_write_trailer not to free the resources if write_trailer call returns AVERROR(EAGAIN) al

Re: [FFmpeg-devel] [PATCH v3 5/5] avformat/tee: Use BSF list API

On 08/21/2016 02:57 PM, Michael Niedermayer wrote: On Tue, Aug 09, 2016 at 02:00:24PM +0200, sebechlebsky...@gmail.com wrote: [...] @@ -506,13 +481,32 @@ static int tee_write_packet(AVFormatContext *avf, AVPacket *pkt) av_packet_rescale_ts(, tb, tb2); pkt2.stream_index

Re: [FFmpeg-devel] [PATCH v11 01/11] avformat: Add fifo pseudo-muxer

On 08/18/2016 09:05 PM, Moritz Barsnick wrote: On Thu, Aug 18, 2016 at 01:25:01 +0200, sebechlebsky...@gmail.com wrote: +@item attempt_recovery @var{bool} +If failure occurs, attempt to recover the output. This is especially useful +when used with network output, allows to restart streaming

Re: [FFmpeg-devel] [PATCH] avformat: Document thread-safety requirement for interrupt callback

On 08/16/2016 06:42 PM, Nicolas George wrote: Le decadi 30 thermidor, an CCXXIV, Marton Balint a écrit : I think the idea was to document this limitation to the fifo muxer only. That would be acceptable, although I still think it would be preferable to avoid that requirement altogether.

Re: [FFmpeg-devel] [PATCH v8 01/11] avformat: Add fifo pseudo-muxer

On 08/16/2016 01:05 AM, Jan Sebechlebsky wrote: On 08/15/2016 11:50 PM, Nicolas George wrote: + +if (just_flushed) +av_log(avf, AV_LOG_INFO, "FIFO queue flushed\n"); + +ret = av_thread_message_queue_recv(queue, , 0); [...] +i

Re: [FFmpeg-devel] [PATCH v8 01/11] avformat: Add fifo pseudo-muxer

On 08/15/2016 11:50 PM, Nicolas George wrote: L'octidi 28 thermidor, an CCXXIV, sebechlebsky...@gmail.com a écrit : [...] +s@item recovery_wait_streamtime @var{bool} ^ Strange. Sorry, that is obviously a typo. Strange thing is it had not produced any kind of warning/error. [...]

Re: [FFmpeg-devel] [PATCH v3 2/5] avcodec/bsf: Add list BSF API

On 08/15/2016 02:08 PM, Michael Niedermayer wrote: On Mon, Aug 15, 2016 at 02:05:43PM +0200, Michael Niedermayer wrote: On Mon, Aug 15, 2016 at 12:38:35PM +0200, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- Changes since the last v

Re: [FFmpeg-devel] [PATCH v2 3/5] avcodec/bsf: Add list BSF API

On 08/15/2016 03:40 AM, Michael Niedermayer wrote: On Fri, Aug 05, 2016 at 02:00:25PM +0200, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- Changes from last version: - fixed doxygen comments - added av_bsf_list_append2() function - c

Re: [FFmpeg-devel] [PATCH v7 01/11] avformat: Add fifo pseudo-muxer

On 08/14/2016 08:12 PM, Marton Balint wrote: [...] +@item max_recovery_attempts +Sets maximum number of successive unsucessful recovery attempts after which +the output fails permanently. Unlimited if set to zero. Default value is 16. Maybe it's just me, but I'd set this to unlimited by

Re: [FFmpeg-devel] [PATCH v7 01/11] avformat: Add fifo pseudo-muxer

On 08/14/2016 08:19 PM, Timothy Gu wrote: On Sun, Aug 14, 2016 at 11:12 AM Marton Balint wrote: On Thu, 11 Aug 2016, sebechlebsky...@gmail.com wrote: +@anchor tee I still get error when building the docs: doc/muxers.texi:1531: @anchor expected braces doc/muxers.texi:1443:

Re: [FFmpeg-devel] [PATCH v2 03/11] avformat/fifo: Add fate test

On 08/11/2016 05:00 PM, Michael Niedermayer wrote: make: *** No rule to make target `libavformat/tests/fifo_muxer.exe', needed by `fate-fifo-muxer-tst'. make: Target `fate-fifo-muxer-tst' not remade because of errors. I was not able to reproduce the exactly same error you got, however I've

Re: [FFmpeg-devel] [PATCH v2 03/11] avformat/fifo: Add fate test

On 08/09/2016 07:42 PM, Michael Niedermayer wrote: On Tue, Aug 09, 2016 at 01:26:04PM +0200, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- Changes since the last version: - R

Re: [FFmpeg-devel] [PATCH v5 01/11] avformat: Add fifo pseudo-muxer

On 08/08/2016 11:55 PM, Marton Balint wrote: Thanks for your work, and sorry for the delay in the review. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Thanks for review!

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/bsf: Add list BSF API

On 08/02/2016 05:26 PM, James Almer wrote: On 8/2/2016 12:14 PM, Nicolas George wrote: +AVBSFList *av_bsf_list_alloc(void); This is personal, but for new APIs, I like "int foo_alloc(Foo **rfoo)" better than "Foo *foo_alloc(void)": that way, the caller can forward the error code instead of

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/bsf: Add list BSF API

Hello Nicolas, On 08/02/2016 05:14 PM, Nicolas George wrote: +AVBSFList *av_bsf_list_alloc(void); This is personal, but for new APIs, I like "int foo_alloc(Foo **rfoo)" better than "Foo *foo_alloc(void)": that way, the caller can forward the error code instead of guessing it is ENOMEM. I

Re: [FFmpeg-devel] [PATCH 03/11] avformat/fifo: Add fate test

On 08/02/2016 10:08 PM, Michael Niedermayer wrote: On Tue, Aug 02, 2016 at 03:24:14PM +0200, sebechlebsky...@gmail.com wrote: segfaults on x86-32 Thanks for testing, I wrongly used uint8_t for boolean AVOptions instead of int. I'll send fixed patch soon. Regards, Jan

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/bsf: Set EOF flag only in pkt == NULL

On 07/26/2016 12:40 PM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Set BSF EOF flag only if pkt == NULL in av_bsf_send_packet(). Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- libavcodec/bsf.c | 2 +- 1 file changed,

Re: [FFmpeg-devel] [PATCH 06/11] avformat: add av_abort_output() function

On 08/03/2016 03:15 PM, Nicolas George wrote: Le sextidi 16 thermidor, an CCXXIV, sebechlebsky...@gmail.com a écrit : From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- libavformat/avformat.h | 14 ++

Re: [FFmpeg-devel] [PATCH 1/2] avformat/tee: Factor parse_slave_options() out

On 08/02/2016 04:42 PM, Nicolas George wrote: LGTM apart from that, but maybe ask Jan if it will not interfere with his work. It will interfere with patch "avformat/tee: Use BSF list API" I've send to ML, but it's not a problem at all, I'll just regenerate and resend the patch after this is

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: Set EOF flag only if pkt == NULL

On 07/25/2016 05:14 PM, Nicolas George wrote: Le septidi 7 thermidor, an CCXXIV, Jan Sebechlebsky a écrit : I gave this a second thought, wouldn't it be better to simply ignore pkt without payload? So after caller would send empty packet using av_bsf_send_packet, he would get AVERROR(EAGAIN

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: Set EOF flag only if pkt == NULL

On 07/22/2016 10:14 PM, Nicolas George wrote: Le quintidi 5 thermidor, an CCXXIV, sebechlebsky...@gmail.com a écrit : From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Set BSF EOF flag only if pkt == NULL in av_bsf_send_packet(). Signed-off-by: Jan Sebechlebsky <sebechlebsky...@

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Hello Nicolas, On 07/15/2016 02:17 PM, Nicolas George wrote: Therefore I would like to keep the fifo muxer as Jan submitted it, without EAGAIN support. If there is a use case for non-blockingingness in a sense you use the phrase, then it can be added later. I am against it. As it is, I

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

On 07/12/2016 10:28 AM, Nicolas George wrote: Le quintidi 25 messidor, an CCXXIV, Marton Balint a écrit : The fifo muxer never returns EAGAIN. It silently drops the packets in non-blocking mode on a full queue. This behaviour is useful for the tee muxer case, when you don't want one

Re: [FFmpeg-devel] [PATCH 2/7] avformat/tee: Use ff_stream_encode_params_copy()

On 07/13/2016 12:56 PM, Jan Sebechlebsky wrote: On 07/12/2016 10:23 AM, Nicolas George wrote: Le quartidi 24 messidor, an CCXXIV, Jan Sebechlebsky a écrit : I think it is used in decoding only - the documentation of AVStream mentions only decoding and I also tried to search references

Re: [FFmpeg-devel] [PATCH 1/7] avformat/utils: Add ff_stream_encode_params_copy()

On 07/11/2016 02:23 AM, Marton Balint wrote: +ret = av_dict_copy(>metadata, src->metadata, 0); +if (ret < 0) +return ret; Since you are resetting every existing field in dst, it might make sense to free the metadata dictionary as well, before copying items to it. Thanks

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

On 07/08/2016 10:39 PM, Marton Balint wrote: On Fri, 8 Jul 2016, Nicolas George wrote: Le primidi 21 messidor, an CCXXIV, Jan Sebechlebsky a écrit : I actually thought about this and maybe I am still missing something, but how is this different from the situation without FIFO muxer

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Hello Nicolas, On 07/07/2016 08:00 PM, Nicolas George wrote: If your worker thread is blocked on an I/O operation when the application tries to close the muxer, it will send the corresponding messages and call pthread_join(). Since the worker thread is still blocked in the I/O operation, it

Re: [FFmpeg-devel] [PATCH 3/7] avformat/tee: Handle AV_NOPTS_VALUE correctly

On 07/04/2016 05:07 PM, Hendrik Leppkes wrote: On Mon, Jul 4, 2016 at 4:45 PM, wrote: +if (pkt->pts != AV_NOPTS_VALUE) +pkt2.pts = av_rescale_q(pkt->pts, tb, tb2); +if (pkt->dts != AV_NOPTS_VALUE) +pkt2.dts =

Re: [FFmpeg-devel] Fix memory leaks in segment muxer

Ping... On 06/20/2016 05:24 PM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Hello, I've observed several memory leaks in segment muxer in case the failure happens in seg_init (write_header call). I'm sending patchset to fix those. Regards, Ja

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Hello Moritz, Thanks for feedback and help with grammar! I'll include your fixes in the next version of patch, which I'm planning to send today. On 07/02/2016 08:49 PM, Moritz Barsnick wrote: +#define FIFO_DEFAULT_RECOVERY_WAIT_TIME100 // 1 second You're assigning it as a

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

Mon Sep 17 00:00:00 2001 From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Date: Wed, 29 Jun 2016 19:41:37 +0200 Subject: [PATCH 1/2] avcodec/bsf: Add ff_bsf_peek_packet function This functions allows to reuse packet in internal bsf structure and saves extra allocation. Signed-of

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Hello Nicolas, On 06/28/2016 03:42 PM, Nicolas George wrote: +The fifo pseudo-muxer allows to separate encoding from any other muxer +by using first-in-first-out queue and running the actual muxer in separate +thread. This is especially useful in combination with tee muxer +and output to

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

On 06/28/2016 12:10 PM, Nicolas George wrote: In summary: I am ok with this version IFF it works without malloc() overhead for empty lists and is reasonably simple. I think I can start to work on this. I think it can be done without dynamic allocation. Apart from that - do you think it would

Re: [FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

On 06/20/2016 02:04 PM, Michael Niedermayer wrote: On Sun, Jun 12, 2016 at 04:30:50PM -0500, Rodger Combs wrote: --- libavformat/internal.h | 5 +++-- libavformat/mux.c | 45 +- libavformat/segment.c | 6 +++-- libavformat/utils.c| 59

Re: [FFmpeg-devel] [PATCH v2] avformat/tee: Support arbitrary number of slaves

Ping :) On 06/12/2016 08:17 PM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- libavformat/tee.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-)

Re: [FFmpeg-devel] [PATCH] avutil/threadmessage.h: Fix swapped comments

Ping :) On 06/10/2016 07:11 PM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Fix swapped descriptions of av_thread_message_queue_set_err_send and av_thread_message_queue_set_err_recv. Signed-off-by: Jan Sebechlebsky <sebechlebsky...@

Re: [FFmpeg-devel] [PATCH] avformat/tee: Support arbitrary number of slaves

On 06/12/2016 04:26 PM, Nicolas George wrote: Le tridi 23 prairial, an CCXXIV, sebechlebsky...@gmail.com a écrit : From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- libavformat/tee.c | 27 +---

Re: [FFmpeg-devel] Tee improvement - discussion

On 06/03/2016 03:53 PM, Nicolas George wrote: Le nonidi 9 prairial, an CCXXIV, Jan Sebechlebsky a écrit : If I understand it correctly, I think this will be handled quite smoothy - you don't have to kill the blocked write, the application has to call write_trailer anyway before closing

Re: [FFmpeg-devel] Tee improvement - discussion

On 06/03/2016 03:46 PM, Nicolas George wrote: Sorry for forgetting to reply. L'octidi 8 prairial, an CCXXIV, Marton Balint a écrit : What if we decouple the non-blocking queue and the retry on failure logic to a separate "buffer" or "fifo" muxer? This seems like what you are trying to do,

Re: [FFmpeg-devel] Tee improvement - discussion

Hi Nicolas, On 05/26/2016 12:09 PM, Nicolas George wrote: But the "stick everything in threads" approach is flawed. Just think about what will happen if the actual muxer is blocking on a write while the application, seeing non-blocking behaviour, wants to close it: how do you kill the blocked

Re: [FFmpeg-devel] Tee improvement - discussion

Hello Nicolas, On 05/19/2016 12:44 PM, Nicolas George wrote: Le tridi 23 floréal, an CCXXIV, Jan Sebechlebsky a écrit : My current idea is to create queue for each output (as Marton suggested) and process each output in separate thread. I was also considering using just single queue, but since

Re: [FFmpeg-devel] [PATCH] avformat/tee: Move to new BSF API

Hello Nicolas, I am sorry for a delayed reply, On 05/12/2016 12:17 PM, Nicolas George wrote: Le quartidi 24 floréal, an CCXXIV, Jan Sebechlebsky a écrit : I can change it to array, the advantage of using linked list was that number of bitstream filters used is not known before arguments

Re: [FFmpeg-devel] Tee improvement - discussion

Hello Marton, sorry for a delayed reply. On 05/16/2016 01:20 AM, Marton Balint wrote: On Wed, 11 May 2016, Jan Sebechlebsky wrote: Hi, I'll be working on tee muxer improvement during GSoC 2016 and I thought maybe it is a good idea to ask about ideas which any of you might have regarding

[FFmpeg-devel] Tee improvement - discussion

Hi, I'll be working on tee muxer improvement during GSoC 2016 and I thought maybe it is a good idea to ask about ideas which any of you might have regarding what could be done in avformat/tee. Currently, the tee muxer works in a simple way, incoming packets are just iteratively fed to

Re: [FFmpeg-devel] [PATCH v10 3/3][GSOC] avformat/tee: Handling slave failure in tee muxer

On 04/21/2016 12:14 AM, Nicolas George wrote: Le duodi 2 floréal, an CCXXIV, sebechlebsky...@gmail.com a écrit : +if (av_strerror(err_n, errbuf, sizeof(errbuf)) < 0) +errbuf_ptr = strerror(AVUNERROR(err_n)); strerror() should not be used, even though a few places still

Re: [FFmpeg-devel] [PATCH v9 3/3][GSOC] avformat/tee: Handling slave failure in tee muxer

Hi Nicolas, On 04/20/2016 04:31 PM, Nicolas George wrote: +static int tee_process_slave_failure(AVFormatContext *avf, unsigned slave_idx, int err_n) +{ +TeeContext *tee = avf->priv_data; +TeeSlave *tee_slave = >slaves[slave_idx]; + +tee->nb_alive--; + +

Re: [FFmpeg-devel] [PATCH v5 2/3] avformat/tee: Fix leaks in tee muxer when open_slave fails

On 04/15/2016 02:28 AM, Marton Balint wrote: On Thu, 14 Apr 2016, Marton Balint wrote: On Tue, 12 Apr 2016, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Calling close_slave in case error is to be returned from open_slave will free all

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/tee: Handling slave failure in tee muxer

On 04/07/2016 12:37 AM, Marton Balint wrote: On Mon, 4 Apr 2016, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Adds per slave option 'onfail' to the tee muxer allowing an output to fail,so other slave outputs can continue. Signed-off-b

Re: [FFmpeg-devel] [PATCH v4 2/3] avformat/tee: Fix leaks in tee muxer when open_slave fails

On 04/07/2016 12:28 AM, Marton Balint wrote: On Mon, 4 Apr 2016, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Calling close_slave in case error is to be returned from open_slave will free allocated resources. Since failure can happen before bsfs

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/tee: Handling slave failure in tee muxer

Hello, can the patchset be applied as it is now? ( I don't want to hurry you, just reminding :) ) Jan S. On 04/04/2016 12:06 AM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky <sebechlebsky...@gmail.com> Adds per slave option 'onfail' to the tee muxer allowing an output to f

Re: [FFmpeg-devel] [PATCH v2 3/3] Tee muxer improvement (handling slave failure)

On 03/29/2016 09:01 PM, Nicolas George wrote: Le decadi 10 germinal, an CCXXIV, Nicolas George a écrit : Le decadi 10 germinal, an CCXXIV, Jan Sebechlebsky a écrit : +@item onfail +Specify behaviour on output failure. This can be set to either 'abort' (which is I believe @code

Re: [FFmpeg-devel] [PATCH v2 2/3] Fix leaks in tee muxer when open_slave fails

On 03/24/2016 09:51 PM, Marton Balint wrote: On Thu, 24 Mar 2016, Jan Sebechlebsky wrote: Calling close_slave in case error is to be returned from open_slave will free allocated resources. Since failure can happen before bsfs array is initialized, close_slave must check that bsfs

[FFmpeg-devel] [PATCH v2 1/3] Refactor close_slaves function in tee muxer

Closing single slave operation is pulled out into separate function close_slave(TeeSlave*). Both close_slave and close_slaves function are moved before open_slave function. Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- libavformat/tee.

[FFmpeg-devel] [PATCH v2 3/3] Tee muxer improvement (handling slave failure)

Adds per slave option 'onfail' to the tee muxer allowing an output to fail,so other slave outputs can continue. Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> --- doc/muxers.texi | 14 + libavformat/tee.c | 91 +---

[FFmpeg-devel] [PATCH v2 2/3] Fix leaks in tee muxer when open_slave fails

Calling close_slave in case error is to be returned from open_slave will free allocated resources. Since failure can happen before bsfs array is initialized, close_slave must check that bsfs is not NULL before accessing tee_slave->bsfs[i] element. Signed-off-by: Jan Sebechlebsky <sebech

[FFmpeg-devel] [PATCH] Tee muxer improvement (handling slave failure)

Adds per slave option 'onfail' to the tee muxer allowing an output to fail, allowing other slaves output to continue. Certain situations, when it does not make sense to continue are still fatal (like allocation errors, or invalid options). Update of tee muxer documentation. Signed-off-by: Jan