[FFmpeg-devel] [PATCH] avcodec/h2645_sei: Remove dead checks

Fixes: CID1596534 Dereference after null check Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/h2645_sei.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c index 96a22e7cf6c..1deb76c765b

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

On Sat, May 04, 2024 at 06:02:25PM -0300, James Almer wrote: > > > On 5/4/2024 5:58 PM, Michael Niedermayer wrote: > > On Sat, May 04, 2024 at 12:16:00PM -0300, James Almer wrote: > > > On 5/4/2024 5:34 AM, Marton Balint wrote: > > > > > > > >

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/amrwbdec: assert mode to be valid in decode_fixed_vector()

On Sun, Apr 28, 2024 at 11:30:51PM +0200, Michael Niedermayer wrote: > Inspired-by: CID1473499 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/amrwbdec.c | 3 +++ > 1 file changed, 3 inse

Re: [FFmpeg-devel] [PATCH 1/5] tools/opt_common: Check for malloc failure

On Sun, Apr 28, 2024 at 11:30:48PM +0200, Michael Niedermayer wrote: > Fixes: CID1539100 Negative loop bound > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > fftools/opt_common.c | 14 -- > 1 file changed, 8 insertions(+), 6 del

Re: [FFmpeg-devel] [PATCH 6/6] avformat/mxfdec: Check body_offset

On Mon, Apr 29, 2024 at 10:25:33PM +0200, Tomas Härdin wrote: > fre 2024-04-26 klockan 05:08 +0200 skrev Michael Niedermayer: > > Fixes: signed integer overflow: 538976288 - -9223372036315799520 > > cannot be represented in type 'long' > > Fixes: 68060

[FFmpeg-devel] [PATCH 2/2] tools/target_enc_fuzzer: Only read pix_fmts if its set

Fixes: null pointer dereference Fixes: rawvideo encoder Signed-off-by: Michael Niedermayer --- tools/target_enc_fuzzer.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/target_enc_fuzzer.c b/tools/target_enc_fuzzer.c index 1749f6905bd..0345595ada7 100644

[FFmpeg-devel] [PATCH 1/2] tools/target_enc_fuzzer: replace assert by clean exit

Signed-off-by: Michael Niedermayer --- tools/target_enc_fuzzer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/target_enc_fuzzer.c b/tools/target_enc_fuzzer.c index 4357d376365..1749f6905bd 100644 --- a/tools/target_enc_fuzzer.c +++ b/tools/target_enc_fuzzer.c

[FFmpeg-devel] [PATCH 2/2] avcodec/fmvc: remove dead assignment

Fixes: CID1529220 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/fmvc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/fmvc.c b/libavcodec/fmvc.c index 30f7aaf6bc3..b51b18a9eec 100644 --- a/libavcodec/fmvc.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 1/2] avcodec/flac_parser: Assert that we do not overrun the link_penalty array

Fixes: CID1454676 Out-of-bounds read Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/flac_parser.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/flac_parser.c b/libavcodec/flac_parser.c index 47904d515a6..d9c47801f83 100644 --- a/libavcodec

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

On Sat, May 04, 2024 at 12:16:00PM -0300, James Almer wrote: > On 5/4/2024 5:34 AM, Marton Balint wrote: > > > > > > On Thu, 2 May 2024, James Almer wrote: > > > > > On 5/2/2024 6:23 PM, Marton Balint wrote: > > > > > > >

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

On Sat, Apr 27, 2024 at 12:39:14PM -0400, Vittorio Giovara wrote: > On Sat, Apr 27, 2024 at 6:24 AM Michael Niedermayer > wrote: > > > On Thu, Apr 25, 2024 at 08:15:27AM -0700, Vittorio Giovara wrote: > > > On Wed, Apr 24, 2024 at 3:00 PM Michael Niedermayer <

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

Hi On Fri, May 03, 2024 at 03:45:20PM +, Cosmin Stejerean via ffmpeg-devel wrote: [...] > What doesn't exist (yet) is a way to keep people on the exact email based > workflow > we currently have, and have bi-directional sync with something like github or > gitlab. > Such a thing could prob

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

On Sat, May 04, 2024 at 02:04:16PM -0400, Vittorio Giovara wrote: > On Sat, May 4, 2024 at 9:06 AM Ondřej Fiala wrote: > > > On Sat May 4, 2024 at 3:11 AM CEST, flow gg wrote: > > > I have tried git-send-email, but it failed. You can say that I am stupid, > > > but I would say that this is becaus

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

On Sat, May 04, 2024 at 09:11:12AM +0800, flow gg wrote: > I saw about comparing emails and gitlab/hub .., I did not comprehensively > understand their advantages and disadvantages, but I want to say that I > support it to change to gitlab/hub > > Simple reason: > > If you need to use git-send-em

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/dovi_rpuenc: Initialize bl_compat_id

On Sat, May 04, 2024 at 12:21:03AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1596607 Uninitialized scalar variable > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/dovi

Re: [FFmpeg-devel] [PATCH v1] scale: Bring back the old yuv2yuvX, use it when disable-x86asm.

On Fri, May 03, 2024 at 04:07:36AM +0800, hu heng wrote: > 于2024年4月26日周五 20:21写道： > > > > From: huheng > > > > rename old inline yuv2yuvX to yuv2yuv_X, to avoid conflicts with > > the names of standalone asm functions. When ffmpeg is compiled with > > --disable-x86asm, using the scale function wi

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/dovi_rpuenc: Initialize bl_compat_id

On Sat, May 04, 2024 at 12:21:03AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1596607 Uninitialized scalar variable > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/dovi

Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: Check av_malloc()

On Thu, May 02, 2024 at 11:34:15PM +0200, Andreas Rheinhardt wrote: > Fixes Coverity issue #1596735. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/movenc.c | 2 ++ > 1 file changed, 2 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC7870

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: Avoid overflow when calculating DAR

On Fri, May 03, 2024 at 05:36:23PM +0100, Derek Buitenhuis wrote: > Both the codecpar's width and height, and the SAR num and den are > ints, which can overflow. Cast to int64_t, which is what av_reduce > takes. > > Without this, occasionally, display_aspect_ratio can be negative in > ffprobe's -s

[FFmpeg-devel] [PATCH 5/5] avcodec/exr: Fix preview overflow

Fixes: CID1515456 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 8bd39f78a45..4bac0be89b2 100644 --- a

[FFmpeg-devel] [PATCH 4/5] avcodec/dovi_rpuenc: Initialize bl_compat_id

Fixes: CID1596607 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/dovi_rpuenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c index 7e0292533bd

[FFmpeg-devel] [PATCH 3/5] avcodec/dovi_rpuenc: fix compaatibility

Fixes: a frequency Found while reviewing: CID1596607 Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/dovi_rpuenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c index 80dc22234a9

[FFmpeg-devel] [PATCH 2/5] avcodec/dovi_rpuenc: initialize profile

Code is taken from dovi_rpudec Fixes: CID1596604 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/dovi_rpuenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c index

[FFmpeg-devel] [PATCH 1/5] avcodec/decode: decode_simple_internal() only implements audio and video

Fixes: CID1538861 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/decode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index d031b1ca176..900b0c07a35 100644

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: only check index_edit_rate when calculating the index tables

On Thu, May 02, 2024 at 11:01:02PM +0200, Marton Balint wrote: [...] > If we add a new FATE file for every fixed file or workflow, the amount of > FATE samples (and the time fate will run) will increase significantly, I am > not sure that is intended. In this case, I could only craft an MXF file, >

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

Hi On Thu, May 02, 2024 at 11:23:13PM +0200, Marton Balint wrote: [...] > surely some users depend on it behaving in a certain > way... who ? I dont think you should assume something without evidence especially for framecrc, which isnt that usefull except for testing the output is changed vs ide

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/av1dec: bit_depth cannot be another values than 8, 10, 12

On Wed, May 01, 2024 at 09:56:53PM -0300, James Almer wrote: > On 5/1/2024 9:41 PM, Michael Niedermayer wrote: > > Fixes: CID1544265 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavc

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/cbs_jpeg: Try to move the read entity to one side in a test

On Thu, May 02, 2024 at 08:58:17AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1439654 Untrusted pointer read > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/cbs_jpeg.c | 4

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/avs3_parser: Check the return value of init_get_bits8()

On Thu, May 02, 2024 at 10:28:36AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1492867 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/avs3_p

Re: [FFmpeg-devel] [PATCH 2/7] avcodec/av1dec: initialize ret in av1_receive_frame_internal()

On Thu, May 02, 2024 at 11:34:48PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Thu, May 02, 2024 at 09:12:36AM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: > >>> Fixes: CID1596605 Uninitialized scalar variable > >>&g

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/avs2_parser: Assert init_get_bits8() success with const size 15

On Thu, May 02, 2024 at 10:25:24AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1506708 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/avs2_p

Re: [FFmpeg-devel] [PATCH 2/7] avcodec/av1dec: initialize ret in av1_receive_frame_internal()

On Thu, May 02, 2024 at 09:12:36AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1596605 Uninitialized scalar variable > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/av1dec.c

Re: [FFmpeg-devel] [PATCH 02/10, v2] avcodec: add amfdec.

On Wed, May 01, 2024 at 08:38:01PM +0200, Dmitrii Ovchinnikov wrote: > From: Evgeny Pavlov > > Added AMF based h264, hevc, av1 decoders. > Co-authored-by: Dmitrii Ovchinnikov > v2: added encoder reinitialisation > --- > libavcodec/Makefile| 7 +- > libavcodec/allcodecs.c | 3 + > libavc

Re: [FFmpeg-devel] [PATCH 3/7] avcodec/avfft: Remove dead code

On Thu, May 02, 2024 at 03:21:11AM +0200, Lynne wrote: > May 2, 2024, 02:42 by mich...@niedermayer.cc: > > > Fixes: CID1543204 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavc

[FFmpeg-devel] [PATCH 7/7] avcodec/cbs_jpeg: Try to move the read entity to one side in a test

Fixes: CID1439654 Untrusted pointer read Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/cbs_jpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cbs_jpeg.c b/libavcodec/cbs_jpeg.c index b1b58dcd65e..406147c082c 100644

[FFmpeg-devel] [PATCH 6/7] avcodec/cbs_av1: Avoid shift overflow

Fixes: CID1465488 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/cbs_av1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c index 1d9ac5ab449..fb829960220 100644

[FFmpeg-devel] [PATCH 5/7] avcodec/avs3_parser: Check the return value of init_get_bits8()

Fixes: CID1492867 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/avs3_parser.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/avs3_parser.c b/libavcodec/avs3_parser.c index a819b5783d6..0f9076befe1

[FFmpeg-devel] [PATCH 4/7] avcodec/avs2_parser: Assert init_get_bits8() success with const size 15

Fixes: CID1506708 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/avs2_parser.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/avs2_parser.c b/libavcodec/avs2_parser.c index 200134f91db..8d4bc3cee0d

[FFmpeg-devel] [PATCH 3/7] avcodec/avfft: Remove dead code

Fixes: CID1543204 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/avfft.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avfft.c b/libavcodec/avfft.c index f6787937f67..0f43f30b776 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 2/7] avcodec/av1dec: initialize ret in av1_receive_frame_internal()

Fixes: CID1596605 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/av1dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 4f9222cca27..93ab04eb378 100644 --- a

[FFmpeg-devel] [PATCH 1/7] avcodec/av1dec: bit_depth cannot be another values than 8, 10, 12

Fixes: CID1544265 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/av1dec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 79a30a114da..4f9222cca27 100644 --- a

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

On Tue, Apr 30, 2024 at 08:29:07PM -0300, James Almer wrote: > On 4/30/2024 8:25 PM, Michael Niedermayer wrote: > > On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: > > > On 4/27/2024 9:07 AM, Michael Niedermayer wrote: > > > > On Sat, Apr 27, 202

Re: [FFmpeg-devel] [PATCH 3/3] avutil/opt: Preserve nb_channels in opt_free

On Tue, Apr 30, 2024 at 06:27:23PM -0300, James Almer wrote: > On 4/29/2024 9:48 PM, Michael Niedermayer wrote: > > Fixes: division by 0 > > Fixes: decoder modifying demuxer channels on failure > > Fixes: -sseof -5 -i zgclab/ffmpeg_crash/poc3 > > > > Found-b

Re: [FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Add comment about ignored return value

On Tue, Apr 30, 2024 at 09:14:16AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1397741 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/avfilt

Re: [FFmpeg-devel] [PATCH v3] lavu/opt: Clarify the scope of AVOptions

On Wed, Apr 24, 2024 at 08:30:28AM +0100, Andrew Sayers wrote: > See discussion on the mailing list: > https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/326054.html > --- > libavutil/opt.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/libavutil/opt.h b/libavutil/opt.h >

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: > On 4/27/2024 9:07 AM, Michael Niedermayer wrote: > > On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: > > > Michael Niedermayer: > > > > This allows detecting issues in side d

Re: [FFmpeg-devel] [PATCH] avformat/iamfdec: check nb_streams in header read

On Sat, Apr 27, 2024 at 08:58:22PM -0300, James Almer wrote: > On 4/27/2024 3:51 PM, Michael Niedermayer wrote: > > Fixes: Assertion pkt->stream_index < (unsigned)s->nb_streams && "Invalid > > stream index.\n" failed at libavformat/demux.c:572 > >

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/atrac9dec: Check init_get_bits8() for failure

On Sun, Apr 28, 2024 at 11:41:48PM +0200, Lynne wrote: > Apr 28, 2024, 23:31 by mich...@niedermayer.cc: > > > Fixes: CID1439569 Unchecked return value > > Fixes: CID1439578 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > >

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: free the infe allocated item data on failure

On Sat, Apr 27, 2024 at 08:17:37PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/mov.c | 30 -- > 1 file changed, 24 insertions(+), 6 deletions(-) fixes 68212/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4963488540721152 thx [..

Re: [FFmpeg-devel] [PATCH 1/3] avformat/kvag: Check sample_rate

On Tue, Apr 30, 2024 at 02:48:52AM +0200, Michael Niedermayer wrote: > Fixes: Division by 0 > Fixes: -copyts -start_at_zero -itsoffset 00:00:01 -itsscale 1 -ss 00:00:02 > -i zgclab/ffmpeg_crash/poc1 output.mp4 > > Found-by: Wang Dawei and Zhou Geng, from Zhongguancun Laboratory

Re: [FFmpeg-devel] [PATCH 17/57] avcodec/mpegvideo, mpegpicture: Add buffer pool

On Mon, Apr 29, 2024 at 11:13:58PM +0200, Andreas Rheinhardt wrote: > This avoids constant allocations+frees and will also allow > to simply switch to the RefStruct API, thereby avoiding > the overhead of the AVBuffer API. > It also simplifies the code, because it removes the "needs_realloc" > fiel

Re: [FFmpeg-devel] [PATCH 31/57] avcodec/mpegpicture: Split MPVPicture into WorkPicture and ordinary Pic

On Mon, Apr 29, 2024 at 11:14:12PM +0200, Andreas Rheinhardt wrote: > There are two types of MPVPictures: Three (cur_pic, last_pic, next_pic) > that are directly part of MpegEncContext and an array of MPVPictures > that are separately allocated and are mostly accessed via pointers > (cur|last|next)

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

On Sat, Apr 27, 2024 at 08:01:14PM +0200, Tomas Härdin wrote: > lör 2024-04-27 klockan 12:53 +0200 skrev Michael Niedermayer: > > On Thu, Apr 25, 2024 at 12:26:00PM +0200, Tomas Härdin wrote: > > > tor 2024-04-25 klockan 02:07 +0200 skrev Michael Niedermayer: > > > >

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

On Mon, Apr 22, 2024 at 01:32:27PM +0200, Lynne wrote: > Apr 22, 2024, 13:07 by stefa...@gmail.com: > > > On date Sunday 2024-04-21 22:12:56 -0300, James Almer wrote: > > > >> On 4/17/2024 10:58 AM, Michael Niedermayer wrote: > >> > > [...] > > &g

Re: [FFmpeg-devel] [PATCH] doc/Doxfyile: Refactor for maintainability

On Mon, Apr 29, 2024 at 09:53:13AM +0100, Andrew Sayers wrote: > On Sun, Apr 28, 2024 at 11:46:18PM +0200, Michael Niedermayer wrote: > > Hi > > > > On Sun, Apr 28, 2024 at 11:10:22AM +0100, Andrew Sayers wrote: > > [...] > > > Ping ? > > > > &g

[FFmpeg-devel] [PATCH 3/3] avutil/opt: Preserve nb_channels in opt_free

Fixes: division by 0 Fixes: decoder modifying demuxer channels on failure Fixes: -sseof -5 -i zgclab/ffmpeg_crash/poc3 Found-by: Wang Dawei and Zhou Geng, from Zhongguancun Laboratory Signed-off-by: Michael Niedermayer --- libavutil/opt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions

[FFmpeg-devel] [PATCH 2/3] avformat/concatdec: Check file

Fixes: null pointer dereference Fixes: -stream_loop 1 -ss 00:00:05 -i zgclab/ffmpeg_crash/poc2 -codec:v copy -codec:a aac -y output.mp4 Found-by: Wang Dawei and Zhou Geng, from Zhongguancun Laboratory Signed-off-by: Michael Niedermayer --- libavformat/concatdec.c | 5 + 1 file changed, 5

[FFmpeg-devel] [PATCH 1/3] avformat/kvag: Check sample_rate

Fixes: Division by 0 Fixes: -copyts -start_at_zero -itsoffset 00:00:01 -itsscale 1 -ss 00:00:02 -i zgclab/ffmpeg_crash/poc1 output.mp4 Found-by: Wang Dawei and Zhou Geng, from Zhongguancun Laboratory Signed-off-by: Michael Niedermayer --- libavformat/kvag.c | 5 - 1 file changed, 4

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/atrac9dec: Check init_get_bits8() for failure

On Mon, Apr 29, 2024 at 08:52:32AM +0200, Paul B Mahol wrote: > On Sun, Apr 28, 2024 at 11:31 PM Michael Niedermayer > wrote: > > > Fixes: CID1439569 Unchecked return value > > Fixes: CID1439578 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund &g

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/aaccoder: assert that escape case len is not causing issues

red by CID1465483 Unintentional integer overflow > >> > > >> > Sponsored-by: Sovereign Tech Fund > >> > Signed-off-by: Michael Niedermayer > >> > --- > >> > libavcodec/aaccoder.c | 2 ++ > >> > 1 file changed, 2 insertions(+) > >&

Re: [FFmpeg-devel] [REFUND-REQUEST] Vulkan F2F travel

Hi On Sat, Apr 27, 2024 at 02:16:36PM +0200, Lynne wrote: > Hi, > > I'm requesting a reimbursement for attending the Khronos F2F > event in Brussels on 2024-04-26, where I gave a talk about the > current status of Vulkan Video integration into FFmpeg: >  - Currently implemented decoding features

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/aaccoder: assert that escape case len is not causing issues

On Sun, Apr 28, 2024 at 11:41:20PM +0200, Lynne wrote: > Apr 28, 2024, 23:31 by mich...@niedermayer.cc: > > > Inspired by CID1465483 Unintentional integer overflow > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- >

Re: [FFmpeg-devel] [PATCH] doc/Doxfyile: Refactor for maintainability

Hi On Sun, Apr 28, 2024 at 11:10:22AM +0100, Andrew Sayers wrote: [...] > Ping ? > > Michael, this is in response to your request[0]. I've queued up some more > patches that depend on this and would help attract and retain developers (e.g. > warning when you're looking at old documentation). Wh

[FFmpeg-devel] [PATCH 5/5] avcodec/atrac9dec: Check init_get_bits8() for failure

Fixes: CID1439569 Unchecked return value Fixes: CID1439578 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/atrac9dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/atrac9dec.c b/libavcodec

[FFmpeg-devel] [PATCH 4/5] avcodec/amrwbdec: assert mode to be valid in decode_fixed_vector()

Inspired-by: CID1473499 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/amrwbdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/amrwbdec.c b/libavcodec/amrwbdec.c index 9d75b972fa7..21a730b835d 100644 --- a

[FFmpeg-devel] [PATCH 3/5] avcodec/ac3_parser: Check init_get_bits8() for failure

Fixes: CID1420393 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/ac3_parser.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/ac3_parser.c b/libavcodec/ac3_parser.c index 4152fd4e018..4e0ba734818

[FFmpeg-devel] [PATCH 2/5] avcodec/aaccoder: assert that escape case len is not causing issues

Inspired by CID1465483 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/aaccoder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/aaccoder.c b/libavcodec/aaccoder.c index 4ce54ca8867..6e5817e237b 100644 --- a

[FFmpeg-devel] [PATCH 1/5] tools/opt_common: Check for malloc failure

Fixes: CID1539100 Negative loop bound Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/opt_common.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/fftools/opt_common.c b/fftools/opt_common.c index 947a226d8d1..9d2d5184a08

[FFmpeg-devel] [PATCH 10/10] fftools/ffplay: Check vulkan_params

Fixes: CID1550133 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffplay.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 63a9806fb80..cc00e209d52 100644 --- a/fftools

[FFmpeg-devel] [PATCH 09/10] fftools/ffplay: Check return of swr_alloc_set_opts2()

This probably makes no difference but its more correct Fixes: CID1503080 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffplay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c

[FFmpeg-devel] [PATCH 08/10] fftools/ffmpeg_sched: Remove dead assignments in sch_dec_send()

Fixes: CID1592383 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_sched.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c index e58b00ea97b..cff824340b7 100644 --- a

[FFmpeg-devel] [PATCH 07/10] fftools/cmdutils: Add protective () to FLAGS

issue found while reviewing CID1452612 Free of array-typed value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/cmdutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index a8f5c6d89b4..d28f5f3a8bd

[FFmpeg-devel] [PATCH 06/10] fftools/ffmpeg_mux_init: Cleanup on error return in set_dispositions()

Fixes: CID1539099 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg.h | 9 +++-- fftools/ffmpeg_mux_init.c | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index

[FFmpeg-devel] [PATCH 05/10] fftools/ffmpeg_mux_init: Free pts on error

Fixes: CID1538863 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_mux_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 8797265145c..b1cb6cf7bd7 100644

[FFmpeg-devel] [PATCH 01/10] fftools/ffmpeg_enc: simplify opaque_ref check

Found-while-revieweing: CID1520670 Dereference after null check Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 618ba193ff5

[FFmpeg-devel] [PATCH 04/10] fftools/ffmpeg_mux: Remove unneeded initialization

Not sure this change makes sense, the code is more robust with ret set Fixes: CID1559178 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_mux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fftools/ffmpeg_mux.c b

[FFmpeg-devel] [PATCH 03/10] fftools/ffmpeg_enc: Initialize Decoder

Fixes: CID1591439 Uninitialized pointer read Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 0b3f3f101a2..928114c20ff 100644 --- a

[FFmpeg-devel] [PATCH 02/10] fftools/ffmpeg_enc: Initialize fd

Fixes: CID1520677 Uninitialized pointer read Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 863d1a43edd..0b3f3f101a2 100644 --- a

[FFmpeg-devel] [PATCH] avformat/iamfdec: check nb_streams in header read

ub.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/iamfdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/iamfdec.c b/libavformat/iamfdec.c index e34d13e74c5..ce6d4aa0647 100644 --- a/libavformat/iamfdec.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/hevcdec: Check ref frame

On Sat, Apr 27, 2024 at 12:14:18PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: NULL pointer dereferences > > Fixes: > > 68197/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6382538823106560 > > > > Found-by: continuous fuzzin

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vp3: Call ff_progress_frame_unref() before ff_progress_frame_get_buffer()

Hi On Sat, Apr 27, 2024 at 11:47:32AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: Assertion !f->f && !f->progress failed at libavcodec/decode.c:1688 > > Fixes: > > 68190/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/pngdec: Check last AVFrame before deref

On Sat, Apr 27, 2024 at 11:36:30AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: NULL pointer dereference > > Fixes: > > 68184/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-4926478069334016 > > > > Found-by: continuous fuzzin

Re: [FFmpeg-devel] [PATCH 1/6] avformat/mov: Check tile_item_list

On Fri, Apr 26, 2024 at 09:30:50AM -0300, James Almer wrote: > On 4/26/2024 12:08 AM, Michael Niedermayer wrote: > > Fixes: Null pointer dereference > > Fixes: > > 67861/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5352628142800896 > > > > Found-by: cont

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > This allows detecting issues in side data related code, same as what > > framecrc does for before already for packet data itself. > > > > Signed-off-by: Michael Niedermaye

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

On Thu, Apr 25, 2024 at 12:26:00PM +0200, Tomas Härdin wrote: > tor 2024-04-25 klockan 02:07 +0200 skrev Michael Niedermayer: > > On Thu, Apr 25, 2024 at 12:50:02AM +0200, Tomas Härdin wrote: > > > ons 2024-04-17 klockan 15:58 +0200 skrev Michael Niedermayer: >

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

On Thu, Apr 25, 2024 at 08:15:27AM -0700, Vittorio Giovara wrote: > On Wed, Apr 24, 2024 at 3:00 PM Michael Niedermayer > wrote: > > > > Microsoft expanded into new fields with Xbox and Azure, yes. But Windows > > is still an OS, and Office is still

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: allow setting which side data parameters are printed

On Thu, Apr 25, 2024 at 11:34:59AM -0300, James Almer wrote: > For some side data types, the size is dependent on the arch at runtime, which > is not good for FATE tests. Which are not bit exact ? I guess its pointer size or something. Either way i have some local improvments for framecrc that i

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: Check if heif item name is already allocated

On Fri, Apr 26, 2024 at 08:57:02PM -0300, James Almer wrote: > On 4/26/2024 8:52 PM, Michael Niedermayer wrote: > > Fixes: memleak > > Fixes: > > 68212/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4963488540721152 > > > > Found-by: continuous fuzzin

[FFmpeg-devel] [PATCH 5/5] avformat/mov: Check if heif item name is already allocated

Fixes: memleak Fixes: 68212/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4963488540721152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 3 +++ 1 file changed, 3 insertions

[FFmpeg-devel] [PATCH 4/5] avcodec/hevcdec: Check ref frame

Fixes: NULL pointer dereferences Fixes: 68197/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6382538823106560 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hevcdec.c | 4

[FFmpeg-devel] [PATCH 3/5] avcodec/decode: Check progress before dereferencing

Fixes: NULL pointer dereference Fixes: 68192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP8_fuzzer-6180311026171904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/decode.c | 2 ++ 1

[FFmpeg-devel] [PATCH 2/5] avcodec/vp3: Call ff_progress_frame_unref() before ff_progress_frame_get_buffer()

Fixes: Assertion !f->f && !f->progress failed at libavcodec/decode.c:1688 Fixes: 68190/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-5942090287611904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-o

[FFmpeg-devel] [PATCH 1/5] avcodec/pngdec: Check last AVFrame before deref

Fixes: NULL pointer dereference Fixes: 68184/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-4926478069334016 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pngdec.c | 2 +- 1

[FFmpeg-devel] [PATCH 6/6] avformat/mxfdec: Check body_offset

peg Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 233d614f783..e65cec74c23 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -791,6 +791,9 @@ static int mxf_read_part

[FFmpeg-devel] [PATCH 5/6] avcodec/wavarc: fix integer overflow in decode_5elp() block type 2

peg Signed-off-by: Michael Niedermayer --- libavcodec/wavarc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wavarc.c b/libavcodec/wavarc.c index b4b26958e6f..93b76c43e8a 100644 --- a/libavcodec/wavarc.c +++ b/libavcodec/wavarc.c @@ -689,7 +689,7 @@ static int d

[FFmpeg-devel] [PATCH 4/6] avformat/iamfdec: Files without streams cannot have packets

ub.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/iamfdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/iamfdec.c b/libavformat/iamfdec.c index e34d13e74c5..67ff7e8f01a 100644 --- a/libavformat/iamfdec.c +++ b/libavformat

[FFmpeg-devel] [PATCH 3/6] swscale/output: Fix integer overflow in yuv2rgba64_full_1_c_template()

ld happen with valid input. Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libswscale/output.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libswscale/output.c b

[FFmpeg-devel] [PATCH 2/6] swscale/output: Fix integer overflow in yuv2rgba64_1_c_template

pen with valid input. Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libswscale/output.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/l

[FFmpeg-devel] [PATCH 1/6] avformat/mov: Check tile_item_list

Fixes: Null pointer dereference Fixes: 67861/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5352628142800896 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 3 +++ 1 file

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

On Wed, Apr 24, 2024 at 01:20:02PM +0200, Jerome Martinez wrote: > Hi, I'm bumping this patch proposal for avoiding a situation where FFmpeg > skips half the visual content when 2 jpeg2000 codestreams are present in one > frame. I re-reviewed this discussion and think I answered all concerns. I'm >

<    5   6   7   8   9   10   11   12   13   14   >