Re: [FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute V2

2018-11-02 Thread Soft Works
> LGTM, will apply next time I get a chance. Thank you very much! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute V2

2018-11-02 Thread Timo Rothenpieler
LGTM, will apply next time I get a chance. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute

2018-11-01 Thread Soft Works
Hi Phil, thank you very much for taking the time to respond. I've understood the differences regarding the parser. > The hwaccels are officially called 'cuvid' and 'nvdec'. As a > convenience, we alias 'cuda' to 'nvdec'. The confusion is that the HW > pix_fmt and hwcontext are called 'cuda' beca

Re: [FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute

2018-11-01 Thread Philip Langdale
On Thu, 1 Nov 2018 23:48:03 + Soft Works wrote: > In this context, I wonder if there is some explanation somewhere > about the differences between the cuvid and nvdec codec > implementations. > > I understand the ffmpeg side where cuvid is a full codec and nvdec is > implemented as hwaccel.

Re: [FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute

2018-11-01 Thread Soft Works
> Those headers come straight from nvidia under a free license(MIT) and > are just slightly modified for better compatibility. > There is no such thing for CUDA sadly. Thanks. I made the requested changes and submitted a new patch. In this context, I wonder if there is some explanation somewher

[FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute V2

2018-11-01 Thread Soft Works
Signed-off-by: softworkz --- include/ffnvcodec/dynlink_cuda.h | 26 ++ include/ffnvcodec/dynlink_loader.h | 2 ++ 2 files changed, 28 insertions(+) diff --git a/include/ffnvcodec/dynlink_cuda.h b/include/ffnvcodec/dynlink_cuda.h index 373215d..069acd1 100644 --- a/incl

Re: [FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute

2018-11-01 Thread Timo Rothenpieler
On 02.11.2018 00:09, Soft Works wrote: That enum is _way_ too massive. Most of that seems entirely useless in the context of ffmpeg anyway, like all the 1D and 3D stuff, and probably most of the 2D stuff as well. I copied the full enum to have an exact match to cuda.h, but no problem, I can tr

Re: [FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute

2018-11-01 Thread Soft Works
> That enum is _way_ too massive. Most of that seems entirely useless in > the context of ffmpeg anyway, like all the 1D and 3D stuff, and probably > most of the 2D stuff as well. I copied the full enum to have an exact match to cuda.h, but no problem, I can trim it down. > Can you trim it down

Re: [FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute

2018-11-01 Thread Timo Rothenpieler
That enum is _way_ too massive. Most of that seems entirely useless in the context of ffmpeg anyway, like all the 1D and 3D stuff, and probably most of the 2D stuff as well. Can you trim it down to only those exact ones you need? Also, just get rid of the comments, we're not doing that anywher

[FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute

2018-11-01 Thread Soft Works
Signed-off-by: softworkz --- include/ffnvcodec/dynlink_cuda.h | 104 + include/ffnvcodec/dynlink_loader.h | 2 + 2 files changed, 106 insertions(+) diff --git a/include/ffnvcodec/dynlink_cuda.h b/include/ffnvcodec/dynlink_cuda.h index 373215d..b16e9a5 100644 --- a