Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-02-04 Thread Philip Langdale
On Wed, 04 Feb 2015 21:13:57 +0100 Timo Rothenpieler wrote: > > Could I get a proper review on this? I'd like to believe that we > > have a consensus that, independent of whether we think there's > > merit in this compensation logic, it shouldn't exist in a single > > encoder, out of step with al

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-02-04 Thread Michael Niedermayer
On Wed, Feb 04, 2015 at 09:13:57PM +0100, Timo Rothenpieler wrote: > > Could I get a proper review on this? I'd like to believe that we have a > > consensus that, independent of whether we think there's merit in this > > compensation logic, it shouldn't exist in a single encoder, out of > > step wi

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-02-04 Thread Timo Rothenpieler
> Could I get a proper review on this? I'd like to believe that we have a > consensus that, independent of whether we think there's merit in this > compensation logic, it shouldn't exist in a single encoder, out of > step with all the other encoders in ffmpeg. > > Thanks, It looks good to merge f

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-02-03 Thread Philip Langdale
Could I get a proper review on this? I'd like to believe that we have a consensus that, independent of whether we think there's merit in this compensation logic, it shouldn't exist in a single encoder, out of step with all the other encoders in ffmpeg. Thanks, --phil On Wed, 28 Jan 2015 09:05:53

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-01-28 Thread Philip Langdale
On Thu, 29 Jan 2015 01:38:31 + Kieran Kunhya wrote: > > this context, that means that they make the following, questionable, > > assumptions: > > erm > > > 1) If the input dimensions are 720x480 or 720x576, assume the > > content has an active area of 704x480 or 704x576. > > 702x576 That

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-01-28 Thread Kieran Kunhya
> this context, that means that they make the following, questionable, > assumptions: erm > 1) If the input dimensions are 720x480 or 720x576, assume the content has > an active area of 704x480 or 704x576. 702x576 Kieran ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-01-28 Thread Philip Langdale
For reasons we are not privy to, nvidia decided that the nvenc encoder should apply aspect ratio compensation to 'DVD like' content, assuming that the content is not bt.601 compliant, but needs to be bt.601 compliant. In this context, that means that they make the following, questionable, assumptio