Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-07 Thread Tomas Härdin
sön 2019-07-07 klockan 18:19 +0200 skrev Michael Niedermayer: > On Sat, Jul 06, 2019 at 11:22:59PM +0200, Tomas Härdin wrote: > > lör 2019-07-06 klockan 18:34 +0200 skrev Michael Niedermayer: > > > On Sat, Jul 06, 2019 at 02:34:34PM +0200, Tomas Härdin wrote: > > > > lör 2019-07-06 klockan 00:08

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-07 Thread Michael Niedermayer
On Sat, Jul 06, 2019 at 11:22:59PM +0200, Tomas Härdin wrote: > lör 2019-07-06 klockan 18:34 +0200 skrev Michael Niedermayer: > > On Sat, Jul 06, 2019 at 02:34:34PM +0200, Tomas Härdin wrote: > > > lör 2019-07-06 klockan 00:08 +0200 skrev Michael Niedermayer: > > > > As we are already off topic,

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-06 Thread Tomas Härdin
lör 2019-07-06 klockan 18:34 +0200 skrev Michael Niedermayer: > On Sat, Jul 06, 2019 at 02:34:34PM +0200, Tomas Härdin wrote: > > lör 2019-07-06 klockan 00:08 +0200 skrev Michael Niedermayer: > > > As we are already off topic, heres an example to test static > > > analysis, does this trigger

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-06 Thread Michael Niedermayer
On Sat, Jul 06, 2019 at 02:34:34PM +0200, Tomas Härdin wrote: > lör 2019-07-06 klockan 00:08 +0200 skrev Michael Niedermayer: > > As we are already off topic, heres an example to test static > > analysis, does this trigger undefined behavior by executing the memcpy > > for some user input ? > > >

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-06 Thread Tomas Härdin
lör 2019-07-06 klockan 00:08 +0200 skrev Michael Niedermayer: > As we are already off topic, heres an example to test static > analysis, does this trigger undefined behavior by executing the memcpy > for some user input ? > > void f(unsigned bigint a) { > bigint i; > for (i = 2;

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-05 Thread Michael Niedermayer
On Fri, Jul 05, 2019 at 05:01:33PM +0200, Tomas Härdin wrote: > ons 2019-07-03 klockan 10:46 +0200 skrev Michael Niedermayer: > > On Wed, Jul 03, 2019 at 09:41:41AM +0200, Reimar Döffinger wrote: > > > > > > > > > On 03.07.2019, at 08:29, Michael Niedermayer > > > wrote: > > > > > > > On Tue,

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-05 Thread Tomas Härdin
ons 2019-07-03 klockan 10:46 +0200 skrev Michael Niedermayer: > On Wed, Jul 03, 2019 at 09:41:41AM +0200, Reimar Döffinger wrote: > > > > > > On 03.07.2019, at 08:29, Michael Niedermayer wrote: > > > > > On Tue, Jul 02, 2019 at 08:42:43PM -0300, James Almer wrote: > > > > > > > > How many

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-04 Thread Hendrik Leppkes
On Thu, Jul 4, 2019 at 8:45 PM Michael Niedermayer wrote: > > On Wed, Jul 03, 2019 at 12:50:59PM +0200, Hendrik Leppkes wrote: > > On Wed, Jul 3, 2019 at 10:46 AM Michael Niedermayer > > wrote: > > > > > > On Wed, Jul 03, 2019 at 09:41:41AM +0200, Reimar Döffinger wrote: > > > > > > > > > > > >

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-04 Thread Michael Niedermayer
On Wed, Jul 03, 2019 at 12:50:59PM +0200, Hendrik Leppkes wrote: > On Wed, Jul 3, 2019 at 10:46 AM Michael Niedermayer > wrote: > > > > On Wed, Jul 03, 2019 at 09:41:41AM +0200, Reimar Döffinger wrote: > > > > > > > > > On 03.07.2019, at 08:29, Michael Niedermayer > > > wrote: > > > > > > > On

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-03 Thread Derek Buitenhuis
On 03/07/2019 08:41, Reimar Döffinger wrote: > Of course another question might be if it might make sense to replace all > memcpy uses with it. I would expect this may break some compiler optimizations around memcpy (like __builtin_memcpy, or direct inlining), no? - Derek

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-03 Thread Hendrik Leppkes
On Wed, Jul 3, 2019 at 10:46 AM Michael Niedermayer wrote: > > On Wed, Jul 03, 2019 at 09:41:41AM +0200, Reimar Döffinger wrote: > > > > > > On 03.07.2019, at 08:29, Michael Niedermayer wrote: > > > > > On Tue, Jul 02, 2019 at 08:42:43PM -0300, James Almer wrote: > > >> On 7/2/2019 5:56 PM,

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-03 Thread Michael Niedermayer
On Wed, Jul 03, 2019 at 09:41:41AM +0200, Reimar Döffinger wrote: > > > On 03.07.2019, at 08:29, Michael Niedermayer wrote: > > > On Tue, Jul 02, 2019 at 08:42:43PM -0300, James Almer wrote: > >> On 7/2/2019 5:56 PM, Michael Niedermayer wrote: > >>> Signed-off-by: Michael Niedermayer > >>>

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-03 Thread Reimar Döffinger
On 03.07.2019, at 08:29, Michael Niedermayer wrote: > On Tue, Jul 02, 2019 at 08:42:43PM -0300, James Almer wrote: >> On 7/2/2019 5:56 PM, Michael Niedermayer wrote: >>> Signed-off-by: Michael Niedermayer >>> --- >>> doc/APIchanges | 3 +++ >>> libavutil/mem.h | 13 + >>>

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-03 Thread Michael Niedermayer
On Tue, Jul 02, 2019 at 08:42:43PM -0300, James Almer wrote: > On 7/2/2019 5:56 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > doc/APIchanges | 3 +++ > > libavutil/mem.h | 13 + > > libavutil/version.h | 2 +- > > 3 files changed, 17

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-02 Thread James Almer
On 7/2/2019 5:56 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/APIchanges | 3 +++ > libavutil/mem.h | 13 + > libavutil/version.h | 2 +- > 3 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges

[FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/APIchanges | 3 +++ libavutil/mem.h | 13 + libavutil/version.h | 2 +- 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index b5fadc2a48..65b8ed74ad 100644 --- a/doc/APIchanges +++