Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-31 Thread Clément Bœsch
On Sun, Aug 31, 2014 at 10:46:29AM +0200, Reimar Döffinger wrote: > On Sat, Aug 30, 2014 at 11:23:52PM +0200, Reimar Döffinger wrote: > > On 30.08.2014, at 21:50, Clément Bœsch wrote: > > > On Sat, Aug 30, 2014 at 04:36:57PM +0200, Reimar Döffinger wrote: > > >> On Fri, Aug 29, 2014 at 09:29:46PM

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-31 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 11:23:52PM +0200, Reimar Döffinger wrote: > On 30.08.2014, at 21:50, Clément Bœsch wrote: > > On Sat, Aug 30, 2014 at 04:36:57PM +0200, Reimar Döffinger wrote: > >> On Fri, Aug 29, 2014 at 09:29:46PM +0200, Clément Bœsch wrote: > >>> On Fri, Aug 29, 2014 at 06:34:52PM +0200

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-30 Thread Reimar Döffinger
On 30.08.2014, at 21:50, Clément Bœsch wrote: > On Sat, Aug 30, 2014 at 04:36:57PM +0200, Reimar Döffinger wrote: >> On Fri, Aug 29, 2014 at 09:29:46PM +0200, Clément Bœsch wrote: >>> On Fri, Aug 29, 2014 at 06:34:52PM +0200, Reimar Döffinger wrote: Signed-off-by: Reimar Döffinger --- >

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-30 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 12:58:35PM -0700, Timothy Gu wrote: > On Aug 30, 2014 7:37 AM, "Reimar Döffinger" > wrote: > > > But mostly I care about having it in .rodata, everything else > > I'm willing to adapt to what others prefer. > > What are the gains for using .rodata instead of .data? It is

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-30 Thread Timothy Gu
On Aug 30, 2014 7:37 AM, "Reimar Döffinger" wrote: > But mostly I care about having it in .rodata, everything else > I'm willing to adapt to what others prefer. What are the gains for using .rodata instead of .data? Timothy ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-30 Thread Clément Bœsch
On Sat, Aug 30, 2014 at 04:36:57PM +0200, Reimar Döffinger wrote: > On Fri, Aug 29, 2014 at 09:29:46PM +0200, Clément Bœsch wrote: > > On Fri, Aug 29, 2014 at 06:34:52PM +0200, Reimar Döffinger wrote: > > > Signed-off-by: Reimar Döffinger > > > --- > > > libavutil/hash.c | 2 +- > > > 1 file chan

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-30 Thread Reimar Döffinger
On Fri, Aug 29, 2014 at 09:29:46PM +0200, Clément Bœsch wrote: > On Fri, Aug 29, 2014 at 06:34:52PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavutil/hash.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavutil/hash.c b/li

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-29 Thread Clément Bœsch
On Fri, Aug 29, 2014 at 06:34:52PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavutil/hash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/hash.c b/libavutil/hash.c > index 773f29e..979fdd9 100644 > --- a/libavutil/hash.c > +++

[FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-29 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavutil/hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hash.c b/libavutil/hash.c index 773f29e..979fdd9 100644 --- a/libavutil/hash.c +++ b/libavutil/hash.c @@ -63,7 +63,7 @@ typedef struct AVHashContext { struct {