Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Michael Niedermayer
On Sat, Jan 24, 2015 at 12:52:58PM -0800, Philip Langdale wrote: > --- > libavcodec/nvenc.c | 5 + > 1 file changed, 5 insertions(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when th

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Philip Langdale
On Sat, 24 Jan 2015 20:28:30 +0100 Michael Niedermayer wrote: > On Sat, Jan 24, 2015 at 10:11:21AM -0800, Philip Langdale wrote: > > On Sat, 24 Jan 2015 13:02:01 +0100 > > Michael Niedermayer wrote: > > > > > On Fri, Jan 23, 2015 at 09:41:23PM -0800, Philip Langdale wrote: > > > > Yeah, I've g

[FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Philip Langdale
--- libavcodec/nvenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 7d82d58..16ef93f 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -590,6 +590,11 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx) memcpy(&ctx-

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Michael Niedermayer
On Sat, Jan 24, 2015 at 10:11:21AM -0800, Philip Langdale wrote: > On Sat, 24 Jan 2015 13:02:01 +0100 > Michael Niedermayer wrote: > > > On Fri, Jan 23, 2015 at 09:41:23PM -0800, Philip Langdale wrote: > > > Signed-off-by: Philip Langdale > > > --- > > > libavcodec/nvenc.c | 5 + > > > 1 fi

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Philip Langdale
On Sat, 24 Jan 2015 13:02:01 +0100 Michael Niedermayer wrote: > On Fri, Jan 23, 2015 at 09:41:23PM -0800, Philip Langdale wrote: > > Signed-off-by: Philip Langdale > > --- > > libavcodec/nvenc.c | 5 + > > 1 file changed, 5 insertions(+) > > Applying: nvenc: Propagate desired number of ref

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Michael Niedermayer
On Fri, Jan 23, 2015 at 09:41:23PM -0800, Philip Langdale wrote: > Signed-off-by: Philip Langdale > --- > libavcodec/nvenc.c | 5 + > 1 file changed, 5 insertions(+) Applying: nvenc: Propagate desired number of reference frames. fatal: sha1 information is lacking or useless (libavcodec/nvenc

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Timo Rothenpieler
> Signed-off-by: Philip Langdale > --- > libavcodec/nvenc.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index c52beb7..e68bbe9 100644 > --- a/libavcodec/nvenc.c > +++ b/libavcodec/nvenc.c > @@ -614,6 +614,11 @@ static av_cold int nvenc_

[FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-23 Thread Philip Langdale
Signed-off-by: Philip Langdale --- libavcodec/nvenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index c52beb7..e68bbe9 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -614,6 +614,11 @@ static av_cold int nvenc_encode_init(AVCodecC

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-23 Thread Philip Langdale
On 2015-01-23 01:54, Timo Rothenpieler wrote: +ctx->encode_config.encodeCodecConfig.h264Config.maxNumRefFrames = avctx->refs; avctx->refs should propably be checked for >= 0. I'm not sure if maxNumRefFrames means the exact same thing as avctx->refs, but the comment in the nvenc header isn'

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-23 Thread Christophe Gisquet
Hi, 2015-01-23 10:54 GMT+01:00 Timo Rothenpieler : > This would also forward the ffmpeg default, 1, to nvenc, instead of the > nvenc default, 0, which lets the driver decide what is best. I'm not sure if > this is desireable and how much it affects the quality. In that case, why not set ffmpeg's

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-23 Thread Timo Rothenpieler
+ctx->encode_config.encodeCodecConfig.h264Config.maxNumRefFrames = avctx->refs; avctx->refs should propably be checked for >= 0. I'm not sure if maxNumRefFrames means the exact same thing as avctx->refs, but the comment in the nvenc header isn't exactly clear about that. This would als

[FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-22 Thread Philip Langdale
Signed-off-by: Philip Langdale --- libavcodec/nvenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index c52beb7..34ec112 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -614,6 +614,8 @@ static av_cold int nvenc_encode_init(AVCodecConte