Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-29 Thread Carl Eugen Hoyos
2016-09-23 1:08 GMT+02:00 Paul B Mahol : >> Log message changed locally to "lavf/mov: Read display >> aspect ratio from ares atom also for dnxhd." > > LGTM Patch applied. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-22 Thread Paul B Mahol
On 9/20/16, Carl Eugen Hoyos wrote: > 2016-09-19 14:57 GMT+02:00 Paul B Mahol : >> On 9/19/16, Paul B Mahol wrote: > >>> Ignore that one above, patck with corrected text is ok. >> >> title should mentioned what kind of aspect ratio this is

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-20 Thread Carl Eugen Hoyos
2016-09-19 14:57 GMT+02:00 Paul B Mahol : > On 9/19/16, Paul B Mahol wrote: >> Ignore that one above, patck with corrected text is ok. > > title should mentioned what kind of aspect ratio this is about. As I > thought it is about sar. Log message changed

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 15:27 GMT+02:00 Paul B Mahol : > On 9/19/16, Carl Eugen Hoyos wrote: >> 2016-09-19 14:57 GMT+02:00 Paul B Mahol : >> >>> title should mentioned what kind of aspect ratio this is about. >>> As I thought it is about sar. >> >> I

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Carl Eugen Hoyos wrote: > 2016-09-19 14:57 GMT+02:00 Paul B Mahol : > >> title should mentioned what kind of aspect ratio this is about. >> As I thought it is about sar. > > I don't understand: FFmpeg only knows about sample aspect > ratio (also

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 14:57 GMT+02:00 Paul B Mahol : > title should mentioned what kind of aspect ratio this is about. > As I thought it is about sar. I don't understand: FFmpeg only knows about sample aspect ratio (also known as pixel aspect ratio), display aspect ratio is only shown on

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Paul B Mahol wrote: > On 9/19/16, Paul B Mahol wrote: >> On 9/19/16, Carl Eugen Hoyos wrote: >>> 2016-09-19 14:02 GMT+02:00 Clement Boesch : On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote:

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Paul B Mahol wrote: > On 9/19/16, Carl Eugen Hoyos wrote: >> 2016-09-19 14:02 GMT+02:00 Clement Boesch : >>> On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote: Hi! Attached patch fixes the aspect ratio

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Carl Eugen Hoyos wrote: > 2016-09-19 14:02 GMT+02:00 Clement Boesch : >> On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch fixes the aspect ratio for the sample from >>> ticket #5325 / #2125. >>> >>> The

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Clément Bœsch
On Mon, Sep 19, 2016 at 02:04:43PM +0200, Carl Eugen Hoyos wrote: > 2016-09-19 14:03 GMT+02:00 Clément Bœsch : > > >> > From the code of conduct: "Do not assume malice for things that can be > >> > attributed to incompetence. Even if it is malice, it’s rarely good to > >> > start

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Clément Bœsch
On Mon, Sep 19, 2016 at 02:03:22PM +0200, Carl Eugen Hoyos wrote: > 2016-09-19 14:02 GMT+02:00 Clément Bœsch : > > On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> Attached patch fixes the aspect ratio for the sample from > >> ticket #5325 / #2125.

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 14:03 GMT+02:00 Clément Bœsch : >> > From the code of conduct: "Do not assume malice for things that can be >> > attributed to incompetence. Even if it is malice, it’s rarely good to >> > start with that as initial assumption." >> >> I thought this is not relevant anymore?

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 14:02 GMT+02:00 Clément Bœsch : > On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes the aspect ratio for the sample from >> ticket #5325 / #2125. >> >> The fate test changes because the fate sample was written >> by FFmpeg

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Clément Bœsch
On Mon, Sep 19, 2016 at 02:01:17PM +0200, Carl Eugen Hoyos wrote: > 2016-09-19 14:00 GMT+02:00 Clément Bœsch : > > On Mon, Sep 19, 2016 at 01:37:10PM +0200, Paul B Mahol wrote: > >> On 9/19/16, Carl Eugen Hoyos wrote: > >> > Hi! > >> > > >> > Attached patch fixes

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 14:00 GMT+02:00 Clément Bœsch : > On Mon, Sep 19, 2016 at 01:37:10PM +0200, Paul B Mahol wrote: >> On 9/19/16, Carl Eugen Hoyos wrote: >> > Hi! >> > >> > Attached patch fixes the aspect ratio for the sample from >> > ticket #5325 / #2125. >> > >> > The

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Clément Bœsch
On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes the aspect ratio for the sample from > ticket #5325 / #2125. > > The fate test changes because the fate sample was written > by FFmpeg with an incorrect aspect ratio. > > Please comment, Carl

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Clément Bœsch
On Mon, Sep 19, 2016 at 01:37:10PM +0200, Paul B Mahol wrote: > On 9/19/16, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes the aspect ratio for the sample from > > ticket #5325 / #2125. > > > > The fate test changes because the fate sample was written > > by

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 13:57 GMT+02:00 Paul B Mahol : > On 9/19/16, Carl Eugen Hoyos wrote: >> 2016-09-19 13:37 GMT+02:00 Paul B Mahol : >>> On 9/19/16, Carl Eugen Hoyos wrote: Hi! Attached patch fixes the aspect ratio

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Carl Eugen Hoyos wrote: > 2016-09-19 13:37 GMT+02:00 Paul B Mahol : >> On 9/19/16, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch fixes the aspect ratio for the sample from >>> ticket #5325 / #2125. >>> >>> The fate test

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 13:37 GMT+02:00 Paul B Mahol : > On 9/19/16, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes the aspect ratio for the sample from >> ticket #5325 / #2125. >> >> The fate test changes because the fate sample was written >> by FFmpeg with an

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes the aspect ratio for the sample from > ticket #5325 / #2125. > > The fate test changes because the fate sample was written > by FFmpeg with an incorrect aspect ratio. > > Please comment, Carl Eugen > > From

[FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
Hi! Attached patch fixes the aspect ratio for the sample from ticket #5325 / #2125. The fate test changes because the fate sample was written by FFmpeg with an incorrect aspect ratio. Please comment, Carl Eugen From 0553b0adfee87401854f0313dbcf386f2fb7ae68 Mon Sep 17 00:00:00 2001 From: Carl