Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-13 Thread James Almer
On 4/13/2019 10:46 AM, Carl Eugen Hoyos wrote: > 2019-04-13 15:28 GMT+02:00, James Almer : > >> It would be nice to know what the reference decoder does > > That's why I told you;-) I must have missed it. Outside of saying its output is bitexact for the first sample as ffmpeg after my patch, i d

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-13 Thread Carl Eugen Hoyos
2019-04-13 15:28 GMT+02:00, James Almer : > It would be nice to know what the reference decoder does That's why I told you;-) Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscr

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-13 Thread James Almer
On 4/13/2019 10:28 AM, James Almer wrote: > On 4/13/2019 5:44 AM, Carl Eugen Hoyos wrote: >> 2019-04-10 21:47 GMT+02:00, Carl Eugen Hoyos : >>> 2019-04-09 20:32 GMT+02:00, James Almer : Fixes ticket #7174. Signed-off-by: James Almer --- This makes what's essentially a non

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-13 Thread James Almer
On 4/13/2019 5:44 AM, Carl Eugen Hoyos wrote: > 2019-04-10 21:47 GMT+02:00, Carl Eugen Hoyos : >> 2019-04-09 20:32 GMT+02:00, James Almer : >>> Fixes ticket #7174. >>> >>> Signed-off-by: James Almer >>> --- >>> This makes what's essentially a non spec compliant >>> stream decodable again with no v

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-13 Thread Carl Eugen Hoyos
2019-04-10 21:47 GMT+02:00, Carl Eugen Hoyos : > 2019-04-09 20:32 GMT+02:00, James Almer : >> Fixes ticket #7174. >> >> Signed-off-by: James Almer >> --- >> This makes what's essentially a non spec compliant >> stream decodable again with no visual artifacts, and >> without reintroducing the risk

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-10 Thread Carl Eugen Hoyos
2019-04-09 20:32 GMT+02:00, James Almer : > Fixes ticket #7174. > > Signed-off-by: James Almer > --- > This makes what's essentially a non spec compliant > stream decodable again with no visual artifacts, and > without reintroducing the risk of overflows. Your patch leads to bit-exact output with

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-10 Thread James Almer
On 4/10/2019 5:24 AM, Michael Niedermayer wrote: > On Tue, Apr 09, 2019 at 03:32:26PM -0300, James Almer wrote: >> Fixes ticket #7174. >> >> Signed-off-by: James Almer >> --- >> This makes what's essentially a non spec compliant stream decodable again >> with >> no visual artifacts, and without r

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-10 Thread Michael Niedermayer
On Tue, Apr 09, 2019 at 03:32:26PM -0300, James Almer wrote: > Fixes ticket #7174. > > Signed-off-by: James Almer > --- > This makes what's essentially a non spec compliant stream decodable again with > no visual artifacts, and without reintroducing the risk of overflows. > > Alternatively, we

[FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-09 Thread James Almer
Fixes ticket #7174. Signed-off-by: James Almer --- This makes what's essentially a non spec compliant stream decodable again with no visual artifacts, and without reintroducing the risk of overflows. Alternatively, we could clip the luma and chroma values to the -128..127 range instead of settin