Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-16 Thread Bohan Li
Gentle ping :) On Mon, Nov 9, 2020 at 11:00 AM Bohan Li wrote: > I have added a feature request in the libaom issue tracker for the key & > value api, although it may take some time for the api to land. Meanwhile I > still suggest that we apply this patch to ffmpeg since as mentioned this >

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-09 Thread Bohan Li
I have added a feature request in the libaom issue tracker for the key & value api, although it may take some time for the api to land. Meanwhile I still suggest that we apply this patch to ffmpeg since as mentioned this option can be quite important for subjective quality control. Please let me

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-06 Thread Bohan Li
Thanks a lot for the comment, Jan and Steven! Yes I very much agree that the number of options is quite large and this is not a great path to go for. But for the moment I still suggest that we apply this patch, while proposing to libaom for a key & value api. This option gives users the option to

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-06 Thread Jan Ekström
On Fri, Nov 6, 2020 at 11:46 AM Steven Liu wrote: > > > > > 2020年11月6日 下午4:42,Bohan Li 写道: > > > > Thanks for the reply, Steven! > > > > Regarding JEEB’s comment, the suggestion was to add an api to the *libaom* > > library, not to ffmpeg. I do agree with the rationale, but when such an api >

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-06 Thread Steven Liu
> 2020年11月6日 下午4:42,Bohan Li 写道: > > Thanks for the reply, Steven! > > Regarding JEEB’s comment, the suggestion was to add an api to the *libaom* > library, not to ffmpeg. I do agree with the rationale, but when such an api > would be available for ffmpeg to use is quite uncertain. In the

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-06 Thread Bohan Li
Thanks for the reply, Steven! Regarding JEEB’s comment, the suggestion was to add an api to the *libaom* library, not to ffmpeg. I do agree with the rationale, but when such an api would be available for ffmpeg to use is quite uncertain. In the meanwhile, I believe it is reasonable to add in this

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-05 Thread Steven Liu
> 2020年11月6日 上午2:29,Bohan Li 写道: > > Another ping :) I think maybe you should fix JEEB’s review comment, then will get responses comments. Not only apply a middle version. > > Bohan > > On Fri, Oct 30, 2020 at 2:43 PM Bohan Li wrote: > >> Gentle ping :) >> >> Bohan >> >> On Tue, Oct 27,

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-05 Thread Bohan Li
Another ping :) Bohan On Fri, Oct 30, 2020 at 2:43 PM Bohan Li wrote: > Gentle ping :) > > Bohan > > On Tue, Oct 27, 2020 at 4:13 PM Bohan Li wrote: > >> Hi Jan, >> >> Thanks for the suggestion! I believe that is a good idea. I am not super >> familiar with this part, though, so will probably

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-30 Thread Bohan Li
Gentle ping :) Bohan On Tue, Oct 27, 2020 at 4:13 PM Bohan Li wrote: > Hi Jan, > > Thanks for the suggestion! I believe that is a good idea. I am not super > familiar with this part, though, so will probably need to propose this to > the Aomedia issue tracker. > Meanwhile I think it is also

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-27 Thread Bohan Li
Hi Jan, Thanks for the suggestion! I believe that is a good idea. I am not super familiar with this part, though, so will probably need to propose this to the Aomedia issue tracker. Meanwhile I think it is also useful to expose useful options (like this one, enable-keyframe-filtering, which is

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-27 Thread Jan Ekström
On Tue, Oct 27, 2020 at 10:38 PM Bohan Li wrote: > > Add the option to use -enable-keyframe-filtering with libaom-av1 > codec. The option controls the encoder behavior on performing > temporal filtering on keyframes. > Hi, Looking at the amount of options etc which you want to expose to FFmpeg

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-27 Thread Bohan Li
Thanks for the comment, Mark. Indeed this may not be helpful for people who did not know the background of such parameters. I added more details to it so people could understand the trade-off behind it better. Will re-submit the patch soon. Best, Bohan On Tue, Oct 27, 2020 at 1:26 PM Mark

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-27 Thread Mark Thompson
On 26/10/2020 22:04, Bohan Li wrote: Add the option to use -enable-keyframe-filtering with libaom-av1 codec. The option controls the encoder behavior on performing temporal filtering on keyframes. Signed-off-by: Bohan Li --- doc/encoders.texi | 13 + libavcodec/libaomenc.c

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
Thanks a lot for the explanation! I'll add the documentation accordingly. Best, Bohan On Mon, Oct 26, 2020 at 2:46 PM James Almer wrote: > On 10/26/2020 6:21 PM, Bohan Li wrote: > > > Regarding the last comment, the enable-keyframe-filtering parameter was a > > boolean, but recently there is

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread James Almer
On 10/26/2020 6:21 PM, Bohan Li wrote: > Regarding the last comment, the enable-keyframe-filtering parameter was a > boolean, but recently there is one more option added to libaom > (--enable-keyframe-filtering=2), so I thought it would be better to use > AV_OPT_TYPE_INT here so people who build

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
Thank you for the prompt response! I'll fix the typo, add documentation and re-submit. Regarding the last comment, the enable-keyframe-filtering parameter was a boolean, but recently there is one more option added to libaom (--enable-keyframe-filtering=2), so I thought it would be better to use

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread James Almer
On 10/26/2020 6:01 PM, Bohan Li wrote: > Signed-off-by: Bohan Li > --- > libavcodec/libaomenc.c | 5 + > 1 file changed, 5 insertions(+) Missing documentation. > > diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c > index 2b0581b15a..a5d9843ae2 100644 > ---