Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-12 Thread James Almer
On 6/12/2020 7:05 AM, Anton Khirnov wrote: > Quoting James Almer (2020-06-10 14:46:21) >> On 6/10/2020 6:19 AM, Anton Khirnov wrote: >>> Quoting James Almer (2020-06-09 14:45:33) On 6/9/2020 6:06 AM, Anton Khirnov wrote: > I don't think this needs to be visible externally, since it's only

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-12 Thread Kieran Kunhya
> > It still seems to me that this is a solution in search of a problem. If > I understand you correctly, the case you have in mind is a codec where > there is an internal implementation that only supports intra frames > and an external implementation that also supports inter frames. > But that

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-12 Thread Anton Khirnov
Quoting James Almer (2020-06-10 14:46:21) > On 6/10/2020 6:19 AM, Anton Khirnov wrote: > > Quoting James Almer (2020-06-09 14:45:33) > >> On 6/9/2020 6:06 AM, Anton Khirnov wrote: > >>> I don't think this needs to be visible externally, since it's only > >>> meaningful for internal use. I'm

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-10 Thread James Almer
On 6/10/2020 6:19 AM, Anton Khirnov wrote: > Quoting James Almer (2020-06-09 14:45:33) >> On 6/9/2020 6:06 AM, Anton Khirnov wrote: >>> I don't think this needs to be visible externally, since it's only >>> meaningful for internal use. I'm wondering if the presence of >>> update_thread_context()

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-10 Thread Anton Khirnov
Quoting James Almer (2020-06-09 14:45:33) > On 6/9/2020 6:06 AM, Anton Khirnov wrote: > > I don't think this needs to be visible externally, since it's only > > meaningful for internal use. I'm wondering if the presence of > > update_thread_context() callback won't be sufficient for this. > >

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-09 Thread James Almer
On 6/9/2020 6:06 AM, Anton Khirnov wrote: > Quoting James Almer (2020-06-08 18:30:16) >> On 6/8/2020 10:46 AM, James Almer wrote: >>> On 6/8/2020 7:54 AM, Anton Khirnov wrote: Quoting Hendrik Leppkes (2020-06-08 12:42:08) > On Mon, Jun 8, 2020 at 12:22 PM Anton Khirnov wrote: >>

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-09 Thread Anton Khirnov
Quoting James Almer (2020-06-08 18:30:16) > On 6/8/2020 10:46 AM, James Almer wrote: > > On 6/8/2020 7:54 AM, Anton Khirnov wrote: > >> Quoting Hendrik Leppkes (2020-06-08 12:42:08) > >>> On Mon, Jun 8, 2020 at 12:22 PM Anton Khirnov wrote: > > This stops update_thread_context() from

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-08 Thread James Almer
On 6/8/2020 10:46 AM, James Almer wrote: > On 6/8/2020 7:54 AM, Anton Khirnov wrote: >> Quoting Hendrik Leppkes (2020-06-08 12:42:08) >>> On Mon, Jun 8, 2020 at 12:22 PM Anton Khirnov wrote: This stops update_thread_context() from being called with frame threading, which causes

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-08 Thread James Almer
On 6/8/2020 7:54 AM, Anton Khirnov wrote: > Quoting Hendrik Leppkes (2020-06-08 12:42:08) >> On Mon, Jun 8, 2020 at 12:22 PM Anton Khirnov wrote: >>> >>> This stops update_thread_context() from being called with frame >>> threading, which causes races. >>> --- >>> libavcodec/codec_desc.c | 2 +-

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-08 Thread Paul B Mahol
On 6/8/20, Anton Khirnov wrote: > This stops update_thread_context() from being called with frame > threading, which causes races. > --- > libavcodec/codec_desc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c > index

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-08 Thread Anton Khirnov
Quoting Hendrik Leppkes (2020-06-08 12:42:08) > On Mon, Jun 8, 2020 at 12:22 PM Anton Khirnov wrote: > > > > This stops update_thread_context() from being called with frame > > threading, which causes races. > > --- > > libavcodec/codec_desc.c | 2 +- > > 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-08 Thread Hendrik Leppkes
On Mon, Jun 8, 2020 at 12:22 PM Anton Khirnov wrote: > > This stops update_thread_context() from being called with frame > threading, which causes races. > --- > libavcodec/codec_desc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/codec_desc.c