Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-12 Thread wm4
On Tue, 12 Dec 2017 18:28:28 -0300 James Almer wrote: > On 12/12/2017 4:38 AM, wm4 wrote: > > On Mon, 11 Dec 2017 22:56:24 +0100 > > Michael Niedermayer wrote: > > > >> On Mon, Dec 11, 2017 at 11:43:30AM +0100, wm4 wrote: > >>> On Fri, 8 Dec 2017

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-12 Thread Carl Eugen Hoyos
2017-12-12 22:26 GMT+01:00 wm4 : > On Tue, 12 Dec 2017 22:13:30 +0100 > Carl Eugen Hoyos wrote: > >> 2017-12-12 22:12 GMT+01:00 Paul B Mahol : >> > On 12/12/17, Carl Eugen Hoyos wrote: >> >> 2017-12-11 11:43

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-12 Thread James Almer
On 12/12/2017 4:38 AM, wm4 wrote: > On Mon, 11 Dec 2017 22:56:24 +0100 > Michael Niedermayer wrote: > >> On Mon, Dec 11, 2017 at 11:43:30AM +0100, wm4 wrote: >>> On Fri, 8 Dec 2017 18:51:52 +0100 >>> Carl Eugen Hoyos wrote: >>> 2017-12-08

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-12 Thread wm4
On Tue, 12 Dec 2017 22:13:30 +0100 Carl Eugen Hoyos wrote: > 2017-12-12 22:12 GMT+01:00 Paul B Mahol : > > On 12/12/17, Carl Eugen Hoyos wrote: > >> 2017-12-11 11:43 GMT+01:00 wm4 : > >> > >>> You've been

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-12 Thread Carl Eugen Hoyos
2017-12-12 22:12 GMT+01:00 Paul B Mahol : > On 12/12/17, Carl Eugen Hoyos wrote: >> 2017-12-11 11:43 GMT+01:00 wm4 : >> >>> You've been ignoring this issue, though. >> >> Please stop using this mailing list for your insults. > > Nobody

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-12 Thread Paul B Mahol
On 12/12/17, Carl Eugen Hoyos wrote: > 2017-12-11 11:43 GMT+01:00 wm4 : > >> You've been ignoring this issue, though. > > Please stop using this mailing list for your insults. Nobody insulted you, perhaps you should be really insulted anyway.

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-12 Thread Carl Eugen Hoyos
2017-12-11 11:43 GMT+01:00 wm4 : > You've been ignoring this issue, though. Please stop using this mailing list for your insults. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-11 Thread wm4
On Mon, 11 Dec 2017 22:56:24 +0100 Michael Niedermayer wrote: > On Mon, Dec 11, 2017 at 11:43:30AM +0100, wm4 wrote: > > On Fri, 8 Dec 2017 18:51:52 +0100 > > Carl Eugen Hoyos wrote: > > > > > 2017-12-08 18:45 GMT+01:00 Tiejun.Peng

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-11 Thread Michael Niedermayer
On Mon, Dec 11, 2017 at 11:43:30AM +0100, wm4 wrote: > On Fri, 8 Dec 2017 18:51:52 +0100 > Carl Eugen Hoyos wrote: > > > 2017-12-08 18:45 GMT+01:00 Tiejun.Peng : > > > i agree with you. too much experience value in condition of Judgement > > > like

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-11 Thread wm4
On Fri, 8 Dec 2017 18:51:52 +0100 Carl Eugen Hoyos wrote: > 2017-12-08 18:45 GMT+01:00 Tiejun.Peng : > > i agree with you. too much experience value in condition of Judgement > > like this: > > "else if(max_frames>=4 && max_frames >=

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-08 Thread Carl Eugen Hoyos
2017-12-08 18:45 GMT+01:00 Tiejun.Peng : > i agree with you. too much experience value in condition of Judgement like > this: > "else if(max_frames>=4 && max_frames >= p->buf_size/1)". > why it is the value ? it is hard to known. > maybe the work of cleaned up

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-08 Thread Tiejun.Peng
i just repair of the probe. -- Original -- From: "wm4";<nfx...@googlemail.com>; Send time: Thursday, Dec 7, 2017 9:16 PM To: "ffmpeg-devel"<ffmpeg-devel@ffmpeg.org>; Subject: Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail On Wed, 6 Dec

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-08 Thread Tiejun.Peng
-- From: "Carl Eugen Hoyos";<ceffm...@gmail.com>; Send time: Saturday, Dec 9, 2017 0:21 AM To: "FFmpeg development discussions and patches"<ffmpeg-devel@ffmpeg.org>; Subject: Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail 2017-12-08 17:13

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-08 Thread Carl Eugen Hoyos
2017-12-08 17:13 GMT+01:00 Tiejun.Peng : > can this commit be merged into master? Given that it would introduce a regression, I guess not. More important though: I cannot reproduce successful playback with vlc - can you provide the output file that vlc produces for you?

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-08 Thread Tiejun.Peng
om>; Send time: Thursday, Dec 7, 2017 0:00 AM To: "FFmpeg development discussions and patches"<ffmpeg-devel@ffmpeg.org>; Subject: Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail 2017-12-06 10:27 GMT+01:00 tiejun.peng <tiejun.p...@foxmail.com>: > fix #6895:

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-07 Thread wm4
On Wed, 6 Dec 2017 17:27:43 +0800 "tiejun.peng" wrote: > fix #6895: https://trac.ffmpeg.org/ticket/6895 > stream:https://trac.ffmpeg.org/attachment/ticket/6895/music_mp3 > > Signed-off-by: tiejun.peng > --- > libavformat/mp3dec.c | 4 >

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-07 Thread Tiejun.Peng
velopment discussions and patches"<ffmpeg-devel@ffmpeg.org>; Subject: Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail 2017-12-06 10:27 GMT+01:00 tiejun.peng <tiejun.p...@foxmail.com>: > fix #6895: https://trac.ffmpeg.org/ticket/6895 The patch brea

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

2017-12-06 Thread Carl Eugen Hoyos
2017-12-06 10:27 GMT+01:00 tiejun.peng : > fix #6895: https://trac.ffmpeg.org/ticket/6895 The patch breaks issue3327-libc-2.17.so > stream:https://trac.ffmpeg.org/attachment/ticket/6895/music_mp3 Which player does something useful with this file? I am not saying there