Juan De León (12019-08-19):
> > > +size_t size = sizeof(AVEncodeInfoFrame) +
> > sizeof(AVEncodeInfoBlock)*FFMAX((int)(nb_blocks - 1), 0);
> >
> > (Commenting from my phone because urgent.)
> > This line do not make sense to me. Can you explain the reason for the
> > cast and how you avoid
On Sat, Aug 17, 2019 at 7:00 AM Nicolas George wrote:
> > +#define AV_ENCODE_INFO_MAX_BLOCKS 33177600
> > +
> > +static int init_encode_info_data(AVEncodeInfoFrame *info, unsigned int
> nb_blocks) {
> > +info->nb_blocks = nb_blocks;
> > +info->block_size = sizeof(AVEncodeInfoBlock);
> >
Juan De León (12019-08-16):
> AVEncodeInfoFrame data structure to store as AVFrameSideData of type
> AV_FRAME_DATA_ENCODE_INFO.
> The structure stores quantization index for each plane, DC/AC deltas
> for luma and chroma planes, and an array of AVEncodeInfoBlock type
> denoting position, size, and
- Forwarded message from Nicolas George -
Date: Fri, 16 Aug 2019 13:55:18 +0200
From: Nicolas George
To: Juan De León
Subject: Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures
Juan De León (12019-08-15):
> I don't think it's common for size_t to wrap around.
siz
Juan De León (12019-08-15):
> AVEncodeInfoFrame data structure to store as AVFrameSideData of type
> AV_FRAME_DATA_ENCODE_INFO.
> The structure stores quantization index for each plane, DC/AC deltas
> for luma and chroma planes, and an array of AVEncodeInfoBlock type
> denoting position, size, and
On 8/15/2019 3:47 PM, Nicolas George wrote:
> Alex Sukhanov (12019-08-15):
>> Time is important here. Juan's internship is ending soon. Juan has been
>> working with Lynne on this design. Since there is back and forth emails in
>> this thread, it would be very helpful for Juan if Nicolas and Lynne
Aug 15, 2019, 19:47 by geo...@nsup.org:
> Alex Sukhanov (12019-08-15):
>
>> Time is important here. Juan's internship is ending soon. Juan has been
>> working with Lynne on this design. Since there is back and forth emails in
>> this thread, it would be very helpful for Juan if Nicolas and Lynne
Alex Sukhanov (12019-08-15):
> Time is important here. Juan's internship is ending soon. Juan has been
> working with Lynne on this design. Since there is back and forth emails in
> this thread, it would be very helpful for Juan if Nicolas and Lynne get to
> some agreement, rather than have intern
On Thu, Aug 15, 2019 at 11:07 AM Nicolas George wrote:
> Juan De León (12019-08-15):
> > Ping. Does anyone have any more feedback?
> > If not, can anyone review this for pushing.
>
> Less than 24 hours feel a bit short to get impatient.
>
> Regards,
>
> --
> Nicolas George
>
Juan De León (12019-08-14):
> In that case, I believe documenting the size of the array and behaviour of
> undefined indexes should be enough. Have the pointers return NULL,
> and let the user handle the result, instead of stopping the execution.
I disagree. Either drop the check altogether or
Juan De León (12019-08-15):
> Ping. Does anyone have any more feedback?
> If not, can anyone review this for pushing.
Less than 24 hours feel a bit short to get impatient.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
On Thu, Aug 15, 2019 at 7:43 PM Juan De León <
juandl-at-google@ffmpeg.org> wrote:
> On Wed, Aug 14, 2019 at 12:11 PM Juan De León wrote:
>
> > AVEncodeInfoFrame data structure to store as AVFrameSideData of type
> > AV_FRAME_DATA_ENCODE_INFO.
> > The structure stores quantization index for
On Wed, Aug 14, 2019 at 12:11 PM Juan De León wrote:
> AVEncodeInfoFrame data structure to store as AVFrameSideData of type
> AV_FRAME_DATA_ENCODE_INFO.
> The structure stores quantization index for each plane, DC/AC deltas
> for luma and chroma planes, and an array of AVEncodeInfoBlock type
>
On Wed, Aug 14, 2019 at 12:10 AM Nicolas George wrote:
> James Almer (12019-08-13):
> > I'm fairly sure this was discussed before, but invalid arguments
> > shouldn't crash an user's application. They even have their own
> > standardized errno value for this purpose.
> > asserts() are to catch
James Almer (12019-08-13):
> I'm fairly sure this was discussed before, but invalid arguments
> shouldn't crash an user's application. They even have their own
> standardized errno value for this purpose.
> asserts() are to catch bugs in our code, not in theirs. Returning a NULL
> pointer is the
On Tue, Aug 13, 2019 at 4:49 PM James Almer wrote:
> I'm fairly sure this was discussed before, but invalid arguments
> shouldn't crash an user's application. They even have their own
> standardized errno value for this purpose.
> asserts() are to catch bugs in our code, not in theirs. Returning
On 8/13/2019 7:29 PM, Nicolas George wrote:
> Juan De León (12019-08-13):
>> The array is there so that the structure isn't opaque, it should be
>> accessed with the function.
>
> I realize you need it, but not for the reason you say. It is needed for
> alignment: if blocks needs more alignment
Juan De León (12019-08-13):
> The array is there so that the structure isn't opaque, it should be
> accessed with the function.
I realize you need it, but not for the reason you say. It is needed for
alignment: if blocks needs more alignment than info, info+sizeof(info)
is not a valid pointer for
On Tue, Aug 13, 2019 at 2:49 PM Nicolas George wrote:
> > +info->blocks_offset = offsetof(AVEncodeInfoFrame, blocks);
>
> You can use sizeof(AVEncodeInfoFrame) and dispense with the blocks final
> array entirely.
>
The array is there so that the structure isn't opaque, it should be
accessed
Juan De León (12019-08-13):
> AVEncodeInfoFrame data structure to store as AVFrameSideData of type
> AV_FRAME_DATA_ENCODE_INFO.
> The structure stores quantization index for each plane, DC/AC deltas
> for luma and chroma planes, and an array of AVEncodeInfoBlock type
> denoting position, size, and
On Mon, Aug 12, 2019 at 11:25:59AM -0700, Juan De León wrote:
> Pinging,
> Any other opinions?
About adding a reserved[128] ?
i think storing the size somewhere is probably better (less memory, and
not having an arbitrary limit which could theoretically be hit one day)
thx
[...]
--
Michael
Pinging,
Any other opinions?
On Sat, Aug 10, 2019 at 2:22 AM Nicolas George wrote:
> Lynne (12019-08-10):
> > >> +typedef struct AVEncodeInfoBlock{
> > >> +/**
> > >> + * Distance in luma pixels from the top-left corner of the
> visible frame
> > >> + * to the top-left corner of the
Lynne (12019-08-10):
> >> +typedef struct AVEncodeInfoBlock{
> >> +/**
> >> + * Distance in luma pixels from the top-left corner of the visible
> >> frame
> >> + * to the top-left corner of the block.
> >> + * Can be negative if top/right padding is present on the coded frame.
>
Aug 9, 2019, 22:54 by geo...@nsup.org:
> Juan De León (12019-08-09):
>
>> AVEncodeInfoFrame data structure to store as AVFrameSideData of type
>> AV_FRAME_DATA_ENCODE_INFO.
>> The structure stores quantization index for each plane, DC/AC deltas
>> for luma and chroma planes, and an array of
Juan De León (12019-08-09):
> AVEncodeInfoFrame data structure to store as AVFrameSideData of type
> AV_FRAME_DATA_ENCODE_INFO.
> The structure stores quantization index for each plane, DC/AC deltas
> for luma and chroma planes, and an array of AVEncodeInfoBlock type
> denoting position, size, and
On 8/9/2019 3:28 PM, Nicolas George wrote:
> James Almer (12019-08-09):
>> Or just a pointer that points to the first byte after itself.
>
> The pointer takes places by itself. And it prevents the structure from
> being copied flatly, which IIRC is forbidden with side data.
Yeah, you're right,
James Almer (12019-08-09):
> Or just a pointer that points to the first byte after itself.
The pointer takes places by itself. And it prevents the structure from
being copied flatly, which IIRC is forbidden with side data.
By the way, the lines of the commit message are too long.
Regards,
--
On 8/9/2019 2:58 PM, Hendrik Leppkes wrote:
> On Fri, Aug 9, 2019 at 7:52 PM James Almer wrote:
>>
>> On 8/9/2019 2:38 PM, Juan De León wrote:
>>> AVEncodeInfoFrame data structure to store as AVFrameSideData of type
>>> AV_FRAME_DATA_ENCODE_INFO.
>>> The structure stores quantization index for
On Fri, Aug 9, 2019 at 7:52 PM James Almer wrote:
>
> On 8/9/2019 2:38 PM, Juan De León wrote:
> > AVEncodeInfoFrame data structure to store as AVFrameSideData of type
> > AV_FRAME_DATA_ENCODE_INFO.
> > The structure stores quantization index for each plane, DC/AC deltas for
> > luma and chroma
On 8/9/2019 2:38 PM, Juan De León wrote:
> AVEncodeInfoFrame data structure to store as AVFrameSideData of type
> AV_FRAME_DATA_ENCODE_INFO.
> The structure stores quantization index for each plane, DC/AC deltas for luma
> and chroma planes, and an array of AVEncodeInfoBlock struct denoting
>
30 matches
Mail list logo
