Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

On Fri, Sep 15, 2017 at 08:35:25AM -0700, Thierry Foucu wrote: > On Fri, Sep 15, 2017 at 8:24 AM, Carl Eugen Hoyos > wrote: > > > 2017-09-15 17:13 GMT+02:00 Thierry Foucu : > > > > >> Too fast to reply again, my bad. It's indeed a GCC bug. > > > > > > Sorry

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

On Fri, Sep 15, 2017 at 8:24 AM, Carl Eugen Hoyos wrote: > 2017-09-15 17:13 GMT+02:00 Thierry Foucu : > > >> Too fast to reply again, my bad. It's indeed a GCC bug. > > > > Sorry about it. I'm glad you found the problem. > > I suspect the comment above only

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

2017-09-15 17:13 GMT+02:00 Thierry Foucu : >> Too fast to reply again, my bad. It's indeed a GCC bug. > > Sorry about it. I'm glad you found the problem. I suspect the comment above only applies to the asan hang, a valgrind issue was also mentioned in this thread. Carl Eugen

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

HI Clement On Fri, Sep 15, 2017 at 7:55 AM, Clément Bœsch wrote: > On Fri, Sep 15, 2017 at 04:53:45PM +0200, Clément Bœsch wrote: > > On Fri, Sep 15, 2017 at 11:15:14AM -0300, James Almer wrote: > > > On 9/15/2017 10:15 AM, Clément Bœsch wrote: > > > > On Fri, Sep 15, 2017 at

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

On Fri, Sep 15, 2017 at 04:53:45PM +0200, Clément Bœsch wrote: > On Fri, Sep 15, 2017 at 11:15:14AM -0300, James Almer wrote: > > On 9/15/2017 10:15 AM, Clément Bœsch wrote: > > > On Fri, Sep 15, 2017 at 02:44:59AM +0200, Michael Niedermayer wrote: > > >> On Tue, Sep 12, 2017 at 06:45:57PM -0700,

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

On Fri, Sep 15, 2017 at 11:15:14AM -0300, James Almer wrote: > On 9/15/2017 10:15 AM, Clément Bœsch wrote: > > On Fri, Sep 15, 2017 at 02:44:59AM +0200, Michael Niedermayer wrote: > >> On Tue, Sep 12, 2017 at 06:45:57PM -0700, Thierry Foucu wrote: > >>> Fix ticket #2674 > >>> Tested with examples

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

On 9/15/2017 10:15 AM, Clément Bœsch wrote: > On Fri, Sep 15, 2017 at 02:44:59AM +0200, Michael Niedermayer wrote: >> On Tue, Sep 12, 2017 at 06:45:57PM -0700, Thierry Foucu wrote: >>> Fix ticket #2674 >>> Tested with examples from ticket 2674. >>> --- >>> Sorry Michael, I forgot to configure

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

On Fri, Sep 15, 2017 at 02:44:59AM +0200, Michael Niedermayer wrote: > On Tue, Sep 12, 2017 at 06:45:57PM -0700, Thierry Foucu wrote: > > Fix ticket #2674 > > Tested with examples from ticket 2674. > > --- > > Sorry Michael, I forgot to configure using --enable-gpl. > > Please find new patch. > >

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

On Tue, Sep 12, 2017 at 06:45:57PM -0700, Thierry Foucu wrote: > Fix ticket #2674 > Tested with examples from ticket 2674. > --- > Sorry Michael, I forgot to configure using --enable-gpl. > Please find new patch. > > > libavfilter/vf_fps.c | 44 >

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

On Tue, Sep 12, 2017 at 6:45 PM, Thierry Foucu wrote: > Fix ticket #2674 > Tested with examples from ticket 2674. > --- > Sorry Michael, I forgot to configure using --enable-gpl. > Please find new patch. > > > ping? > libavfilter/vf_fps.c | 44

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

On Mon, Sep 11, 2017 at 06:25:08PM -0700, Thierry Foucu wrote: > Fix ticket #2674 > Tested with examples from ticket 2674. > --- > > Update the Patch with the correct number of duplicate showing. > For exmaple, in case we up-sample one second video at 24fps by 2, we should > be getting 24

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

On Tue, Sep 12, 2017 at 1:35 AM, Thomas Mundt wrote: > Hi Thierry, > > 2017-09-12 3:25 GMT+02:00 Thierry Foucu : > >> Fix ticket #2674 >> Tested with examples from ticket 2674. >> --- >> >> Update the Patch with the correct number of duplicate showing. >>

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

Hi Thierry, 2017-09-12 3:25 GMT+02:00 Thierry Foucu : > Fix ticket #2674 > Tested with examples from ticket 2674. > --- > > Update the Patch with the correct number of duplicate showing. > For exmaple, in case we up-sample one second video at 24fps by 2, we > should be getting

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

Hi Thierry, 2017-09-11 23:00 GMT+02:00 Thierry Foucu : > Fix ticket #2674 > Tested with examples from ticket 2674. > --- > libavfilter/vf_fps.c| 40 +++- > tests/ref/fate/filter-fps | 6 ++ > tests/ref/fate/filter-fps-r | 4

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

See new patch. Getting 12 frame out when down-sample (instead of 13) === I tried it against ticket 2674 and here is the output: ffmpeg -loglevel verbose -i 24fps.avi -vf fps=12 -y 12fps.avi ffmpeg version N-87234-g9a32769f5e Copyright (c) 2000-2017 the FFmpeg

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

Hi Thierry, 2017-09-08 19:03 GMT+02:00 Thierry Foucu : > --- > libavfilter/vf_fps.c| 42 ++ > +++- > tests/ref/fate/filter-fps | 6 ++ > tests/ref/fate/filter-fps-r | 4 > 3 files changed, 47 insertions(+), 5