Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/avienc: Add support for palette side data packets

2016-02-28 Thread Mats Peterson
On 02/28/2016 01:05 PM, Reimar Döffinger wrote: On Sun, Feb 28, 2016 at 12:26:15PM +0100, Mats Peterson wrote: Also it might be helpful for you to have a look at tests/fate/demux.mak and tests/fate/video.mak and use copy-paste to write some basic tests for all the things you implement, so it

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/avienc: Add support for palette side data packets

2016-02-28 Thread Reimar Döffinger
On Sun, Feb 28, 2016 at 12:26:15PM +0100, Mats Peterson wrote: > >Also it might be helpful for you to have a look at tests/fate/demux.mak > >and tests/fate/video.mak and use copy-paste to write some basic tests > >for all the things you implement, so it doesn't get broken the moment > >you look

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/avienc: Add support for palette side data packets

2016-02-28 Thread Mats Peterson
On 02/28/2016 12:59 PM, Reimar Döffinger wrote: On Sun, Feb 28, 2016 at 12:33:16PM +0100, Mats Peterson wrote: On 02/28/2016 12:26 PM, Mats Peterson wrote: On 02/28/2016 12:16 PM, Reimar Döffinger wrote: Well, the documentation says that avio_seek() is a variant of the fseek() function. I

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/avienc: Add support for palette side data packets

2016-02-28 Thread Reimar Döffinger
On Sun, Feb 28, 2016 at 12:33:16PM +0100, Mats Peterson wrote: > On 02/28/2016 12:26 PM, Mats Peterson wrote: > >On 02/28/2016 12:16 PM, Reimar Döffinger wrote: > >Well, the documentation says that avio_seek() is a variant of the > >fseek() function. I would rather say it's a variant of lseek(),

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/avienc: Add support for palette side data packets

2016-02-28 Thread Mats Peterson
On 02/28/2016 12:26 PM, Mats Peterson wrote: On 02/28/2016 12:16 PM, Reimar Döffinger wrote: And Reimar, the AVI muxer libavformat/avienc.c uses *lots* of avio_seek() all over the place, so it won't work well on stdout regardless of my patch. I have checked for avio_seek() returning >= 0 in my

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/avienc: Add support for palette side data packets

2016-02-28 Thread Mats Peterson
On 02/28/2016 12:16 PM, Reimar Döffinger wrote: And Reimar, the AVI muxer libavformat/avienc.c uses *lots* of avio_seek() all over the place, so it won't work well on stdout regardless of my patch. I have checked for avio_seek() returning >= 0 in my part of the code in any case, but it won't

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/avienc: Add support for palette side data packets

2016-02-28 Thread Reimar Döffinger
On Sun, Feb 28, 2016 at 06:11:27AM +0100, Mats Peterson wrote: > On 02/28/2016 05:38 AM, Mats Peterson wrote: > >On 02/28/2016 05:27 AM, Mats Peterson wrote: > >>Use "palette side data" instead of "palette extradata" in error message. > >> > >> > >> >

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/avienc: Add support for palette side data packets

2016-02-27 Thread Mats Peterson
On 02/28/2016 05:38 AM, Mats Peterson wrote: On 02/28/2016 05:27 AM, Mats Peterson wrote: Use "palette side data" instead of "palette extradata" in error message. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/avienc: Add support for palette side data packets

2016-02-27 Thread Mats Peterson
On 02/28/2016 05:27 AM, Mats Peterson wrote: Use "palette side data" instead of "palette extradata" in error message. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Michael, I would like to