Re: [FFmpeg-devel] [RFC]Revert the default for ffplay to -noautoexit

2014-09-08 Thread tim nicholson
On 07/09/14 21:39, Carl Eugen Hoyos wrote: > Hi! > > I have no strong opinion on this but I wonder if ffplay isn't primarily > a test application for which it is very useful not to exit. > +1 > Please comment, Carl Eugen > [..] -- Tim. Key Fingerprint 38CF DB09 3ED0 F607 8B67 6CED 0C0B FC44

[FFmpeg-devel] MXF : default fied dominance is TFF

2014-09-08 Thread Gaullier Nicolas
The field dominance is an optional property in the MXF specifications. It shall be assumed to be 1 (top field first) if not present. Nicolas diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 7a4633f..7517285 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -152,6

Re: [FFmpeg-devel] MXF : default fied dominance is TFF

2014-09-08 Thread Carl Eugen Hoyos
Gaullier Nicolas arkena.com> writes: > case 0x3212: > descriptor->field_dominance = avio_r8(pb); > +descriptor->field_dominance_present = 1; Is it possible to instead initialize descriptor->field_dominance to MXF_TFF? > case SeparateFields: > +

[FFmpeg-devel] [PATCH] lavf/segment: abort in case of invalid segment format options

2014-09-08 Thread Stefano Sabatini
--- libavformat/segment.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 00e5881..72977b1 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -662,6 +662,8 @@ static int seg_write_header(AVFormatContext *s) if (av_dict_c

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself as segment maintainer

2014-09-08 Thread Stefano Sabatini
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ddd84b0..c863e41 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -469,6 +469,7 @@ Muxers/Demuxers: sbgdec.c Nicolas George sdp.c Mart

[FFmpeg-devel] [PATCH 2/2] avdevice/x11grab: fix cursor drawing in multi-screen setup

2014-09-08 Thread Antonio Ospite
The code uses XFixes to retrieve the cursor coordinates, but XFixes gives no information of what screen the pointer is on; this results in always drawing the cursor on the captured screen even if the mouse pointer was on another screen. For example, when capturing from screen 1 (i.e. -f x11grab -i

[FFmpeg-devel] [PATCH 1/2] avdevice/x11grab: rename the "w" Window to "root" in paint_mouse_pointer

2014-09-08 Thread Antonio Ospite
This specifies better the meaning of the variable, and is also in preparation of a subsequent change which will introduce a temporary Window variable for which "w" is an good name. Signed-off-by: Antonio Ospite --- libavdevice/x11grab.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[FFmpeg-devel] [PATCH 0/2] avdevice/x11grab: fix cursor drawing in multi-screen setup

2014-09-08 Thread Antonio Ospite
Hi, with multi-screen setups x11grab does not behave in the correct way wrt. drawing the mouse cursor, e.g. when doing: ffplay -f x11grab -i ":0.1" the mouse cursor was drawn in the captured video even when the mouse pointer was on :0.0. The following patches fix the issue. Patch 1 is just a

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself as segment maintainer

2014-09-08 Thread Michael Niedermayer
On Mon, Sep 08, 2014 at 12:49:59PM +0200, Stefano Sabatini wrote: > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not once nor twice but times without number that the same ideas make their a

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-08 Thread Reinhard Tartler
On Sun, Sep 7, 2014 at 5:30 PM, Michael Niedermayer wrote: > On Fri, Sep 05, 2014 at 08:18:57AM +0200, Reimar Döffinger wrote: >> On 05.09.2014, at 03:46, Reinhard Tartler wrote: >> > On Thu, Sep 4, 2014 at 9:32 PM, Michael Niedermayer >> > wrote: >> >>> At the end of the day, I need a source t

Re: [FFmpeg-devel] MXF : default fied dominance is TFF

2014-09-08 Thread Gaullier Nicolas
I did not found an easy way to set up initialization values to properly handle defaults but I am not a highly skilled developer, and maybe someone will find how to implement this more elegantly. They are also many other properties in mxf that are only optional, for example component depth and ho

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-08 Thread Clément Bœsch
On Mon, Sep 08, 2014 at 08:13:48AM -0400, Reinhard Tartler wrote: [..] > May I ask out of curiosity, what in FFmpeg actually uses libpostproc > other than than libavfilter/vf_pp.c? You said that you prefer to > maintain libpostproc inside FFmpeg because that way you can apply the > FFmpeg test syst

Re: [FFmpeg-devel] [PATCH] lavf/segment: abort in case of invalid segment format options

2014-09-08 Thread Michael Niedermayer
On Mon, Sep 08, 2014 at 12:49:38PM +0200, Stefano Sabatini wrote: > --- > libavformat/segment.c | 2 ++ > 1 file changed, 2 insertions(+) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when they are wro

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-08 Thread Nicolas George
Le duodi 22 fructidor, an CCXXII, Reinhard Tartler a écrit : > May I ask out of curiosity, what in FFmpeg actually uses libpostproc > other than than libavfilter/vf_pp.c? You said that you prefer to > maintain libpostproc inside FFmpeg because that way you can apply the > FFmpeg test system on it.

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-08 Thread Michael Niedermayer
On Mon, Sep 08, 2014 at 08:13:48AM -0400, Reinhard Tartler wrote: > On Sun, Sep 7, 2014 at 5:30 PM, Michael Niedermayer wrote: > > On Fri, Sep 05, 2014 at 08:18:57AM +0200, Reimar Döffinger wrote: > >> On 05.09.2014, at 03:46, Reinhard Tartler wrote: > >> > On Thu, Sep 4, 2014 at 9:32 PM, Michael

Re: [FFmpeg-devel] [PATCH] lavf/segment: abort in case of invalid segment format options

2014-09-08 Thread Stefano Sabatini
On date Monday 2014-09-08 14:21:38 +0200, Michael Niedermayer encoded: > On Mon, Sep 08, 2014 at 12:49:38PM +0200, Stefano Sabatini wrote: > > --- > > libavformat/segment.c | 2 ++ > > 1 file changed, 2 insertions(+) > > LGTM Pushed with a change preventing a leak, thanks. -- FFmpeg = Fancy Fun

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself as segment maintainer

2014-09-08 Thread Stefano Sabatini
On date Monday 2014-09-08 13:22:12 +0200, Michael Niedermayer encoded: > On Mon, Sep 08, 2014 at 12:49:59PM +0200, Stefano Sabatini wrote: > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > LGTM Applied, thanks. -- FFmpeg = Friendly and Fundamental Muttering Patchable Exxager

[FFmpeg-devel] [RFC] ffprobe: add -show_pixel_descriptions option

2014-09-08 Thread Tobias Rapp
As a follow-up to the "ffprobe: Add bits_per_component to stream output" discussion thread here comes my current state of adding pixel format detail output to ffprobe. I'm still unsure if/how to output pixel format flags. Maybe as a simple white-space separated string "rgb alpha be"? Any fee

Re: [FFmpeg-devel] [PATCH 5/5] lavfi/vf_fps: accept EOF timestamp.

2014-09-08 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > Fix trac ticket #2674. > > > > Signed-off-by: Nicolas George nsup.org> > > --- > > libavfilter/vf_fps.c | 33 + > > 1 file changed, 25 insertions(+), 8 deletions(-) > > probably ok Should this get pushed? Carl Eugen __

Re: [FFmpeg-devel] [PATCH 5/5] lavfi/vf_fps: accept EOF timestamp.

2014-09-08 Thread Nicolas George
Le duodi 12 fructidor, an CCXXII, Carl Eugen Hoyos a écrit : > Ping? I am actively procrastinating this patch series because I am not completely satisfied with it. The whole mechanism is fragile, and only works if all filters in the chain can forward the EOF message. If that was the design from th

Re: [FFmpeg-devel] MXF : default fied dominance is TFF

2014-09-08 Thread James Darnley
On 2014-09-08 14:17, Gaullier Nicolas wrote: > [FFmpeg-devel] MXF : default fied dominance is TFF That should be *field* dominance. If you're going to submit another patch please correct the commit message. signature.asc Description: OpenPGP digital signature _

Re: [FFmpeg-devel] [PATCH] Fix vf_cropdetect returning negative rectangles

2014-09-08 Thread hjiodjf 97xgw46
On Thu, Sep 4, 2014 at 1:08 PM, Michael Niedermayer wrote: > On Tue, Sep 02, 2014 at 02:20:40PM -0700, hjiodjf 97xgw46 wrote: >> The cropdetect filter is prone to reporting negative-sized rectangles, >> particularly for dark images. This patch adjusts the limits of the >> filter loops, preventing

[FFmpeg-devel] [PATCH] avformat/rmdec: very basic MLTI support

2014-09-08 Thread Michael Niedermayer
Fixes Ticket2152 Signed-off-by: Michael Niedermayer --- libavformat/rmdec.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index f53ab8c..5d9c9b5 100644 --- a/libavformat/rmdec.c +++ b/libavformat/rmdec.c @@ -315,6 +315,21 @@ ff_r

Re: [FFmpeg-devel] [PATCH] avformat/mpeg: increase score for short mpeg-ps by 1

2014-09-08 Thread Michael Niedermayer
On Sun, Sep 07, 2014 at 07:18:21PM +0200, Michael Niedermayer wrote: > Fixes Ticket 3855 > > Signed-off-by: Michael Niedermayer > --- > libavformat/mpeg.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC78

Re: [FFmpeg-devel] [PATCH] Fix vf_cropdetect returning negative rectangles

2014-09-08 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 02:20:40PM -0700, hjiodjf 97xgw46 wrote: > The cropdetect filter is prone to reporting negative-sized rectangles, > particularly for dark images. This patch adjusts the limits of the > filter loops, preventing the left/right and top/bottom offsets from > crossing each other,

Re: [FFmpeg-devel] [PATCH] Fix vf_cropdetect returning negative rectangles

2014-09-08 Thread Michael Niedermayer
On Mon, Sep 08, 2014 at 11:16:49AM -0700, hjiodjf 97xgw46 wrote: > On Thu, Sep 4, 2014 at 1:08 PM, Michael Niedermayer wrote: > > On Tue, Sep 02, 2014 at 02:20:40PM -0700, hjiodjf 97xgw46 wrote: [...] > Moreover, as you said, this patch reduces the number of passes through > a blank frame from 4

Re: [FFmpeg-devel] [PATCH] avformat/mpeg: increase score for short mpeg-ps by 1

2014-09-08 Thread Timothy Gu
On Sep 7, 2014 10:18 AM, "Michael Niedermayer" wrote: > - : AVPROBE_SCORE_EXTENSION / 2; // 1 more than .mpg > + : AVPROBE_SCORE_EXTENSION / 2 + 1; // 1 more than .mpg The comment should be up

Re: [FFmpeg-devel] [PATCH] avformat/rmdec: very basic MLTI support

2014-09-08 Thread Timothy Gu
On Sep 8, 2014 4:10 PM, "Michael Niedermayer" wrote: > +if (number_of_mdpr != 1) { > +avpriv_request_sample(s, "MLTI with multiple MDPR"); > +} No return? Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:/

Re: [FFmpeg-devel] [PATCH] avformat/mpeg: increase score for short mpeg-ps by 1

2014-09-08 Thread Michael Niedermayer
On Mon, Sep 08, 2014 at 05:21:46PM -0700, Timothy Gu wrote: > On Sep 7, 2014 10:18 AM, "Michael Niedermayer" wrote: > > > - : > AVPROBE_SCORE_EXTENSION / 2; // 1 more than .mpg > > + : > AVPROB

Re: [FFmpeg-devel] [PATCH] avformat/rmdec: very basic MLTI support

2014-09-08 Thread Michael Niedermayer
On Mon, Sep 08, 2014 at 05:23:10PM -0700, Timothy Gu wrote: > On Sep 8, 2014 4:10 PM, "Michael Niedermayer" wrote: > > > +if (number_of_mdpr != 1) { > > +avpriv_request_sample(s, "MLTI with multiple MDPR"); > > +} > > No return? no, i hoped it still might be able to

Re: [FFmpeg-devel] [PATCH 0/2] avdevice/x11grab: fix cursor drawing in multi-screen setup

2014-09-08 Thread Michael Niedermayer
On Mon, Sep 08, 2014 at 01:15:17PM +0200, Antonio Ospite wrote: > Hi, > > with multi-screen setups x11grab does not behave in the correct way wrt. > drawing the mouse cursor, e.g. when doing: > > ffplay -f x11grab -i ":0.1" > > the mouse cursor was drawn in the captured video even when the mou

Re: [FFmpeg-devel] [RFC] ffprobe: add -show_pixel_descriptions option

2014-09-08 Thread Dave Rice
On Sep 8, 2014, at 10:08 AM, Tobias Rapp wrote: > As a follow-up to the "ffprobe: Add bits_per_component to stream output" > discussion thread here comes my current state of adding pixel format detail > output to ffprobe. > > I'm still unsure if/how to output pixel format flags. Maybe as a si

Re: [FFmpeg-devel] [RFC] ffprobe: add -show_pixel_descriptions option

2014-09-08 Thread Tobias Rapp
On 09.09.2014 05:38, Dave Rice wrote: On Sep 8, 2014, at 10:08 AM, Tobias Rapp wrote: BTW: How can one test the ffprobe XML output against the XSD? I tried it with "xmllint --noout --schema doc/ffprobe.xsd ffprobe-output.xml" without success. What tools do other developers use? That's the co