Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 14:02 GMT+02:00 Clément Bœsch : > On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes the aspect ratio for the sample from >> ticket #5325 / #2125. >> >> The fate test changes because the fate sample was written >> by FFmpeg

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 13:37 GMT+02:00 Paul B Mahol : > On 9/19/16, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes the aspect ratio for the sample from >> ticket #5325 / #2125. >> >> The fate test changes because the fate sample was written >> by FFmpeg with an

[FFmpeg-devel] [PATCH v3 03/25] avformat/movenc: support for multiple and client-provided track references

2016-09-19 Thread Erkki Seppälä
Instead of one track reference, allow many, and instead of of track reference type (ie. 'cdsc'), allow many. In addition this patch allows client to explicitly add track references with side packet AV_PKT_DATA_TRACK_REFERENCES containing AVTrackReferences (which of there can many many).

[FFmpeg-devel] [PATCH v3 01/25] avformat/movenc: mov_write_ftyp_tag: write the major brand as a compatible brand

2016-09-19 Thread Erkki Seppälä
when the option "brand" is used. This allows custom brands to end up in the compatible brands as well. Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer --- libavformat/movenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[FFmpeg-devel] [PATCH v3 00/25] Add timed metadata tracks, track references, channel layout

2016-09-19 Thread Erkki Seppälä
Hello again! Here is the patch set version 3 with the goal of adding the following features to the ISO base media file format support of FFmpeg (also available at https://github.com/nokiatech/FFmpeg/tree/timed-metadata-v3): - This patchset is still against the same version of FFmepg as before,

[FFmpeg-devel] [PATCH v3 09/25] avcodec/metaenc, metadec: added an encoder/decoder for timed metadata

2016-09-19 Thread Erkki Seppälä
It has the codec id AV_CODEC_ID_META and type of AVMEDIA_TYPE_DATA. This codec basically passes the data forward and is used for referring timed meta data tracks by a codec. It is useful for dealing with the metadata in a similar way as other kinds of codecs. Signed-off-by: Erkki Seppälä

[FFmpeg-devel] [PATCH v3 04/25] avformat/mov, isom: read (multiple) track references (tag and multiple ids)

2016-09-19 Thread Erkki Seppälä
This can be useful in particular with timed meta data tracks related to multiple tracks. Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer --- libavformat/isom.h | 3 ++ libavformat/mov.c | 119

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes the aspect ratio for the sample from > ticket #5325 / #2125. > > The fate test changes because the fate sample was written > by FFmpeg with an incorrect aspect ratio. > > Please comment, Carl Eugen > > From

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 13:57 GMT+02:00 Paul B Mahol : > On 9/19/16, Carl Eugen Hoyos wrote: >> 2016-09-19 13:37 GMT+02:00 Paul B Mahol : >>> On 9/19/16, Carl Eugen Hoyos wrote: Hi! Attached patch fixes the aspect ratio

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 14:00 GMT+02:00 Clément Bœsch : > On Mon, Sep 19, 2016 at 01:37:10PM +0200, Paul B Mahol wrote: >> On 9/19/16, Carl Eugen Hoyos wrote: >> > Hi! >> > >> > Attached patch fixes the aspect ratio for the sample from >> > ticket #5325 / #2125. >> > >> > The

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Clément Bœsch
On Mon, Sep 19, 2016 at 02:01:17PM +0200, Carl Eugen Hoyos wrote: > 2016-09-19 14:00 GMT+02:00 Clément Bœsch : > > On Mon, Sep 19, 2016 at 01:37:10PM +0200, Paul B Mahol wrote: > >> On 9/19/16, Carl Eugen Hoyos wrote: > >> > Hi! > >> > > >> > Attached patch fixes

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Carl Eugen Hoyos wrote: > 2016-09-19 14:02 GMT+02:00 Clement Boesch : >> On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch fixes the aspect ratio for the sample from >>> ticket #5325 / #2125. >>> >>> The

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-09-19 Thread Richard Kern
> On Sep 10, 2016, at 10:33 PM, Aman Gupta wrote: > > > > On Sunday, September 11, 2016, Richard Kern > wrote: > > > On Sep 8, 2016, at 4:19 AM, Aman Gupta > wrote: > > > > From: Aman Gupta > >

[FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-19 Thread Carl Eugen Hoyos
Hi! We read a display aspect ratio from ARES atom because of several user-provided samples, I believe it makes sense to also write the width value into the ares atom depending on the aspect ratio. Please review, Carl Eugen From ba2a97d8ff012895e39389dee65c075fe7a20f5c Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Paul B Mahol wrote: > On 9/19/16, Paul B Mahol wrote: >> On 9/19/16, Carl Eugen Hoyos wrote: >>> 2016-09-19 14:02 GMT+02:00 Clement Boesch : On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote:

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Interpret unspecified color range as limited range

2016-09-19 Thread Ronald S. Bultje
Hi, On Fri, Sep 16, 2016 at 9:27 AM, Clément Bœsch wrote: > On Fri, Sep 16, 2016 at 03:20:49PM +0200, Vittorio Giovara wrote: > > This is the assumption that is made in pixel format conversion do > > throughout the code (in particular swscale), and BT-specifications > > mandate. >

[FFmpeg-devel] [PATCH v3 25/25] doc/examples/muxing_with_metadata: example for dealing with timed meta data

2016-09-19 Thread Erkki Seppälä
Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer --- configure | 2 + doc/examples/Makefile | 2 + doc/examples/muxing_with_metadata.c | 885 3 files changed, 889

[FFmpeg-devel] [PATCH v3 24/25] doc/examples/extract_timed_metadata: added a bare-bones metadata extractor; find only the frames

2016-09-19 Thread Erkki Seppälä
Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer --- configure | 2 + doc/examples/Makefile | 1 + doc/examples/extract_timed_metadata.c | 230 ++ 3 files changed,

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Carl Eugen Hoyos wrote: > 2016-09-19 14:57 GMT+02:00 Paul B Mahol : > >> title should mentioned what kind of aspect ratio this is about. >> As I thought it is about sar. > > I don't understand: FFmpeg only knows about sample aspect > ratio (also

[FFmpeg-devel] [PATCH v3 23/25] Updated Changelog

2016-09-19 Thread Erkki Seppälä
--- Changelog | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Changelog b/Changelog index c642d08..3d63482 100644 --- a/Changelog +++ b/Changelog @@ -31,6 +31,9 @@ version : - Added support for muxing and demuxing timed metadata tracks (AV_CODEC_ID_META of type AMEDIA_TYPE_DATA). With

[FFmpeg-devel] [PATCH v3 22/25] avutil: added channel_layout_isoiec23001_8.h to HEADERS

2016-09-19 Thread Erkki Seppälä
--- libavutil/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/Makefile b/libavutil/Makefile index 1e06176..731b852 100644 --- a/libavutil/Makefile +++ b/libavutil/Makefile @@ -18,6 +18,7 @@ HEADERS = adler32.h \

[FFmpeg-devel] [PATCH v3 21/25] avformat/mov: read the chnl box as side data AV_PKT_DATA_AUDIO_TRACK_CHANNEL_LAYOUT

2016-09-19 Thread Erkki Seppälä
Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer --- libavformat/mov.c | 96 +++ 1 file changed, 96 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 059c7c4..b48a5d2

[FFmpeg-devel] [PATCH v3 17/25] avformat/mov: read urim metadata from meta

2016-09-19 Thread Erkki Seppälä
The data is read into side packet AV_PKT_DATA_TIMED_METADATA_INFO of format AVTimedMetadata. Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer --- libavformat/mov.c | 141 ++ 1 file changed,

[FFmpeg-devel] [PATCH v3 16/25] avformat/mov: ff_mov_read_stsd_entries now deals with AVMEDIA_TYPE_DATA

2016-09-19 Thread Erkki Seppälä
Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer --- libavformat/mov.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 4dfe1eb..f9126c4 100644 --- a/libavformat/mov.c +++

[FFmpeg-devel] [PATCH v3 20/25] avformat/movenc: mov_write_audio_tag can write the proper number of channels, not the hardcoded 2

2016-09-19 Thread Erkki Seppälä
It does it only when the chnl box is to be written. The specification for the chnl box (ISO 14496-12) requires proper number of channels to be written here is it is used, and without the proper number of channels available it becomes tricky to parse the data, as the number of channels in this box

[FFmpeg-devel] [PATCH v3 19/25] avcodec/avcodec, avformat/movenc: support embedding channel layout to stream side data

2016-09-19 Thread Erkki Seppälä
Added support for passing complex channel layout configuration as side packet data (AV_PKT_DATA_AUDIO_TRACK_CHANNEL_LAYOUT) to ISO media files as specified by ISO/IEC 14496-12. AVAudioTrackChannelLayout has the fields to setting both predefined audio layouts, completely configuring the azimuth and

[FFmpeg-devel] [PATCH v3 13/25] avcodec/utils: do_decode now supports AVMEDIA_TYPE_DATA

2016-09-19 Thread Erkki Seppälä
This allows using avcodec_send_packet with data frames (ie. timed metadata) Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer --- libavcodec/utils.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c

[FFmpeg-devel] [PATCH v3 15/25] avformat/mov: basic support for identifying (and reading) timed metadata

2016-09-19 Thread Erkki Seppälä
mov_codec_id is now able to set AVMEDIA_TYPE_DATA to the st->codec->codec_type field when the input is of type AVMEDIA_TYPE_DATA; previously it used AVMEDIA_TYPE_SUBTITLE as the value to set in that case. Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer

[FFmpeg-devel] [PATCH v3 07/25] avformat/mov: mov_read_tkhd stores alternate group to AV_PKT_DATA_TRACK_ALTERNATE_GROUP

2016-09-19 Thread Erkki Seppälä
This is done only if the option read_alternate_group is set as to not change the behavior when copying tracks. FFmpeg automatically assigns track groups (when no AV_PKT_DATA_TRACK_ALTERNATE_GROUP side data is not available) by the track indices, so if the track indices would be changed, reusing

[FFmpeg-devel] [PATCH v3 18/25] Updated Changelog

2016-09-19 Thread Erkki Seppälä
--- Changelog | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Changelog b/Changelog index 3712172..c642d08 100644 --- a/Changelog +++ b/Changelog @@ -28,7 +28,9 @@ version : - Added side data AV_PKT_DATA_TRACK_ALTERNATE_GROUP for explicitly setting the alternate track groups (supported

[FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
Hi! Attached patch fixes the aspect ratio for the sample from ticket #5325 / #2125. The fate test changes because the fate sample was written by FFmpeg with an incorrect aspect ratio. Please comment, Carl Eugen From 0553b0adfee87401854f0313dbcf386f2fb7ae68 Mon Sep 17 00:00:00 2001 From: Carl

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Clément Bœsch
On Mon, Sep 19, 2016 at 01:37:10PM +0200, Paul B Mahol wrote: > On 9/19/16, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes the aspect ratio for the sample from > > ticket #5325 / #2125. > > > > The fate test changes because the fate sample was written > > by

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Clément Bœsch
On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes the aspect ratio for the sample from > ticket #5325 / #2125. > > The fate test changes because the fate sample was written > by FFmpeg with an incorrect aspect ratio. > > Please comment, Carl

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Paul B Mahol wrote: > On 9/19/16, Carl Eugen Hoyos wrote: >> 2016-09-19 14:02 GMT+02:00 Clement Boesch : >>> On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote: Hi! Attached patch fixes the aspect ratio

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Paul B Mahol
On 9/19/16, Carl Eugen Hoyos wrote: > 2016-09-19 13:37 GMT+02:00 Paul B Mahol : >> On 9/19/16, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch fixes the aspect ratio for the sample from >>> ticket #5325 / #2125. >>> >>> The fate test

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 14:03 GMT+02:00 Clément Bœsch : >> > From the code of conduct: "Do not assume malice for things that can be >> > attributed to incompetence. Even if it is malice, it’s rarely good to >> > start with that as initial assumption." >> >> I thought this is not relevant anymore?

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Clément Bœsch
On Mon, Sep 19, 2016 at 02:03:22PM +0200, Carl Eugen Hoyos wrote: > 2016-09-19 14:02 GMT+02:00 Clément Bœsch : > > On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> Attached patch fixes the aspect ratio for the sample from > >> ticket #5325 / #2125.

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 14:57 GMT+02:00 Paul B Mahol : > title should mentioned what kind of aspect ratio this is about. > As I thought it is about sar. I don't understand: FFmpeg only knows about sample aspect ratio (also known as pixel aspect ratio), display aspect ratio is only shown on

[FFmpeg-devel] [PATCH v3 14/25] avcodec/utils: do_encode now supports AVMEDIA_TYPE_DATA

2016-09-19 Thread Erkki Seppälä
Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer --- libavcodec/utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 8b55464..f0e22b9 100644 --- a/libavcodec/utils.c +++

[FFmpeg-devel] [PATCH v3 11/25] avformat/movenc: add the urim sample descriptor

2016-09-19 Thread Erkki Seppälä
This also adds libavformat/movmeta that contains the meta data information. Actually the sample configuration data is performed with side packet data AV_PKT_DATA_TIMED_METADATA_INFO where the value is stored inside AVTimedMetadataInfo. Signed-off-by: Erkki Seppälä

[FFmpeg-devel] [PATCH v3 08/25] Updated Changelog

2016-09-19 Thread Erkki Seppälä
--- Changelog | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Changelog b/Changelog index f95a1f5..3712172 100644 --- a/Changelog +++ b/Changelog @@ -25,6 +25,9 @@ version : multiple tracks references by such track references (supported by isom for both reading and writing) +-

[FFmpeg-devel] [PATCH v3 06/25] avcodec/avcodec, avformat/movenc: introduced AV_PKT_DATA_TRACK_ALTERNATE_GROUP side data for expressing alternate groups

2016-09-19 Thread Erkki Seppälä
Alternate groups previously always generated for ISO media files. With this addition client code can define track groups arbitrarily. Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer --- libavcodec/avcodec.h | 11 +++

[FFmpeg-devel] [PATCH v3 10/25] avformat/movenc: deal with AVMEDIA_TYPE_DATA by using AV_CODEC_ID_META

2016-09-19 Thread Erkki Seppälä
This includes creating an AVCodecTag table ff_codec_metadata_tags as there are for video, audio and subtitles. The tag table is used for mov-compatiblity. Signed-off-by: Erkki Seppälä Signed-off-by: OZOPlayer --- libavformat/isom.c | 5 +

[FFmpeg-devel] [PATCH v3 02/25] Updated Changelog

2016-09-19 Thread Erkki Seppälä
--- Changelog | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Changelog b/Changelog index 71abe8c..e1c8010 100644 --- a/Changelog +++ b/Changelog @@ -18,6 +18,8 @@ version : - bitplanenoise video filter - floating point support in als decoder +- Custom major brand (the "brand" option)

[FFmpeg-devel] [PATCH v3 05/25] Updated Changelog

2016-09-19 Thread Erkki Seppälä
--- Changelog | 4 1 file changed, 4 insertions(+) diff --git a/Changelog b/Changelog index e1c8010..f95a1f5 100644 --- a/Changelog +++ b/Changelog @@ -21,6 +21,10 @@ version : - Custom major brand (the "brand" option) of MPEG4 is written as a compatible brand as well. +- Added

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Clément Bœsch
On Mon, Sep 19, 2016 at 02:04:43PM +0200, Carl Eugen Hoyos wrote: > 2016-09-19 14:03 GMT+02:00 Clément Bœsch : > > >> > From the code of conduct: "Do not assume malice for things that can be > >> > attributed to incompetence. Even if it is malice, it’s rarely good to > >> > start

Re: [FFmpeg-devel] [PATCH 4/4] lavf/mov: Add support for edit list parsing.

2016-09-19 Thread Sasi Inguva
I have sent a patch fixing the gapless playback . PTAL. Basically the patch will make sure that , at least in case of one edit list for audio, the timestamps provided by the demuxer are strictly monotonically increasing , and also that the skip_samples field is correctly set to the edit list media

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-19 Thread Lukasz Marek
On Sep 18, 2016 04:57, "Ronald S. Bultje" wrote: > > Hi, > > On Sat, Sep 17, 2016 at 4:26 PM, Marton Balint wrote: > > > I think we should wait until Lukasz does the port of the opengl device to > > SDL2, and do the switch after that. > > > When do we think

[FFmpeg-devel] [PATCH] lavf/mov.c: Make audio timestamps strictly monotonically increasing inside an edit list. Fixes gapless decoding.

2016-09-19 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavcodec/utils.c | 15 +++--- libavformat/mov.c| 75 tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 2 +- tests/ref/fate/gaplessenc-pcm-to-mov-aac | 2 +- 4

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Make audio timestamps strictly monotonically increasing inside an edit list. Fixes gapless decoding.

2016-09-19 Thread Michael Niedermayer
On Mon, Sep 19, 2016 at 06:31:31PM -0700, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavcodec/utils.c | 15 +++--- > libavformat/mov.c| 75 > >

[FFmpeg-devel] [PATCH] avformat/concatdec: don't call open_file when seek position within a file

2016-09-19 Thread raymond
--- libavformat/concatdec.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index b3a430e..1cd9ec1 100644 --- a/libavformat/concatdec.c +++ b/libavformat/concatdec.c @@ -64,6 +64,8 @@ typedef struct

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself for mlp/truehd

2016-09-19 Thread Michael Niedermayer
On Sun, Sep 18, 2016 at 11:22:27AM +0530, Jai Luthra wrote: > Signed-off-by: Jai Luthra > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 15:27 GMT+02:00 Paul B Mahol : > On 9/19/16, Carl Eugen Hoyos wrote: >> 2016-09-19 14:57 GMT+02:00 Paul B Mahol : >> >>> title should mentioned what kind of aspect ratio this is about. >>> As I thought it is about sar. >> >> I

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-09-19 Thread Aman Gupta
On Monday, September 19, 2016, Richard Kern wrote: > > On Sep 10, 2016, at 10:33 PM, Aman Gupta > wrote: > > > > On Sunday, September 11, 2016, Richard Kern

Re: [FFmpeg-devel] [PATCH 2/6] avformat/avframe.h: Add a flag in AVIndexEntry to discard frame after decoding.

2016-09-19 Thread Michael Niedermayer
On Thu, Sep 15, 2016 at 01:36:15PM -0700, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/avformat.h | 3 +++ > 1 file changed, 3 insertions(+) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind

Re: [FFmpeg-devel] [PATCH 5/6] lavf/utils: Support av_index_search_timestamp in case of AVIndexEntry with discarded packets.

2016-09-19 Thread Michael Niedermayer
On Thu, Sep 15, 2016 at 01:36:18PM -0700, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/utils.c | 10 ++ > 1 file changed, 10 insertions(+) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 3/6] lavc: Add a flag in AVPacket to discard packet after decoding. Discard frames after decoding based on the flag.

2016-09-19 Thread Michael Niedermayer
On Thu, Sep 15, 2016 at 01:36:16PM -0700, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavcodec/avcodec.h | 6 ++ > libavcodec/utils.c | 15 ++- > 2 files changed, 20 insertions(+), 1 deletion(-) applied thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 4/6] lavf/mov: Add support for edit list parsing.

2016-09-19 Thread Sasi Inguva
Thanks Michael, for the assiduous review. We caught 2-3 audio decoding bugs because of it, and implemented basic seek functionality. On Mon, Sep 19, 2016 at 10:54 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Sun, Sep 18, 2016 at 10:09:03PM -0700, Sasi Inguva wrote: > >

Re: [FFmpeg-devel] [PATCH 1/6] avutil/frame: Add a flag to discard frame after decode.

2016-09-19 Thread Michael Niedermayer
On Thu, Sep 15, 2016 at 01:36:14PM -0700, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavutil/frame.c | 1 + > libavutil/frame.h | 4 > libavutil/version.h | 2 +- > 3 files changed, 6 insertions(+), 1 deletion(-) applied thx [...] -- Michael

Re: [FFmpeg-devel] [PATCH] doc/encoders: minor aac encoder formatting improvements

2016-09-19 Thread Rostislav Pehlivanov
On 18 September 2016 at 23:01, Moritz Barsnick wrote: > Minor changes for markup consistency. > > That line I shifted is probably redundant. > > Moritz > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

[FFmpeg-devel] [PATCH]lavc/rscc: Support pal8

2016-09-19 Thread Carl Eugen Hoyos
Hi! Attached patch fixes the colours for the sample in ticket #5611. Please comment, Carl Eugen From 7af0c224f5c0fd8dec095ba5333a87257ffccd85 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 19 Sep 2016 19:12:12 +0200 Subject: [PATCH] lavc/rscc: Support pal8 in rscc.

Re: [FFmpeg-devel] [PATCH 3/4] lavc: Add a flag in AVPacket to discard packet after decoding. Discard frames after decoding based on the flag.

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 20:32 GMT+02:00 wm4 : > But I guess you don't care, neither did whoever pushed this > low quality patch before the patch was fixed? I believe you didn't oppose the current mailing list rules so please refrain from personal attacks. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavc/rscc: Support pal8

2016-09-19 Thread Paul B Mahol
On 9/19/16, Carl Eugen Hoyos wrote: > 2016-09-19 20:28 GMT+02:00 Paul B Mahol : >> On 9/19/16, Carl Eugen Hoyos wrote: >> >>> Attached patch fixes the colours for the sample in ticket #5611. > >> You should use av_packet_get_side_data

Re: [FFmpeg-devel] [PATCH]lavc/rscc: Support pal8

2016-09-19 Thread Paul B Mahol
On 9/19/16, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes the colours for the sample in ticket #5611. > > Please comment, Carl Eugen > You should use av_packet_get_side_data instead. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 3/4] lavc: Add a flag in AVPacket to discard packet after decoding. Discard frames after decoding based on the flag.

2016-09-19 Thread wm4
On Tue, 9 Aug 2016 18:48:21 -0700 Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavcodec/avcodec.h | 6 ++ > libavcodec/utils.c | 14 +- > libavcodec/version.h | 2 +- > 3 files changed, 20 insertions(+), 2

Re: [FFmpeg-devel] [PATCH]lavc/rscc: Support pal8

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 20:28 GMT+02:00 Paul B Mahol : > On 9/19/16, Carl Eugen Hoyos wrote: > >> Attached patch fixes the colours for the sample in ticket #5611. > You should use av_packet_get_side_data instead. New patch attached, thank you! Carl Eugen From

Re: [FFmpeg-devel] [PATCH 4/6] lavf/mov: Add support for edit list parsing.

2016-09-19 Thread Sasi Inguva
For the gapless playback: I can hack so that we have monotonically increasing timestamps for the audio , when demuxing . Basically going back in the index and setting correct timestamps for the discarded packets. But, as pointed out in the IRC channel, I modify skip_samples field too in the

Re: [FFmpeg-devel] [PATCH 4/6] lavf/mov: Add support for edit list parsing.

2016-09-19 Thread Michael Niedermayer
On Mon, Sep 19, 2016 at 11:08:30AM -0700, Sasi Inguva wrote: > Thanks Michael, for the assiduous review. We caught 2-3 audio decoding bugs > because of it, and implemented basic seek functionality. It seems this causes a regression durandal117 and wm4 on IRC pointed out that the change to the

Re: [FFmpeg-devel] [PATCH]lavc/rscc: Support pal8

2016-09-19 Thread Carl Eugen Hoyos
2016-09-19 21:42 GMT+02:00 Paul B Mahol : > On 9/19/16, Carl Eugen Hoyos wrote: >> 2016-09-19 20:28 GMT+02:00 Paul B Mahol : >>> On 9/19/16, Carl Eugen Hoyos wrote: >>> Attached patch fixes the colours for the sample

Re: [FFmpeg-devel] [PATCH 4/4] lavf/mov: Add support for edit list parsing.

2016-09-19 Thread wm4
On Tue, 9 Aug 2016 18:48:22 -0700 Sasi Inguva wrote: > diff --git a/tests/ref/fate/gaplessenc-itunes-to-ipod-aac > b/tests/ref/fate/gaplessenc-itunes-to-ipod-aac > index aacb058..145bd09 100644 > --- a/tests/ref/fate/gaplessenc-itunes-to-ipod-aac > +++

[FFmpeg-devel] [PATCH 1/2] avcodec: add pcm_f16le and pcm_f24le decoder

2016-09-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 2 ++ libavcodec/allcodecs.c | 2 ++ libavcodec/avcodec.h| 2 ++ libavcodec/codec_desc.c | 14 ++ libavcodec/pcm.c| 34 ++ libavcodec/utils.c | 2 ++ 6

[FFmpeg-devel] [PATCH 2/2] avformat/wavdec: add support for decoding 24.0 and 16.8 floating point pcm formats

2016-09-19 Thread Paul B Mahol
Fixes #5602 and #5603. Signed-off-by: Paul B Mahol --- libavformat/wavdec.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index 7176cd6..9f760c1 100644 --- a/libavformat/wavdec.c +++ b/libavformat/wavdec.c @@