Re: [FFmpeg-devel] [PATCH] avformat/utils: fix crashes in has_decode_delay_been_guessed

On Fri, 2 Dec 2016 13:51:24 +0100 Timo Rothenpieler wrote: > These paths can be taken when the actual underlying codec is not h264, > but the user forces, for example via ffmpeg command line, a specific > input decoder that happens to be a h264 decoder. > > In that case,

Re: [FFmpeg-devel] [PATCH] matroskadec: partly revert "demux relevant subtitle packets after a seek" c16582579b1c6f66a86615c5808cd5b2bf17be73

On Sat, 26 Nov 2016 08:27:44 +0100 Rainer Hochecker wrote: > From: Rainer Hochecker > > > Alternative patch. Revert the original code because it does more harm than > any good. > > > Signed-off-by: Rainer Hochecker > --- >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/thread: Add pthread_cond_timedwait function.

On 12/2/2016 5:21 AM, Matt Oliver wrote: > Signed-off-by: Matt Oliver > --- > compat/os2threads.h | 24 > compat/w32pthreads.h | 50 ++ > libavutil/thread.h | 6 ++ > 3 files changed, 80

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

Le duodi 12 frimaire, an CCXXV, Matt Oliver a écrit : > --- > configure | 6 -- > libavformat/udp.c | 48 +++- > 2 files changed, 19 insertions(+), 35 deletions(-) It looks like there are unrelated changes in this patch. Can you explain

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

On 2 December 2016 at 22:16, Nicolas George wrote: > Le duodi 12 frimaire, an CCXXV, Matt Oliver a écrit : > > --- > > configure | 6 -- > > libavformat/udp.c | 48 +++- > > 2 files changed, 19 insertions(+), 35

Re: [FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

> > +switch (avctx->color_primaries) { > > +case AVCOL_PRI_BT709: > param.sSpatialLayers[0].uiColorPrimaries = CP_BT709; break; > > +case AVCOL_PRI_UNSPECIFIED: > param.sSpatialLayers[0].uiColorPrimaries = CP_UNDEF; break; > > [ignore] > Please align

[FFmpeg-devel] [PATCH] avformat/utils: fix crashes in has_decode_delay_been_guessed

These paths can be taken when the actual underlying codec is not h264, but the user forces, for example via ffmpeg command line, a specific input decoder that happens to be a h264 decoder. In that case, the codecpar codec_id is set to h264, but the internal avctx is the one of, for example, an

Re: [FFmpeg-devel] [PATCH] travis: setup for automated coverity builds

On 12/2/2016 4:14 AM, Timothy Gu wrote: > On Thu, Dec 1, 2016 at 1:23 PM Timo Rothenpieler > wrote: > >> Travis can only run scheduled builds daily, weekly or monthly. > > So we run them daily, and use a bit of logic in the .travis.yml to >> cancel out early on 3 days per

Re: [FFmpeg-devel] [PATCH] matroskadec: partly revert "demux relevant subtitle packets after a seek" c16582579b1c6f66a86615c5808cd5b2bf17be73

absolutely. thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] avutil/thread: Add pthread_cond_timedwait function.

Signed-off-by: Matt Oliver --- compat/os2threads.h | 24 compat/w32pthreads.h | 50 ++ libavutil/thread.h | 6 ++ 3 files changed, 80 insertions(+) diff --git a/compat/os2threads.h

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_h26[45]: add crop info support in vaapi_h26[4, 5]

On 2016/12/1 19:03, wm4 wrote: > On Wed, 30 Nov 2016 18:25:59 +0100 > Michael Niedermayer wrote: > AVFrame had a pan_scan parameter to store one or more croping rectangles. That is now available as side data I remember the intend that this could

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

On Fri, Dec 2, 2016 at 9:22 AM, Matt Oliver wrote: > --- > configure | 6 -- > libavformat/udp.c | 48 +++- > 2 files changed, 19 insertions(+), 35 deletions(-) > > diff --git a/configure b/configure > index

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_h26[45]: add crop info support in vaapi_h26[4, 5]

On Fri, 2 Dec 2016 16:15:10 +0800 Jun Zhao wrote: > On 2016/12/1 19:03, wm4 wrote: > > On Wed, 30 Nov 2016 18:25:59 +0100 > > Michael Niedermayer wrote: > > > AVFrame had a pan_scan parameter to store one or more croping > rectangles. >

[FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

--- configure | 6 -- libavformat/udp.c | 48 +++- 2 files changed, 19 insertions(+), 35 deletions(-) diff --git a/configure b/configure index b5bfad6..cec94c4 100755 --- a/configure +++ b/configure @@ -1934,7 +1934,6 @@ SYSTEM_FUNCS="

Re: [FFmpeg-devel] [PATCH] movenc: Tag files generated with strict experimental with a warning

On Fri, 2 Dec 2016 17:17:23 -0300 James Almer wrote: > On 12/2/2016 5:00 PM, Vittorio Giovara wrote: > > This will simplify identifying files that were generated with > > unfinished/incomplete/non-standard specifications. > > > > Signed-off-by: Vittorio Giovara

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

On Sat, Dec 03, 2016 at 12:57:49AM +0100, Hendrik Leppkes wrote: > On Sat, Dec 3, 2016 at 12:52 AM, Michael Niedermayer > wrote: > > This is a bit messy as codecar does not support AVOptions so we need > > to use AVCodecContext where AVOptions are required and copy back

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

On 03.12.2016 00:52, Michael Niedermayer wrote: > This is a bit messy as codecar does not support AVOptions so we need > to use AVCodecContext where AVOptions are required and copy back and forth. > > Signed-off-by: Michael Niedermayer > --- > libavformat/ffmdec.c | 159

Re: [FFmpeg-devel] [PATCH 3/3] configure: fail if autodetect-libraries are requested but not found

On 02.12.2016 19:20, Michael Niedermayer wrote: > On Fri, Dec 02, 2016 at 12:44:41AM +0100, Andreas Cadhalpun wrote: >> There is already va_va_h in vaapi_deps and I'm not sure, what else >> you'd like to have there. > > i see a "disable vaapi" here but that should be done by the dependency > or

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

On Sat, Dec 3, 2016 at 12:52 AM, Michael Niedermayer wrote: > This is a bit messy as codecar does not support AVOptions so we need > to use AVCodecContext where AVOptions are required and copy back and forth. > ffmenc can't really write any data that doesn't go into

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix crashes in has_decode_delay_been_guessed

On Fri, Dec 02, 2016 at 05:05:29PM +0100, Timo Rothenpieler wrote: > > Is it just me or is this completely inconsistent? > > the codec id told to the user is h264 while we internally use a > > mpeg2 decoder to analyze it ? > > > > If its h264 (as forced by the user) we should use a h264 decoder >

Re: [FFmpeg-devel] [PATCH 1/5] avformat/ffmdec: Remove some st->codec uses which set encoder parameters

On 03.12.2016 00:52, Michael Niedermayer wrote: > Modern ffserver should not need these > > Signed-off-by: Michael Niedermayer > --- > libavformat/ffmdec.c | 148 > +-- > 1 file changed, 74 insertions(+), 74 deletions(-) >

[FFmpeg-devel] [PATCH 4/5] ffserver: remove one avcodec_context_copy()

Signed-off-by: Michael Niedermayer --- ffserver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ffserver.c b/ffserver.c index 19c3ceda1a..3ff761f68f 100644 --- a/ffserver.c +++ b/ffserver.c @@ -2854,7 +2854,8 @@ static int

[FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

This is a bit messy as codecar does not support AVOptions so we need to use AVCodecContext where AVOptions are required and copy back and forth. Signed-off-by: Michael Niedermayer --- libavformat/ffmdec.c | 159 ++- 1 file

[FFmpeg-devel] [PATCH 3/5] avformat/ffmdec: Drop flags2, debug and codec->time_base setting

It should still be possible to set these through recommended_encoder_configuration Signed-off-by: Michael Niedermayer --- libavformat/ffmdec.c | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/libavformat/ffmdec.c

[FFmpeg-devel] [PATCH 5/5] avformat/ffmdec: remove last use of st->codec

Signed-off-by: Michael Niedermayer --- libavformat/ffmdec.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c index f3497e2b24..9b9373eae5 100644 --- a/libavformat/ffmdec.c

[FFmpeg-devel] [PATCH 1/5] avformat/ffmdec: Remove some st->codec uses which set encoder parameters

Modern ffserver should not need these Signed-off-by: Michael Niedermayer --- libavformat/ffmdec.c | 148 +-- 1 file changed, 74 insertions(+), 74 deletions(-) diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c index

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix crashes in has_decode_delay_been_guessed

On Fri, Dec 02, 2016 at 01:51:24PM +0100, Timo Rothenpieler wrote: > These paths can be taken when the actual underlying codec is not h264, > but the user forces, for example via ffmpeg command line, a specific > input decoder that happens to be a h264 decoder. > > In that case, the codecpar

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix crashes in has_decode_delay_been_guessed

> Is it just me or is this completely inconsistent? > the codec id told to the user is h264 while we internally use a > mpeg2 decoder to analyze it ? > > If its h264 (as forced by the user) we should use a h264 decoder > to internally analyze it > Yes, something is very wrong here. I also

Re: [FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

On 12/1/2016 6:26 PM, Gregory J. Wolfe wrote: > As of version 1.6, libopenh264 saves (in the output video file) > information about the color primaries, transfer characteristics, > and color matrix used when the video pixel data was created. > This patch sets the required libopenh264 data

Re: [FFmpeg-devel] [PATCH] travis: setup for automated coverity builds

On Fri, Dec 2, 2016 at 3:22 AM Timo Rothenpieler wrote: > On 12/2/2016 4:14 AM, Timothy Gu wrote: > > On Thu, Dec 1, 2016 at 1:23 PM Timo Rothenpieler > > wrote: > > > >> Travis can only run scheduled builds daily, weekly or monthly. > > > > So we

Re: [FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On > Behalf Of James Almer > Sent: Friday, December 02, 2016 9:31 AM > > On 12/1/2016 6:26 PM, Gregory J. Wolfe wrote: > > As of version 1.6, libopenh264 saves (in the output video file) > > information about the color primaries,

Re: [FFmpeg-devel] [PATCH] travis: setup for automated coverity builds

> That has been done my Michael as I can see. > > So one question: will this .travis.yml be applied to the main FFmpeg repo > or the newly created FFmpeg-Coverity repo? That's a good point, it doesn't even need to be in the main repo, specially as there already is a travis.yml there. Would

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

Le duodi 12 frimaire, an CCXXV, Matt Oliver a écrit : > Which changes would those be? The fix of errno / return value for pthread_cond_timedwait() for example. > This function is already set as nonblocking I think you read this specific part of the code wrong. Unfortunately, since

Re: [FFmpeg-devel] [PATCH 3/3] configure: fail if autodetect-libraries are requested but not found

On Fri, Dec 02, 2016 at 12:44:41AM +0100, Andreas Cadhalpun wrote: > On 01.12.2016 01:34, Michael Niedermayer wrote: > > On Thu, Dec 01, 2016 at 12:22:50AM +0100, Andreas Cadhalpun wrote: > >> @@ -6381,6 +6410,11 @@ for thread in $THREADS_LIST; do > >> fi > >> done > >> > >> +# Check if

Re: [FFmpeg-devel] [PATCH 2/6] avformat/ffmenc: Replace some st->codec use by codecpar

On Thu, Dec 01, 2016 at 05:37:35PM +0100, Michael Niedermayer wrote: > Note, this temporarly drops the ability to set ffmpeg encoder debug and > flags2 via ffserver.conf > > Signed-off-by: Michael Niedermayer > --- > libavformat/ffmenc.c | 24 +--- >

[FFmpeg-devel] [PATCH] movenc: Tag files generated with strict experimental with a warning

This will simplify identifying files that were generated with unfinished/incomplete/non-standard specifications. Signed-off-by: Vittorio Giovara --- libavformat/movenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c

[FFmpeg-devel] [PATCH] swresample/resample: do not rebuild filter when sample_delta is zero

Signed-off-by: Muhammad Faiz --- libswresample/resample.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswresample/resample.c b/libswresample/resample.c index e65a57a..71dffb9 100644 --- a/libswresample/resample.c +++ b/libswresample/resample.c @@

Re: [FFmpeg-devel] [PATCH] movenc: Tag files generated with strict experimental with a warning

On 12/2/2016 5:00 PM, Vittorio Giovara wrote: > This will simplify identifying files that were generated with > unfinished/incomplete/non-standard specifications. > > Signed-off-by: Vittorio Giovara > --- > libavformat/movenc.c | 2 ++ > 1 file changed, 2

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: use mastering display metadata's own alloc function

On Fri, 2 Dec 2016 16:09:25 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/matroskadec.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: use mastering display metadata's own alloc function

On 12/2/2016 4:43 PM, wm4 wrote: > On Fri, 2 Dec 2016 16:09:25 -0300 > James Almer wrote: > >> Signed-off-by: James Almer >> --- >> libavformat/matroskadec.c | 14 +- >> 1 file changed, 9 insertions(+), 5 deletions(-) >> >> diff --git

[FFmpeg-devel] [PATCH] avformat/matroskadec: use mastering display metadata's own alloc function

Signed-off-by: James Almer --- libavformat/matroskadec.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 017a533..7b070ff 100644 --- a/libavformat/matroskadec.c +++

Re: [FFmpeg-devel] [PATCH 1/4] Add a compat stdatomic.h implementation based on windows atomics

On 11/29/2016 9:12 AM, wm4 wrote: > On Mon, 28 Nov 2016 15:29:53 -0800 > Wan-Teh Chang wrote: > >> From: Anton Khirnov >> >> Adapted from the code by Rémi Denis-Courmont from VLC >> >> This merges libav commit

[FFmpeg-devel] [PATCH] configure: add -fPIE instead of -pie to C flags for ThreadSanitizer

-pie was added to C flags for ThreadSanitizer in commit 19f251a2882a8d0779b432e63bf282e4d9c443bb. Under clang 3.8.0, the -pie flag causes a compiler warning and a linker error when running configure --toolchain=clang-tsan. Here is an excerpt from config.log: clang ... -fsanitize=thread -pie

Re: [FFmpeg-devel] [PATCH 1/6] tests/ffserver.regression.ref: Update ffserver checksums

On 02.12.2016 04:27, Michael Niedermayer wrote: > On Fri, Dec 02, 2016 at 12:59:41AM +0100, Andreas Cadhalpun wrote: >> The test is unfortunately not very reproducible. >> Right now I'm getting varying values like on one run: >> -0c9639f09decbc54c9f091dcf1ca0e8f *ff-test_h.avi >>