Re: [FFmpeg-devel] avfilter : merge setfield and setrange and add set color property option

2018-10-22 Thread Paul B Mahol
On 10/21/18, Martin Vignali wrote: >> >> You forgot to update setparams filter long description. >> >> > Patch in attach fix description, and two mistakes (not setting color > primaries, trc, space to auto for setfield and setrange, and colorspace > option for setparams > Sorry. > > Martin >

[FFmpeg-devel] [PATCH] avformat/libsrt: add several options supported in srt 1.3.0 v2

2018-10-22 Thread Matsuzawa Tomohiro
Several SRT options are missing. Since pkg_config requires libsrt v1.3.0 and above, it should be able to support options added in libsrt v1.3.0 and below. This commit adds 8 SRT options. sndbuf, rcvbuf, lossmaxttl, minversion, streamid, smoother, messageapi and transtype The keys of option are

Re: [FFmpeg-devel] [PATCH v4] fate: add api-h264-slice test

2018-10-22 Thread Josh de Kock
On 16/10/2018 12:33, Michael Niedermayer wrote: On Mon, Oct 15, 2018 at 01:32:03PM +0100, jos...@ob-encoder.com wrote: From: Josh de Kock This test ensures that you are able to send N number of slice NALUs in slice threaded mode to be decoded simultaneously --- Tested on Linux 32/64, MinGW

[FFmpeg-devel] [PATCH V4] Add a filter implementing HDR image generation from a single exposure using deep CNNs

2018-10-22 Thread Guo, Yejun
see the algorithm's paper and code below. the filter's parameter looks like: sdr2hdr=model_filename=/path_to_tensorflow_graph.pb:out_fmt=gbrp10le The input of the deep CNN model is RGB24 while the output is float for each color channel. This is the filter's default behavior to output format with

[FFmpeg-devel] [PATCH] avdevice: Fix ioctl method signature for Android builds

2018-10-22 Thread Don Turner
When compiling avdevice for Android I received a compile error from libavdevice/v4l2.c. Full details in the 2nd part of this answer: https://stackoverflow.com/questions/52896607/why-do-i-get-error-invalid-instruction-mnemonic-when-compiling-ffmpeg-for-and/52900973#52900973 Patch below: diff

Re: [FFmpeg-devel] [PATCH V3] Add a filter implementing HDR image reconstruction from a single exposure using deep CNNs

2018-10-22 Thread Guo, Yejun
> -Original Message- > From: Song, Ruiling > Sent: Monday, October 22, 2018 10:02 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org>; Guo, Yejun > Subject: RE: [FFmpeg-devel] [PATCH V3] Add a filter implementing HDR > image reconstruction from a single exposure using

[FFmpeg-devel] [PATCH] avformat/libsrt: add several options supported in srt 1.3.0 v3

2018-10-22 Thread Matsuzawa Tomohiro
Several SRT options are missing. Since pkg_config requires libsrt v1.3.0 and above, it should be able to support options added in libsrt v1.3.0 and below. This commit adds 8 SRT options. sndbuf, rcvbuf, lossmaxttl, minversion, streamid, smoother, messageapi and transtype The keys of option are

[FFmpeg-devel] [PATCH] avcodec/hevcdec: fix non-ref frame judgement

2018-10-22 Thread Mark Wu
After inspecting the source code of x265, mpv and ffmpeg, I've found that ffmpeg mistakenly regards EVC_NAL_BLA_N_LP and HEVC_NAL_IDR_N_LP as non- reference frames, which are acutally reference frames according to the specification in x265, and drops them. This patch should address the problem.

[FFmpeg-devel] [PATCH] libavformat/matroskadec.c: Fix support seek to non keyframes

2018-10-22 Thread Seokjin Hong
After a seek with AVSEEK_FLAG_ANY to reach near end of the stream, matroskadec.c always drops packets which consists of non-keyframe. Signed-off-by: Seokjin Hong --- libavformat/matroskadec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH V3] Add a filter implementing HDR image reconstruction from a single exposure using deep CNNs

2018-10-22 Thread Song, Ruiling
> Thanks for the link, however i'm still not sold on the term. You "generate" > hdr data, not "reconstruct": it's generated/estimated/made up data, not > data that is lost and needs to be reconstrcuted. I suggested "tonemap" > because you're mapping SDR tones (aka colors) to HDR ones, and that

Re: [FFmpeg-devel] avfilter : merge setfield and setrange and add set color property option

2018-10-22 Thread Martin Vignali
> > Patch in attach fix description, and two mistakes (not setting color > > primaries, trc, space to auto for setfield and setrange, and colorspace > > option for setparams > > Sorry. > > > > Martin > > > > LGTM > Pushed, thanks Martin ___

Re: [FFmpeg-devel] [PATCH] avcodec/imm4: improve decoding of some files

2018-10-22 Thread Timo Rothenpieler
> @@ -205,9 +206,26 @@ static int decode_blocks(AVCodecContext *avctx, GetBitContext *gb, > static int decode_intra(AVCodecContext *avctx, GetBitContext *gb, AVFrame *frame) > { > IMM4Context *s = avctx->priv_data; > -int ret, x, y; > +int ret, x, y, offset = 0; > > -

Re: [FFmpeg-devel] swscale/unscaled : add grayf32 bswap and rename packed_16bpc_bswap

2018-10-22 Thread Michael Niedermayer
On Sun, Oct 21, 2018 at 07:25:31PM +0200, Martin Vignali wrote: > New patch in attach > > 001 : change unscaled test condition for float (only use isFloat(src) || > isFloat(dst)). > 002 : add grayf32 le <-> be > i disable float (in/out) in the latest part of the patch, because it's > currently

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: simplify dnxhd handling and add more flavors

2018-10-22 Thread Tomas Härdin
mån 2018-10-22 klockan 11:37 -0700 skrev Baptiste Coudurier: > --- >  libavformat/mxfenc.c | 215 --- >  1 file changed, 61 insertions(+), 154 deletions(-) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index f6acf80d36..71a9b97bed 100644 >

Re: [FFmpeg-devel] [PATCHv2 2/2] avdevice/sdl2 : add option to set window position

2018-10-22 Thread Marton Balint
On Sat, 20 Oct 2018, Marton Balint wrote: From: Dave Rice Allows arrangement of multiple windows such as: ffmpeg -re -f lavfi -i mandelbrot -f sdl -window_x 1 -window_y 1 mandelbrot -vf waveform,format=yuv420p -f sdl -window_x 641 -window_y 1 waveform -vf vectorscope,format=yuv420p -f sdl

Re: [FFmpeg-devel] [PATCH] avfilter: add vibrance filter

2018-10-22 Thread Paul B Mahol
On 10/20/18, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 29 + > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_vibrance.c | 240 ++ > 4 files changed, 271 insertions(+)

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread Michael Niedermayer
On Sat, Oct 20, 2018 at 02:32:20PM +0200, Martin Vignali wrote: > Hello, > > Patch in attach add a bsf filter to set color property of a prores frame > > Can be used, to set all frames of prores file to the same value > (avoid color shift on some frame depending of the software used to decode >

[FFmpeg-devel] [PATCH] libvmaf: update docs

2018-10-22 Thread Kyle Swanson
From: Kyle Swanson For context: https://github.com/Netflix/vmaf/issues/237 Signed-off-by: Kyle Swanson --- I'll push this sometime in the next 24hrs unless someone has an issue. doc/filters.texi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec.c: Fix support seek to non keyframes

2018-10-22 Thread Carl Eugen Hoyos
2018-10-22 14:36 GMT+02:00, Seokjin Hong : > After a seek with AVSEEK_FLAG_ANY to reach near end of the stream, > matroskadec.c always drops packets which consists of non-keyframe. I believe the current behaviour is expected unless seek2any flag was set. Carl Eugen

[FFmpeg-devel] [PATCH] avcodec/msrle: Check that the input is large enough to contain a end of picture code

2018-10-22 Thread Michael Niedermayer
Fixes: Timeout Fixes: 10625/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSRLE_fuzzer-5659651283091456 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/msrle.c | 3 +++ 1 file changed, 3

Re: [FFmpeg-devel] [PATCH V5 2/2] lavf/vc1test: add rcv to vc1test demuxer extensions

2018-10-22 Thread Michael Niedermayer
On Wed, Oct 17, 2018 at 08:18:58AM +0800, Jun Zhao wrote: > rcv is commonly used as extension for vc1 test stream files. > > Signed-off-by: Jun Zhao > --- > libavformat/vc1test.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/libavformat/vc1test.c

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread James Almer
On 10/20/2018 9:32 AM, Martin Vignali wrote: > Hello, > > Patch in attach add a bsf filter to set color property of a prores frame > > Can be used, to set all frames of prores file to the same value > (avoid color shift on some frame depending of the software used to decode > the file) > or fix

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread Martin Vignali
> > Could you look into adding ProRes bitstream parsing support to the CBS > framework? It would be ideal for a filter like this. > > Hello, The only metadata, which seems to have an interest to be edited (color property), is at the start of every prores frame, no need to go deeper to edit these

[FFmpeg-devel] [PATCH] libaomenc: Add support for tiles

2018-10-22 Thread Mark Thompson
Adds an option to specify the number of tile rows and columns, then uses a uniform tiling if possible and otherwise a fixed tiling with equal-sized tiles to fill the frame. Also adds -tile-columns and -tile-rows options to make tilings with power-of-two numbers of tiles, matching the behaviour of

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: remove FF_CODEC_CAP_INIT_THREADSAFE flag

2018-10-22 Thread Carl Eugen Hoyos
2018-10-22 2:25 GMT+02:00, Marton Balint : > > On Sun, 21 Oct 2018, Henrik Gramner wrote: > >> Fixed in x264-sandbox. All uses of plain strtok() will be >> removed from x264 in the next push. > > Great, thanks! Can you give us an X264_BUILD number from > which this will be fixed? Could you push

Re: [FFmpeg-devel] [PATCH v4] fate: add api-h264-slice test

2018-10-22 Thread Michael Niedermayer
On Mon, Oct 22, 2018 at 03:13:08PM +0100, Josh de Kock wrote: > On 16/10/2018 12:33, Michael Niedermayer wrote: > >On Mon, Oct 15, 2018 at 01:32:03PM +0100, jos...@ob-encoder.com wrote: > >>From: Josh de Kock > >> > >>This test ensures that you are able to send N number of slice NALUs in >

Re: [FFmpeg-devel] swscale/unscaled : add grayf32 bswap and rename packed_16bpc_bswap

2018-10-22 Thread Martin Vignali
> > rename and simplify are ok > > the other needs a more verbose commit message > > New patch in attach Changed the second patch. I edited planarCopyWrapper to add bswap32, instead of disable this func for float. Will probably help to support more float pix fmt in the future Martin

Re: [FFmpeg-devel] [PATCH] Revert "avcodec/decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext"

2018-10-22 Thread James Almer
On 9/13/2018 6:50 AM, Timo Rothenpieler wrote: >> So, what do we do now? Honor the doxy and stop trying to manipulate >> what's meant to be an user owned pointer/buffer, officially break the >> API and declare it's meant to be allocated by the user but then >> ownership is passed to the library

Re: [FFmpeg-devel] [PATCH 3/3] cbs_h2645: Allocate all internal buffers with padding

2018-10-22 Thread Mark Thompson
On 17/10/18 01:40, Aman Gupta wrote: > On Tue, Oct 16, 2018 at 2:08 PM Mark Thompson wrote: > >> Any of these buffers (for both H.264 and H.265) might reasonably be >> parsed using the bitstream reader, so include padding on all of them. >> --- >> This seems simpler than adding it to specific

Re: [FFmpeg-devel] [PATCH] avdevice: Fix ioctl method signature for Android builds

2018-10-22 Thread Michael Niedermayer
On Mon, Oct 22, 2018 at 05:40:21PM +0100, Don Turner wrote: > When compiling avdevice for Android I received a compile error from > libavdevice/v4l2.c. Full details in the 2nd part of this answer: >

Re: [FFmpeg-devel] [PATCH V5 1/2] lavf/vc1test: fix vc1test can't probe some RCV file.

2018-10-22 Thread Michael Niedermayer
On Wed, Oct 17, 2018 at 08:18:57AM +0800, Jun Zhao wrote: > case 1: > use the hexdump -C SMM0005.rcv get: > size skip (size - 4) > || > VV > 18 00 00 c5 05 00 00

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

2018-10-22 Thread Michael Niedermayer
On Mon, Oct 22, 2018 at 01:47:47AM +0200, pkv.stream wrote: > (commit message changed to include number of trac tricket solved) > > For context , search for the discussion: aacenc: remove unsupported PCE > mappings > > Additional details: > > the aac decoder decodes PCE correctly but since

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Fix off by 1 error in JPEG2000_PGOD_CPRL handling

2018-10-22 Thread Michael Niedermayer
On Sun, Oct 21, 2018 at 12:35:11AM +0200, Michael Niedermayer wrote: > Fixes: assertion failure > Fixes: > 10785/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5672160496975872 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/ilbcdec: Check startindex

2018-10-22 Thread Michael Niedermayer
On Sun, Oct 21, 2018 at 06:21:32PM +0200, Paul B Mahol wrote: > On 10/21/18, Michael Niedermayer wrote: > > Fixes: Out of array read > > Fixes: > > 10789/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ILBC_fuzzer-5153255445757952 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread Martin Vignali
> > fails on mips qemu > > Thanks for testing. New patch in attach, 001 : unchanged 002 : limit frame entries for ffprobe part, in order to not have pix_fmt in the output. Martin 0001-avcodec-add-prores_metadata-bsf-for-set-the-color.patch Description: Binary data

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread James Almer
On 10/22/2018 6:44 PM, Martin Vignali wrote: >> >> Could you look into adding ProRes bitstream parsing support to the CBS >> framework? It would be ideal for a filter like this. >> >> Hello, > > The only metadata, which seems to have an interest to be edited (color > property), is at the start of

Re: [FFmpeg-devel] [PATCH v2 1/5] vaapi_encode: Support configurable slices

2018-10-22 Thread Mark Thompson
On 25/09/18 02:40, myp...@gmail.com wrote: > On Mon, Sep 24, 2018 at 5:53 AM Mark Thompson wrote: >> >> This adds common code to query driver support and set appropriate >> address/size information for each slice. It only supports rectangular >> slices for now, since that is the most common

Re: [FFmpeg-devel] [PATCH] avdevice: Fix ioctl method signature for Android builds

2018-10-22 Thread Carl Eugen Hoyos
2018-10-22 18:40 GMT+02:00, Don Turner : > When compiling avdevice for Android I received a compile error from > libavdevice/v4l2.c. I only get a warning here. > Full details in the 2nd part of this answer: >

[FFmpeg-devel] [PATCH] avformat/mxfenc: simplify dnxhd handling and add more flavors

2018-10-22 Thread Baptiste Coudurier
--- libavformat/mxfenc.c | 215 --- 1 file changed, 61 insertions(+), 154 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index f6acf80d36..71a9b97bed 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -142,23 +142,10 @@

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread Mark Thompson
On 22/10/18 21:53, Martin Vignali wrote: > From 312b153d2b92012cacd8a189d34738de9bdfa615 Mon Sep 17 00:00:00 2001 > From: Martin Vignali > Date: Mon, 22 Oct 2018 22:46:05 +0200 > Subject: [PATCH 1/2] avcodec : add prores_metadata bsf for set the color > property of each prores file > > --- >

Re: [FFmpeg-devel] [PATCH V5 2/2] lavf/vc1test: add rcv to vc1test demuxer extensions

2018-10-22 Thread myp...@gmail.com
On Tue, Oct 23, 2018 at 4:39 AM Michael Niedermayer wrote: > > On Wed, Oct 17, 2018 at 08:18:58AM +0800, Jun Zhao wrote: > > rcv is commonly used as extension for vc1 test stream files. > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/vc1test.c |1 + > > 1 files changed, 1

Re: [FFmpeg-devel] [PATCH V5 1/2] lavf/vc1test: fix vc1test can't probe some RCV file.

2018-10-22 Thread myp...@gmail.com
On Tue, Oct 23, 2018 at 4:40 AM Michael Niedermayer wrote: > > On Wed, Oct 17, 2018 at 08:18:57AM +0800, Jun Zhao wrote: > > case 1: > > use the hexdump -C SMM0005.rcv get: > > size skip (size - 4) > > || > >