Re: [FFmpeg-devel] [PATCH] matroskadec: Add sizes to forward declarations

2019-07-17 Thread Paul B Mahol
On 7/17/19, Andreas Rheinhardt wrote: > Unknown-length elements end when an element not allowed in them, but > allowed at a higher level is encountered. In order to check for this, > c1abd95a added a pointer to every syntax level's parent to each > EbmlSyntax. Given that the parent must of course

Re: [FFmpeg-devel] FFmpeg classification

2019-07-17 Thread Nicolas George
Tomas Härdin (12019-07-17): > > blocked-based, or not. > > multi-thread capable, or not. > > has assembler optimisations, or not. > > is direct render capable, or not > > standard derived or reverse engineered <- more of a numerical scale than > > categorical variable > > Game codec, or not > VQ

Re: [FFmpeg-devel] [PATCH] avcodec/prores_ks reduce twice fdct calls

2019-07-17 Thread Paul B Mahol
Do we want to apply this? On 1/4/19, Alex Mogurenko wrote: > ping > > On Mon, Dec 31, 2018 at 11:02 PM Alex Mogurenko wrote: > >> thanks, >> just sent new patch >> >> On Mon, Dec 31, 2018 at 5:56 PM Derek Buitenhuis < >> derek.buitenh...@gmail.com> wrote: >> >>> On 31/12/2018 09:12, Alex

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add hdr10, linear, hlg color transfer function for videotoolboxenc

2019-07-17 Thread Vittorio Giovara
On Tue, Jul 16, 2019 at 10:29 PM Limin Wang wrote: > On Tue, Jul 16, 2019 at 09:36:32PM -0400, Rick Kern wrote: > > Testing for the new transfer functions when compiling for OSX 10.12 > reports > > the color settings as "yuv420p(tv, bt2020nc/bt2020/reserved)" in ffprobe. > > Is "reserved" (0)

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-17 Thread Nicolas George
Ulf Zibis (12019-07-17): > Because anyone I ask including mathematicians, is the opinion that the > sign of 0 is positive. They were not very competent mathematicians. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] FFmpeg classification

2019-07-17 Thread Paul B Mahol
On 7/17/19, Nicolas George wrote: > Tomas Härdin (12019-07-17): >> > blocked-based, or not. >> > multi-thread capable, or not. >> > has assembler optimisations, or not. >> > is direct render capable, or not >> > standard derived or reverse engineered <- more of a numerical scale than >> >

Re: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs for autoscale/autorotate

2019-07-17 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Linjie Fu > Sent: Tuesday, July 16, 2019 4:20 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs for >

Re: [FFmpeg-devel] [PATCH] avcodec: list the allocation requirements for intra_matrix and inter_matrix fields

2019-07-17 Thread James Almer
On 7/15/2019 11:39 AM, James Almer wrote: > Signed-off-by: James Almer > --- > See > https://git.videolan.org/?p=vlc.git;a=commitdiff;h=d86c4c87aa78130a4fd00294e25df865d0e2b327 > > libavcodec/avcodec.h | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs for autoscale/autorotate

2019-07-17 Thread Nicolas George
Linjie Fu (12019-07-16): > Add docs for autoscale. > > Update information for autorotate according to ffplay. > > Signed-off-by: Linjie Fu > --- > doc/ffmpeg.texi | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi > index

Re: [FFmpeg-devel] [PATCH 2/3] fate: change the scenecut fate threshold for one more scenecut scenes

2019-07-17 Thread Michael Niedermayer
On Tue, Jul 16, 2019 at 06:53:57AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak| 2 +- > tests/ref/fate/filter-metadata-scenedetect | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) The commit

Re: [FFmpeg-devel] [PATCH] libavformat/subfile: Fix SEEK_CUR and SEEK_END seeking

2019-07-17 Thread Michael Niedermayer
On Mon, Jul 15, 2019 at 07:48:35PM +0200, Andreas Rheinhardt wrote: > Up until now, when performing a SEEK_END seek, the subfile protocol > ignored the desired position (relative to EOF) and used the current > absolute offset in the input file instead. I think this comment is only intended to be

Re: [FFmpeg-devel] [PATCH] avcodec: list the allocation requirements for intra_matrix and inter_matrix fields

2019-07-17 Thread Paul B Mahol
LGTM On 7/15/19, James Almer wrote: > Signed-off-by: James Almer > --- > See > https://git.videolan.org/?p=vlc.git;a=commitdiff;h=d86c4c87aa78130a4fd00294e25df865d0e2b327 > > libavcodec/avcodec.h | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] libavformat/subfile: Fix SEEK_CUR and SEEK_END seeking

2019-07-17 Thread Andreas Rheinhardt
Michael Niedermayer: > On Mon, Jul 15, 2019 at 07:48:35PM +0200, Andreas Rheinhardt wrote: >> Up until now, when performing a SEEK_END seek, the subfile protocol >> ignored the desired position (relative to EOF) and used the current >> absolute offset in the input file instead. > > I think this

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2019-07-17 Thread Michael Niedermayer
On Mon, Jul 15, 2019 at 06:38:35PM +0800, Linjie Fu wrote: > Currently, ffmpeg inserts scale filter by default in the filter graph > to force the whole decoded stream to scale into the same size with the > first frame. It's not quite make sense in resolution changing cases if > user wants the

Re: [FFmpeg-devel] [PATCH v6] Fix integer parameters size check in SDP fmtp line

2019-07-17 Thread Michael Niedermayer
On Fri, Jul 12, 2019 at 08:40:40AM +0200, Olivier Maignial wrote: > === PROBLEM === > > I was trying to record h264 + aac streams from an RTSP server to mp4 file. > using this command line: > ffmpeg -v verbose -y -i "rtsp:///my_resources" -codec copy -bsf:a > aac_adtstoasc test.mp4 > >

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-17 Thread Ulf Zibis
Am 17.07.19 um 19:21 schrieb Nicolas George: > Ulf Zibis (12019-07-17): >> Because anyone I ask including mathematicians, is the opinion that the >> sign of 0 is positive. > They were not very competent mathematicians. In normal arithmetic, yes, sgn(0) is 0, but here we are in floating point

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/ivi: Ask for samples with odd tiles

2019-07-17 Thread Michael Niedermayer
On Tue, Jul 02, 2019 at 09:59:04PM +0200, Michael Niedermayer wrote: > Fixes: Assertion failure > Fixes: > 15422/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INDEO5_fuzzer-5676625481433088 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec: list the allocation requirements for intra_matrix and inter_matrix fields

2019-07-17 Thread James Almer
On 7/17/2019 4:47 PM, Paul B Mahol wrote: > LGTM > > On 7/15/19, James Almer wrote: >> Signed-off-by: James Almer >> --- >> See >> https://git.videolan.org/?p=vlc.git;a=commitdiff;h=d86c4c87aa78130a4fd00294e25df865d0e2b327 >> >> libavcodec/avcodec.h | 12 >> 1 file changed, 8

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/parser: Check next index validity in ff_combine_frame()

2019-07-17 Thread Michael Niedermayer
On Sat, Jul 06, 2019 at 12:57:45PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 15522/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DNXHD_fuzzer-5747756078989312 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH] avcodec/tak_parser: don't return error values

2019-07-17 Thread James Almer
The API does not allow it. Also set poutbuf and poutbuf_size to NULL/0 on error to avoid leaving them uninitialized. Signed-off-by: James Almer --- libavcodec/tak_parser.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavcodec/tak_parser.c

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add hdr10, linear, hlg color transfer function for videotoolboxenc

2019-07-17 Thread Limin Wang
On Wed, Jul 17, 2019 at 10:53:08AM -0400, Vittorio Giovara wrote: > On Tue, Jul 16, 2019 at 10:29 PM Limin Wang wrote: > > > On Tue, Jul 16, 2019 at 09:36:32PM -0400, Rick Kern wrote: > > > Testing for the new transfer functions when compiling for OSX 10.12 > > reports > > > the color settings

[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: make transfer_fnc initialized for unsupport function

2019-07-17 Thread lance . lmwang
From: Limin Wang The current function will report one error message, but the caller func haven't check it, so change the default to process as AVCOL_TRC_UNSPECIFIED. Signed-off-by: Limin Wang --- libavcodec/videotoolboxenc.c | 1 + 1 file changed, 1 insertion(+) diff --git

[FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-17 Thread Juan De León
--- libavfilter/vf_extractqp.c | 116 libavutil/Makefile | 2 + libavutil/quantization_params.c | 28 libavutil/quantization_params.h | 98 +++ 4 files changed, 244 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-17 Thread Juan De León
For context https://docs.google.com/document/d/1WClt3EqhjwdGXhEw386O0wfn3IBQ1Ib-_5emVM1gbnA/edit?usp=sharing Feel free to comment the doc. On Wed, Jul 17, 2019 at 4:18 PM Juan De León wrote: > --- > libavfilter/vf_extractqp.c | 116 > libavutil/Makefile

[FFmpeg-devel] [PATCH] avformat/ifv: Check for EOF in read_index()

2019-07-17 Thread Michael Niedermayer
Fixes: Timeout Fixes: 15567/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5758451487080448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/ifv.c | 2 ++ 1 file changed, 2

Re: [FFmpeg-devel] [PATCH 2/3] fate: change the scenecut fate threshold for one more scenecut scenes

2019-07-17 Thread Limin Wang
On Wed, Jul 17, 2019 at 09:26:42PM +0200, Michael Niedermayer wrote: > On Tue, Jul 16, 2019 at 06:53:57AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > tests/fate/filter-video.mak| 2 +- > >

[FFmpeg-devel] [PATCH] Issue#6001:Fix for incorrect refs frame count in ffprobe

2019-07-17 Thread Mukund Manikarnike
Hi, Please find the patch for issue#6001 attached. I tried git send-email without any success. I'm getting a success message. But, it doesn't show up in the ffmpeg-devel list. Sendmail: /usr/sbin/sendmail -i ffmpeg-devel@ffmpeg.org muk...@gmail.com From: Mukund Manikarnike To:

Re: [FFmpeg-devel] dash: add descriptor which is useful to the scheme defined by ISO/IEC 23009-1:2014/Amd.2:2015.

2019-07-17 Thread Jeyapal, Karthick
On 7/17/19 10:21 AM, Tao Zhang wrote: > Jeyapal, Karthick 于2019年7月17日周三 上午10:46写道: >> >> >> On 7/15/19 8:41 AM, leozhang wrote: >>> change history: >>> 1. remove unnecessary cast. >>> 2. add some braces. >>> >>> Please comment, Thanks >> Thanks for sending the patch. Please find some of my

[FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-17 Thread Ulf Zibis
Hi, I have a patch for bug #8027 (see attachment). But there is still a problem with -0.0, but FFABS(-0.0) works fine. Testcode:    av_log(NULL, AV_LOG_ERROR, "FFSIGN(0): %d\n", FFSIGN(0));     av_log(NULL, AV_LOG_ERROR, "FFSIGN(-0): %d\n", FFSIGN(-0));    

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-17 Thread Ulf Zibis
Again with the patch attached ... Am 17.07.19 um 08:30 schrieb Ulf Zibis: > Hi, > > I have a patch for bug #8027 (see > attachment). > > But there is still a problem with -0.0, but FFABS(-0.0) works fine. > > Testcode: >    av_log(NULL, AV_LOG_ERROR,

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-17 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Ulf Zibis > Sent: Wednesday, July 17, 2019 2:34 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for > FFSIGN(0) > > Again with the patch

[FFmpeg-devel] [PATCH 1/1] libavcodec/h264: Handle ENOMEM error when decoding slice nal unit.

2019-07-17 Thread Asaf Kave
Populate the real error when alloc_picture failed, during decoding h264 slice. When this error occurred, need to break the decoding process of the rest nal's, and need to rise this error back to the user, to indicate that there is decoder memory issue. --- libavcodec/h264_slice.c | 5 +++--

Re: [FFmpeg-devel] FFmpeg classification

2019-07-17 Thread Tomas Härdin
ons 2019-07-17 klockan 18:04 +1000 skrev Peter Ross: > On Wed, Jul 17, 2019 at 10:10:13AM +0900, Maaya Murakami (JP) wrote: > > Hello > > > > Hope all is well. > > Currently I am researching about the trends of FFmpeg and its supporting > > codecs, and in order to do so I am trying to classify

Re: [FFmpeg-devel] FFmpeg classification

2019-07-17 Thread Peter Ross
On Wed, Jul 17, 2019 at 10:10:13AM +0900, Maaya Murakami (JP) wrote: > Hello > > Hope all is well. > Currently I am researching about the trends of FFmpeg and its supporting > codecs, and in order to do so I am trying to classify FFmpeg codecs into > different types. Are there meaningful

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-17 Thread Ulf Zibis
Am 17.07.19 um 08:57 schrieb Song, Ruiling: > Why do you think FFSIGN(0.0) should return +1? Because anyone I ask including mathematicians, is the opinion that the sign of 0 is positive. > What issue do you meet? I wanted to use the macro in my code, but with the current behaviour it is

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-17 Thread Paul B Mahol
On 7/17/19, Ulf Zibis wrote: > > Am 17.07.19 um 08:57 schrieb Song, Ruiling: >> Why do you think FFSIGN(0.0) should return +1? > Because anyone I ask including mathematicians, is the opinion that the > sign of 0 is positive. > >> What issue do you meet? > > I wanted to use the macro in my code,

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-17 Thread Hendrik Leppkes
On Wed, Jul 17, 2019 at 9:55 AM Ulf Zibis wrote: > > > Am 17.07.19 um 08:57 schrieb Song, Ruiling: > > Why do you think FFSIGN(0.0) should return +1? > Because anyone I ask including mathematicians, is the opinion that the > sign of 0 is positive. It really doesn't matter what anyone else

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-07-17 Thread Carl Eugen Hoyos
> Am 08.07.2019 um 14:05 schrieb Gyan : > > > >> On 25-04-2019 01:48 PM, Gyan wrote: >> >> >>> On 25-04-2019 01:23 PM, Ali KIZIL wrote: >>> >>> There are also Dolby Codecs (ac3 & eac3). Will it also throw error for >>> these codecs ? >> >> AC3 is supported before and after this

Re: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: add x86 SIMD for filter_3x3()

2019-07-17 Thread Paul B Mahol
On 7/15/19, Song, Ruiling wrote: >> -Original Message- >> From: Song, Ruiling >> Sent: Tuesday, July 9, 2019 9:15 AM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Song, Ruiling >> Subject: [PATCH] avfilter/vf_convolution: add x86 SIMD for filter_3x3() >> >> Tested using a simple command (apply

Re: [FFmpeg-devel] [PATCH 1/3] lavf/f_select: support scenecut with more pixel formats

2019-07-17 Thread Limin Wang
On Wed, Jul 17, 2019 at 12:58:04AM +0200, Marton Balint wrote: > > > On Tue, 16 Jul 2019, lance.lmw...@gmail.com wrote: > > >From: Limin Wang > > > >This patch haven't make other pixel format usable yet to make sure the test > >result is same with rgb format. > > > >Signed-off-by: Limin Wang