Re: [FFmpeg-devel] [PATCH, v3] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2019-07-28 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Paul B Mahol > Sent: Wednesday, July 24, 2019 21:17 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v3] fftools/ffmpeg_filter: add - >

Re: [FFmpeg-devel] [PATCH, RFC 2/2] fftools/ffmpeg: add dynamic resolution encode support for libvpx-vp9

2019-07-28 Thread Gyan
On 28-07-2019 03:24 PM, Linjie Fu wrote: According to spec, vp9 should support dynamic resolution changes. Add dynamic resolution encoding support in libvpx-vp9, and flush encoders when resolution change happens. Format change should also be supported, but I didn't test it so just leave it

Re: [FFmpeg-devel] [PATCH v2] avcodec/mips: [loongson] refine process of setting block as 0 in h264dsp_mmi.

2019-07-28 Thread Reimar Döffinger
I have no MIPS experience, but for what little it is worth thus: it looks fine to me. On 28.07.2019, at 06:42, Shiyou Yin wrote: > In function ff_h264_add_pixels4_8_mmi, there is no need to reset '%[ftmp0]' > to 0, because it's value has never changed since the start of the asm block. > This

Re: [FFmpeg-devel] [PATCH v7 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-28 Thread Paul B Mahol
On Sun, Jul 28, 2019 at 12:30 AM Reimar Döffinger wrote: > On 26.07.2019, at 09:34, Nick Renieris wrote: > > > Στις Παρ, 26 Ιουλ 2019 στις 2:21 π.μ., ο/η Reimar Döffinger > > έγραψε: > >> > >> On 25.07.2019, at 17:35, velocit...@gmail.com wrote: > >> > >>> +// Lookup table lookup > >>> +

Re: [FFmpeg-devel] [PATCH, RFC 2/2] fftools/ffmpeg: add dynamic resolution encode support for libvpx-vp9

2019-07-28 Thread Nicolas George
Linjie Fu (12019-07-28): > +enc->internal->draining = 0; "internal" means you should not be doing that. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH, v4 1/2] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2019-07-28 Thread Linjie Fu
Currently, ffmpeg inserts scale filter by default in the filter graph to force the whole decoded stream to scale into the same size with the first frame. It's not quite make sense in resolution changing cases if user wants the rawvideo without any scale. Using autoscale/noautoscale to indicate

[FFmpeg-devel] [PATCH, RFC 2/2] fftools/ffmpeg: add dynamic resolution encode support for libvpx-vp9

2019-07-28 Thread Linjie Fu
According to spec, vp9 should support dynamic resolution changes. Add dynamic resolution encoding support in libvpx-vp9, and flush encoders when resolution change happens. Format change should also be supported, but I didn't test it so just leave it open. cmdline: ffmpeg -noautoscale -y -i

Re: [FFmpeg-devel] [PATCH 1/4] libavfilter/dnn: move dnn files from libavfilter to libavfilter/dnn

2019-07-28 Thread Guo, Yejun
> -Original Message- > From: Pedro Arthur [mailto:bygran...@gmail.com] > Sent: Saturday, July 27, 2019 12:10 AM > To: FFmpeg development discussions and patches > Cc: Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH 1/4] libavfilter/dnn: move dnn files from > libavfilter to

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/lcldec: Optimize YUV422 case

2019-07-28 Thread Michael Niedermayer
On Sun, Jul 28, 2019 at 12:45:36AM +0200, Reimar Döffinger wrote: > > > On 28.07.2019, at 00:31, Michael Niedermayer wrote: > > > This merges several byte operations and avoids some shifts inside the loop > > > > Improves: Timeout (330sec -> 134sec) > > Improves: > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/lcldec: Optimize YUV422 case

2019-07-28 Thread Michael Niedermayer
On Sun, Jul 28, 2019 at 12:45:36AM +0200, Reimar Döffinger wrote: > > > On 28.07.2019, at 00:31, Michael Niedermayer wrote: > > > This merges several byte operations and avoids some shifts inside the loop > > > > Improves: Timeout (330sec -> 134sec) > > Improves: > >

Re: [FFmpeg-devel] [PATCH, RFC 2/2] fftools/ffmpeg: add dynamic resolution encode support for libvpx-vp9

2019-07-28 Thread Fu, Linjie
> -Original Message- > From: Nicolas George [mailto:geo...@nsup.org] > Sent: Sunday, July 28, 2019 17:58 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH, RFC 2/2] fftools/ffmpeg: add dynamic > resolution encode

Re: [FFmpeg-devel] [PATCH 1/2] dnn: add layer pad which is equivalent to tf.pad

2019-07-28 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Pedro Arthur > Sent: Friday, July 26, 2019 10:36 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/2] dnn: add layer pad which is equivalent > to

[FFmpeg-devel] [PATCH] avcodec/adpcm: check also extradata_size

2019-07-28 Thread Paul B Mahol
Hi, patch attached. 0001-avcodec-adpcm-check-also-extradata_size.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/lcldec: Optimize YUV422 case

2019-07-28 Thread James Almer
On 7/28/2019 8:56 AM, Michael Niedermayer wrote: > On Sun, Jul 28, 2019 at 12:45:36AM +0200, Reimar Döffinger wrote: >> >> >> On 28.07.2019, at 00:31, Michael Niedermayer wrote: >> >>> This merges several byte operations and avoids some shifts inside the loop >>> >>> Improves: Timeout (330sec ->

Re: [FFmpeg-devel] [PATCH v7 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-28 Thread Nick Renieris
Στις Κυρ, 28 Ιουλ 2019 στις 1:30 π.μ., ο/η Reimar Döffinger έγραψε: > > Huh? Are you thinking of templates? always_inline can usually be used the > same way. > I haven't looked into the how or anything, it was just a comment in principle. You're totally right (I checked on godbolt just to make

Re: [FFmpeg-devel] [PATCH v7 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-28 Thread Nick Renieris
Actually, I checked a more accurate version of my loop, and GCC optimizes away the LUT check anyway: https://godbolt.org/z/G1e1R4 As you can see it's smart enough to create 2 versions of my functions (started at L3 with a lookup and L7 without it) and it does the check outside. There's no

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/lcldec: Optimize YUV422 case

2019-07-28 Thread Reimar Döffinger
On 28.07.2019, at 13:56, Michael Niedermayer wrote: > On Sun, Jul 28, 2019 at 12:45:36AM +0200, Reimar Döffinger wrote: >> >> >> On 28.07.2019, at 00:31, Michael Niedermayer wrote: >> >>> This merges several byte operations and avoids some shifts inside the loop >>> >>> Improves: Timeout

[FFmpeg-devel] [PATCH V2 1/3] dnn: add layer pad which is equivalent to tf.pad

2019-07-28 Thread Guo, Yejun
the reason to add this layer first is that vf_sr uses it in its tensorflow model, and the next plan is to update the python script to convert tf.pad into native model. Signed-off-by: Guo, Yejun --- libavfilter/dnn/Makefile | 1 +

[FFmpeg-devel] [PATCH V2 2/3] fate: add unit test for dnn-layer-pad

2019-07-28 Thread Guo, Yejun
'make fate-dnn-layer-pad' to run the test Signed-off-by: Guo, Yejun --- tests/Makefile | 5 +- tests/dnn/Makefile | 11 +++ tests/dnn/dnn-layer-pad-test.c | 203 + tests/fate/dnn.mak | 8 ++ 4 files changed,

[FFmpeg-devel] [PATCH] avfilter/fade: don't allow nb_frames == 0

2019-07-28 Thread Gyan
Fixes crash when user inputs a sub-unit fractional number for nb_frames. Gyan From b3e463c6514eabb1081a22e32dce33d62f5278ce Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Mon, 29 Jul 2019 10:53:12 +0530 Subject: [PATCH] avfilter/fade: don't allow nb_frames == 0 In filter init, there's a

[FFmpeg-devel] [PATCH V2 3/3] dnn: convert tf.pad to native model in python script, and load/execute it in the c code.

2019-07-28 Thread Guo, Yejun
since tf.pad is enabled, the conv2d(valid) changes back to its original behavior. Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_native.c| 35 + libavfilter/dnn/dnn_backend_native.h| 2 +- tools/python/convert_from_tensorflow.py | 23

Re: [FFmpeg-devel] [PATCH 25/31] cbs: Add function to update video codec parameters

2019-07-28 Thread Andreas Rheinhardt
Mark Thompson: > On 20/06/2019 00:45, Andreas Rheinhardt wrote: >> If any of the *_metadata filter based upon cbs currently updates a video >> codec parameter like color information, the AVCodecParameters are not >> updated accordingly, so that e.g. muxers write header values based upon >>

Re: [FFmpeg-devel] [PATCH v7 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-28 Thread Reimar Döffinger
On 28.07.2019, at 10:40, Nick Renieris wrote: > Actually, I checked a more accurate version of my loop, and GCC > optimizes away the LUT check anyway: > https://godbolt.org/z/G1e1R4 > As you can see it's smart enough to create 2 versions of my functions > (started at L3 with a lookup and L7

Re: [FFmpeg-devel] [PATCH v7 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-28 Thread Reimar Döffinger
On 28.07.2019, at 08:55, Paul B Mahol wrote: >> >> Just provide as metadata and leave to e.g. libavfilter. >> > > That does not follow DNG specification. > I really do not have time to comment on other irrelevant stuff you pointed > in your review. If you had just told me that I should back

Re: [FFmpeg-devel] [PATCH v7 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-28 Thread Paul B Mahol
On Sun, Jul 28, 2019 at 4:39 PM Reimar Döffinger wrote: > On 28.07.2019, at 08:55, Paul B Mahol wrote: > > >> > >> Just provide as metadata and leave to e.g. libavfilter. > >> > > > > That does not follow DNG specification. > > I really do not have time to comment on other irrelevant stuff you

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/lcldec: Optimize YUV422 case

2019-07-28 Thread Michael Niedermayer
On Sun, Jul 28, 2019 at 11:06:16AM -0300, James Almer wrote: > On 7/28/2019 8:56 AM, Michael Niedermayer wrote: > > On Sun, Jul 28, 2019 at 12:45:36AM +0200, Reimar Döffinger wrote: > >> > >> > >> On 28.07.2019, at 00:31, Michael Niedermayer > >> wrote: > >> > >>> This merges several byte

Re: [FFmpeg-devel] [PATCH v2] avcodec/mips: [loongson] refine process of setting block as 0 in h264dsp_mmi.

2019-07-28 Thread Michael Niedermayer
On Sun, Jul 28, 2019 at 04:07:40PM +0200, Reimar Döffinger wrote: > I have no MIPS experience, but for what little it is worth thus: it looks > fine to me. will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-28 Thread Paul B Mahol
On Sun, Jul 28, 2019 at 6:02 AM David Bryant wrote: > On 7/24/19 12:26 AM, Paul B Mahol wrote: > > On 7/23/19, David Bryant wrote: > >> On 7/23/19 12:47 AM, Paul B Mahol wrote: > >>> On 7/23/19, David Bryant wrote: > On 7/21/19 11:23 PM, Paul B Mahol wrote: > > On 7/22/19, David

Re: [FFmpeg-devel] [PATCH 28/31] vp9_metadata: Improve spec-compliance and warnings

2019-07-28 Thread Mark Thompson
On 09/07/2019 02:10, Andreas Rheinhardt wrote: > The earlier version had three deficits: > 1. It allowed to set the stream to RGB although this is not allowed when > the profile is 0 or 2. > 2. If it set the stream to RGB, then it did not automatically set the > range to full range; the result was

[FFmpeg-devel] [PATCH 2/2] h264_metadata: Support overscan_appropriate_flag

2019-07-28 Thread Mark Thompson
Fixes #8041. --- Requested in . doc/bitstream_filters.texi | 4 libavcodec/h264_metadata_bsf.c | 11 +++ 2 files changed, 15 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 023945e9be..50a1679fc7

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v2]

2019-07-28 Thread Andreas Håkon
Hi Michael, ‐‐‐ Original Message ‐‐‐ On Sunday, 28 de July de 2019 16:39, Michael Niedermayer wrote: > On Sat, Jul 27, 2019 at 08:41:02PM +, Andreas Håkon wrote: > > > Hi, > > This newversion fixes all the problems commented in > > https://patchwork.ffmpeg.org/patch/14036/ > >

Re: [FFmpeg-devel] [PATCH v4 1/2] vaapi_encode: Add ROI support

2019-07-28 Thread Mark Thompson
On 16/07/2019 08:19, Guo, Yejun wrote:>> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Mark Thompson >> Sent: Monday, July 08, 2019 3:27 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH v4 1/2] vaapi_encode: Add ROI

[FFmpeg-devel] [PATCH] avcodec/dsddec: add slice threading support

2019-07-28 Thread Paul B Mahol
Hi, patch attached. 0002-avcodec-dsddec-add-slice-threading-support.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH, v4 1/2] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2019-07-28 Thread Michael Niedermayer
On Sun, Jul 28, 2019 at 05:54:24PM +0800, Linjie Fu wrote: > Currently, ffmpeg inserts scale filter by default in the filter graph > to force the whole decoded stream to scale into the same size with the > first frame. It's not quite make sense in resolution changing cases if > user wants the

Re: [FFmpeg-devel] [PATCH 23/31] cbs_mpeg2: Remove zero byte stuffing

2019-07-28 Thread Mark Thompson
On 20/06/2019 00:45, Andreas Rheinhardt wrote: > Remove superfluous trailing zeros from slices. Because MPEG-2 slices > can end with zero bits a safe number of trailing zero bits is always > kept. > > More explicitly, 6 + max{f_code[i][1] - 1, i = 0,1, f_code[i][1] != 0xf} > is an upper bound for

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-28 Thread Paul B Mahol
On Sun, Jul 28, 2019 at 7:18 PM Paul B Mahol wrote: > > > On Sun, Jul 28, 2019 at 6:02 AM David Bryant wrote: > >> On 7/24/19 12:26 AM, Paul B Mahol wrote: >> > On 7/23/19, David Bryant wrote: >> >> On 7/23/19 12:47 AM, Paul B Mahol wrote: >> >>> On 7/23/19, David Bryant wrote: >> On

[FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v3]

2019-07-28 Thread Andreas Håkon
Hi, This last version fixes the small bug discovered by Michael Niedermayer: https://patchwork.ffmpeg.org/patch/14099/ This version is finally clean. Regards. A.H. ---From 08565b81aa2b6d75043e5e984da143480891c3b0 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Sun, 28 Jul 2019 19:59:51

Re: [FFmpeg-devel] [PATCH 1/2] cbs_h264: Fix missing inferred colour description fields

2019-07-28 Thread Andreas Rheinhardt
Mark Thompson: > With video_signal_type_present_flag set but colour_description_present_flag > unset the colour fields would not have had their correct values inferred. > --- > libavcodec/cbs_h264_syntax_template.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v2]

2019-07-28 Thread Michael Niedermayer
On Sat, Jul 27, 2019 at 08:41:02PM +, Andreas Håkon wrote: > Hi, > > This newversion fixes all the problems commented in > https://patchwork.ffmpeg.org/patch/14036/ > > Now, it works with/without video streams. > > Regards. > A.H. > > --- > From c9b295c49828f31bba3879de887c7b2ed0e2641c

Re: [FFmpeg-devel] [PATCH v7 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-28 Thread Reimar Döffinger
On 28.07.2019, at 16:45, Paul B Mahol wrote: > On Sun, Jul 28, 2019 at 4:39 PM Reimar Döffinger > wrote: > >> On 28.07.2019, at 08:55, Paul B Mahol wrote: >> Just provide as metadata and leave to e.g. libavfilter. >>> >>> That does not follow DNG specification. >>> I really

Re: [FFmpeg-devel] [PATCH 24/31] av1/h264_metadata: Don't reinitialize data

2019-07-28 Thread Mark Thompson
On 20/06/2019 00:45, Andreas Rheinhardt wrote: > If the relevant elements (the color description elements for AV1 and the > VUI elements in general for H.264 (since 1156b507)) are absent, then their > correct values (usually meaning unknown) have already been inferred by > the reading process, so

[FFmpeg-devel] [PATCH 1/2] cbs_h264: Fix missing inferred colour description fields

2019-07-28 Thread Mark Thompson
With video_signal_type_present_flag set but colour_description_present_flag unset the colour fields would not have had their correct values inferred. --- libavcodec/cbs_h264_syntax_template.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/cbs_h264_syntax_template.c

Re: [FFmpeg-devel] [PATCH 2/2] h264_metadata: Support overscan_appropriate_flag

2019-07-28 Thread Andreas Rheinhardt
Mark Thompson: > Fixes #8041. > --- > Requested in . > > > doc/bitstream_filters.texi | 4 > libavcodec/h264_metadata_bsf.c | 11 +++ > 2 files changed, 15 insertions(+) > > diff --git a/doc/bitstream_filters.texi

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-28 Thread Paul B Mahol
On Sun, Jul 28, 2019 at 6:02 AM David Bryant wrote: > On 7/24/19 12:26 AM, Paul B Mahol wrote: > > On 7/23/19, David Bryant wrote: > >> On 7/23/19 12:47 AM, Paul B Mahol wrote: > >>> On 7/23/19, David Bryant wrote: > On 7/21/19 11:23 PM, Paul B Mahol wrote: > > On 7/22/19, David

Re: [FFmpeg-devel] [PATCH 25/31] cbs: Add function to update video codec parameters

2019-07-28 Thread Mark Thompson
On 20/06/2019 00:45, Andreas Rheinhardt wrote: > If any of the *_metadata filter based upon cbs currently updates a video > codec parameter like color information, the AVCodecParameters are not > updated accordingly, so that e.g. muxers write header values based upon > outdated information that

[FFmpeg-devel] [PATCH] avcodec/dstdec: add slice threading support

2019-07-28 Thread Paul B Mahol
Hi, patch attached. 0001-avcodec-dstdec-add-slice-threading-support.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

[FFmpeg-devel] [PATCH] avcodec/arm/sbcenc: save callee preserved vfp registers

2019-07-28 Thread James Cowgill
When compiling FFmpeg with GCC-9, some very random segfaults were observed in code which had previously called down into the SBC encoder NEON assembly routines. This was caused by these functions clobbering some of the vfp callee saved registers (d8 - d15 aka q4 - q7). GCC was using these

[FFmpeg-devel] [PATCH 3/3] avformat/mpsubdec: Check pts / duration before cast

2019-07-28 Thread Michael Niedermayer
Fixes: 3e+47 is outside the range of representable values of type 'int' Fixes: 16057/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-569307214848 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 2/3] avcodec/eatqi: Check for minimum frame size

2019-07-28 Thread Michael Niedermayer
The minimum header is 8 bytes, the smallest bitstream that is passed to the MB decode code is 4 bytes Fixes: Timeout (35sec -> 18sec) Fixes: 15800/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EATQI_fuzzer-5684154517159936 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 1/3] avcodec/eatgv: Check remaining size after the keyframe header

2019-07-28 Thread Michael Niedermayer
The minimal size which unpack() will not fail on is 5 bytes Fixes: Timeout (14sec -> 77ms) (testcase 15508) Fixes: 15508/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EATGV_fuzzer-5700053513011200 Fixes: 15996/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EATGV_fuzzer-5751353223151616